From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: Simplify avtext_print_rational()
Date: Wed, 16 Apr 2025 08:30:40 +0200
Message-ID: <GV1P250MB0737799B60DE7474279E85688FBD2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <DM8P223MB03656475EF7EB9E348BBC216BABD2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
softworkz .:
>
>
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
>> Andreas Rheinhardt
>> Sent: Mittwoch, 16. April 2025 07:37
>> To: ffmpeg-devel@ffmpeg.org
>> Subject: Re: [FFmpeg-devel] [PATCH 01/12]
>> fftools/textformat/avtextformat: Simplify avtext_print_rational()
>>
>> softworkz .:
>>>
>>>
>>>> -----Original Message-----
>>>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
>>>> Andreas Rheinhardt
>>>> Sent: Mittwoch, 16. April 2025 06:28
>>>> To: ffmpeg-devel@ffmpeg.org
>>>> Subject: Re: [FFmpeg-devel] [PATCH 01/12]
>>>> fftools/textformat/avtextformat: Simplify avtext_print_rational()
>>>>
>>>> softworkz .:
>>>>>
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
>>>>>> Andreas Rheinhardt
>>>>>> Sent: Dienstag, 15. April 2025 10:36
>>>>>> To: ffmpeg-devel@ffmpeg.org
>>>>>> Subject: Re: [FFmpeg-devel] [PATCH 01/12]
>>>>>> fftools/textformat/avtextformat: Simplify avtext_print_rational()
>>>>>>
>>>>>> softworkz .:
>>>>>>>
>>>>>>>
>>>>>>>> -----Original Message-----
>>>>>>>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf
>> Of
>>>>>>>> Andreas Rheinhardt
>>>>>>>> Sent: Dienstag, 15. April 2025 03:00
>>>>>>>> To: FFmpeg development discussions and patches <ffmpeg-
>>>>>>>> devel@ffmpeg.org>
>>>>>>>> Subject: [FFmpeg-devel] [PATCH 01/12]
>>>>>> fftools/textformat/avtextformat:
>>>>>>>> Simplify avtext_print_rational()
>>>>>>>>
>>>>>>>> Patches attached.
>>>>>>>>
>>>>>>>> - Andreas
>>>>>>>
>>>>>>>
>>>>>>> Hi Andreas,
>>>>>>>
>>>>>>> thanks a lot for working through this. I'll go over it tomorrow.
>>>>>>>
>>>>>>> As to not waste your time, it's probably best when we get those
>>>>>>> changes applied in a timely manner so that I can rebase the new
>>>>>>> patchset on top of it.
>>>>>>>
>>>>>>> Since you're sending the patches as attachments:
>>>>>>> How do you want me to reply with code context? Whole files or
>>>>>>> just snippets? And quoted?
>>>>>>>
>>>>>>
>>>>>> Snippets is better. So is quoted.
>>>>>>
>>>>>> - Andreas
>>>>>>
>>>>>
>>>>> Hi Andreas,
>>>>>
>>>>> thanks again for the well-spotted improvements. Just two notes:
>>>>>
>>>>>
>>>>> 0007-fftools-textformat-Use-av_default_item_name.patch
>>>>>
>>>>> In the new patchset, those macros are removed from the individual
>>>>> files. There's now a single macro in tf_internal.h and I've
>> applied
>>>>> this change there.
>>>>
>>>> So you use a move/deduplicate commit to change something? Not good.
>>>
>>> No. The patchset has a deduplication commit. That's what I've
>> submitted
>>> to the ML already.
>>> Now I made another commit locally (on top of that) which makes this
>> change.
>>>
>>>
>>>>> 0008-fftools-textformat-avtextformat-Fix-segfault-upon-al.patch
>>>>> 0009-fftools-textformat-avtextformat-Fix-segfault-upon-al.patch
>>>>>
>>>>> Can this happen?
>>>>
>>>> Of course it can. All allocations can fail. That's why we check
>> them.
>>>> Have you been coding with the assumption that allocations never
>> fail?
>>>> (You can use av_max_alloc(1); to simulate allocation failures.)
>>>
>>> Allocations can fail, but statically initialized global const
>> values?
>>
>> The pointers to said static objects are only set after having
>> allocated
>> the private context. So the issue can happen (not with current master)
>
> Current master is on top of which I had applied your patches and
> there's no possible way for those pointers to be null.
>
> That you are submitting a patch that is fixing a flaw in an
> unmerged future patch is pretty cool, but was also beyond my range
> of consideration. 😊
>
> Thanks for the clarification.
>
You completely misunderstand (or you try to be trolling me as your 😊
indicates). "The issue" that can no longer happen with current master is
the segfault after allocation failure. This could really happen before
my fixes. The pointers to writer/formatter can still be NULL even on
master (namely after allocation failure), therefore the checks need to
be there.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-04-16 6:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 1:00 Andreas Rheinhardt
2025-04-15 1:25 ` softworkz .
2025-04-15 8:36 ` Andreas Rheinhardt
2025-04-16 0:31 ` softworkz .
2025-04-16 4:27 ` Andreas Rheinhardt
2025-04-16 4:38 ` softworkz .
2025-04-16 4:46 ` softworkz .
2025-04-16 5:36 ` Andreas Rheinhardt
2025-04-16 6:15 ` softworkz .
2025-04-16 6:30 ` Andreas Rheinhardt [this message]
2025-04-16 6:46 ` softworkz .
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1P250MB0737799B60DE7474279E85688FBD2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git