From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id AF4E44E2E8
	for <ffmpegdev@gitmailbox.com>; Wed, 30 Apr 2025 21:58:27 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BAC6D687B2E;
	Thu,  1 May 2025 00:58:24 +0300 (EEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05olkn2081.outbound.protection.outlook.com [40.92.90.81])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9A58F687AB8
 for <ffmpeg-devel@ffmpeg.org>; Thu,  1 May 2025 00:58:18 +0300 (EEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
 b=iwV3Ciy1GZHAOoTrpiYGbs115u2viEcZwD62ZjJkaWRomJ52j9temGeL5Sj0OPgnjE7wOqwNBSen0hPiXc7nMbDuYBXwwtT2ZDAwAGTd8rCjr+yYM8qQk/l8YzVnmOl1zYdCbd4otXtxE7yeVzPVJeglvkauIF1V1hEgJzZKJElh5kBvdBoqLnvB24gLIso3um3ONqp8t8d8xSUojY/Bzkwk2i6Hvv2SN2uhxOUmVyJz7W1gg+FSxBO1MxWyIqMC087S18n1JiNfM+HPt1ZOmvYXYXr2m9IoBkv+TsY5WE7sn95mOlGQfK5JgzrqkrVT0coAA4KsuXzC6AizSzS2nw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector10001;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eyVq4x7vLGq9aaYOmTFJfZ62S7puk0bdCV6/3hG/kC8=;
 b=cafhM1uCF1ZSzroE47kUzIpy47ia/FS67g1VktsZCJu5s7uAiHd1545zgPlL4qkJ2gs1y12q9jSbAVIrRumhmQNapt5jXOM7w3oRjrNLWd1UeDr2VKQXwRBfygyZnpGSyX1EbROdaaXBqDLvuhzXF07IMrpAGZ4xkkQTcK67XVMB2XUQbcfFINJeHab8yqeJl4VBxLmYLP8eGn0bLmu9m+D4r8en532jLUr3rAIR1vUyYSw5qDf/+NHf76hhhX1TdG+lZhLv1V49rtUxsppkoxTLSr+GWrtxkSjFAYpysTREZmt6B9GKZ2U9ZvzXiRf6vj83b9JAQWHrdNZLKFqDXw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=eyVq4x7vLGq9aaYOmTFJfZ62S7puk0bdCV6/3hG/kC8=;
 b=THDh9N3pXgzbDyumCnxg9puNBW74wvBw4jJeP3ri29ClG7eeIDjeprjxb2qVxukh9AYisuzGt0Qg4cFa9ffDPa3gN2Q+evtmF7Xz8NsHW/xsVxjfWaFEDfkNpY0pd7hwJKdAUqNpIMEfUcRAdItsOUTxlS3wjNJ9PvPLH823Lap7j3wYPXeaL4xEJVE9NwgvGVj+sVYzIiyRR4fT3DvLSCpQwtAemTZPhm1yYBpseaQIuizYTEr2cOPzr/LYM9T2T8Bu/jHHNmjusrPUnCmpieQWOPQD6fLVdYwtS0cfSL8PkyB2plvjZDTSwWyZfjItIKi1vHo85dR6ezFtfvLQZw==
Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17)
 by PRAP250MB0514.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:291::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.20; Wed, 30 Apr
 2025 21:58:17 +0000
Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
 ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
 ([fe80::d6a1:e3af:a5f1:b614%5]) with mapi id 15.20.8699.021; Wed, 30 Apr 2025
 21:58:16 +0000
Message-ID: <GV1P250MB07377306C6F8F7F239FA578E8F832@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
Date: Wed, 30 Apr 2025 23:58:15 +0200
User-Agent: Mozilla Thunderbird
To: ffmpeg-devel@ffmpeg.org
References: <GV1P250MB073702055A32692137764B888F812@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
 <65deee43-c9e9-4386-b3b3-2b7d7cf17fc3@jkqxz.net>
Content-Language: en-US
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
In-Reply-To: <65deee43-c9e9-4386-b3b3-2b7d7cf17fc3@jkqxz.net>
X-ClientProxiedBy: FR2P281CA0117.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:9d::7) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
 (2603:10a6:150:8e::17)
X-Microsoft-Original-Message-ID: <41cab67b-b3b0-44e0-8c8c-c29f21a3f81c@outlook.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PRAP250MB0514:EE_
X-MS-Office365-Filtering-Correlation-Id: 5af567c1-b88d-46f8-4b40-08dd88321c8e
X-MS-Exchange-SLBlob-MailProps: AZnQBsB9XmpI8tRyoOXaSUmOkLVCBKasHnvfNzXCKm/BxlZ0XumdUPZ4BY36EdZYAww34GgZw1Jk2OgzzNuq1KlXiq1DXF9Ws5P/bazYfQcv9n8B4LO8Oj/0L2kS/64fnAB8i6DTzUn0u/bzRPipAt06C9yLlSxDLol4Mv2Gs1kZRiYZ3hh4h7xRdgbpFIbC5sK/S1xM/lnYpTCx2gk7uoyqjpYxO0MACKc7BSYIw7lxFqGb5W3RL2P9kbLtnv4l29a77JNHn/oWWVRxzNNfSDaGe0gi+i99PxsAf50Tih0xGAyN3j0MK036G4vrqMErEp4+h3fIcUUKEynyy+pUwE5cDHcnAoNjgWbsNMb1PM33HzXVaFqW7kWTMJLZHbM3wvbIKNK7zBU4nIMsyry9/5SRRIC6ZsznUK4Alm2jpm6GMLxp6SvuirIxS3psb3tP8C8mzzvEG/ZyWkpVoYBW8/XodvNPTOsF+k1vKnLhAOEEGyYHpo4ZY8oNwnkuFNFciRyOhx5RVKj0WspbA2SBr4vZ9nKfHhXBfaYK4x5jYGJNPcq0w5BBGbxSfK9yPZaFotbmSG5OIZxSsNAsLBkN7jDvRakv3+lkN3oVSUFcHHs/ENGfLEtA5PmhoKMw0ar4Bhqw0TKdjQ0R3xDwme9/ozAgxFQDB9SROkS2zE4GBjlpJApudKtfeCoVqyplhT9s4Rk6HQqqd963w0gUEqivQYiUr1zfXrO742KIi0hTl//4pKtO61tqQNMoHj/yaAGussensCUoYGQ=
X-Microsoft-Antispam: BCL:0;
 ARA:14566002|15080799006|461199028|6090799003|7092599003|5072599009|19110799003|8060799006|56899033|440099028|3412199025;
X-Microsoft-Antispam-Message-Info: =?utf-8?B?ekZWRDJMQnVrRzRhUmVpNDlBNWxYMTUxS1M1MnE2Lzl6K0Jid1YrNU95Rk9M?=
 =?utf-8?B?WTNwWXR4U01PbWxPTmRGcFdwcU81eGNiU3JVYkVpbldIVitPVjR0Q1lzcVB5?=
 =?utf-8?B?K3ZCZUVDVW9TakNLMjVVdzBMUXZlV1Y1T2N6KzJjblppbVdvN1dMR3FlRGFk?=
 =?utf-8?B?TXZlcWRQaG5DdEhMNTBRQndacFlwTUVOQTdQWlkyVDMrMGFFQ3luMlY3S2Jp?=
 =?utf-8?B?emkraHg1bnRuR20xbXVvNkIzNVVxMXBiVm43RndUUlR0Y0lxVm8xajVHdi9F?=
 =?utf-8?B?RDY0OUx4eThmNEljUVFyVUNjT3g1WW9xTmdqUFVkMU1CZ0NOK2hFU0cyS0xF?=
 =?utf-8?B?RzRqSkhZeVpRRVJIbDJYMXhJZUpkb0FNZXhBUTBweUxiQ0FyNVpMRDdSZU03?=
 =?utf-8?B?ajZzNTBSSEJpY05pcVBiNWpQVkJDcHlpeEtEWHVYQXVPM1FhOWZoTlRRMGt3?=
 =?utf-8?B?czBlYWZUNk1VK1lYdHV1ZlFiWnlESHZ5K1NVNGtYamZ3QmFCbTZJUEZJenp0?=
 =?utf-8?B?WkszT3l1U3E4Y2hPOWFFWWliSUswUmtILzI0bWNNaHFUT3JtM2lnZTdNTFpr?=
 =?utf-8?B?NU9pMHJCTkxlK1lvaDlGcXZEb2lvTCtsam16akVDeFVhVXJXaU5QY0g1WFd3?=
 =?utf-8?B?ak82Zm1LeUF1R2xCUUp0eUxoVzczUUkyZ05NaGQ5anIwaWlEM2huejlkdVlm?=
 =?utf-8?B?UzhhcmRCdC9ZQ2EwekdmZVFMUnVsVHpIOVcrVVkyU0NyY0dEVVpvUDFIQkVy?=
 =?utf-8?B?NVJyYVI0eVlUeHlJdytHQWo2eC9IMUoxTHBURkUyWjRENmJFSkhzaG50MnQ4?=
 =?utf-8?B?ZDRsQlpVRVdMUGZkbHQ2VVlIRDAwclpyWmRRbElqQ1BIQmh3YjdCazJwZThj?=
 =?utf-8?B?clhna3lDZElSK0ZGejZxWWdjR2M5cTB5U1VhWUdVMjhWM0xZaHdFSGxGaXVM?=
 =?utf-8?B?bnU4azZ2aHVmVFdGMTZ5SHlOWVF5U3VRcm8wVmhaZmV0dlRmNy9aTEZObits?=
 =?utf-8?B?QXl4Y0M3MVZxVG01bGNmZ0VLZlQrMzRVRUdzUjhOVk9vMmkvVTRXbENPNFhQ?=
 =?utf-8?B?SWd3czBnS3B6UXNRdnJKNjUyQ1BXVmhKWXRTbldESkpKd01acml3OU53UnlZ?=
 =?utf-8?B?aXNEK1RzL3JuODJtQVdZRUZjcVpmeld2bWUrRUlpTmZ5TlNSaEZoakMyWll4?=
 =?utf-8?B?Um96OWtxRVRPYzV6RFl5MUpjZCtlS2Q2Y1ZhZ05qTXgvWGJmeGszbFF1a3dz?=
 =?utf-8?B?SUNCZkdrbmp5S0hsVGMvVmlTeWJ4b2dZaU15V1F2WG5DRUovRWRXcEhISkR2?=
 =?utf-8?B?UXppTmZsRHN0bkVlcitRZ1VWUnh0d2lvbDQyQUdBWmdUdmlXUWlqZmY2NmRE?=
 =?utf-8?B?RkZiN2Yyc2c4ZWlYc1JZVVJ5Zjd5bVhTT1h5L1p1TjB2bWN3WlhZdkQ4TThI?=
 =?utf-8?B?K0sxZkppeWxUVjdWb3dGeW1ncnIyeE9Ma2RjK1NTWEFJeFZoVHhGcldHTzY4?=
 =?utf-8?B?eHE0SGdhZ0VrRVpqdHVXZi9McXlHa2haNmxSdzB5c1NJYVV5MVBhSzJ4dFdD?=
 =?utf-8?B?Q3pXZz09?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UG1nL3hFcDh0L01FWGxrZTZVNDJidU9pMVV3V2NnNktoQXJ5RmpBRXhrOEJP?=
 =?utf-8?B?eThoQXpKeXJZenJESEdMMlFPZXpicFQ3eGUybmVxejkvUWV5TGxaUTFTSGJL?=
 =?utf-8?B?TGNLMFU1eWQrQ0w0Rm9pR0FYbVp5M3U0bEsxbzAwVVlZSDFEVHowZGVTZ1ZV?=
 =?utf-8?B?bzZlakVhMlpacmRWNXFoTVZwNzNERTdCYmtrekkvYWh2Z2V2NE9PMlM2dVBH?=
 =?utf-8?B?OTMxVkltMnllTmk5RkVoSVNXcklsZnNGQldUa0hqL2h3bFJyUmVIaUlCa0ty?=
 =?utf-8?B?ZmFNcVQ4TEgrRUppZGwxTUJrUTVyZWpSZC9LbTdFUjJoc3dKdzlpdHJiR1JP?=
 =?utf-8?B?akFYYUxOb2R4Y1BRa0N5cW82RThMb3dTZk5HOStPZ21NOE5KeFhqYktwT2lj?=
 =?utf-8?B?SmcwdE4rVlBaMm4ya2xNVDRqTzVQVlRCNzNxWVJtNWJMMHYwS0t4bjRNUkJL?=
 =?utf-8?B?VjYzbmFwVkVtY1JCN0F4cERRTVVzUTdPQlZVZytpMU44UmpjSzFjaU9FYmth?=
 =?utf-8?B?UVVDTkw4ZGs2OVBLamVKYmpiL09FU1YyVTRFS2VxZ25nNVZiNDBKdFlJNEhn?=
 =?utf-8?B?aTRISGZpL0FUUlArU1JEd1JjSWYraHRybmJTeDdyOEw4WDFrbHRLQjVZWjZo?=
 =?utf-8?B?MGR6bjBKV3lFU2d4Mm1aVEtPOTBlNEFFZ0lUZ3A2aFY5M0lyTlRSR1pmbnVO?=
 =?utf-8?B?dWc5ZjVmZmJDRXBDaEI4YVlDUFBmbU4xRmpYYk53Y0FSKzVWdDF0Z2h4aXlr?=
 =?utf-8?B?bGhlRWxuZFdyWUlXYW0wdVZzbmxYdjRiUVZibmJFVG1STmZpQUl3Zlp0S3Fn?=
 =?utf-8?B?K3oxc3h5Yzh5ZzBWVDdFRWZqLzhjVkdMZlhkeENFMnU2VFFMM0l3REg0NUs4?=
 =?utf-8?B?a005SWwwa3VlZzFLVXVFVkZ4TXhsTzBPNHhWcWcxVzZRZzFjRDlFVC9sdE4z?=
 =?utf-8?B?N3ViUm81aWhJdzNLbTRIT0FkRWVNd09JU21XVmd3c0dRSmdxYk5qbEhnTjFE?=
 =?utf-8?B?dnNlMlEzTTN3VFpJQUxpTU4xSnVFRFRNWlR5QW1YS3NJKyszbVdGN3VPcXNp?=
 =?utf-8?B?YkErUFJRU09zZW9uVFdvVW9hVlBIUjNwR01LSDlBUWhvalVVTEo5RytPN1V2?=
 =?utf-8?B?YXpTRS9RbXRFOE01Mkl4eXlqODZ0dnRQZzVOUG9Kb2d6cEdQVWpTTkNnSXhs?=
 =?utf-8?B?RGlTOTA2ZzkwOVpLOS9xMFlnUklmc2lISHJhc2lCOCtnUm9TYUZPSk1iK2pk?=
 =?utf-8?B?TzRmbm9ZNnV6VCtWQXBZRzRnYmVFOFI2Z05vMWJEOVlYZU5NMnRpdW9ZOUQz?=
 =?utf-8?B?cHFoaVpyelhWeUJsZjRPR3JLQUdFTXA3cE12VUFiNUJrQXY0Qk4zRWNCL1dX?=
 =?utf-8?B?NUU3aDJBWGJLMnFJLysvQzhobWowOVRJVWw3VS8zVkMxcUZFWXZWcmFCUFlW?=
 =?utf-8?B?eVpWaTRnWVZmcDRjTytZc2w3YTgvOVNPdkt2VUZDSlNabFhFUElqb29zUnBO?=
 =?utf-8?B?dXJqWlQ4bllWaXFwcytWNVFoanV2b3FGWkprYmtjYTB2dmJ3YVlpV3JkTDdi?=
 =?utf-8?B?N1Vzbks0UytjOHQ3TU43UTl0ZFg4aG8vb1BYSkFGRGxKOFlrbnVFdkxxcE9y?=
 =?utf-8?B?a3g5RDdiTWdUQVFJclY5TU9pb283MGRVL0RwckxPRU44d2dsYnFTRmhYSE1m?=
 =?utf-8?B?NzlCRjBGUHkzUFByQUZLNnRUcW1TQURvcEpZQjAxNUZCbU1sdWJPdFlOTVAv?=
 =?utf-8?B?dklKb1ZZOE8rMUpyc3hRSEhHNXBBZm5jUTFWcUVMRkd2c3UzWExCMFAxbGVr?=
 =?utf-8?B?REFYYk5kL1dncU1ma0EwZz09?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5af567c1-b88d-46f8-4b40-08dd88321c8e
X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2025 21:58:16.8913 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PRAP250MB0514
Subject: Re: [FFmpeg-devel] [PATCH 1/5] avformat/apvdec: Use ffio_read_size()
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/GV1P250MB07377306C6F8F7F239FA578E8F832@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Mark Thompson:
> On 28/04/2025 10:39, Andreas Rheinhardt wrote:
>> Patches attached.
>>
>> - Andreas
>>
> 
>> [PATCH 1/5] avformat/apvdec: Use ffio_read_size()
> 
> LGTM.
> 
>> [PATCH 2/5] avformat/apvdec: Check before access
> 
> LGTM.
> 
>>     pkt->flags        = AV_PKT_FLAG_KEY;
> 
> Not sure where the funny alignment on this line came from (setting some other field there?) but suggest fixing it at the same time as this patch since you edit the previous line and it's not really worth its own patch.
> 
>> [PATCH 3/5] avformat/apvdec: Fix seeking
> 
> This makes more sense, thank you.  LGTM.
> 
>> [PATCH 4/5] avformat/apvdec: Remove inappropriate INIT_CLEANUP flag
> 
> Sure.
> 
>> [PATCH 5/5] avcodec/apv_entropy: Remove ff_apv_read_vlc()
> 
> See patch sent a few minutes ago - suggestions for nicer answer welcome.  (Copy/paste is not a nicer answer.)
> 

a) #include "libavcodec/apv_entropy.c" in the test program.
b) Move apv_read_vlc() into a header (apv_decode.h).
I'd prefer a).

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".