From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/5] avformat/apvdec: Use ffio_read_size()
Date: Wed, 30 Apr 2025 23:58:15 +0200
Message-ID: <GV1P250MB07377306C6F8F7F239FA578E8F832@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <65deee43-c9e9-4386-b3b3-2b7d7cf17fc3@jkqxz.net>
Mark Thompson:
> On 28/04/2025 10:39, Andreas Rheinhardt wrote:
>> Patches attached.
>>
>> - Andreas
>>
>
>> [PATCH 1/5] avformat/apvdec: Use ffio_read_size()
>
> LGTM.
>
>> [PATCH 2/5] avformat/apvdec: Check before access
>
> LGTM.
>
>> pkt->flags = AV_PKT_FLAG_KEY;
>
> Not sure where the funny alignment on this line came from (setting some other field there?) but suggest fixing it at the same time as this patch since you edit the previous line and it's not really worth its own patch.
>
>> [PATCH 3/5] avformat/apvdec: Fix seeking
>
> This makes more sense, thank you. LGTM.
>
>> [PATCH 4/5] avformat/apvdec: Remove inappropriate INIT_CLEANUP flag
>
> Sure.
>
>> [PATCH 5/5] avcodec/apv_entropy: Remove ff_apv_read_vlc()
>
> See patch sent a few minutes ago - suggestions for nicer answer welcome. (Copy/paste is not a nicer answer.)
>
a) #include "libavcodec/apv_entropy.c" in the test program.
b) Move apv_read_vlc() into a header (apv_decode.h).
I'd prefer a).
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-04-30 21:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 9:39 Andreas Rheinhardt
2025-04-30 17:48 ` Andreas Rheinhardt
2025-04-30 21:15 ` Mark Thompson
2025-04-30 21:58 ` Andreas Rheinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1P250MB07377306C6F8F7F239FA578E8F832@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git