[FFmpeg-devel] [PATCH] avcodec/g728dec: Remove AVCodec.sample_fmts

[FFmpeg-devel] [PATCH] avcodec/g728dec: Remove AVCodec.sample_fmts

[Andreas Rheinhardt]

[-- Attachment #1: Type: text/plain, Size: 27 bytes --]

Patch attached.

- Andreas

[-- Attachment #2: 0001-avcodec-g728dec-Remove-AVCodec.sample_fmts.patch --]
[-- Type: text/x-patch, Size: 1043 bytes --]

From e2b8892a583a09ca4aa607af8813b4947c2e6fc1 Mon Sep 17 00:00:00 2001
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Date: Mon, 23 Jun 2025 12:41:36 +0200
Subject: [PATCH] avcodec/g728dec: Remove AVCodec.sample_fmts

It is unnecessary for decoders (they just set
AVCodecContext.sample_fmt). This also fixes a warning
with Clang (because sample_fmts is set directly,
not via CODEC_SAMPLEFMTS).

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/g728dec.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libavcodec/g728dec.c b/libavcodec/g728dec.c
index fdaf0a853e..edf45c589b 100644
--- a/libavcodec/g728dec.c
+++ b/libavcodec/g728dec.c
@@ -215,6 +215,4 @@ const FFCodec ff_g728_decoder = {
     FF_CODEC_DECODE_CB(g728_decode_frame),
     .p.capabilities = AV_CODEC_CAP_CHANNEL_CONF |
                       AV_CODEC_CAP_DR1,
-    .p.sample_fmts  = (const enum AVSampleFormat[]) { AV_SAMPLE_FMT_FLT,
-                                                      AV_SAMPLE_FMT_NONE },
 };
-- 
2.45.2


[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/g728dec: Remove AVCodec.sample_fmts

[Peter Ross]

[-- Attachment #1.1: Type: text/plain, Size: 1301 bytes --]

On Mon, Jun 23, 2025 at 12:43:54PM +0200, Andreas Rheinhardt wrote:
> Patch attached.
> 
> - Andreas

> From e2b8892a583a09ca4aa607af8813b4947c2e6fc1 Mon Sep 17 00:00:00 2001
> From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> Date: Mon, 23 Jun 2025 12:41:36 +0200
> Subject: [PATCH] avcodec/g728dec: Remove AVCodec.sample_fmts
> 
> It is unnecessary for decoders (they just set
> AVCodecContext.sample_fmt). This also fixes a warning
> with Clang (because sample_fmts is set directly,
> not via CODEC_SAMPLEFMTS).

ok

> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/g728dec.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/libavcodec/g728dec.c b/libavcodec/g728dec.c
> index fdaf0a853e..edf45c589b 100644
> --- a/libavcodec/g728dec.c
> +++ b/libavcodec/g728dec.c
> @@ -215,6 +215,4 @@ const FFCodec ff_g728_decoder = {
>      FF_CODEC_DECODE_CB(g728_decode_frame),
>      .p.capabilities = AV_CODEC_CAP_CHANNEL_CONF |
>                        AV_CODEC_CAP_DR1,
> -    .p.sample_fmts  = (const enum AVSampleFormat[]) { AV_SAMPLE_FMT_FLT,
> -                                                      AV_SAMPLE_FMT_NONE },
>  };

please apply

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".