From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7D6D44A70E for ; Thu, 4 Apr 2024 16:59:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DCA7468D0F4; Thu, 4 Apr 2024 19:59:19 +0300 (EEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03olkn2088.outbound.protection.outlook.com [40.92.58.88]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7C63368CFDA for ; Thu, 4 Apr 2024 19:59:13 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j59DINgj9mG176XcgbUef9TkX6a0Rdj1MzDxG7s7XJRCzYjRMsQ14UMxrUvH9ud8TqbBu97Ah38wUvEoUCc/KSvdsnaq3Tx/hEoNYU2OYw4UjyGVpjyKLKW/NKuBziFjP6td/Z/By0V+wuPxk5Ea2F6Ei7p6mhzGmhwNKz+z8+v5fX8NW6mmmn/MQndpwRH5qfCIWaD8Snrwb702JnWJlnF0HT2JfbRAwkVEt0hB3EDioT0yw6JGm8V0pIAXV8uJwVBUytx0lkW++70Tu05PHoGLCnWs75WGgORQT5axPt978gbNPEuNePnaVaQ5iEoaT9MJhyKiBiCrraQOAT86Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DCQDzWiXrsArj+Ei+Tg66hFzzN2MswwiL1wgg18p5NY=; b=jYe6Exn4YHWpiK+9RdG1lR56zaGZO/ZOrl3FmK+F2mWVWk1LcAdQj5VenhDTWWVUqqGHvSCE5gkj4gVsjzaNQ4m2i2DEW+3SHEgFj7Rz20y75HSWKFLvuHACMtHu37cCkPlYmNYe2QQl3IV3RWGGktHi9yfvBs7n76Cn/fmNa5AMtGlSjL+IMky5rL/9H56ebBW5bLCfvNnGegKNQ0l90r1jF+Z2kgsmMmVop0iOqHb6OVHXvFZPaWsLLf9dyvmn7htA0V8G8/q2fD2RNLzNOXN9Exb2+B3QI83laG46dw2d2JyF219QrT4G8xkI4CC31RQUNFvy66wApGqqjW6p8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DCQDzWiXrsArj+Ei+Tg66hFzzN2MswwiL1wgg18p5NY=; b=I7vIlddqiCIRLJv1T/KgAay9QJoSi3bO/BtMIGIVKFa21FJa+FJjzrGez6skVjmxzvqerl4qVAyU+i8oJ38gQ9HE3NGaXIfTEai4iFrYvXNfjtpGkZWCC4ZqyGff+u995Y4wOoNbq95kG9mLIVa7ffgPrDScNoEQAtLbitRHMqfZUOtEYvvWIasbj3OMDeW6QvVe4tAJd+5UKzTIACChOPaMRNQllbk1RcUFE8ECRvvAtXUHkQKRVhEyLAPow2P6q78xd2DB35KL+or1pPdwESrsvO0+EVQSDnopPRjMOptI1IHqdCed1fFAMvYP3kb7nmQ+odPFG/BNAiAao1aFbA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PRAP250MB0613.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:293::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Thu, 4 Apr 2024 16:59:11 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.042; Thu, 4 Apr 2024 16:59:11 +0000 Message-ID: Date: Thu, 4 Apr 2024 18:59:09 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240404162936.4581-1-jamrial@gmail.com> <20240404162936.4581-2-jamrial@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240404162936.4581-2-jamrial@gmail.com> X-TMN: [Ih+Haw52dUt3Kx32bvcaqO1tzHAI53TCzEJ90Ok0W1c=] X-ClientProxiedBy: FR3P281CA0118.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::13) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PRAP250MB0613:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a69cc4f-c951-4627-a3ef-08dc54c88c98 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yDccgx2cb9qQHYVqk8s6xEhfnnUNTq0+ZVoq3y/uh4hHxkY0HyQHnu3QTHazbbThEOhWQFziA0kesGaGYsXezivQ2ly306PLsz9ImY7vj9TELEuQRVMLW8uHimPPvnnj667cm0et2NAlbPWKqah/jE/5ac2nFQvaJuGnCsme/HDuLmzSbfiyCS5tHkHvshNzG9Lz4jzF6WWp6Po2I6pnNYzWZZ3eSSFrqNCK4pJyERn0ApMp9DPku2/D90qA3WBTnSPlSaC1f0xX0o6wWf7HEZeVLXMkyVer1sGEsu0ss78K0h/u7zwp7t8HHJabrhEkwPpdlZcGFDlW3CWgd2a+G0Vsem6U14LTKO7NBHWkTjoa88dVghiE9g24QLLUOv+SzroXAgkFi/c+UhsypIG5H8fbBM7+wvpLNIr+TszA479pOZ1V+Gm3TAaQxrwmmR4amA4+HIzI/aEdbwTC6GZYBJBekHR6Wk4b0ALFqHLOhIo1h/XZpb6qGJm5QV8/VYCnfgiWuCqyErLWkprHdkta/VqIleSqOpulNpyKNaca8exoqRCI9xR0SdVjjON0Dhwt X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1RIOFU3bnA5MTJBWDRlS0pTVzlkcENUenpzdzNidHozVTV2Y2h2b0M2SjFM?= =?utf-8?B?cTNDN0RyZlROVGZBVjZDNkZlSW9RenJMZDViSXF4REF4Z21iUlFoTzVleVZC?= =?utf-8?B?L2FubzJFODJDbitzaFVhZGpHVXNYT1BQMXBWb3dWUGxMSWNkQ2tBUVhkeWIz?= =?utf-8?B?U0Y5bTQwWnl4SVIrOUtjclYxdDd3cUl5UG9ld1UvaGhzMmM3MUJhdExab0Jp?= =?utf-8?B?aFFxUHZObXc2dkRPSFl0djZLa0wxMFFrZVByQllWWnZHQVhXdkJNSGNzby9w?= =?utf-8?B?alVoQVFDSm82cVlEblRBMzhzbWtPUlJaZlJDajBKWkd0RmI1WEJSMlpjMkp4?= =?utf-8?B?aUs1NXA0UmN0eE5md1ptWmVWQmk2ZVFEM2lNeFp5V3ZZNmFNV1I3dzh4NmRy?= =?utf-8?B?bTlPaDIrZ2IrbS9tWXRUNWNLdVdPWWhaMU83VkhkUzBNNVRXVWZnTGljcVg5?= =?utf-8?B?eDlITVVsNlZyKys5RVJ4TUZWemsxMnhPVTk0LzhwTkpQV1A3U0hjaTY4eUh1?= =?utf-8?B?N3AxOGQ3UFB6TFcrcUV3MkR4dFNaUWFSNGdRSDBaTnVITnhwZzRPSUZwQklm?= =?utf-8?B?Rk1ycEJWTWNPamRCNEVOUU1PcTUrSDlEdEczM1hsWnpqWEJwM3h4WUxJcHB0?= =?utf-8?B?VUFYM1YySDc1dktaOFBtVTczeG1LNGwvZ0lRbExnZzhQcnl2SjJ5UUdlQ0Nv?= =?utf-8?B?bm94d1ZlUFIyOHJqMnJ0ejJEY3JSRWhOajArdWZmUUJBR0NZdERlM3pnZEJw?= =?utf-8?B?bjFobjI1RlM5S21PN3lzNlByYkhjeUszOHZFbUszR2JDaHZFcmJ5Ukt1Tzd2?= =?utf-8?B?dVNTVU53UVI1RkVYMU9FNytiYzZiL09RZjR0eUYrR2IvY01oRlJPR29tdjky?= =?utf-8?B?Y2pjSkFmV1pzL095UnRmSTlhMmNIOXR6ckp6dWVEQ1gzUUlSVEhJN1haWGVQ?= =?utf-8?B?M3Y3Y0pGdVZYWk5ZTmlCblFTOXRFVlFjVlVLcU1QdjNzNWFPNzV4REpMZUNz?= =?utf-8?B?aXcwcUVzN1l1Ymc0K21vVUs3WHNnU25sRXF5bmhFYTNxY2hxaWlQWDdnK09R?= =?utf-8?B?c1N3TWpJRDhFaXNWa0MzOXBST0Z4dWJSRjJpMTdvblFRSTlZT2Q2SWp2T2FC?= =?utf-8?B?Q3ZDbERsem1lZ2tsQ3RKMXVybXBBQ1JpRXNjT0VSM1RuKzFsUVU1TE9VRlRZ?= =?utf-8?B?MWcyc3psM0E1NnJBVUp5MHFyZFFjQVIyZ3dZS1NFeGdYRVBLS0FnL0dLSXpv?= =?utf-8?B?RFdOMzZQbXNCbkhDVlZaYTdBTldZSE9GYUFLZEJMcWlyNjJBZVhaYnRVa3VZ?= =?utf-8?B?aFkrYUd6cTk0OFNKcTVUcmR3QzFEN0JsWHJKWEE3YU0xQWdPNm94QnFFR0lT?= =?utf-8?B?a0lIYWhwUkJOYWZQWmRyOWVKQlZTVmp3KzIvU0syQ0pNOUZVRUkwSkJGSGlu?= =?utf-8?B?cVpxM2FVTVJmdHZiV3IySHVmWmd4Y05Ga1UvZWs4a0lDdlNTOUJhR25TbFhD?= =?utf-8?B?MWFqNkUyYUpodFVCWDJ1aFNrVmh1TW14UFc5eXUzMFZBK2MreGR5L1IxbWFM?= =?utf-8?B?NFR6Q3pBQVg5bk5oaDFCVmFJNW5jLzc2N1dTRG9ncWhTYzhvYTZuLzdCZWxR?= =?utf-8?B?S25zSlFNTldSR3p2YzdOakxnMDVTeVloeGRJY0h5NXpaU3ZQVjdQRDFBT1Zw?= =?utf-8?B?VWhCYnNSdjg3KzRiOTcvTUI3b0E5TGZSQy9RSFRVeEhBUGJsVTNheGxRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a69cc4f-c951-4627-a3ef-08dc54c88c98 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 16:59:11.0472 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PRAP250MB0613 Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/liblc3enc: don't force unspec channel layouts X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > We only care about channel count. Layout details will be ignored either way. > > Signed-off-by: James Almer > --- > libavcodec/liblc3enc.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/liblc3enc.c b/libavcodec/liblc3enc.c > index 63d1645b10..5f8169a0cf 100644 > --- a/libavcodec/liblc3enc.c > +++ b/libavcodec/liblc3enc.c > @@ -61,6 +61,11 @@ static av_cold int liblc3_encode_init(AVCodecContext *avctx) > "Unsupported frame duration %.1f ms.\n", frame_us / 1000.f); > return AVERROR(EINVAL); > } > + if (channels < 0 || channels > ENCODER_MAX_CHANNELS) { > + av_log(avctx, AV_LOG_ERROR, > + "Unsupported channel count %d. Should be 1 or 2\n", channels); > + return AVERROR(EINVAL); > + } > > hr_mode |= srate_hz > 48000; > hr_mode &= srate_hz >= 48000; > @@ -195,9 +200,6 @@ const FFCodec ff_liblc3_encoder = { > .p.type = AVMEDIA_TYPE_AUDIO, > .p.id = AV_CODEC_ID_LC3, > .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_DELAY, > - .p.ch_layouts = (const AVChannelLayout[]) > - { { AV_CHANNEL_ORDER_UNSPEC, 1 }, > - { AV_CHANNEL_ORDER_UNSPEC, 2 }, { 0 } }, > .p.supported_samplerates = (const int []) > { 96000, 48000, 32000, 24000, 16000, 8000, 0 }, > .p.sample_fmts = (const enum AVSampleFormat[]) I think we should rather change encode.c to mean that an UNSPEC channel layout (in AVCodec.ch_layouts) works with every channel layout with the same number of channels. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".