Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH 1/3] avcodec/evc_ps: Fix size of tile_(row|column) arrays
Date: Sun, 16 Jul 2023 16:22:28 +0200
Message-ID: <GV1P250MB073764F3F49BCC06E8FFDAB58F3AA@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)

Prevents out-of-bound writes when parsing tile row heights.
Fixes Coverity issue #1538300.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/evc_ps.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/evc_ps.h b/libavcodec/evc_ps.h
index 0bbec1f138..336953b176 100644
--- a/libavcodec/evc_ps.h
+++ b/libavcodec/evc_ps.h
@@ -192,8 +192,8 @@ typedef struct EVCParserPPS {
     uint32_t num_tile_columns_minus1;                              // ue(v)
     uint32_t num_tile_rows_minus1;                                 // ue(v)
     uint8_t uniform_tile_spacing_flag;                             // u(1)
-    uint32_t tile_column_width_minus1[EVC_MAX_TILE_ROWS];          // ue(v)
-    uint32_t tile_row_height_minus1[EVC_MAX_TILE_COLUMNS];         // ue(v)
+    uint32_t tile_column_width_minus1[EVC_MAX_TILE_COLUMNS];       // ue(v)
+    uint32_t tile_row_height_minus1[EVC_MAX_TILE_ROWS];            // ue(v)
     uint8_t loop_filter_across_tiles_enabled_flag;                 // u(1)
     uint32_t tile_offset_len_minus1;                               // ue(v)
     uint8_t tile_id_len_minus1;                                    // ue(v)
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2023-07-16 14:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-16 14:22 Andreas Rheinhardt [this message]
2023-07-16 14:24 ` [FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg_enc: Remove always-true checks Andreas Rheinhardt
2023-07-16 14:24 ` [FFmpeg-devel] [PATCH 3/3] fftools/ffmpeg_enc: Reindentate after the last commit Andreas Rheinhardt
2023-07-16 14:39 ` [FFmpeg-devel] [PATCH 1/3] avcodec/evc_ps: Fix size of tile_(row|column) arrays James Almer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=GV1P250MB073764F3F49BCC06E8FFDAB58F3AA@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git