From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7443E46A9F for ; Wed, 2 Aug 2023 15:36:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E6CF868C64E; Wed, 2 Aug 2023 18:36:02 +0300 (EEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01olkn2029.outbound.protection.outlook.com [40.92.65.29]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0B14768BC6A for ; Wed, 2 Aug 2023 18:35:56 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LoO+2pADuMbwqbMryjWDonCwQ2U0HBJu9uO8tv7rcXeqZ3gsY6e6eTlOlMJIZTG137qGWfLrc2PeuMJbhhsFMuo4XkcTg+2D5rwgNUxEYJxfcTgvYYJt8BxWzQsJrZ1XglmSV2RL3d0ppzqfwRQ35wt2fI0Ak2bMVny7d293uqDWwMgmFdXeEzkvu98TLhxXJQrD2XkiWLRUXdXnheJz0fbZODHb0Hfr7GJGmjL11qcnfmkJWeHXbyvy06X28HOtw2Z9ztShK0AsI/ixA9Db56kAGpy1luYSJ2N+tLr26VTFXi1TtUFb8NO8wLGWZAcdwTE0riHjSCv0kepwNJAC8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DhGeGfh8170aVRJ15sELI2hiUhL21iK/i0GYFxdpTN4=; b=lLbAgkar5bgAz7zvxHCKPH/xDXyVHhkdI1SgN4M75jFbD3zgcx3EVPhtA210k9UPCBQjcMhAk3Eiuc3DXrN05hWzVFecGSXs9jGeKpHFQSssSGmQBSwTL7h8XXaCtttJj1itwwrZB9opDiy52cV+Wyq+EduawXVTKrfa2vGNt/OdB3vrw0nFm4vWxePPMKc2yfCPJfrKUBb48ZuhVdDBDffjnKxLPC73eBQ4C+lsu0Y+T8UQUoPfr9TpYVoiOrKp02BPYFjPN6OL0vC/D17cQxLexbbNSvNq/Mo/Xxa9NhuaplVsY9DxZ59k+WhDITLpD/mVz7Y0oYyrKEBtXcJ4CQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DhGeGfh8170aVRJ15sELI2hiUhL21iK/i0GYFxdpTN4=; b=rTmwOHa5nI2E/xbbYhgBJV7Dogfx6FAz02bz6fcYNybNlIql1HKhxFI0mUxJ99x2xfxOzWoocv3VZLjwdPGoA6ziB6k1qUVyBpzewcY3DVfMVV4Tb/IfIUNTAOMLhQUWT3lLSdYBd619Xbmr5+n7FzuQtStbTJ2fCVaypotPWTvOdTSoeD5M/O9NzwdmNpp529TYLcwirljB8NyQ5rrqvFEfsZdE4ZHvBjlgsKd11N8iaCNdmWuyRqeWiYr+ggGFvQHr8L8Qzh557xWUfz6XCcI3ioaxDdLevPwIiYTnH3Dj0teHvyuko0dArC9vTnZesK8uE7PIRZjFxmq7Dw34LA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0158.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:321::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.19; Wed, 2 Aug 2023 15:35:55 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4d3a:7ca6:cf28:9e8c]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4d3a:7ca6:cf28:9e8c%7]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 15:35:55 +0000 Message-ID: Date: Wed, 2 Aug 2023 17:37:07 +0200 To: FFmpeg development discussions and patches References: <168907039655.27367.6593832128550408622@lain.khirnov.net> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <168907039655.27367.6593832128550408622@lain.khirnov.net> X-TMN: [W+1NR+4ltE9XcsZikGgoai+gQrzDg3atSv2lVQmUqAs=] X-ClientProxiedBy: ZR0P278CA0104.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::19) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AM8P250MB0158:EE_ X-MS-Office365-Filtering-Correlation-Id: a2d23058-16ff-40db-1e3b-08db936e2955 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bD1rkmqTK3Smd5NekMJXAPSzM1Y687MbjmdsmKT29QJdfkfWYKiO3QLYBN/FjM9RZCHeBwgdIloS+wyGblH7QKoSaHrIGLlGeH2RXKdn0u178w0CF4JV49yvRMmcqiwmOVYTNITHSRE3fhrk7SqWmiykOtopG7cZZDn6R0Crhx9zIixcVtjcetw718GQLLOf4mpVF+bSsqlKjOxQg1KkcybDaH8sCYfd5+Y6/kqCwNVUWaLbGi+z93bYUwz1QZHKw48bPWTIQv5cseCgR3nSlm+RxT9QWqFHlZBF10wk91t4rJAljIoTr3qdosGGlOQlzaz3rNOs4u4CKm1FuU1ziWIt0o+ywzUpnch5OPr08qBcZj+LkTANnEgvLH4vNJyDhJY7Ft5Zya71kgaTEdoX2d76pu2K0RnT4Dyz37nv+7Zu7r44SlOAOhcMMBqDAODCVrlTlcmilbojJ8zB/EZvwy+UgNfe6akev+LdC5OiUxNO/kN21/ItDa0cej1DZMrzDBeodU1qi2JTqBQGzxPKT1ruNPmzOceFyhcJRRFPG7WmwIX7/akOlR6CDOawYLNj X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WTNTaU1OTFBkK0dySC9DM1loNVltOEdyakxiVmtQYncxc3lDcExOUnF5YW5F?= =?utf-8?B?ZjZXRXd5R0l1Mkd2bEk2QXR1S0RpY1p2ZEFDbHpjdVljYWdCcGVZNkFFMThS?= =?utf-8?B?REVuK3h2NnZhbzZ5NDI1eTRKaTk2aFNCV29nWFIyN3lDeUwwa0U0ajExTkxZ?= =?utf-8?B?NS9qTkNPL0dxVGpZZHZrOTFJNHlLUndTd0VOQUFBMEttdDNzeUxyZXZPQ2R5?= =?utf-8?B?YmN1ZWs2cSttejRPdm56RW9HT2NHdzBFdnFud2h2bEFtM3pRSjFPek51UFk2?= =?utf-8?B?ZDd1b0JpYitQN2ZFSTlkUlJ0bGFYdEl3d2ZDRDd2MlJqNDV3VUZySU5rWHhL?= =?utf-8?B?bnpnK2tDWTBXNGZ4Q3FBVHlZTE43R1IreUdWaWp6RCtIOE5IVCtzRHJ2Mk1X?= =?utf-8?B?QzhaTFZhYU1aVFNwZk1rOWRQUktDb2toRU1rUjhPQ0VMV2VCejdDRllRanFp?= =?utf-8?B?eWdMbEJoQVNuM2s3cEQyWVVnZERWcVRVU0VINE9nZFBVclBsQU5wZUNBdi8y?= =?utf-8?B?Zy9uN2NYWk5jbGt5eFhmMXVTV3VxNXpGSXY3R3ByQ2RqVDMzbWxaK3NsVlps?= =?utf-8?B?Qk8zZW1ZL3RpNTZyMG0wRW5IUkk4eEF0TmZYR1h6OU1TUkJoVm9ZNitkNkFa?= =?utf-8?B?d0R4Q2Z5bnNWL1NVYklmQUtGdjUzclJNUlN4NFRtdTBTQ3FXdzkrS2Zza0kw?= =?utf-8?B?RDlreExlQUE4a2lHM0UxL0dJOFZLeEJFdDl0NTBaQ1BSMEVIZElBZnJtQjBJ?= =?utf-8?B?QTNpZDYvVTdwZ2NsTTRCTzQ3YW9TOWQ0ZG1jOXY1dUpIRlI1c0p3TUZmOXdS?= =?utf-8?B?MVllL054UDJCMzVPdHB1ZjNzd0h0VjVqVk44L2szTG55TEhlZXdZbDJ0OVov?= =?utf-8?B?ckgwSkNxT2lxOVpXdHFKcStnTmlhUjl1akJPQmh1K0R5YlZieHlQQmwzTUdj?= =?utf-8?B?MTZEMGdoRUk2YzBZTVJyWmdCTGFYSWJONk1uK0NDQ1VETDlzYTR3UFVteHhu?= =?utf-8?B?THlZWkx6WXpPTU9iMmZvZVc5U0NSSmdKMURwNWNKMzlvTGVkWmpraWpwb1BL?= =?utf-8?B?SURSVUMrNGZqSjVrci9VNFdnek5kVURrUXRacDNLVnhRa2V0aU9KQ2doTmJD?= =?utf-8?B?OEI2K3VxZUdKYTBuUmcxSjlhWWdUcU5yNkVtR20xWUtRZFEvOHJFU2lqdFlU?= =?utf-8?B?c0FNdEpGZERFY045eE9MUUt1NVhGY2dSaEZibS9YMXJBbUJDRlRTczhQVDUx?= =?utf-8?B?cjJabXFwSjNyZzd3bi80cHB0TFRYMmFOTEZ1MVRDdkJLSlVTUmFjTTZJeGFv?= =?utf-8?B?eUhieThYbnhRaHRqKzkrblEyQm1vY1kvdmlHOWtQUGtzVytubGM4SDM0Sjkx?= =?utf-8?B?MUdIS0ZWYUJpZmY3a3poMEorQ2JUK1h1dVBHWDIwZVQxcFBkWmRIbUJaYUNh?= =?utf-8?B?OG9EQmZyS29XSGZTTm5YTlZFdGUvZDROSlg3bG1aeXFJUzlBOXhFVENjV1Zx?= =?utf-8?B?TlBkTjZOZnk2UkpIUzQwVGtBUHZuM01tS3pYMklrOUZySGwyQzFLa3BxK3Vv?= =?utf-8?B?ckkrVGhkaTJuYnAyVkx5aXp3ZVVNTHlXT2poVW00Mzd4L2xqM3ByaitSODdB?= =?utf-8?B?VTh4d1JicmN1ZVJHME1iMEwzRGZCbEdIRzdkc2FBQ2UrVm9ibU5rWi85TjdZ?= =?utf-8?Q?H/1CpDTJf/96YqlE3pZ2?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2d23058-16ff-40db-1e3b-08db936e2955 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 15:35:55.5111 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0158 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/internal: Move AVCodecInternal to a header of its own X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Andreas Rheinhardt (2023-07-11 03:10:38) >> This allows to avoid exposing AVCodecInternal to files that >> don't need it and only include internal.h for something else >> (like the avpriv functions which are of course included outside >> of libavcodec where AVCodecInternal should never be visible). > > Actually looking at all those other things in internal.h it seems to me > that (almost?) all of them belong somewhere else. > > Multiple functions are only used in one place, some others are > encoding-only and belong in encode.h, etc. > I just sent some patches that moved some of those functions to their only callers; there is one more, namely ff_alloc_timecode_sei(), but I am unsure of how intentional it was to put it in utils.c. ff_guess_coded_bitrate() could be moved to encode.h, but I am unsure whether the implementation should not be moved to encode.c (or to a new encode_utils.c?) in this case. Furthermore this function is only used by encoders, but it is used to set a field (namely AVCodecContext.bit_rate) which encoders are not allowed to set (for raw codecs the bitrate that will be used is actually determined by other factors (like dimensions fps, pixel/sample format), but normally bitrate is an input parameter when encoding). ff_add_cpb_side_data() is used by mostly encoders, but also used by mpeg12dec.c, so there is currently no better place for this. The two avpriv functions as well as ff_toupper4() (duplicated into lavf for shared builds) can't be moved to their only callers, obviously. ff_exp2fi() is only used by two places and could be moved to e.g. mathops.h, but then this function would be included in so many places where it is not used. ff_match_2uint16() could be used to e.g. mpegutils.h, but that is just based upon the current users and not about the function itself. FF_SANE_NB_CHANNELS is used in several demuxers (which is the reason why I want to separate AVCodecInternal out of internal.h). So I conclude that one can't move everything except AVCodecInternal out of internal.h into existing headers/callers. So either one adds a new header misc.h or utils.h for the rest or one adds a new header for AVCodecInternal. Or one leaves everything as it is. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".