From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6C8E14A195 for ; Sat, 23 Mar 2024 13:15:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 55AA568D526; Sat, 23 Mar 2024 15:15:18 +0200 (EET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2017.outbound.protection.outlook.com [40.92.89.17]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4BFCE68D439 for ; Sat, 23 Mar 2024 15:15:11 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bsyd0hk2eIZkAffNFfdzsIxDtgGV7leWW8zTb8koVjm4IPkpeUuNeZ3EHsXIuVVc9EDGeMHbyRAZQJoJudVhbuzGhfg82e84XZXUnv/8Z/w5ym5YOktTU32eohliSkok2+I0UQzz/SNvMwjviKpW7cZNtOe3rxROxex7Kx3NUkS+4hGYxs++ZQ0ViZrsnI609wlQ/mB95GdszjWw8cuGXapoEXANIB7+b5eNIunL/AzNIHSXS+hTyAZpre9xECHcLsMqqgs0tDa/GoqFZRNLvhOKE0CRseP+DsFYj8LeRmcFZttCdrhaJ1e7KO4DTqUgeA8Mp7QXZGry6nA0OSxjGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OFXNwTjEO4ft0kKLovD8LG2sIfe/L1peyNAVWD9pXqY=; b=knTYGxePbnwXQq2/wurUebZYSeudLnUaDCmYFRnpJtSfJxz0tbrR6vMv/q3FC+8ZV5WD0bLHgn9di01bVCHsmoGNbI4I2tRhfXTr9ZZRgNJmiRo28tg949QlHCYoJjqo5o3Y6T77YUZEa9jXnFHrmi8GrWt/LBkxQKFiKrD9V0vNtNc5cib+KUdAeGyGbY4FiUKQ3Uu0257/A5dL1fLbHpgoruZFSyorjS2TAJmNDlud2dJ0l05rC+hZZIqBqUWPW9h+E6y3hBP6NPBxDKo6HgY1h2GQFL471hFtBfnURW29nR695OEXeata/cDLPsfwZ03tucr01PyuRsOSyc+TTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OFXNwTjEO4ft0kKLovD8LG2sIfe/L1peyNAVWD9pXqY=; b=rv2605RmbvXiq8ymv+Iwt1a6qdl3fs1x9yz1TkrlRHQSv2Eiv/vdOemWdQ2guDikV1xT6LmVQaQ3cO9CiT3NlURwrzgenK3cv4Jod9e69aMXag4fmuWMVWOpPheJZFFJORtFyt3GciM4jNzlWO+U9OuS21r2JDKqwfE64ECLL1tWPrV5Ou65RDc2XbkTge181jy5qCILz+Tq20HgnqsuL/iN/lE1brfaaqVKm5nUCtfstGW418Ec+gvupIMe0R4Cg2GT+9pSv7pUAnKytfFu/8PXOwhlB6UeOWSV4vf8qa+cMyy3IfhDT4T/Pr9kzXLrUpyxvFSqn8h//cH2lDuBOA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DU2P250MB0174.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:273::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.26; Sat, 23 Mar 2024 13:15:09 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7386.025; Sat, 23 Mar 2024 13:15:09 +0000 Message-ID: Date: Sat, 23 Mar 2024 14:15:06 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240323130409.20925-1-anton@khirnov.net> <20240323130409.20925-2-anton@khirnov.net> From: Andreas Rheinhardt In-Reply-To: <20240323130409.20925-2-anton@khirnov.net> X-TMN: [WEFYqRckGstRRyIvF5SMmWWyH4F6dJrpmpeiZNCFcxw=] X-ClientProxiedBy: ZR0P278CA0059.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:21::10) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <17261e5c-e9dc-4d13-b98f-4ca5d7fc3d68@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DU2P250MB0174:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e08a45a-2dcc-43c8-50c8-08dc4b3b4351 X-MS-Exchange-SLBlob-MailProps: Cq7lScuPrnqkjmXb1vlddM5aSa/Epk3A5x6rj+83+QTC9KFg3Jw2NmmkdhgzRgVKSPV4ZYm57s0YYpUU40BD3c42LFLY7OuTbebiZvol2FqpJy3un2O61VD3AfLAvKPEAiAFQoJGY45zirsTQNl2ayCZnPj7y3l3kSQmF5JmLqbADbB5gnC+NK1ONp4f3gkqRL5wIuwJEqezByTLXHylpcxLFbXl6LruVpscOP2TvBokHs+TTzc80D+NkjZMSzoyAD3U/M7irlswGLnu5eo8Y2M4VO5IiR3AzbRINb3zgdmoAKggUsfDCSBVXtKCv0c0dd1EOyq9IAfJgiB6X4ELim/24ziT+UafFupFeGQ74NcIO7b8/u+3m4Jd7PUiaKvWiLkalgj4hpMa/1r5MEX+XyKgRmRXqlMd6ucn+lvhZxWbiLWZxzs385+/txCdZHVQxFOPAm6giipKT9NWdZD/Plzv2V1PIePyfi6rdzCOSdCSZwdXQRbLa48HbSDqjLx6AHt4MymewPDsDNN+DSBH7k6WBh+h95Au7lMZtQ6fxiR93TvQJJBrWY/lOcpXowbLObGVpykYGtsk1I9qNteldEcgXfv7CCpSRPGBuZ9TKV7qgLKU5tNKs5Fyl7vxsKDigYHwDtw+moaGF7v0P+1r5QU6W6OwbhBcz8BjktvTHo1Fls1pUTMxnT3slE+iJv8GOj/5noQEsvtX1Zik1g5XHbaWjAflRbe2G6zqXmE4FRO+kdfvtP+qnd2J8lSvk2rNIiz58lJL0gY= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uypLisn0CWs/0TlvpKX3xWnhzFovFrPp1L0EmK4WdlV6OaCAMBII10/qiDBTTtyVE0cqzntNZocDrSQ1Cx3YjZRek+hWrEbsWzytn1mYt9XzJHOzH6P0lgC+tTBKveF3MuRQJoEON6DJAyaJVYz73+DSuIlT+KDS+bpPIZ6N2Vu7XIClp1mny0zYWbqnCtCO5n/3vUsboxa82oO1moc48rwRPh4sXCc2vr57sTvyaIXeBXFsbHMTAMAprX40K7WTk1P9bOVIP/eAkjejP1GGrMpZ/YUJ20bcSo4lVGN54NtLgyfC9yUtuktlpniJ04myXkSwgxbF2wuzw6Fx64Pv7r15Fvc+s3Gy9tUSh+riW4xN7S60P/pIFIygaD3VswBCS6CDg81tLmsDziY89523hG5/kwpbrNkEQ1n4vygF/XOr00cZoHpMhnWLKT61C+24URXV3ua+wOSm7sdTp+R2sw0QnQnbrUwOxgLOXiuwsml3V09ILL1voy9R+EO+9JiNto3u/uxgxSnfcSZnVeMfXOcmss5RPT4nvdKkzCu51TY2lzkm6SgU+VryBqZCWm/4 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Sm9lT28yTWdmT0JmNWdaQXhaWU1RTUlBdTkvNHowOGpkRkZtUmtsMVJuK0kr?= =?utf-8?B?b1Z5VVd2a1Zkem1GMUs1TS84UVB4VUtjSlMvK3M3VXJaR0xMOXpEZ05GK0Nj?= =?utf-8?B?WWlLVDl1TUhMNXZlc05UWWg5ckV4R3hLSXBtdjlOZTlXbnFyUVJyU0FJaXo5?= =?utf-8?B?U0ZCT3l5VC8vOVpocWVsbUwzUkNmU1lhZzlJUlFOS2c1RCtVTHBpS2NETTh4?= =?utf-8?B?aUlOMktuSGxRck1vakFoNGRFS2p4bVYwM1drSm5acFpmb0ZWQkZsWkJtUnBZ?= =?utf-8?B?cUZLMmdQU1NCNDJKNlJ5YjVxaXpnZGxHdHJMMldBZ3k4dzZUd0sxMlBabDA2?= =?utf-8?B?M2FBUHNUSjVkelRuR0c1SWtXamhhUTBCY3RxYi8rRUxDanAwU2xHWVdGWDVq?= =?utf-8?B?ZnJnTjN3MzR3S1dLSWdWQzF0M1BWRTREaEpQNHJVTnVCUHRTT3kwSW14MVk5?= =?utf-8?B?UllnYVBDa1BOcEowTDl3UEl0NlIyK3R5a2FoOEZJZW5IUVFWQ0t6OEFMUkd4?= =?utf-8?B?ZDhVUTNkMGZKenEvRU5HdmYrQkQwWmFKbFhjMHprYWZoMlRGYW1vaG1MYUw4?= =?utf-8?B?TFh3QzhYS1RmZUFvQ0d0VkswTUw5aVNtTmU4bWl3WGV0WEpZV3ZDd09QcDRh?= =?utf-8?B?QnNhaGlqMy84RFFUUHpRUi84amZOL2hRakQ4YXFSckZMSU1LRmh4OUlkay9l?= =?utf-8?B?Mk5ueHZyZnZwWUt5K09BOHQ2aHNGN3JoWElpK1JIcHcvWmwrdzhpZ25wRWRj?= =?utf-8?B?WjdRcFBaNVZQV1NBN0VKN1c4SHcrdlUyRGcyN3VzVCs1VTlrUStSaEhSQnBB?= =?utf-8?B?NzV4ZnJxUEZ3MzBGeXZNUmZFL29WVzVKeTBNWUxuYlZyZlBlSHRGQ0hIS1Y2?= =?utf-8?B?ck02NE1uR0VSczAzNWNjdFBnOHNzRURzeDNyVkd5R0JIRTk2U3lTS3l4aGx3?= =?utf-8?B?U0JDaTZ3NFBXT0FDVGx0M2ViL2ZLVU1NR1pRazRtQnN2YXBqVHovck52dkUr?= =?utf-8?B?UFhBMXA1N3RqcVM4YkNEVEhPT2xvV1JBVHBXRGpxSWRuczlHeDBOaDcwQWcv?= =?utf-8?B?RzUrYzRwdDE5cVpsdzhISEp1N0RBQUsybTRyUkZ5UVk3V0N0WFVmaXFTTE1R?= =?utf-8?B?RmV5c0tVVDRJR05PNzBrNm1HRExiWVk4djAzL21VeTZkUHc3KzZJTGdlclNk?= =?utf-8?B?YlU3YSt1UDgzL1NkNXkveDZhSy9MeXdSbFV5QnpZODZ0UFg1Q092SDRiR0dm?= =?utf-8?B?V2ZuZnRZaGRkQzQrMWhIMjNDeTVuczEvZXdIN1JtRVVwNStDODJ4VUhVMHdS?= =?utf-8?B?cmZ5QXhzOEtZK0ZQUXRpcmg1N1krdW14QzlFb0V0ZDNNbWZObTErTjJVekc5?= =?utf-8?B?WnR6eFE4YVBocXlVTzkyR0RFT1FZZXAra3NjVW1POWpaWGlCN3JCREhXdTU0?= =?utf-8?B?akxIN0JRMWhad2p2S2lQMUtPaXYzNEZ1dUdyZUc4TDZaYk9NUXJvb285TGkx?= =?utf-8?B?WllTWGpqZzZyQzViRThIRjJSZHZrUVFXUlY0Q20yWkt0R1RIenFHRlJpVk4y?= =?utf-8?B?VG84YWV5Z1lwV0luaW5TL2JQTDd3dWN3L1VDN0Z6SGZPc3BIeG9IUFNtb2Va?= =?utf-8?B?cUNMcjRoQVVLbXlhbG1uUExkNyt1YVIyZTA2WnhDWWxMZHovUDBoaHcwVUZy?= =?utf-8?B?d0VNbHFIRlhKYUozZkl5dGhIWCtMbS9xWmxwV2xmT3MzTldRbXFyZjdnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e08a45a-2dcc-43c8-50c8-08dc4b3b4351 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2024 13:15:08.9619 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0174 Subject: Re: [FFmpeg-devel] [PATCH 2/4] fftools/ffmpeg_enc: only promote first frame side data to global when meaningful X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Skip those side data types that do not make sense as global side data. > --- > fftools/ffmpeg_enc.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c > index f01be1c22f..6a91fd0398 100644 > --- a/fftools/ffmpeg_enc.c > +++ b/fftools/ffmpeg_enc.c > @@ -247,6 +247,11 @@ int enc_open(void *opaque, const AVFrame *frame) > enc_ctx->chroma_sample_location = frame->chroma_location; > > for (int i = 0; i < frame->nb_side_data; i++) { > + const AVSideDataDescriptor *desc = av_frame_side_data_desc(frame->side_data[i]->type); > + > + if (!desc || !(desc->props & AV_SIDE_DATA_PROP_GLOBAL)) > + continue; Why the first check? Is it intended that a defined side data type doesn't have a descriptor? Because IIRC all side data types that can occur here are defined and have not been created by letting the user pass a number via options. > + > ret = av_frame_side_data_clone( > &enc_ctx->decoded_side_data, &enc_ctx->nb_decoded_side_data, > frame->side_data[i], AV_FRAME_SIDE_DATA_FLAG_UNIQUE); _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".