Re: [FFmpeg-devel] [PATCH 2/4] fftools/ffmpeg_enc: only promote first frame side data to global when meaningful

From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/4] fftools/ffmpeg_enc: only promote first frame side data to global when meaningful
Date: Sat, 23 Mar 2024 14:15:06 +0100
Message-ID: <GV1P250MB07375E82C3D65313A781397A8F302@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20240323130409.20925-2-anton@khirnov.net>

Anton Khirnov:
> Skip those side data types that do not make sense as global side data.
> ---
>  fftools/ffmpeg_enc.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c
> index f01be1c22f..6a91fd0398 100644
> --- a/fftools/ffmpeg_enc.c
> +++ b/fftools/ffmpeg_enc.c
> @@ -247,6 +247,11 @@ int enc_open(void *opaque, const AVFrame *frame)
>          enc_ctx->chroma_sample_location = frame->chroma_location;
>  
>          for (int i = 0; i < frame->nb_side_data; i++) {
> +            const AVSideDataDescriptor *desc = av_frame_side_data_desc(frame->side_data[i]->type);
> +
> +            if (!desc || !(desc->props & AV_SIDE_DATA_PROP_GLOBAL))
> +                continue;

Why the first check? Is it intended that a defined side data type
doesn't have a descriptor? Because IIRC all side data types that can
occur here are defined and have not been created by letting the user
pass a number via options.

> +
>              ret = av_frame_side_data_clone(
>                  &enc_ctx->decoded_side_data, &enc_ctx->nb_decoded_side_data,
>                  frame->side_data[i], AV_FRAME_SIDE_DATA_FLAG_UNIQUE);

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".