From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 03E3444536 for ; Wed, 14 Sep 2022 17:11:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 11C7368BB50; Wed, 14 Sep 2022 20:11:05 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2015.outbound.protection.outlook.com [40.92.91.15]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 34C6268BAB0 for ; Wed, 14 Sep 2022 20:10:58 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Np/Q8UcKoB0pw9Mbten7XxJLffV49pirnbS15HkIkCCC6U4OoWbo1msQZrStf4KYs3+8d9tT5vUeLaN1aAluaI6s57qGK2JiEmkN5ZGc+u1R9m9zNf1X39JvrAbLoBKLT8yWSEYefVqz4Die16SKCGwTmnCNfyzj6EzVJ5qMII9Y/8NNRrI4FpyOAtwd/TVjPP9rGSM68fTjLkswXstj/DzJ3XoL52mnu9ylxmzauOSjcmfW9SOsUkk+Wbwiq7TJIMr8VpXfH3M3xFTl/l3EzELtAeWoe9On9HaTxXfN8uHB0LbWkh525ogmkVTxphYHlLpOpOSybSZZf2WRvqPIJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P/3fqhQrelkIx3B/Y0C5DTgVxvMq19KKIR3WiewwmbE=; b=fEMHyyPisOSWpvx9OclwEW3zDR9e6NM19Qf3jJSSEOqFp5UwuqLM0s+KeeHzTW1j2dJPfvK2Rla8m3SeanGj3W6LaROKkkPLlewH6aEyOKcW1HX/KCBcio0PfBhykpA9C1rQ5uBIfPyFDxi+MDH44nrCvIPDBysBzKsN9GAR53zPa5g6ktFhcicFu8CiRpzCMAYgo1pnUbLpBR76gxmJLmytPL709gg5A+GpeJ8qoA8S83FILLAoif4kHVKZS02VOJKBU6iNZEJEqJJ4pXVeZoFpEDttD4gQ9FePpE0UfZ2GvYJaFDEt3B6cMEyE2FqRBIp6XADlB5l1nOio0/Te1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P/3fqhQrelkIx3B/Y0C5DTgVxvMq19KKIR3WiewwmbE=; b=jrhSDMgc+8gW98q9lMwP8RLFwEMusSlFVLUgGmhjOzBIBTAlHxJrNQhp6tUzJeTc0bXVa7eFlKStLH/HX3NtBsnpUrgH6vsSZDDlSvp1hxOvzYkTG5mM8DM9rVkuw3vC4rQ/l0D0AGU+unA5JBSEfYt7vOXLPtcUvJabixXzk9c3a7Q78CzYYf334jU+F2sMlKWfF1/sumk5uPag+VpRWiZTfVBN9QrZFHsZQlNEdGEw8HKDVZwsgQzUEDySO1GCCdYnHShGYVbB8kPS+MasVOnMgVx8YF9ybwUhrdGWrMLYZJYVBKk8jGm6J39JfObrTtvN1CdS6FHIevgsnoHiGQ== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0090.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:36d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Wed, 14 Sep 2022 17:10:56 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::51a4:ed23:ea45:dfeb]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::51a4:ed23:ea45:dfeb%8]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 17:10:56 +0000 Message-ID: Date: Wed, 14 Sep 2022 19:10:59 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220903092144.569716-1-mvanb1@gmail.com> <20220903092144.569716-2-mvanb1@gmail.com> From: Andreas Rheinhardt In-Reply-To: X-TMN: [WKjD0mt8PCvAL4tv/C32+SDARXB6QCr3Cjq1qh7cCCo=] X-ClientProxiedBy: ZR2P278CA0011.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:50::16) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <253727b2-5adb-eee3-8a01-f703741932c9@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AM8P250MB0090:EE_ X-MS-Office365-Filtering-Correlation-Id: 80831313-7997-4f4f-1bd5-08da96741643 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ChEyRHsWVZzg2LfAbQzotQRHiy07RlMy++yu6JB5h77E/dzT6uwjfhEE9SgT13LQa+0UpVUoe5QFiyA5YKxgy7SsWIOzeGDUGPrbZIZfhHJga5KjUSSL7xAd++wU1mSMbODuQOS+3tC6QydeSvWPr6AXPh6YxxSdXk8D6qVaK5r9Bzlb9TSjboGZPDus6a2jbx4lYjZHvQgQHxaxf/AttDpJ2bSRF8w3uOAlXuV3/18gF6rM9aGv/LtpZK5rvz4B4BxmCAtQrWko2Q3ERRmG9FEolgbNcsvcmjkHsBfuOCNbHbQJz4MecPwVrpj/T9RHBLExOgstpmn2N4mTZyNx5g2e2V4MXe/iRt8ECmRDNZ9xjVVlr2dT4DEet6QUtrg2AEmXaWYHL3PkNM2VL+NqrnIEiRk7T6zRkgF+dSVanDdvXdigOnmQZrHdzkZ7ijwjvl50uij6uy0JQElyvmNHeKVAX81KeYPijuAcPjw3dEA9klQ5vOUOK3rtpz26eIF+IY+YaCcjQUKo2Sg/mQAHhYiE8KX6O/3QcKaKpU9J0vyoBTR66yq77W80gHEMmwLK+6n30crcQM+Se8p3bTqJuLiN7nE20pUS0oxrrr2VBK0COOCzWM/BgzQeu+EkZ79EJ1x1/SaCd0QPVT7LvvLYpb8VZESlVpSuGe20KgQ7ISsHFV66wSyl2+tZtgoAJvAX X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TnRhK09qc2xsd0l5R3JZSGJmN2l2ZzJNZWM5R25YVnNTMHhMNDlmb2UxNzhz?= =?utf-8?B?SnlvQjMzSkU0b2xkL1o3bnhLUGFkNFpxWEtJNkZ0Tjhrcmc4aytZTUhRQ3BP?= =?utf-8?B?MmFHSVJMSkFwVGJiV041YkpTU2MyYWx5S053Rng0enk4eWl5Q3hBZTI0Tk1k?= =?utf-8?B?cGl1Y1RVb2FHWnFpc1hMblpFUndlYWlJWEYrcGVVVFQ0SmplNHgyejBjTzRE?= =?utf-8?B?STM4NEsyQ2pzYjVNZ3pOTEU0MmlMV1hqV0grUzRJclFteWUrenJ0dGtRelNG?= =?utf-8?B?OUZBWkpNb2w2UEVydjkydi94VUU4Uk40SWV3VmY1TlF3UldMZlJIUktSM0Vq?= =?utf-8?B?SDAyVi9zK2pTR2V0ZkdPYVNEbmJOR1daL0lYUlZBSHBtd1pIOWxNREp5YVBl?= =?utf-8?B?ekQ1bjgzb0xDa25QTXBMUGNKS0V3b21FZHFBV25talZoV0pKVjRzeFFrRDBT?= =?utf-8?B?K0FFWXRJL05XNCtBS3JrVnpMYzYzQmxYKzFkcGhtT3ZxSEZ3T0pXeXVGc0pt?= =?utf-8?B?aVdFRWlpNlJML05ad1V1S0IzV3pRbm5QTkd3V0FnaFBhQmFVV2FKbGs5SzFq?= =?utf-8?B?RllldngyU3ZncEl3TjNSc2pUcjVkNWxUMGtZaG1ZZFdDbXVHR2xTbHNGUnY5?= =?utf-8?B?SmE0WWl1eXJLWEM3bTlmUXdkd0FoVkhEUTBzQ1lUYUlMUStFbTlVMzBBZ0dj?= =?utf-8?B?YkVMaUZyME8ra3VYcmZvVlpRMVo4ais3R3NuU25yRXp0dWlBVjI2M0xKNmZ2?= =?utf-8?B?d3VjWllmbmpRVkxHdTVjMGxma1NMSkZyZ2tvV0ZiSk95QVpUeUE2SnFMdmhX?= =?utf-8?B?VEw1dWYxTUQvQXhYbmVMYWd2VG92dmdVUlFjV0ZiRm1sNm9pbDE0dGpwaEgr?= =?utf-8?B?a0lXUXBTVVZ6Qjh0c0N5N0xhakFhVzFlVi8vZ3Q1M2ROV2VhU0x0SUhtZWds?= =?utf-8?B?ckJFcFk2ZVJ1UHpYS2oxN1k4WFF4dnpPRGdINHY0YzZ6MkRCL3BVSE5LRzVu?= =?utf-8?B?d1JQM1hSb04ySjNWbWdUNVhhbnlPbHRNS3dCVHZLRWFWRXZMOVVPVmRsallj?= =?utf-8?B?SnVSYlg2Y1FGdzZIUXhrUEtMclpjVnhqZGRLanF4QTBBRTB3c1JTaUc0SmRq?= =?utf-8?B?clRQWk45NjJUTmhkYVVjaG1NZFY5ZTVSaDdzb0tSQTRJUDBHOWNoQXR0M3Fz?= =?utf-8?B?cGE1VFhYcTZRVjdPT0VjK3hYdi80Y1hpVkhiY1ZCVVl5RVdMN1k4aXc5ai9n?= =?utf-8?B?anRzaVpiaDhxTEVZd2dJbXhZUjhPVGFpR1NjSkZFdGQ3OUFLOXRKdHpNZ0hE?= =?utf-8?B?YlJ0MGh5ZEdlUk15ZFZRUzkwODd5WGNsUXRQRGNIeWJ3dEJodlYySCthMlhQ?= =?utf-8?B?cWd5TE5wZEJSaXdYNkdsSkVUY21CUkJGOHdaOGt1SFZCZlNpSVR0aHNLUVFE?= =?utf-8?B?N2JlU24wUGQwODVFOFlubllYcm5oNXE1MVUzU1g2dE0wMUhoL29vMlF6Tk16?= =?utf-8?B?Z2pFS1BCQ2VPY3dHTklnY0hoMnBzVTl3TlRKV2N1cFM0TSsrNVoyaFpWU1Ar?= =?utf-8?B?UHh6RjdYc0pGYWoxdEJyUGtFY09yaUUvZUNKQ0pYNmlPTzRiMXU1Y3d5N2k5?= =?utf-8?B?U1VlZVhZeVRmMXpjbmRrTDQ4QmdNQ1htVUhHQlVUeE5YZU5sMEliUk91Tzdq?= =?utf-8?B?K084S2VRTEFDZDRqdGRHcGM1bUFGSnY4RzBLeFlEcTdhYWdMWXN4Zlp5dzA3?= =?utf-8?Q?Styu4YHuLGmdMS7zslkx6JNh3VXffLDTreBK9sd?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80831313-7997-4f4f-1bd5-08da96741643 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 17:10:56.3497 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0090 Subject: Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Martijn van Beurden: > Op wo 14 sep. 2022 om 15:03 schreef Andreas Rheinhardt < > andreas.rheinhardt@outlook.com>: > >>> --- a/libavcodec/flacdec.c >>> +++ b/libavcodec/flacdec.c >>> @@ -64,6 +64,9 @@ typedef struct FLACContext { >>> int32_t *decoded[FLAC_MAX_CHANNELS]; ///< decoded samples >>> uint8_t *decoded_buffer; >>> unsigned int decoded_buffer_size; >>> + int64_t *decoded_33bps; ///< decoded samples for a >> 33 bps subframe >>> + uint8_t *decoded_buffer_33bps; >> >> Why do you need a new buffer here instead of just reusing decoded_buffer? >> >> > I don't follow, do you mean I could have decoded_33bps use decoded_buffer > too? Wouldn't that kind of aliasing lead to problems? > I was actually asking you whether it could lead to any problems. Or in other words, whether decoded_buffer and decoded_buffer_33bps are used at the same time, because it appeared to me that they are not. Now that I have taken a second look I know the answer to be "no" because of decorrelate_33bps(). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".