From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] checkasm/blockdsp: don't randomize the buffers for fill_block_tab
Date: Tue, 7 May 2024 12:49:33 +0200
Message-ID: <GV1P250MB073757654C2B0FCFE75577258FE42@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <b84d7fab-2dc-f668-79e4-82fa7a287cdd@martin.st>
Martin Storsjö:
> On Mon, 6 May 2024, James Almer wrote:
>
>> It ignores and overwrites the previous values.
>> Fixes running the test under ubsan.
>>
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>> tests/checkasm/blockdsp.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> The change is probably correct, but what issue is ubsan complaining
> about? If this would just be a dead store of unused random values, that
> shouldn't be an ubsan issue in general, right?
>
UBSan complains about unaligned stores in randomize_buffers; which is
obvious given that i is incremented by 1, not by 2. I sent a patch that
fixes this without removing randomization:
https://ffmpeg.org/pipermail/ffmpeg-devel/2024-May/326945.html
(Ideally, this test should be extended to cover cases of stride != width.)
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-05-07 10:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 0:27 James Almer
2024-05-07 5:44 ` Martin Storsjö
2024-05-07 10:49 ` Andreas Rheinhardt [this message]
2024-05-07 10:52 ` Martin Storsjö
2024-05-07 11:11 ` James Almer
2024-05-07 15:02 ` [FFmpeg-devel] [PATCH 2/3] checkasm/blockdsp: use smallest allowed aligned buffers for fill_block_tab tests James Almer
2024-05-07 15:02 ` [FFmpeg-devel] [PATCH 3/3] x86/blockdsp: add sse2 and avx2 versions of fill_block_tab James Almer
2024-05-07 15:10 ` Andreas Rheinhardt
2024-05-07 15:15 ` James Almer
2024-05-07 15:14 ` [FFmpeg-devel] [PATCH 2/3] checkasm/blockdsp: use smallest allowed aligned buffers for fill_block_tab tests Andreas Rheinhardt
2024-05-07 15:26 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1P250MB073757654C2B0FCFE75577258FE42@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git