Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH 1/6] avformat/oggdec: Check ffio_ensure_seekback()
Date: Wed, 22 May 2024 07:07:05 +0200
Message-ID: <GV1P250MB0737573F097D7A823FE23B2A8FEB2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)

Fixes Coverity issue #1492327.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavformat/oggdec.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libavformat/oggdec.c b/libavformat/oggdec.c
index 8ea81e5d45..5339fdd32c 100644
--- a/libavformat/oggdec.c
+++ b/libavformat/oggdec.c
@@ -364,7 +364,9 @@ static int ogg_read_page(AVFormatContext *s, int *sid, int probing)
     ffio_init_checksum(bc, ff_crc04C11DB7_update, 0x4fa9b05f);
 
     /* To rewind if checksum is bad/check magic on switches - this is the max packet size */
-    ffio_ensure_seekback(bc, MAX_PAGE_SIZE);
+    ret = ffio_ensure_seekback(bc, MAX_PAGE_SIZE);
+    if (ret < 0)
+        return ret;
     start_pos = avio_tell(bc);
 
     version = avio_r8(bc);
-- 
2.40.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2024-05-22  5:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22  5:07 Andreas Rheinhardt [this message]
2024-05-22  5:08 ` [FFmpeg-devel] [PATCH 2/6] avformat/gifdec: " Andreas Rheinhardt
2024-05-22  5:08 ` [FFmpeg-devel] [PATCH 3/6] avformat/westwood_vqa: " Andreas Rheinhardt
2024-05-22  5:08 ` [FFmpeg-devel] [PATCH 4/6] avformat/qoadec: " Andreas Rheinhardt
2024-05-22  5:08 ` [FFmpeg-devel] [PATCH 5/6] avformat/dhav: " Andreas Rheinhardt
2024-05-22  5:08 ` [FFmpeg-devel] [PATCH 6/6] avformat/dhav: Check amount read Andreas Rheinhardt
2024-05-24  6:29 ` [FFmpeg-devel] [PATCH 1/6] avformat/oggdec: Check ffio_ensure_seekback() Andreas Rheinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=GV1P250MB0737573F097D7A823FE23B2A8FEB2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git