From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5BA1B46967 for ; Mon, 31 Jul 2023 11:12:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B025168C5B4; Mon, 31 Jul 2023 14:12:45 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2048.outbound.protection.outlook.com [40.92.91.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 34054680016 for ; Mon, 31 Jul 2023 14:12:39 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XHPMdUFyBC42zs73LzNLMaTQTUxqN6yERMo/AOSNltsZsWiCjEWz5r0iqC2gOOG3ekMUUSFc2omr/os/ZurUv2bort+LAzUvNn8/d1toDZciqGbxAC9zrbgitCssu6U6ZCrFXiLMuW0hWn1r0mcUV0Fl4Sh71Jf2i7KqqiudaGrmT37LKhUM/jpY8pnwQvbipPH2ESYFdp/t/4Cc+QqV4ciRf9jQntgt7gQOtdYtUQTcVBvqLbiXgwWEsLNBsV1y/goqxrch7f+8H7iGtBiytGc76YAejo0v13m2H/fOymQn1YO1+P3GaIw6FP/h+zAXeaIpOK/heCTU9OkZugqxZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+9SOzaQ+iu775JI3WoBNJCFoe88ZF25Dm4PshCF0TTU=; b=n70ba5lzaoNJn1pHdt1CgeTvgfDzRpnQYlKrDxekw+MTUw/cJkR6UFw+UfjgUZoZzbOkBajBqsgATgWGio3j4jgX8FuH6jT9nCsD8duoH4WQMO0irrrzTSn4iS08Fdgeq5mhA8EgZgzuB6vnCfX08PKqrhnd0UKE1L8JKBeG3aq8MwUdTOgMopKyTCxnIkCD+DgAarConpw9yBsZgHiDSq9+RN12zxit0FR3eY3De8Y5tDPH3PwEl485dAY3WMWhIaWEw3apfkS9iVywuQvO05pN7EONcmFdStZWuVFDX7zhkakAwvpb+34HWkj8EAygsoCHLCSPZgYG8Eh24crUhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+9SOzaQ+iu775JI3WoBNJCFoe88ZF25Dm4PshCF0TTU=; b=KbVgKEDsAs1RkC4WhlrJfDvcm17v5ZJ6ATW+IBJqAd6oZj+TvXk7nzC2yRYFh1AoPsQ+Qm1136OOO0JIqn2WCEuqe7kmkXLoIEJMcNMa2HrE1OmsGBMitrheZzqsHNG6d1zFW2L+QH1hsZRRM+JmFJxkueHUsykdP9LQWAVwuqBaAwnPgszeKz3jyuWVfPDhripAV3NX3wEzh7CPp0olE+FwPN1MHr8kRjoEsyU+IIW2wU2HLndo7T93syZXhBRTWeVX2MlXMgYegpdA/ZbvZIg8qG7mURX+7QUlKvqIKWDBpz6a97AeFnZaMZnqYRNtu94qRMeUgYOsZdjuGGBERg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DU2P250MB0271.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:270::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.43; Mon, 31 Jul 2023 11:12:38 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4d3a:7ca6:cf28:9e8c]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4d3a:7ca6:cf28:9e8c%7]) with mapi id 15.20.6631.042; Mon, 31 Jul 2023 11:12:38 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Mon, 31 Jul 2023 13:13:33 +0200 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: X-TMN: [wBkCUIM61OumlW/qSYJ9WNcGzkq5GTBB8cLPvRyKmzQ=] X-ClientProxiedBy: ZR0P278CA0009.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:16::19) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <20230731111335.3313288-2-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DU2P250MB0271:EE_ X-MS-Office365-Filtering-Correlation-Id: f5b1b42f-ce5b-4437-7797-08db91b70cc3 X-MS-Exchange-SLBlob-MailProps: AZnQBsB9XmqJuwtH5CpNudvoJXR8nEMbJoaK7JTNW3MVy7YJYq4yUqsV+AMWMjrQBaoi0FGGK7VYFCbpXj0j4FQzGY15xNjZvNRq2tQ3s+f0NEl9Ui1uJgmnyAtEFYrcUn3pTsuPPHDAMbSLlegIPee/1Yle05PZSGMzg8ixmxeszZhyWm3RSY8Kuk/FlBX7XcckUH8d5PQJHzFyLaQLTMRU5NA487Eah20Ok4DntVD8/NEvfpbuGxMjrZh4/AIdVCGIvMrqfECUX6T0u6seyUEMGr6XTQhpXwnckTw7NMucZrU1MhFY9DUzAnuSdGK00HWllYCSQV1Pcwe6e8MLcmzwcop1tLds2EMY1MQL/2jAW80ubVMFUNoSVakTnk04kokrQEMmw/G7eQ3uxiHqwR4S6JTlaHN8J/bnNhHAr87X/YaocdLBdO/0FQ7It6jv521Unm2PAj3dbt0pI/N2YIk/3mTXFAXFcvsda+dJcq5akbmO9VBbil6A1uc5G7asZPDJUeqhZflb5/Vxb7pEoXnr0MOdokXzCUs5Ce9eHgnDn5r8mIj+LCGemtPQ1hF0ZbBRHa7UZomYX+LtkvGBLtuE/dAWGnI1L0LBnvV7Us9iaDUx+6odlzvPU0DPu7EuDU9t9tXm83C32xLtFAFFk8gPD5V46yRdeu5kgzjpZJbJ+kEsEf1ViIB1BLIQRF10jE22GXUwNq1vnZXvJ/YqQ6oTK1dWbd00mC7HW25Dj1Bn2Sg6O/paUjzk6kqXgqcohXXpmpYcn+g= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CKME5pRQ6x4CEcYr3+80qw3hz7zDyUPGpDkgyM0adoW+TRgQfOk8YfUlIJywyQwv/tr6dZX6jFBIqkOltIKoKxD9F9gZ1nYK4Omt/xG4cZ+ErcpEOAZw8n78KC7+jItSrlzInJFDGDnrrIDk5a1mWa818zfCNePh2sx7RE4zmHmw9WJAwp+6hL2icyHj+LQKusy9+4xVqMfyWJ7hDq44NKHQczTBGQO1ypfB32Xm4IWGFUjtKGbUkJFs7764HoyzgnBNB5+qLZRvmyvuqxmxnHe/yu8TsIqdMepkC7FjC8a/tgUgftruBEbBZF11/vsxv8bItzjJJ1+knjf0jNFJur4KKysLKN3gXDIlvhg3PpsIWYEZ3prBTJ71wFLx7zRsNyXkHbKb8dAPc92bb4oHA0h9JSAdvn9fnL40INeSoIIJbRECWoUWgzaOu0aMo2p+6z9SD6LG2SeJmh5+3Zb+ZGAv6/wr4j5aV6ZCr90QRpKb+2om5TlrdytZ5KDFojLLNajRlebb0kMvNMzu9GJKLC9zEMbFpqs/ttO7LEwxlsBs8GVSH9RMVoUYsPrnVO1IT3yCZVsbMp7BJKY/pFvxWhlpimtqXBIQ2/f5Zq1IKP1vkmHcKex5KF9O82bWLyGr X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9mJTJUyihzpylTDEh40QVlqCVx0ztfMIPJ1YFhavyWOYgenqlWxwohoQOprd?= =?us-ascii?Q?deYLGx9xeSiJ6mZKOl5kJnInFXp/a5nuqAkgrtRmRHMwbcV/cI4gRzlFj4zT?= =?us-ascii?Q?TaPmb8aAuhK0BFKWFTQ3V/iWMdcjFHP16bfntTouAU2SsPj2koBsjC9q4R/O?= =?us-ascii?Q?OAC3GmHCvy/1haAh3MPsycrnI9xbqoKZbu0d3QmnwyNpGFHq7fCjm27RhOqh?= =?us-ascii?Q?dIAwrHALKOIDP1gLdoQFI6RswBe88+CRlsjyzZf4de7wth1M0P2sx1UwE6+k?= =?us-ascii?Q?HziVNr4/JcQN1JEUiTjdJgSm16v3SKyGtaUKFsJ3tcuDAPyZGMreERITkqdg?= =?us-ascii?Q?XkGhPeCqpLOVTP39whN5KcYealHKqYyv6EL9/kfdW5SGx2bMTJGUBWut1OBC?= =?us-ascii?Q?GmgiAG1TMYyIHXM5ta7u8+G3tKBpjHStN6J3gmgeptNdzT3a0T6VG9m/ETF0?= =?us-ascii?Q?+vBlcM2H69ksgF6P4fjPQNEztM03rdGVnN8dZdFbwdwghQ5MuQ2587e3CbC1?= =?us-ascii?Q?I5yeNZ+6gRw8uVDDWOWhR/Dz+HJcqe9+AP/8dPjcLNnJpQxaqxVgNFOb6v82?= =?us-ascii?Q?G9lUcY/zAaW9wGlR8KNnbd7L5QepsdSEYub2zeZ0q/OMIe75nox2skUtqVlw?= =?us-ascii?Q?sPMyV016fKorSLTK7MdopoHMNcm0Gf9i5yD0I1QZTmaXL0OfDGiThNWgVqj3?= =?us-ascii?Q?/IEVSEgX9YlNshKI4aCyA4jtrnX3g7Wl5S0TU4fFjEYPjt7fxCFZJ0p+dzCo?= =?us-ascii?Q?vpJ7iawXsLHpuw4g84P19Z37kwFuPDFwzybSSHxc5eDMfqXrWW5VH5dUyjGq?= =?us-ascii?Q?R3OWEBKEXZj3HWazkDNcw7BRFezlBdEjCPt6D90OV4DvWr5YbHEiDCrmOF55?= =?us-ascii?Q?G3BmkgwtOx2ObKmj9siCLGMpNtsNHS2kWoUVL62DH2YWuKlsbCQbcLhcTpOM?= =?us-ascii?Q?+2AYJQ4SCE3Na4jr23CZtEIVRVajqhyOwsj9uJK3VHIwKHqKP8KGsDPXGgxN?= =?us-ascii?Q?1k39Blj/T+kokteCp9auOSbD0SMUuxRZiXRIrB97n48wu8rnvUsv5pCAiG4c?= =?us-ascii?Q?CwzAr4+PxQwLbT33MJt7zlbBWPE+hxJ49uYM6wUq+AIOPvG+hnvW6bqOZrev?= =?us-ascii?Q?WkQHbW64VN0sJSaefDpT55ZQOzWqel6MO7aF5ucu2LtVgN3fIhII2t6C6DTd?= =?us-ascii?Q?4XQ8kyAFZibD0e3Z3Dcvg2V7SJKd/5RBq2koHzvx85XCzl3VXgvPLg2QJR4R?= =?us-ascii?Q?I4FgMojszPQHo/I+d7Df?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5b1b42f-ce5b-4437-7797-08db91b70cc3 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 11:12:38.5150 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0271 Subject: [FFmpeg-devel] [PATCH 3/5] avcodec/nvenc: Remove always-true check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: nvenc_store_frame_data() is always called with frame != NULL (checked at the beginning of nvenc_send_frame()); in fact, frame is dereferenced unconditionally after the block guarded by the check for frame. Therefore Coverity complains about this in issue #1538295. Signed-off-by: Andreas Rheinhardt --- libavcodec/nvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 0b6417674e..505b95f93c 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -2249,7 +2249,7 @@ static int nvenc_store_frame_data(AVCodecContext *avctx, NV_ENC_PIC_PARAMS *pic_ // in case the encoder got reconfigured, there might be leftovers av_buffer_unref(&frame_data->frame_opaque_ref); - if (frame && frame->opaque_ref && avctx->flags & AV_CODEC_FLAG_COPY_OPAQUE) { + if (frame->opaque_ref && avctx->flags & AV_CODEC_FLAG_COPY_OPAQUE) { frame_data->frame_opaque_ref = av_buffer_ref(frame->opaque_ref); if (!frame_data->frame_opaque_ref) return AVERROR(ENOMEM); -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".