From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AEEEC40E8D for ; Thu, 8 Sep 2022 19:38:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A809168B9C0; Thu, 8 Sep 2022 22:38:56 +0300 (EEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-oln040092067104.outbound.protection.outlook.com [40.92.67.104]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1DC7E68B7DB for ; Thu, 8 Sep 2022 22:38:50 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mv1Rr6ZV6bFYUH/gcnra8tYzHfnAbZqU3uAl+xEhJTosyaMmdRWWz3GMsjzcs2xcLlfBVzx0DXN7qSXbnJPqlVQvDW01I/L/HRpf+KcxTJGWKC+DtTQ5WHje4Q+QmkOqLl97xgsBn1PrTe3Rer21y9R/JB97GEehOvyHWxs0SIYD/bFuJ4HJmlWVrbBAPeHJ+GMAf59dpCvmz7o+g0Dts6MyX73sNUA/ydr23gWzxsmjWYx4Uds0xKUt1pnXRJHzvvwiUtsqu4dMWG7A1ASHiUflcCcPdj8fsFCTRRxxLP//TXWmy9DrlyAcXaFR6WG1MsZ31gDIOJcyTfeWndqPpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PTQ6L22ixrcP4IOz+2ALfVzVFhIA/f5VSGN7iEa9oR0=; b=EIX4S90nJ+MaFjRvfiYB0xi5ZBIC9Ktt84vG5rSvSuczCOEW6kjuSJy5FuS/RIQpJiMEYCy/vOIEswGcxdirOC/sxgLiuHZaQEpRkB9ev6SwleNvARCOCMsUUS0a0wfagIDSJZsWF/Ls29ZkzAdvGCpQHKPON8ju0o8KaaCoDNNZsz+aEM0oSDUMLAowxrBRXnPiMei27owwqvfFQKJvEP1xCUvx/8hQVcLjXYwmnplak2f2ma5K4PzwwGuOSSDlQ+IUsCv3BPr7lNf6SgTtvDt1+w6uJcLE2fSJBOCMbbPTNa7dQBPTMj64gYcVJwS3+OMygBVAVA1f+43IBzWT6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PTQ6L22ixrcP4IOz+2ALfVzVFhIA/f5VSGN7iEa9oR0=; b=XESFrj60Eo+5cePOO8b6swbLi7+F3H1roEEvrKwg1Gqv9iXluJAQvXmvVAFUBV6kk3jeaDbiAMEG928OrjPHAHI8jttVwuDXXcMJNd9QUq+RChmQ2j/2g2wVKfX0uWeaWUsgSyWjGbCctpmbmy+NR2xfwsgcVhq4YI03hD5z0MYd9a4JbLupzinbkQqmL4OPdpMzcrZJRlvB8DQE5ubMVOUWmhDspLky+R0wGq00d+PSYhVjLAhDAtX5olAk/ck4Uc2//jbvDeJfhNk8y0089HtaPI7MjcVIDOfSVpAA9CQg3O2O6Z3z85mw3HhRWyKAGUm6s+UA9LznVjSsNRb3qA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0389.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:328::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Thu, 8 Sep 2022 19:38:48 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::c3af:c609:301f:beab]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::c3af:c609:301f:beab%8]) with mapi id 15.20.5588.018; Thu, 8 Sep 2022 19:38:48 +0000 Message-ID: Date: Thu, 8 Sep 2022 21:38:51 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220908173911.GA2088045@pb2> From: Andreas Rheinhardt In-Reply-To: <20220908173911.GA2088045@pb2> X-TMN: [fWd/yHo3T/o8HnrxvvQhgfNwRf2TTfHgJZ/iXab/HFg=] X-ClientProxiedBy: AM5PR0601CA0047.eurprd06.prod.outlook.com (2603:10a6:203:68::33) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bbed1f69-bd12-46c5-48a9-08da91d1c016 X-MS-TrafficTypeDiagnostic: AM8P250MB0389:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5dQzYBoC//Ze8OubOZ8UAC6CtY1VErW1ctuEne7BqUjJST3O9wXXUJKDimIs9d2/nC4d02c2B08auOnGoUinDcStL2OGJe0pR2JQmT2tGjQfjbisa6nxw9bBZfQYgE4k8SvJbuaNWPI4tMRilGGfJ81z5GxubfXJsPB9QHu+iFBnvUPAhE/ThzjWtN/N2Lh7iC1uCFpiETFtNIg9nF4jkl/otowcKR29RTMvz8jWJ/cqW7WiqaHU98keIBiSgSoI3IAIOG1gOOqrfbq/EEvywGmn/ADi6ULM5sSOndo1Lz/Zoph/hV6trpSMR1HOAnib8He6bskXXc0WB1wwSU1uxls24Kh7F/UIfohjflnu97NHOCRfINunoY24R4NLVaSfAxoeMz8uI09zalKlaYTqJ6rs9RCJ5rJooQQ6SqXZr0uzXoroUkyB94+vEnVTgQQyGBuRCkmd2SvjQ6p9BNIYYnE/tk99NUYDkbsm7AXIN1Jp8MkspNv/87OZpPiPHJV3E29FyztmJD2UD9KknoVVPTMuOlYMG6wc9ISLx6gLaBQEvnUTJ8RNgmCdETpBgNftSZpdz47KODbrJxC0lig59PmJtkRktyBl6wyx+po2Gu6giuQs9wABMKtcB0QSMKcPMUG6R7LLwTPC/cAkP2zcIlF6czUbS4MPv5fSwEZWagQY6V0ntb6PaWxAuQg78afk X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3A4NVpDTE9IL2JYNlI4L3Q1ZWc1dnZGdm1kbHdmUHN2YlZuQVJ2UWpGNEpS?= =?utf-8?B?eExtQThRcVF3TERIL1dlSFRSV2ZnSkphNnFFa3FjcjFlL0J3ZUZna0E5aHhi?= =?utf-8?B?OW83OGJjeFFiR05mNlZJMUs3UkZpdUFVWXVHTHpLRXc0QjYvNExYMXoyRHRD?= =?utf-8?B?U2QySkt0b1FDOGd0RTRHanlZWVl2T1R3SEMvN21NSUxMZDQ4VCtvVUNRUGZr?= =?utf-8?B?WFpHRTBuMjRzaDFHdTRRd0RZYjAzODExSzJFdDhOUm0zVFJGZGozQkoxbHQy?= =?utf-8?B?R3BGZStqZTNtcGhKRFE3MSt2VE1xMmxOMGpMeW5POS8yQzFpZTJSOVVXQVpV?= =?utf-8?B?RlA5UzlSZTIxdjJER0F4ZTZZM1JrLzlqc0VBVlRiM1VmYkV3eUFQcWc4d2Jp?= =?utf-8?B?L09IVFRhVUFtMlYwYVlia0lwa3dwUnBrVlJqOVBjdExLcGVJUmFINlFRa3VK?= =?utf-8?B?bWZHV1RmZS9wMzdybGpvYVg4NGVoUnNIQ2pNUXhCV3pKemlvdzZtQVBzTVVK?= =?utf-8?B?YVQxZkFmVXVYRDN2OGF4V2Q5UStvOUlTS09rRTdQNXpiajdKYmRNYXA4VFYx?= =?utf-8?B?cCtvK3RDYVU0MUV0NTQ5SnN1MUFTQWk2VkdsbmhhRmdFOXFrZjY4QVlBZE9O?= =?utf-8?B?MER1Y28valBGblJ1dS9xRE1XMzFYZ3BMR3lLdE5mNkJKa0tFNGw3MExTdVRl?= =?utf-8?B?dDlZck1BWWFQSUlGSThXZi9yR2VXV2dpUE52UllxWnpNaU1YbW10WGRSSTJ2?= =?utf-8?B?dWY4VndlT0l5c08zalJ3U3VwTjE5TzJsUzljL0dWaExGczdVdGM0MTd6Yk95?= =?utf-8?B?cWx2SGtNTi9oTDZpNldYc1BkVnFDQ3dDcjQzd1phcXJ6eGVCSVNVVjJsMXh3?= =?utf-8?B?WGxEZVBucExqZ3lzNUs5bitLZTZYQ2l5Y2UwVStwSmduUWNxeC9FdXpXUHpx?= =?utf-8?B?TTJEemxRSEt5VUQyUzQycjd6RUdyNDVqTldySTZNaTIwZEZ4VWsyWklXTUlR?= =?utf-8?B?SjFXb2R1L1AzT3pYV0NFZVd0UTV2MzltZXg4OWlVcGJ3RGpZYllZdmJJSStq?= =?utf-8?B?d0NkNDlkODQ3WE9HVWF3clRuNWZhWjNhVjBiOWg2bWs0a3lud2Z0U2RuMWN4?= =?utf-8?B?d29wMTBrYWkrTGhqdE1RL3dhYWcwREZnYkJwaEtzZG43emVHSW9vSzNQNWpy?= =?utf-8?B?eVB6RzZOOEtKN0M1SXNBWkdJeDVsckxIZEd6Z3Y1cWdTNEtuYkUxakYzcmty?= =?utf-8?B?SU93cFhCN2wvWnZOZXR0YjZITjBsL1E4SXFsdHlCTXZqWnArd24vYnZUQ0Fo?= =?utf-8?B?TU9VS3N6ZW0zZ29JelJEUjhsa1hyN1M0TUZpNzhiWGRuU0ZnVE9RdUVqbnNv?= =?utf-8?B?T2FyYTZIUXo4cWxoRThKYkNlcjdtcGMxeXJtb0dqb09Fc2lSdVpqUjNVTVRq?= =?utf-8?B?VFcwNVljRk9VaTV0NjA1UjQ0cGpIRjY0dWRSaWVhRjF5TldEWlFnMHJJNjg0?= =?utf-8?B?YjUwbDNRbW5OTnplelhzRUUrZG1PaFpVbXkyVmREVEF5NXZmTHpmenhuTjBo?= =?utf-8?B?dWNrYld3Sm9rTFo0cEd4YjBweGN3Q2M3ZVlCSnkxTlJhOVpHQ2N2U0d0d1J1?= =?utf-8?B?cWZQWkFCMEphWkpLWEJUVTNHS1U4Z1BJUWJQeVFPYUxaVC9Ob0psOWdvMXNv?= =?utf-8?B?Q3cwZzB1SXQ4Y2dETTM3QmhucnNQME41NW1vcG14RTdlN0h4Vm5GOGtGN3ly?= =?utf-8?Q?F1Nsq5gCjhmCEf50jzHBoHVs0YQX0gtrqBAp8uR?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbed1f69-bd12-46c5-48a9-08da91d1c016 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 19:38:48.5736 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0389 Subject: Re: [FFmpeg-devel] [PATCH 2/2] swscale/input: Avoid calls to av_pix_fmt_desc_get() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > Hi > > On Thu, Sep 08, 2022 at 04:38:11AM +0200, Andreas Rheinhardt wrote: >> Up until now, libswscale/input.c used a macro to read >> an input pixel which involved a call to av_pix_fmt_desc_get() >> to find out whether the input pixel format is BE or LE >> despite this being known at compile-time (there are templates >> per pixfmt). Even worse, these calls are made in a loop, >> so that e.g. there are six calls to av_pix_fmt_desc_get() >> for every pair of UV pixel processed in >> rgb64ToUV_half_c_template(). >> >> This commit modifies these macros to ensure that isBE() >> is evaluated at compile-time. This saved 9743B of .text >> for me (GCC 11.2, -O3). > > hmm, all these functions where supposed to be optimized out > why where they not ? > > iam asking as the code is simpler before your patch if that > "optimization out" thing would work > Why should these functions be optimized out? What would enable the compiler to optimize them out? (And I really don't see why this patch would make the code more complicated.) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".