From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 184F949CDC for ; Wed, 8 May 2024 19:27:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9274A68D6B8; Wed, 8 May 2024 22:27:37 +0300 (EEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01olkn2014.outbound.protection.outlook.com [40.92.64.14]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4B55968D4AE for ; Wed, 8 May 2024 22:27:31 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eHsYf4bW/ep5t2yJpx+BrVAiH7OLhivhffuIuWRADMmOaDWzVdipwuWszXKRznnBfp+llJL/WtTHEwu8UkUeUa+zFjpRi14wfwtIYZUK6yiiQ8lS0rJkJAN4jnjdlKcoauueyArvb28zAY2gg2DelBP8dwbdZLEOva6mJNNx6/+qe4dRVf28EKC9LGJ6bRN1OCC9HMay5l55GB/JfRla68tWul+ogD/0+1/f8TWYT99M0BrwzR0o5ksoQ1IVlml3rGxjrqLTqCOzTyglfbtkIfcV/0BPjOLfHWI039Implk7NdX1nL4a703Ry3rGLOkJk+0jhXvEzj4HCazEKWbIZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lE/7WQ1UDQEWcUZfO4gW/rjzyVRGqyPFW6gDXVPW8ac=; b=nEeahwDAYpp4hzmUgiNCJw6N0iq0RNwUnOvqUs6q+izguHJRAWnhM8qfwK6i5W5PhT1XmwbbQQWeozbKmmrRMohokcTT2AmJiRDl58VrC6meNGynV53W3u2GIr2W6a6URXhsEAPbGgErVqgthxJEv/5yArBC3hVWVw18SW8wOYxLLo0pF544ZTiAZR4w+8VyuNBcUpVTdQOKehAai1lQDT33M97wqVdetvEX973+lTlnIhAYhwW7zJchzJAD6NYd1WiPRErwvsNqua3mIDwcIi9AusAAkaCMAckKS8587uajrVUZwtuTGrTcSt2z1rM84j89s5uvxrXxzl8niN5r6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lE/7WQ1UDQEWcUZfO4gW/rjzyVRGqyPFW6gDXVPW8ac=; b=P047CVq4gwEG7UHz9vwg8FQ31EjtVr5GyNEvzE91h6XP2NP8kZLfqzx2auN6hH1s2SuBR8pjJQgg4464CP9oMGFsz9xDlynVBxkmtHbBy2mDqemkHH1FAzLaJQmuDMZ9SAiHR6ohtvMjSFlD/SKYlbyHN85jiyruCu18ww4DPayvZ0ApYaBVJfuBdhnYqBYBxKeI5CVe8vtdJknAAivVx4axiku/nevvceetinUaxFf5bsWt2xgj8BJb9aSAAypYDPrW6wDqe6Wm9CteQnzms7Xq06DWJPM4iTwGIt0zbeQp3pNFwPER7ZZ+dhevXT4WV0KfGq/v848f/ZmQqISmhA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0170.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:321::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.45; Wed, 8 May 2024 19:27:29 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%7]) with mapi id 15.20.7544.041; Wed, 8 May 2024 19:27:28 +0000 Message-ID: Date: Wed, 8 May 2024 21:27:27 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [bU/lPA8NIZuI6WPPjVh6W1y2DRpxJPe6PV69mP7yG2M=] X-ClientProxiedBy: FR3P281CA0170.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::18) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AM8P250MB0170:EE_ X-MS-Office365-Filtering-Correlation-Id: c02b336b-c2a5-47f6-f06e-08dc6f94e61d X-Microsoft-Antispam: BCL:0; ARA:14566002|461199019|16110799005|440099019|3412199016; X-Microsoft-Antispam-Message-Info: BcXbVoZJplONXYu/zPQFC3D9kalujubaXZiTmmJVDPSSO4OROsEdrYvwblFxATVjzzWnbKHAFqBgqv6MfGbvTw5XINMddIEd9D4zbwyKFXj7pT/2qCx13Z/qzIL+p8iDM/eLum0xnMvR9Z/hSsa8YFKTp98IuPQPfUXLXe4kQ3a5JytY6Gden2XMxw2DIbZGpaaMV0p2jbtQ63KWK8VJi9bziUMxS47h2auETkeWCD+xGe3Aml7TLrKRWW7FURzEEONT5HQUvTCX7z1SCdpW6cKJ4NC1FyqSQmqmLY8sgiuWbX4xdu0qVZpVz+A3tQTiWoHshRepNkS3blzXeyCAg80J2lixs8vM7FIsQP+Am6rzPCMPjcAVMFbZYE/3lMCBf7fE7eV/jdDS9IdfzO7OVJgc04bRrXwKrcab7pH5rp+5fAOFEwTrLoPDY/ke+9mSevm+kfWqyjdQLZG3P1U1UsS2h0bW2l0qgjYaPWbaUvDiMfmrkbK0BE87eMA547XaBI0OsJ3KFCZzcz1muVHD9D45BCrelRyen3fILNxy6knr92aCoCZLSM/7IL1g3uW0GPwN9/6It89SLZxQ2bvLQt4Jv/Bv/vDshd9Y/ZMyhfXMvAgExjCOFZZTqGhBOQMN X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?alBzTitIcWVoTkhqZXBIa0hFZUp5SE5vQXB0c0kvRlYvbkpwTGRHcTNOYnl6?= =?utf-8?B?OHBqZUthcldtTS92cForb1ZRT3B1d2hvTTYwTDQrS2JCVCtGVlhGZ2dFMTFE?= =?utf-8?B?VTc0Q3U0dTZNa2JLUGNaQkNpRXNuNDVhOVRuMHlIV2RxQ1dTNzFKRHRuRWFx?= =?utf-8?B?dHNXWVVNSGY1NzdEa05WNEpGcFJWOWtQZjF3cnFvQnpZclpPTTJEVTNYRmFQ?= =?utf-8?B?Y2FUNFpBcWlxU1lGVVk4cGppbmlwS2NLU1g2R1hHNVhEZldCbXRlQnVOTjd4?= =?utf-8?B?QlY2UE0rUDBpd2k0RkRhRlFyTDNhRFkxRFRFR1dzOGx3ZkRnalR1eXZYc2g1?= =?utf-8?B?VWtMUWlnL0dYOXk1UURsVVl4elo4NTc2NURnNENpMEJReHJBNTMvcC9xallP?= =?utf-8?B?S3lQUXBtWXp0N20wbktGNEZ2R3JNTEZBV0oxaHhaTWh4dVJDRFcwckRWakVW?= =?utf-8?B?RzFoYmdNNVJQY0kxWkx3cENzRjIzanhkQUNuM1ZiV3FtbE1zWEpvcG8ydTdN?= =?utf-8?B?cDl0VHdrNm5lVHRCTEVzVEFPNGdOZysyZzdjWWRKZXR0ekwyNlVycWhLUExh?= =?utf-8?B?RHNjWGovYStucFZDRVlVTUJGakRnNllMck85SENta0RGNXA2czJxTWZYK0pM?= =?utf-8?B?ckZGVnZ1R0YwNlVteSswazcvaFJEaFpyT2Zvd3lwSURVS010bFJteng3MUpl?= =?utf-8?B?WURxcUpBUjlLVFVzZ0FnWVZWUU43Mm9kTG1IZXN2UVZQeWYxaUM4Nm4xQWMr?= =?utf-8?B?Q0NXNElJdGZWSFNOakNSMkF1R1QyMGdPMGgwcVFoaHNBbU4vRENMUldPWXda?= =?utf-8?B?bDM0ZFc2ZEJkYi9jZ0MwQmtWT2gyd21JUjlSTzFjZkxDbkJLdVVNbFBXZHBl?= =?utf-8?B?WHRieFIzTXI0RE9ORFVmWFZhTWNXc21LRWxPNTNJRjAvdVdGWnU1SnE5cTli?= =?utf-8?B?cnNOem5wU3pGYXNEMDJtMzZLRWNSeEY4WkNpRjhXRmRzc3ZlUW9KdDZwazA2?= =?utf-8?B?Z1JyZnlnSk9hOVY4eVFQQk5VU3VYNmREMmIrVlZQTzlrK21IbFpnSTkvRC9x?= =?utf-8?B?QUtHblpiYnZuQy9FbDVmcWZzUzVwVzdYekJVV2VKZzRjWXNuUy9xY2F4S2N4?= =?utf-8?B?TDNWWWNEZnRwaHNWQjltdHc3VWRaTWJMeEJvak9mSWZZZ2RNTVN2NWk5Q0Y2?= =?utf-8?B?QmxsQkFtWTlVN2pWczVObkxPTExPMXpTaFZVSjZna1RaMmRaN0lzWEcva0p0?= =?utf-8?B?ZElacW5meVM2U01hbStzWWg2Z2FuWncrR1dDTGVubDBGQ1ErTWNWcms2dHJJ?= =?utf-8?B?Qm9kaDl1NWJ1V0MwVUZnN24xZDIzakl1T3BFcmZEVGhKai9FQVQvWHpxcFZr?= =?utf-8?B?c0c0WXlrRkQ0MWdYc3BIdGgwdDltcGFQSnlEYXI1aDErNHlIVlRQS3hzc1R4?= =?utf-8?B?akRQWlgwVWdwZjl0bEZRNEVNbGtRU0Vqam1ZQisvVmtyUzN1NEN1eTlxWUNV?= =?utf-8?B?K2IzbktCL2cyYkdpU0ZvSHFteXNXSTdNNnhJNmN3L0pZYnZsNVMzUUxEdmpN?= =?utf-8?B?enZnZHpoN0tJVkc4dk1QQnNOQXlFUURFZFNvTmM0WTRIbU9qR3YrWEtacHUx?= =?utf-8?B?TkpHOXExUytBMnpmY3RQbGZTTmpMRjJmaE9qd2Q5MVorYjRuTmpjRFVGZ29C?= =?utf-8?B?eWJLdktDVnllZ0JvOU0vN1NNNEdHTmVqWU5Kc2hQeDI1UUZ4NkdZQ093PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c02b336b-c2a5-47f6-f06e-08dc6f94e61d X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 19:27:28.9006 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0170 Subject: Re: [FFmpeg-devel] [PATCH] tests/checkasm/svq1enc: Use proper range for input X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > ssd_int8_vs_int16 is only called from encode_block() > in svq1enc.c; it calls it in stages: At stage 0, > the int16_t array contains the difference of two > uint16_t. At each of the following stages, the > int16_t array is filled by subtracting an int8_t from > the current stage's int16_t array. The maximum stage > is five, so the int16_t are in the range > (-255 + 5 * 127)..(255 + 5 * 128). > > This commit modifies the checkasm test to only use > values from this range, fixing (undefined) integer overflow > in the test. > > Signed-off-by: Andreas Rheinhardt > --- > tests/checkasm/svq1enc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tests/checkasm/svq1enc.c b/tests/checkasm/svq1enc.c > index 1a6f531141..f9abdcbff8 100644 > --- a/tests/checkasm/svq1enc.c > +++ b/tests/checkasm/svq1enc.c > @@ -18,7 +18,6 @@ > * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > */ > > -#include "libavutil/mem.h" > #include "libavutil/mem_internal.h" > > #include "libavcodec/svq1encdsp.h" > @@ -26,11 +25,13 @@ > #include "checkasm.h" > > #define BUF_SIZE 1024 > +#define MIN_VAL (-255 - 5 * 127) > +#define MAX_VAL ( 255 + 5 * 128) > > #define randomize(buf, len) \ > do { \ > for (int i = 0; i < len; i++) \ > - buf[i] = ((rnd() % 65281) - 32641); \ > + buf[i] = ((rnd() % (MAX_VAL - MIN_VAL + 1)) + MIN_VAL); \ > } while (0) > > static void test_ssd_int8_vs_int16(SVQ1EncDSPContext *s) { Will apply tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".