From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 02AA54AD66 for ; Tue, 21 May 2024 05:56:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AE60068D2A7; Tue, 21 May 2024 08:56:54 +0300 (EEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2040.outbound.protection.outlook.com [40.92.89.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0CB4A68D1C4 for ; Tue, 21 May 2024 08:56:47 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b/8kfiXB4M852ADXTvnUkKu2wlqmYbfXxjE0thA8DQDUkfZjUfuqR0dKWeuPiulP3wlUM7IcEp3K/+EpnI22iq32PZIjemLMo73PFcoW0lqmx9vR1Vq2IWb2EqQQAAPnkFmnDTynp/B0lez7Qk9gUMuB/BtIfmrswrXC46QjESZC3lpk/GBXok5GslSWiXqIMGMhW1N3YMDI3ma6LB3G5L1cxDX3eq5lzyn4E1wOVLGnWu1J+ZBWXnc4sGMqANnFMpx8QKyoTTzVht6EjZMPSkJlSFOxvZL/P3JYFGxBmoQsLQksuob1cztHSEQKQ9SVhhn90AGxbAJUx852KEBEIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1v9uG6ZdC39yk/ZblnQbOcbFhUvBaZuuFC+mbct3urY=; b=DTC1Szh30tuJfX40rVeurxLdjJ8QlGXgDpd9z6vDdizg5e8i24ty0UwBj6HV9YypExKjNXysZXYE8wK/igkbiEBhFJ+zwYN/nDfCgUqgWoNzPgImEbbemdA8qzbLjPIqejb9VUxfVIcogbEsJZfA0r5XoKv8SPTL0k1WwnS4eu390so038ZbyoCzA+/8N5s3WiMv8IghgUPkaWdMlo7kDY5iNzxVtzkyM6dlU61Nl79fmmyXTQ+67UHPc2bEm8vnLsZokZRAozDNUVQQErlRoDQYG0T0mrWjsPQBLRW/PpAmPw5yc6fma/4C0gC10DojMQfp+f2MIzpkQwrBpOOzig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1v9uG6ZdC39yk/ZblnQbOcbFhUvBaZuuFC+mbct3urY=; b=Z1rGyZ1mXA4HZ+GTiZlV56GwOFEUstW1R62Y6NtHx1NK7FBLhzurZZOrFLGAf8e7N0phqEzp66wiQ3sczCLjLoMVAQJ4L6PuVlyNVytwcRWdxbyzx9K+LTqKXF+J/aIHIXN8d9Pq5sd97oO08HKh/wCEEmJVNUzj+MMuAY209PfvgK5WNT6YKHCF8hFDR5O/l4P7/rfgMEGxDREXTFNbjI0M/XuFhS4+YmP4PsrLO/vJy5dn5sSP/jtvl5mFsY5dUFub8dCsRr0Kt25Tn7Hp65rpysDs9YPFsak7LlKTCehesPXoNMlM/fCzQg+YpxwJ3cmmfLCW5gwT7OmG5P+dFQ== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS1P250MB0556.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:4a0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Tue, 21 May 2024 05:56:45 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%3]) with mapi id 15.20.7587.030; Tue, 21 May 2024 05:56:45 +0000 Message-ID: Date: Tue, 21 May 2024 07:56:42 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240521011728.29347-1-cosmin@cosmin.at> <0101018f98b99e17-5074658e-5904-4d46-8d6f-4a7f3630bdd4-000000@us-west-2.amazonses.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <0101018f98b99e17-5074658e-5904-4d46-8d6f-4a7f3630bdd4-000000@us-west-2.amazonses.com> X-TMN: [HMVawjC4rtsmv5Fc+zC+Qi0xj5QyauRu3+DmPMoHa9o=] X-ClientProxiedBy: ZR2P278CA0045.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:47::18) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <86b5b8ee-9e68-4098-8b8e-4b533e485dc2@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS1P250MB0556:EE_ X-MS-Office365-Filtering-Correlation-Id: fb630ae0-9bdd-47ac-2b95-08dc795acbb7 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|440099019|3412199016; X-Microsoft-Antispam-Message-Info: KUVDjJOtNBm5VOb0oMudMC43b9r4BenH6Fyx5BmrmoDn8XdVp2hv0mLed+oBLqJxaxKcu980luWFCZyhFDcKC3RlvKAmTQV1sZdUMGeWop9PPeBJKv8bGhws+7cbayHFu0XhPJXEHzPsejXJVJDLytj5nIieyoisR+wJNBVNsaGA/TuKlhYFlT0ZhL5MAkLB0FFBBjufXa3blMhvOzF0zB5/pjnL3obTHd7PtYFJXAk6ZgBUJf7mOymZTzpBtWirS5fBcPg8/04hMePorIDL1zbIFl/Cna2imE4EEQNb0YCbqyA13+WscT9oVP1plkqV9lRWBN7geQ8BDSEdD6R/SXDtH2sVRZgr1tASzp9kz0R6euhx8XYLYwsZfeSKjI7GzyzoALYKQBMMDb6YIEQ6hmgEbgHP0CnoMhGrmmSybXkaK+rqmjuszpJfSfH9cB/w7O3s8o3lZrdEWTmQ2WJJEieDw9sFbdmagUjlBLMHfdDeQ4np4lejESOH4lVY7TyhXPbUgMWyACkb4PH7ZLzjenhYK5WJbDE9Nr1jxRQTwMmG6qEwCBF+TL2DGRQwUtMj X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGVZWHJsWTVDZ2hldm9Lc2IxL0UrdjBsOGtOSXB4K29Qc3dmQ3VnaFg5WjJR?= =?utf-8?B?T0RqQ29lWUxzVHpzUUdnVHViLzFaNS9oeTVXaGJNTFR4RVJrWjhTOW92SGRM?= =?utf-8?B?TGlOdDFzSjVKUEJRc2ErV1Rrdzd4dzRMb09vRnBxdlQrR1FYQ3JZYURWbUhF?= =?utf-8?B?Wngwa05vdjF3eDh5bXFYbG1qWmFKR08zSi92Zi9YNmlLUVlaVXN1dHN3Q28y?= =?utf-8?B?YTlzcGJDSTNHUjRtOVk2aHpNNkNMcnFXZnZsa0FOUUMxcFFRWnZnNWQvVkM2?= =?utf-8?B?RGtBMjdXODR0c2ozZVRJWVV4dUNUcHFhUEdXN3hlcTROV1N3NC9EZWpQalhh?= =?utf-8?B?a2dLYTNabUNSMW93K215ZzltWThHUWpRQWE3UXkwL2RMME82NDVKV3FEZHNt?= =?utf-8?B?SW4wYkkzeHA2UXRKdFExUHFoNG8xclBaM1FiKzhPd0M4L2F6Q20rUHVpVGI0?= =?utf-8?B?ZEQ1N2xYR3FYdUdnQTBpOWJUVnd3dFRZSTdDNU5Mcyt6Q3lYQURQZytiTzdu?= =?utf-8?B?WmtPUDc3QUNUcDM1Z0xZYmpYUzJiYk43dW0rMTU2UFc2MzcyZEszNWFrUjVq?= =?utf-8?B?V000emRpRFl6YzlYNG80MWU2UVRFbkUyTVZ6dmlxYTRueVdGR0RMemI3SUIx?= =?utf-8?B?aXBzNktjcDh3cUxFSUdwYXlYRWFqY2F2YXZVVjgrOEpPUG5YMk5wc0RSOVRB?= =?utf-8?B?dm5Sd0FVQkZWQytkK3BINW53SXBPcVNod21IekFMa05EbWhNUU9SLzBlNFNX?= =?utf-8?B?RmRnUlpQVzE5RDFwWjRCbHpxam1zS2E2SnBzMi9hWlR5ZnJMamtDUnZtTEZh?= =?utf-8?B?YUF2c0tRbEpJcE81aURIOHVtQ0R1MzA1V2dJQnRYdTZ4UG1WVDZ4dzc2WGhl?= =?utf-8?B?WHl0TkVZSlUxcUk3LzVCWXRCbHRHWDhSUndySXdRSGt2ZW5DQjFwV3dGVlRk?= =?utf-8?B?d1VEV0NiMUljK3ZTbGZkL0ZwOW5vR2pqNS9DNDVnaE5jZGduOG1aOG9TaW1O?= =?utf-8?B?MVdsVysxUTNFVVdYYmg3Q2tCaXVIOGx5TFFPblUvREVYakIzMFpiOE8rS3Ex?= =?utf-8?B?OVcwQWhyd0dJYk4vS1NRTGwwT1R1QmVXRVhhRWZ3NzNaaDNPc0Fuckg3SXdz?= =?utf-8?B?dkFuQ3FBcTFmd0pWYVFaUit1dWRzKzZTRkRma1VkV1ZWZmVzT01LRHVpV2Ey?= =?utf-8?B?RkRNMGIxamR5STZBeTdnRU83SC9SeWt5NEZnNFlrY0ZGTHNib0srVzhCZjE4?= =?utf-8?B?ZVNZNWQ0aUVUTnJla3Q1c1dUWjMraWIyc01TeDYxU3lBZTFPMUhxcEZMSXc3?= =?utf-8?B?MjJManVJTlJZNHZ4MWZVQzhITmpVMUJNVXpiOTFpQ21sYzdOaTFjZkdrYWxi?= =?utf-8?B?K3cySzVPcERHc01MWElPRzUvRWNhalJ2MHc0QWxGRmFzOWlxa2c4SDk5Ry9I?= =?utf-8?B?eDhNNmZBNFVQbm1LVlE5VVFQUHNudkJrZUhwRlFqTWUrYkI3UUpCdjFHMGRQ?= =?utf-8?B?WTZGSSt2Sm9xKytVRmZrRFd4QVRkUUpOWW93RCtZUFdUL3BFK1FoQzhQOHND?= =?utf-8?B?TUJhUlN1TUhWQjhSWkpJZm9vcE1aUzNMUndtaEZVeGwvZVJkT0k0cEJkSGMr?= =?utf-8?B?VlNWTnpsRWF4TTQrVHo2RCtUV05oVnI0OHI3d0xaN3JIUm9MOWZ1RDJwd3pt?= =?utf-8?B?ajBQK3J3Y2FxSzZETzBhMVRUWWpXZ0o3OTNSZ3o2d1BqeHlOWUdNVE53PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb630ae0-9bdd-47ac-2b95-08dc795acbb7 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2024 05:56:45.4237 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1P250MB0556 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/dovi_rpudec - correctly read el_bit_depth_minus8 when ext_mapping_idc is non-zero X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Cosmin Stejerean via ffmpeg-devel: > From: Cosmin Stejerean > > It looks like the el_bitdepth_minus8 value in the header can also encode > ext_mapping_idc in the upper 8 bits. > > Samples having a non-zero ext_mapping_idc fail validation currently because the > value returned is out of range. This bypasses this by currently ignoring the > ext_mapping_idc and using only the lower 8 bits for el_bitdepth_minus8. > > --- > libavcodec/dovi_rpudec.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/dovi_rpudec.c b/libavcodec/dovi_rpudec.c > index 7c7eda9d09..1b11ad3640 100644 > --- a/libavcodec/dovi_rpudec.c > +++ b/libavcodec/dovi_rpudec.c > @@ -411,7 +411,9 @@ int ff_dovi_rpu_parse(DOVIContext *s, const uint8_t *rpu, size_t rpu_size, > > if ((hdr->rpu_format & 0x700) == 0) { > int bl_bit_depth_minus8 = get_ue_golomb_31(gb); > - int el_bit_depth_minus8 = get_ue_golomb_31(gb); > + // this can encode a two byte value, with higher byte being ext_mapping_idc > + // use only the lower byte for el_bit_depth_minus8 > + uint8_t el_bit_depth_minus8 = get_ue_golomb_long(gb) & 0xFF; > int vdr_bit_depth_minus8 = get_ue_golomb_31(gb); > VALIDATE(bl_bit_depth_minus8, 0, 8); > VALIDATE(el_bit_depth_minus8, 0, 8); So there is a field (ext_mapping_idc) in RPU that neither rpudec nor rpuenc (nor dovi_meta.h) know about? In this case, we should disable the encoding parts. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".