* [FFmpeg-devel] [PATCH] fftools/ffmpeg_enc: Don't call frame_data twice
@ 2024-03-22 16:07 Andreas Rheinhardt
2024-03-22 16:46 ` Jan Ekström
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Rheinhardt @ 2024-03-22 16:07 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
fftools/ffmpeg_enc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c
index f01be1c22f..5f7fcf8a5f 100644
--- a/fftools/ffmpeg_enc.c
+++ b/fftools/ffmpeg_enc.c
@@ -646,7 +646,6 @@ static int encode_frame(OutputFile *of, OutputStream *ost, AVFrame *frame,
if (frame) {
FrameData *fd = frame_data(frame);
- fd = frame_data(frame);
if (!fd)
return AVERROR(ENOMEM);
--
2.40.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_enc: Don't call frame_data twice
2024-03-22 16:07 [FFmpeg-devel] [PATCH] fftools/ffmpeg_enc: Don't call frame_data twice Andreas Rheinhardt
@ 2024-03-22 16:46 ` Jan Ekström
0 siblings, 0 replies; 2+ messages in thread
From: Jan Ekström @ 2024-03-22 16:46 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Fri, Mar 22, 2024 at 6:07 PM Andreas Rheinhardt
<andreas.rheinhardt@outlook.com> wrote:
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> fftools/ffmpeg_enc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c
> index f01be1c22f..5f7fcf8a5f 100644
> --- a/fftools/ffmpeg_enc.c
> +++ b/fftools/ffmpeg_enc.c
> @@ -646,7 +646,6 @@ static int encode_frame(OutputFile *of, OutputStream *ost, AVFrame *frame,
> if (frame) {
> FrameData *fd = frame_data(frame);
>
> - fd = frame_data(frame);
> if (!fd)
> return AVERROR(ENOMEM);
>
Good catch, LGTM.
Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-22 16:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-22 16:07 [FFmpeg-devel] [PATCH] fftools/ffmpeg_enc: Don't call frame_data twice Andreas Rheinhardt
2024-03-22 16:46 ` Jan Ekström
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git