From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 351694787E for ; Tue, 26 Sep 2023 18:43:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 68D6C68CA44; Tue, 26 Sep 2023 21:43:06 +0300 (EEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01olkn2059.outbound.protection.outlook.com [40.92.65.59]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5A80168CA1B for ; Tue, 26 Sep 2023 21:43:00 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eljDo6XGSL+2NH0W0ogOi9n/5jHzoS/y3AeNR5yfpLR23OaLMmyfGNqvpP7ves+aWqtco7JGhwOKTvX8ycC6+NiTjJD5o0weuUZSOMPOQUCCxkvkUd5BlhtLzDMFgbM1xwxwYtMFf5tQ1U4hPDmJD4tIQXRq6i1UeySpKle5SwEG6TN/j6KhSGTta0JoQhIZ10YZdLAreZV3M0rVNWZJ8PPQ4H/bq2+9+46lMpvzO1wMQU05KApPFz4SH9Uw6dxwphipvhTIia8sJ2T+ZPz35cM5TimVPqbwQ8RAXczpdSm8931r3Rh5HO6UOHsBosg2ymXSoiCPlWhcqacLL/wuoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uGYTNF5axqGX3ziHzFEiJgL3Xn6vi893zL3yKXsB6mA=; b=LkiA/K3pp7o45/avOtLOh/o4Iz7PCm9IGErRdhl9K+a102FkovN+VIBV6pAdYyC+KdoDmCC+4DegAsp908wd4lgHHodDdCvlXXsQsnqZVxIvBpuKmbcnXGYfjgnTScVClLQYmQRZo0QXkdJ2bE3Lbg0967ebdPB2SMHfXCO4l86uaXEogFaqr8C98nBT9iYbuSrQ822k1S8WWJ6GqsKWcyRJKtoa8Dzq+AoQLwpKeOTb8mpKZTM0Unb1Kc8mjvYr0enuESHxucolpYdq1vZDSyAXYwXQ/r4dh10jNumOv4FdEyk3qcWcOiX2m33XkseglL+yy/rXYsF1vk3YBXJcfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uGYTNF5axqGX3ziHzFEiJgL3Xn6vi893zL3yKXsB6mA=; b=UvwZMa68eE8k0Fx8A2tullHwHEP9dNs7nEWQdYxN8S1ww94cAByUoUaOnTCKBn6pEJZ/bTd6WHyy9WQhPENhzNonaOMvnLp6d3w9HN0fVY2QLNlvuu7YZI7HbgMEll1zwkUWBh/daHdEbwZYbVopG1KMl9wuPwmku06Y3xu6iEZHzbCnOt9H/DDe6XkWjK/X0wWgkOCFVxGVStGH/yz4MKBaln7ygxGBdLzJ6HXb7PNfzjYJfWfb3zDcqmGwRgCCbiz/S+OWPe+TYYbo5T4PIKdGHY/nLFDJ14AoEgh3wT0I+JNNOAMYNdKhRQT4s/yKFnDHwD/+4P17fR6hzvB38g== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DU2P250MB0095.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:270::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Tue, 26 Sep 2023 18:42:58 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::9d42:7b4f:71ef:c76a]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::9d42:7b4f:71ef:c76a%3]) with mapi id 15.20.6813.027; Tue, 26 Sep 2023 18:42:58 +0000 Message-ID: Date: Tue, 26 Sep 2023 20:44:13 +0200 To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [JTBctUvxA1+qnPfsEMvll1/Ge7zHp4lk] X-ClientProxiedBy: ZR0P278CA0118.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::15) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DU2P250MB0095:EE_ X-MS-Office365-Filtering-Correlation-Id: bced5842-2c95-4d2b-aa0f-08dbbec0678d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2sFjm4BDiAs7RtwI4MEH+ycUcesJq3sZjrhVFRWK3bIrOZBcJXMBjton19IZGxftoJ6IFDkwwbARY+Q9HveK0yV+gNyCuTRk74QmB6Whz/0hhEijcQ2BA3VJfO/sBzrUrVbanTeonr9NijKOZica6rg7V5yllxX9jivB9+Te1B4fRdJrDMrQDBgneV4tQogO7L7s/XCReFu5Q2PIRqP9oZdAa0klJiWRKOJ52AY04n7KTaXKtFA06P6X7agBRaVCUVlN4VgQPIys9eCSPDvZlQl9U/PKLYKsIVVoTiVQxNnEVsslFHTUCvNALFigGyh7QbkID4AWDzK4WMZxi3bARt/7FrvxnqoYOwwRHYSjxkqiZxsqDa/UAp/7upheyYqyzSiEAKWj6IDpAyavW2Ard9vJRV63FVVy5oKI7diahMskxQy/c5S3fNSirKJPVuJpDdnZjDbPliMgMlFZEbcacl1sKiZx9jyZVOTfF9624qoadCGVIb6mGWedbzpp2KgnpWSs4o9XitBTuPAPdwYmNnHXCaDQdAqXmM4Q0GM9IWnoU4RT7X5dI79zEEZ8Znin X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnhyMXBKTnZqTVJKdnlFWjBMd0xlNldqQkM0YU1aVzNFa0VWQzNBaWhHaSti?= =?utf-8?B?bEl1YjJ2UTZWRzhVb29McjU3OGsxRzV3SEZNMVNQQURyUXNMMEhHU2lESDZF?= =?utf-8?B?emVoZzJhM2VLNEY3clNFRkg4M2svTFJUMUU1aDd2YUM4a1RkNEtKZGRwZ0Nq?= =?utf-8?B?dmVIN20yTWMrdUlDL3lNaXFHQkZuUUpmdDc4S0J0LzVjdUZ3VFREcHNzbXNw?= =?utf-8?B?b2JwTmlBZUZJckx3Zm1XeS9NWnMwWENMY05Vb2d3SDJyTFUxc3RFNlZPY2Ja?= =?utf-8?B?NDhRQXZ1Njd5YmNaTE1KcEhYZDB5cmQ4RkoxbFZ6TmtndmdpRHBZYjVrRkw3?= =?utf-8?B?TnlYbFk2a1N5ZGV3MlhWSXRPZ3UzRWJxNlhkdHYyK1lXMm42MVY0QTVGL0J6?= =?utf-8?B?dVNwbFV3T0lPRk5XbUlnK2oxVjNTUS9MNm5xQnMrNFBEdUFvNnVYSG5BU0tT?= =?utf-8?B?NFkwOHdOdkhxVzUzTnVGcjF0d3VULzNuMHQrczlock5yWEJhQ1ZqSzVLU2M0?= =?utf-8?B?ZHJZc0hqNFZZdDFZeW5Icm1tL2lPV1B3U0wrYlNLb1QybHkzTlNsYmhYaXlu?= =?utf-8?B?WUtqQnFNUCsvZ2ZwZytnbEV6N1dWL1RIczN2L1F4MFZxaVZmR0RhSDZXT1dH?= =?utf-8?B?Z2U2YXpoS3EvNU9WcDMyMWxCYVR6Qlp5YWQ4YnhnaFFnUjBnOWprU2RDRkhC?= =?utf-8?B?dGNuWHRXSkR6ZXRhaGdSVVlkTVlmSWpySkZGdzRaaXBWaUpZQXlxTmYvallE?= =?utf-8?B?YlY1WWVsVC9iM2VVRWFwdlFMai9CWVdDcUtBcUFjeEk1MENTcmpGN2NGTFlJ?= =?utf-8?B?UVBVT2VqRENDNWJuTDBzSmIrcU9xWVJmNVpCb2h0NWRSTlAvNG5WUzlGK0VN?= =?utf-8?B?T1ErTERuY2V2REpNOTFybHM2b3RQaGN2MTg3VUlEdDZQMHFNMGhiNmFNRFUv?= =?utf-8?B?Tk9MQitIQkUwY1Z4S0tsWjQ3VXp0aHZaSGVtK0I0S1BwS3Q3T2o4SUJtTVpX?= =?utf-8?B?eDlqMUZwaGtmRzNuSzB2RjQ5cDg4VEZCYVpzU0wvZUFCT01ZLy9iVTI0RDZ2?= =?utf-8?B?N1FiSmJ0T2Y1OWVhaExmUnFmalBtY3NLd0dBZW9ZUjl6dGI5bGdUTFE4SmVs?= =?utf-8?B?UklkRm9FOGpmNWN6S242NGlVeERKWlRST0JEbVZVZUVkV3NPcWFjQ2plTTNt?= =?utf-8?B?WTY4TTVkczNYb0NKaGl1VVZXWDFSTXRIUTI5RVNWek50ZWN0d2ZiOHJ3bE5Y?= =?utf-8?B?QzkyTzJIZkIxeFFYYUZvYXNCNEwyeWNMeml4aUdrY3ZHYTd3UzFRL0grdWZy?= =?utf-8?B?amNva0ZvUXRkZzZiSFFIaVdkVmEvbTJTNXQ5L01yekhOTllNVDVwMVhkWU9P?= =?utf-8?B?VWNIdGV0NEh3SXYvREdjNThPOUUxVncrRi9vZzJqQS9DTTBINSt3WjBYMDVx?= =?utf-8?B?SFl2a2hrTTNqc3JHeWZVYzRwTjZkYzNtRDBkQVc1YmkwR080ZjZBUkxEVjNY?= =?utf-8?B?MVpERVEyNVJtMkl0UGkwb1ljZXBIclBzTjM1Z0Y0YzdxQXBqb21aSDlLYjh2?= =?utf-8?B?RmNiUC9IT3dnK0RWdlkvR09xTmRyV2d2V0dlRjNPTXRiWXdqTVZtQU5jM1Az?= =?utf-8?B?RUswUU1USE5GV1ZWZEo5N2RONitPWmtnOXVhbEhFSkp2Q054TXRQa1BNY29O?= =?utf-8?Q?Sl2BHaL+38bLUS/PS3Rq?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bced5842-2c95-4d2b-aa0f-08dbbec0678d X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 18:42:58.6549 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0095 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/evc_ps: Fix leak on error X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Regression since 4565747056a11356210ed8edcecb920105e40b60. > Fixes Coverity ticket #1545072. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/evc_ps.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/evc_ps.c b/libavcodec/evc_ps.c > index 6f93f5b373..64d60f44e2 100644 > --- a/libavcodec/evc_ps.c > +++ b/libavcodec/evc_ps.c > @@ -243,8 +243,10 @@ int ff_evc_parse_sps(GetBitContext *gb, EVCParamSets *ps) > sps->max_num_tid0_ref_pics = get_ue_golomb_31(gb); > else { > sps->sps_max_dec_pic_buffering_minus1 = get_ue_golomb_long(gb); > - if ((unsigned)sps->sps_max_dec_pic_buffering_minus1 > 16 - 1) > - return AVERROR_INVALIDDATA; > + if ((unsigned)sps->sps_max_dec_pic_buffering_minus1 > 16 - 1) { > + ret = AVERROR_INVALIDDATA; > + goto fail; > + } > sps->long_term_ref_pic_flag = get_bits1(gb); > sps->rpl1_same_as_rpl0_flag = get_bits1(gb); > sps->num_ref_pic_list_in_sps[0] = get_ue_golomb(gb); Will apply. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".