From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH 08/10] avfilter/vf_grayworld: Remove empty options and AVClass
Date: Sun, 31 Mar 2024 07:31:21 +0200
Message-ID: <GV1P250MB07374C72AF055F5EBC8E39DB8F382@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <GV1P250MB0737617682B4E58E89589F5E8F382@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
This filter only had an AVClass and empty options because up until
recently, avfilter_init_str() errored out when options were provided
for a filter without an AVClass. But setting (generic) options is
necessary to take advantage of timeline support. So with
avfilter_init_str() fixed, the AVClass and the options can be removed.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
libavfilter/vf_grayworld.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/libavfilter/vf_grayworld.c b/libavfilter/vf_grayworld.c
index 61ed832253..0b6d673168 100644
--- a/libavfilter/vf_grayworld.c
+++ b/libavfilter/vf_grayworld.c
@@ -27,7 +27,6 @@
#include "libavutil/imgutils.h"
#include "libavutil/mem.h"
-#include "libavutil/opt.h"
#include "avfilter.h"
#include "internal.h"
@@ -41,20 +40,11 @@ typedef struct ThreadData {
} ThreadData;
typedef struct GrayWorldContext {
- const AVClass *class;
float *tmpplab;
int *line_count_pels;
float *line_sum;
} GrayWorldContext;
-#define OFFSET(x) offsetof(GrayWorldContext, x)
-#define FLAGS AV_OPT_FLAG_FILTERING_PARAM | AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_RUNTIME_PARAM
-static const AVOption grayworld_options[] = {
- { NULL }
-};
-
-AVFILTER_DEFINE_CLASS(grayworld);
-
static void apply_matrix(const float matrix[3][3], const float input[3], float output[3])
{
output[0] = matrix[0][0] * input[0] + matrix[0][1] * input[1] + matrix[0][2] * input[2];
@@ -311,7 +301,6 @@ const AVFilter ff_vf_grayworld = {
.name = "grayworld",
.description = NULL_IF_CONFIG_SMALL("Adjust white balance using LAB gray world algorithm"),
.priv_size = sizeof(GrayWorldContext),
- .priv_class = &grayworld_class,
FILTER_INPUTS(grayworld_inputs),
FILTER_OUTPUTS(ff_video_default_filterpad),
FILTER_PIXFMTS(AV_PIX_FMT_GBRPF32, AV_PIX_FMT_GBRAPF32),
--
2.40.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-31 5:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-31 5:30 [FFmpeg-devel] [PATCH 01/10] avcodec/libvpxenc: Avoid unused-variable warning if VP9 enc is disabled Andreas Rheinhardt
2024-03-31 5:31 ` [FFmpeg-devel] [PATCH 02/10] avcodec/tiff: Don't cast const away via bsearch Andreas Rheinhardt
2024-03-31 5:31 ` [FFmpeg-devel] [PATCH 03/10] avfilter/avfilter: Use AV_DICT_DONT_STRDUP_(KEY|VAL) when possible Andreas Rheinhardt
2024-03-31 5:31 ` [FFmpeg-devel] [PATCH 04/10] avfilter/avfilter: Honour the short options documentation Andreas Rheinhardt
2024-03-31 5:31 ` [FFmpeg-devel] [PATCH 05/10] avfilter/vf_swapuv: Remove empty options and AVClass Andreas Rheinhardt
2024-03-31 5:31 ` [FFmpeg-devel] [PATCH 06/10] avfilter/vf_vflip: " Andreas Rheinhardt
2024-03-31 5:31 ` [FFmpeg-devel] [PATCH 07/10] avfilter/vf_hflip: " Andreas Rheinhardt
2024-03-31 5:31 ` Andreas Rheinhardt [this message]
2024-03-31 5:31 ` [FFmpeg-devel] [PATCH 09/10] avfilter/avfilter: Don't use av_uninit Andreas Rheinhardt
2024-03-31 5:31 ` [FFmpeg-devel] [PATCH 10/10] all: " Andreas Rheinhardt
2024-04-01 18:21 ` [FFmpeg-devel] [PATCH 01/10] avcodec/libvpxenc: Avoid unused-variable warning if VP9 enc is disabled James Zern via ffmpeg-devel
2024-04-01 18:28 ` Andreas Rheinhardt
2024-04-02 18:32 ` James Zern via ffmpeg-devel
2024-04-03 8:36 ` Anton Khirnov
2024-04-03 15:28 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1P250MB07374C72AF055F5EBC8E39DB8F382@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git