From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/asvenc: Remove unnecessary emms_c()
Date: Fri, 7 Oct 2022 12:50:05 +0200
Message-ID: <GV1P250MB0737498E8F9F6E95768FFBDB8F5F9@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <GV1P250MB07371EC08C0BC5390879D0868F5D9@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
Andreas Rheinhardt:
> PixblockDSP does not use MMX functions any more since
> 92b58002776edd3a3df03c90e8a3ab24b8f987de and FDCTDSP
> since d402ec6be99dc82e263bad883e7c1c3d957343db.
> BswapDSP never used MMX, so that the emms_c() here
> is unnecessary.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> libavcodec/asvenc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/libavcodec/asvenc.c b/libavcodec/asvenc.c
> index e185d501b3..9da7cbb986 100644
> --- a/libavcodec/asvenc.c
> +++ b/libavcodec/asvenc.c
> @@ -300,7 +300,6 @@ static int encode_frame(AVCodecContext *avctx, AVPacket *pkt,
> encode_mb(a, a->block);
> }
> }
> - emms_c();
>
> if (avctx->codec_id == AV_CODEC_ID_ASV1)
> flush_put_bits(&a->pb);
Will apply tomorrow unless there are objections.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-10-07 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 15:44 [FFmpeg-devel] [PATCH] avcodec/asv: Split ASV1Context into decoder and encoder contexts Andreas Rheinhardt
2022-10-04 15:43 ` Andreas Rheinhardt
2022-10-05 1:37 ` [FFmpeg-devel] [PATCH 2/2] avcodec/asvenc: Remove unnecessary emms_c() Andreas Rheinhardt
2022-10-07 10:50 ` Andreas Rheinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1P250MB0737498E8F9F6E95768FFBDB8F5F9@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git