From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CD9E4493D3 for ; Tue, 9 Apr 2024 15:37:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D7B1368CE20; Tue, 9 Apr 2024 18:37:42 +0300 (EEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01olkn2106.outbound.protection.outlook.com [40.92.65.106]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D540B68C7AE for ; Tue, 9 Apr 2024 18:37:36 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZI+oRE3UT2uiTF9iMMkEKjYya7mQYanMWydx9BDHW20C7ev97aptY/9e2PGWK+AAk8W30se2L0y5VjIBk3vzx4CFuFHqF5ZcTsk8swynQwO0CNH33XI4j20/tGXGqXHCmY67+0Y4/2fW0POEWcL+0k7F8KlYpqYYUkhIb4KIa9tB9VFAj3L62btRUpA2an6FghffRYkpBW4jD9xZiPw454XC6r5DWbq2tHFQmNhPbhuWXVf2NzzcQU3Lm1lGucuN0hd89W/o9hUodS7CsFLRvCKPqjykPo/7JOqiE6Kfz1bQME2lIaf3Klmju+PQdLcoB8SdGVMD/xWFKPKG/eRvVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jnm+sXdSN9wRwVvCQvlPRcqokrvlKl1SvDh40AiZTa4=; b=VIiXYbE25YCM+7QlPI2+ombjysVv52JFhby80HiESOepDw2vlLuVWTkagYz/lAVwEISfww8vAQaE3DozUZLOcB3FTiydEj43MsyNL0slL3277DmQBLFZOpLb9NQmJlpTG7u4RhQl5yQlpp8/w2xFPTXpfEwH6m2xtPM0Ub0bfQdwWRsnZnvNp6Iw9FmVJ32idFK81OY8PK1mTzfyFZg2Eqx7V2sDEx3yusFT99tWHj0pybq9gvetEujnm9AP5PgY30uLZgKR7FXOT8XedNO2YtNklziqWJlSEFEm0x3XP7V8HKVzQZ19+T5HoZ5ZVMtaTN0WSYvJ8Dm8i8rHdBvUXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jnm+sXdSN9wRwVvCQvlPRcqokrvlKl1SvDh40AiZTa4=; b=N2OnQk3rH9h/kp/yZ5tH2aQZjf1FJY4t9OIsff4laLAqsE4bjWOC8GdWaHZzINmQBY5hzmDLhPy1PkDU1ubDXAmprWfUwx4VN1DjOo85QOWE1v0qXEIfnJbLLarRHu7fCPZNapZ8IatBSS3Hld83TCzqOv/aHE/eCVUIV4kxsxUOFswII1RWUWc44VE0BQ9rVGUBFXb9/dAib2SCPqI6HFQtSqMwS2t3+/eNkw2ul4x2qN3bPd2p59l4Hc0RbU0m4fFUyS9l6wKA9VBeIE4wosDvliB23t+HE5zHsht6puHjp/2RYLnMog3Z7lPwJv/FE0qWatCUB/KNGcan00A1sw== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS1P250MB0432.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:4a7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.47; Tue, 9 Apr 2024 15:37:35 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.042; Tue, 9 Apr 2024 15:37:34 +0000 Message-ID: Date: Tue, 9 Apr 2024 17:37:32 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240409125914.61149-1-ffmpeg@haasn.xyz> <20240409125914.61149-5-ffmpeg@haasn.xyz> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240409125914.61149-5-ffmpeg@haasn.xyz> X-TMN: [LnOWGn3YwzF9F6ofA+daY5qPJTgtH/3t] X-ClientProxiedBy: ZR2P278CA0023.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:46::18) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <7ff34d37-2ba0-4839-94fe-4095e9027222@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS1P250MB0432:EE_ X-MS-Office365-Filtering-Correlation-Id: e60d6bc3-4272-4d3e-e32d-08dc58aafa50 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vXoSoBSboACOPixIZRVerj0X18Kq4FuSXAJ+UviD71hen1Ex3iLg7zj336hKv6fyFg2xsW0H++I4q1dqgpcZ4kN8bURiZBD1qO18KK/ApfS4NrwZFvszCfgMIFNGJ1ApFgEwTyiU1k+HPfwn+PAaVSShq1RI44m6egDFHch75jXCVDdxgMvYc2XlhkbHuZ/guUpAY0qB5bBQhi+xVZSpXQwf3iv/XpOgDEQxcxU3rQLuIIuYAJppF3i3GuBgMZrWrAYHNzecYVUpp7kybo8Zj4B6suWEhZwlEMnQPrWKSRtxrgjUa0hpq6mGO6AfZEIN8kgxL18ozu/y5zoJGRRoZLn3ArTtKHuE02FOPtAzaj0ZrdakRBToVgAQKlXuRNrg70n7uYUioxQkEA8RK+QpOR+7VJbm3W45sx0fBEjIzqcA3sNZvCrU15wOD4bGoZBeIzsAnuT7DycvFpuqtdnBZFWieSOVCvy4u8TzSCslDWuCODnAhEiKR1Juc60iuPXUdF3K42+yulYbsbeAeQvLHX+D18TNOep5GYXVQQ5H5RNZ3AyJsIhtNR31t81f1vzw X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnJDQy95bUlFRlJ0RUZkNkVHaW5YaEFEdXc1STFZcHh3WkVNdTlxMzJLZ3Zy?= =?utf-8?B?M2tjRGg0YWZDajNEVHpCajdPYXpOVDFuWWwxTjRjYzFMUjRPeVYvQVVxNldN?= =?utf-8?B?aDZ5R0VlL0FLN1c0YS9wdVp4RWFPeFhOMCthRWN5L0FGaTkxSisxNWVDT3RM?= =?utf-8?B?WlB3SS9LRm43bzhZa0pkT3N5NFUyV2dadEJQNFZrV0pLMHVzVzliaHBlejZm?= =?utf-8?B?U29jT0owaDVIb0xaYkN3anNtaU5yQmU2eXdGRFZ2anZaZS9lamcxSy9xZmQr?= =?utf-8?B?ZmFRRDB3RzM5NnFhYjIrRWJDeXJsdGVIUTZ0di9oaS8xYnZPOGFvRGJycEVB?= =?utf-8?B?R2pqVWdBS0lVbGVXR0t5OEJ3UVJSd09ObDR3Mng4aDNwd1hVOXlpbUx4UXll?= =?utf-8?B?bTMrM29PVG05THAyUVRUZFpFYWpvUXVYd2FyYitJaGhvdHlCRC9vU05salEz?= =?utf-8?B?aXRIc0gzNE9ONTJBRTYvZGswditxZG1NREh5UXEwVGJtbUNYVEE0a2VTM0JF?= =?utf-8?B?MDRsZVlwNytFVkYrUWFLOXFxVjVvc0lPU3c2T3o2dWJjL0RTNVg5dU11MG96?= =?utf-8?B?cDVYcUpYdU41Qk9uNFBieXZya3BvUGRKV3lONjVwaXRBSXpJZkl0ektnNXpm?= =?utf-8?B?cWdyMTRuOW42N2QwRXo1cmhIVnFuYTE0MTYreS9LVnMyNitqeHcrczUwRm15?= =?utf-8?B?dFYwZzBzYzdvVGtRV0tKVmxUZVJTaHEzSWZIT1A3ekMxUFovdy9aZjJucGN4?= =?utf-8?B?b21CSHZwNUR1MnBxR3NPTjY4eHVvZ3Y3S2RzOVQ4T29FbGRQRmE0d0N3T09Y?= =?utf-8?B?aHh0Yk9Uc1JKeHVpRHFyR1B2MUkvT0hQdzJ0ZGlaL0dvY3d3S3RMMTlwelR1?= =?utf-8?B?R09yRmEyRldaL2M3dVh2MzU0elE2TnNKM0hqWm90eitmczBFci8yb0QySUhv?= =?utf-8?B?WnlncWFrdlRBOTZOc1JuQ0Y3c0hnRGJsRUlpUEhXM0pGOGp6M0JSRDhOSVda?= =?utf-8?B?SnpnVUVzclgxeE1hK1B3TForeGwzeXhjU0twblZZSlFtQk9XdWhrRFRzSC9j?= =?utf-8?B?c2Y3NkV3b2RmVGRTUm9ZbDg3cmFleng1QUtTYmpQeEJyM2dPYm9jakhGdmhC?= =?utf-8?B?RFllN0VOd1ozVW1wTEhOMm85MFd2VUhiOEhPVTBJKzl5YWIzOTQ2TEs1OUZw?= =?utf-8?B?MHo2L1lvdllCZlMzcmtSTUkwclc2UlpOOG1VdktGaDJ3M1VOajEvbEtadEdT?= =?utf-8?B?NWg5WlF1TkN6RWhaU2dtV1QrWnlXa1BvbDlzSEtRMzdyQytQamtMOFpXbFRE?= =?utf-8?B?TmxNbzBLUTlFcnFPNTJ3ZlpTa3hVcUsvTUVPejJicDhGbnVYckNtWm03ODlw?= =?utf-8?B?N3l2UXRUNzM1V2FwSjBaWWZyRFM4ZnBBZTBiTDB5SklzNjQwQ1VVUUxHaldU?= =?utf-8?B?UEw0SEJtclMyc3hsdW5Kc1E2MUU5a2dvb21VQzRWdHJSdHBnQ3c2elBnNGR4?= =?utf-8?B?SlkzeFZqZ0ZHUGxlWHpTY1ZGRGpiRmgwdVdTNlpDWUlYdUZBektpVG5BMU1a?= =?utf-8?B?RjdNOUQ1NTFNeGRiY3lRSW9xYUxKbExQcVUzQWtqN0ZOa0NVaTZ2YWhmRFdF?= =?utf-8?B?dEJPRy9SOHNxT2RZS1pVWjh3SUowdytiTmExdVNYSTlnOHJJTGdHTy9YUW1z?= =?utf-8?B?V3duU0hLSVlPZW1nWXUyYnMxb2N3bHVSWGdJVzRRdStHUTZ1VTNmUFZnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e60d6bc3-4272-4d3e-e32d-08dc58aafa50 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 15:37:34.9255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1P250MB0432 Subject: Re: [FFmpeg-devel] [PATCH v2 04/11] avcodec/dovi_rpu: clarify semantics of guess_profile() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Niklas Haas: > From: Niklas Haas > > This is based on HEVC only, H.264/AV1 use their own (hopefully correctly > signalled) profiles. > --- > libavcodec/dovi_rpu.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/dovi_rpu.c b/libavcodec/dovi_rpu.c > index 267e52ceb66..4da711d763e 100644 > --- a/libavcodec/dovi_rpu.c > +++ b/libavcodec/dovi_rpu.c > @@ -121,7 +121,8 @@ int ff_dovi_attach_side_data(DOVIContext *s, AVFrame *frame) > return 0; > } > > -static int guess_profile(const AVDOVIRpuDataHeader *hdr) > +/* Note: Only works for HEVC */ > +static int guess_hevc_profile(const AVDOVIRpuDataHeader *hdr) > { > switch (hdr->vdr_rpu_profile) { > case 0: > @@ -510,7 +511,7 @@ int ff_dovi_rpu_parse(DOVIContext *s, const uint8_t *rpu, size_t rpu_size, > use_prev_vdr_rpu = get_bits1(gb); > use_nlq = (hdr->rpu_format & 0x700) == 0 && !hdr->disable_residual_flag; > > - profile = s->cfg.dv_profile ? s->cfg.dv_profile : guess_profile(hdr); > + profile = s->cfg.dv_profile ? s->cfg.dv_profile : guess_hevc_profile(hdr); > if (profile == 5 && use_nlq) { > av_log(s->logctx, AV_LOG_ERROR, "Profile 5 RPUs should not use NLQ\n"); > goto fail; Is guess_hevc_profile only called for HEVC? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".