Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH 04/14] avcodec/huffyuvenc: Remove always-false check
Date: Sun,  2 Oct 2022 02:06:07 +0200
Message-ID: <GV1P250MB0737481E54D6F88448541B0E8F589@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <GV1P250MB073731CA0D62A48F301E43DA8F589@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>

The ffvhuff encoder has AVCodec.pix_fmts set and therefore
encode_preinit_video() checks that the used pixel format
is permissible.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/huffyuvenc.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/libavcodec/huffyuvenc.c b/libavcodec/huffyuvenc.c
index fa4923962f..80dcdbaa93 100644
--- a/libavcodec/huffyuvenc.c
+++ b/libavcodec/huffyuvenc.c
@@ -310,12 +310,6 @@ static av_cold int encode_init(AVCodecContext *avctx)
     }
 
     if (avctx->codec->id == AV_CODEC_ID_HUFFYUV) {
-        if (avctx->pix_fmt == AV_PIX_FMT_YUV420P) {
-            av_log(avctx, AV_LOG_ERROR,
-                   "Error: YV12 is not supported by huffyuv; use "
-                   "vcodec=ffvhuff or format=422p\n");
-            return AVERROR(EINVAL);
-        }
         if (s->interlaced != ( s->height > 288 ))
             av_log(avctx, AV_LOG_INFO,
                    "using huffyuv 2.2.0 or newer interlacing flag\n");
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2022-10-02  0:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-02  0:04 [FFmpeg-devel] [PATCH 01/14] avcodec/ylc: Remove inclusion of huffyuvdsp.h Andreas Rheinhardt
2022-10-02  0:06 ` [FFmpeg-devel] [PATCH 02/14] avcodec/huffyuvenc: Remove redundant casts Andreas Rheinhardt
2022-10-02  0:06 ` [FFmpeg-devel] [PATCH 03/14] avcodec/huffyuvenc: Avoid pointless indirections Andreas Rheinhardt
2022-10-02  0:06 ` Andreas Rheinhardt [this message]
2022-10-02  0:06 ` [FFmpeg-devel] [PATCH 05/14] avcodec/huffyuvenc: Remove redundant call Andreas Rheinhardt
2022-10-02  0:06 ` [FFmpeg-devel] [PATCH 06/14] avcodec/huffyuvenc: Don't second-guess error code Andreas Rheinhardt
2022-10-02  0:06 ` [FFmpeg-devel] [PATCH 07/14] avcodec/huffyuvencdsp: Pass pix_fmt directly when initing dsp Andreas Rheinhardt
2022-10-02  0:06 ` [FFmpeg-devel] [PATCH 08/14] avocdec/huffyuvdec: Don't use HYuvContext.avctx Andreas Rheinhardt
2022-10-02  0:06 ` [FFmpeg-devel] [PATCH 09/14] avcodec/huffyuvenc: Improve code locality Andreas Rheinhardt
2022-10-02  0:06 ` [FFmpeg-devel] [PATCH 10/14] avcodec/huffyuvenc: Avoid unnecessary function call Andreas Rheinhardt
2022-10-02  0:06 ` [FFmpeg-devel] [PATCH 11/14] avcodec/huffyuv: Use AVCodecContext.(width|height) directly Andreas Rheinhardt
2022-10-02  0:06 ` [FFmpeg-devel] [PATCH 12/14] avcodec/huffyuv: Inline ff_huffyuv_common_init() in its callers Andreas Rheinhardt
2022-10-02  0:06 ` [FFmpeg-devel] [PATCH 13/14] avcodec/huffyuv: Split HYuvContext into decoder and encoder context Andreas Rheinhardt
2022-10-02  0:10 ` [FFmpeg-devel] [PATCH 14/14] avcodec/huffyuv: Speed up generating Huffman codes Andreas Rheinhardt
2022-10-02 14:46 ` [FFmpeg-devel] [PATCH 15/15] avcodec/huffyuv: Update outdated link Andreas Rheinhardt
2022-10-07 11:58 ` [FFmpeg-devel] [PATCH 01/14] avcodec/ylc: Remove inclusion of huffyuvdsp.h Andreas Rheinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=GV1P250MB0737481E54D6F88448541B0E8F589@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git