From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 726FC49943 for ; Mon, 25 Mar 2024 01:55:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 674D568D4EB; Mon, 25 Mar 2024 03:54:25 +0200 (EET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04olkn2107.outbound.protection.outlook.com [40.92.75.107]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B910868D4EB for ; Mon, 25 Mar 2024 03:54:23 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KpiNsL8r9e+Cti/agtQRfDO03zXk8p/NUK/CFnExulltVT4svxw3KNrcBC1b+R+BG+cdXi+nm+t0NITNnqgJjlNd0bw+xE2i0HvV9EZNpubtwLmQSBKCrfFqpqg1ZAG7jNDOZQQ7U0h4CeyyqY9lQtrek0WZY3rUFLgMsrEPGeQIJ8kp2sh+Bxn7YWjB+uBJjFXUfvYcStxvvdSCxZLs6wLl6HVJgO2Qis1D7f2II8pkTpRi/S8P1HLRWFohmlyotEIzu3rZqaa8eOTZ5pDs2bQmOPrSZ6Ol9XnBuKdL0bsvAPgRK6TjHWSO5XhV7XGixSVqlsyRVGUWNKVmfDWMuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3MCUQNp+MwY+67bI8iBQZiqXzZ6fncRC0h00S5EACWc=; b=d+xsZOutribaAPJFy7s9g04ioxxgo9mdj5rY2bS4ggxy09M1wXKIJWtt23NSwI793pYQc+Nn3zvVruUGjCcGDYIHLS5E92eCGM8tSoXCrBd3v+G3ww+cP0M/XvXELbKpFeJtcsDIycV76l1mDp7+wx3zuNCsIHLbZqnJXDtpvjeTBWvaIOLbEZBYET5wEZ/9RuiLXnpCoJlDyLdNLpT1JRtjuyO5j5mHFyNYyfD0DfZC/jZdlpaD/8qndTV2r/V+41ofQ1Lu7mbmLn/M66+uMgsERuMvCuFVQO2jGksm2sM1aluMqyDynFOpFFmgMzO8qAYCv6+BImDJbxx9/f/OfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3MCUQNp+MwY+67bI8iBQZiqXzZ6fncRC0h00S5EACWc=; b=sif2YVArvaIlrLjo7MFYKoJc+GJ6Tzv2gTYZHfq5TZF223hO0u5nbsMVMiVkRaRp6YorvF3wiMGSlbbPlHCxeTah6Xwv/u62okmVN/qhLB9K9AywhLcIlLmUwA4u7ZXXDnxM/LZCZf5iOgNkA6jSSVTf4qRsYpWi04ajid/muXXsEX59J/TiSOTh8ZpthwQ+FfyaGb0DdVSh8/KAcTA5WkVwVaCg5iJ5r80UqH5T1/QSOJAWDD2vUZudmBMb6frmM5TsyeGl6GKGnouDQRZf7r66mc7xefYpE86n80E324MeOZ/ekbGvh2BICefP9C5aiKhm2A9JCFgnEIJGWAB/9A== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS8P250MB0118.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:371::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.31; Mon, 25 Mar 2024 01:54:22 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.028; Mon, 25 Mar 2024 01:54:22 +0000 Message-ID: Date: Mon, 25 Mar 2024 02:54:20 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [++i5SNlddff485bG34Run86DcUTECLrQLrTpzMbM8oM=] X-ClientProxiedBy: ZR0P278CA0216.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:6a::7) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <38eddf6d-4936-42af-8ebf-94cbffa78e04@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS8P250MB0118:EE_ X-MS-Office365-Filtering-Correlation-Id: 71d16269-ad4a-4818-252d-08dc4c6e7dfe X-MS-Exchange-SLBlob-MailProps: 9IecXKUgicBMjzDtAlr46x5HKEJiZ0Rb5bA0KwGfsbeK1Yg8fPWrhkS7NGvN08nWYVf5rb7y9/wW1bK6sMqdac3lhtT4UhZ75WE1EwvQ9mUZr5kCwZvaIyOX3o2g1yzFKjTrAPAY823ooRxfI1Qj7TICHrwglxHrDobdsf+E1LvbyKr/af9H/5u4lWX9SwRPVhWoAaNKKN3kVV6ZlPiF3Gu+hoyuP+UKHziE70KFL++drtgKf2tKqs4KpKhCzitG861EXqm4xaGW9e9fuKSEhlB8JCQ/kwRzsP4Vqs94pgGHIHCqbMIDTpAYwgts05j6EwcjMhPCHg2VugiSPjvaGacMm1hborJmF5EZzP4cjIGd32wJSJhgAd98RByUCo97Vrsu2lR+fnmED1zBbjl9jVp4TFoXvuS3EV4CcvBZe3Ex/4Zl/0+bHpUNGrUAx1BYco6v/Rp4zZuAdV0QU0LDQwXAMqcifvSrs1cTTfrv9erzAcpInFHSVPOyUw2dsOl6l5t9SFVPYc2TnXHwutYUSD15+zxZFXi/TUtL7CRUdpzGxoNxPxf7WxAW5KTu8iriQrdIuDGHSL+Ln/c66DdzpZsKDha/hOCAo4Yh4N24KlDlqFyO3PdP5PKT8bnvNq4H/KrKeUXUPAEbMF4mWSNIovR12YWZrOATmUWj61R+XlA8OzbbWa+pXFiWj+5JUeZ58Wm0vUGKEwJmOkPtxvvh9V7HYTfEAJE3G3EXEW8PrezY39qxr380HQ== X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IVLZm42XbxBnEmKg4gUGnJkQBq3j655EoWfmxBn6OtnFZGtitw9hDP1kYvMQvuPzdOC0Tw7QuK+ecTglbRqyFiTqefiZeeHBdE72ysPG8e3IO5VyfdNO2YA/uwPeQV8HkQSk2lt2spZuH76rFgP90sfW0olcHyEuN6anbJ9MhF1iep2bXQKlVA7XVka8jo51BnS5l1SiZ69Rc6PcVckGadHoiwlVWN/bzuXoYtPepDsllARIrnratiGilu+Oyv1dnXfcUt0pE++qtAS7+hAcHIkQb+0b6f2yIz0Gm2aLBsRcL3FQJ/B1+nhRC1kWtDrDORxenn9spPwSZ4eFiOeJTkdEQn2Clq7QwxhjJN4LPieLNAGV4TEG+sC5vBQ0h3MyQ8op9xgElfOhjl3jCIOVptbydY35COvc13JpbTJIWL6fcoDe0ngrf7/gyYe/ZdOs0Ajfqb8PxSx5jkq+xmut6+pPtzpt6ZNLz3EXcJ1c8jWUmIA8/yi1GnQDST6Cm5JldG7nVUcdcjIsiVQ+0uEmJgszZtOuhgrYM2BVCM46ET53EQnbDu2ktQLLxEAWAayr X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUlzNGRTV1cyeGsvdWM1QTRWTDROR3JRYzg3d3F4T2tZU013MnJTVkRGQjhL?= =?utf-8?B?bC9mblRHd1ZMZCs1bFhNMUpsQ3czK2FwckY0a0l1dVc5TUpCU1VrYjRWaFRR?= =?utf-8?B?U3J1WUtaaERtNlpway9Lc3E2RVIvQVAwRnF0SkxRaHRoempTNE9lc2JBRkxD?= =?utf-8?B?MlVWdkhKZUZLSjFsNGsxcUNSaVJ1ZEhyMkFCQWZGMFNHellaMUtIbTg5VCt6?= =?utf-8?B?Y2xKYjNDaG5tUUpaWHVHUWhQUjN4bkN5Z1NTMFVtblZBV1dyOGpQTk5sRVBx?= =?utf-8?B?emlJUGE2WVQyVzVjUHFOYkY3UFA5WERGRnVMdERKR3JuaS80SnRTbUtKT1FX?= =?utf-8?B?Sk50b05lRmxKYVZJNzhpUVlsc0t4RjRkR0ZiQnh3bHVISzVvYW1XZGhNYkRD?= =?utf-8?B?bG9PQzBra2loTkJLNHNuZDliUDR5OXFSbUpsYUZ3OHBrTHZ6OXA0TUY1dldN?= =?utf-8?B?cUU2VHE5a2VZd28vL1p0aE1Gb3pXWUVqMDl2YncrTzRxWEZsVGdGMzBtTTNa?= =?utf-8?B?WFgxUDZKL2RZcGVJWjVyeGhrUHU0aURyWmR3QVhlYmxZdjRKL0lGYXBwYmZ3?= =?utf-8?B?UWdYNzBOSnFsdk1kMmZJN2V1NlhFNzJpOHo3OENTbDVNb2xKbDE4VWREWDZM?= =?utf-8?B?N2p6ekhtYU02SFNFSlpzaG5yWjNqdHc1Qmt6a3NkRGM1cHdlZUlITDU3cE5X?= =?utf-8?B?Rm0wcjgrTi9CQkRNMDhDaDBMRTVjSVVKM2lMLy9aK0JkOTRBaS9CM29LcktJ?= =?utf-8?B?L0hPbFU2T0lBblArVHVhVDBaQll2WkhOak9aZW5qUjNFZzRQWnhEdUt1OVdN?= =?utf-8?B?MWVWOTc2Wm5LektSK2RZL1hONm14SlVxRndxY1Y5U3VNd25wUGxvOHhzSXNh?= =?utf-8?B?S0xjQzI4eEc3VWJHUms2SmZBSUZBZDQvNlUyN2tISndqSXhkaThrNlBKd2pl?= =?utf-8?B?RGpJaDNRZWxLdDNnOWZ4MjlIRnZNVHFqTnV4dmJkSXNzZ1VQRWZ3d2tWTFF6?= =?utf-8?B?cUlqU29qeGplb2Z3bTM2TTdSb05mYmhpOEx2bWczYk01RWx2WjJmdU5aVER4?= =?utf-8?B?TXdkSGZPcGFZSmtKNFZQVFZ1VkFaS2hLbzZDSjhkTGgrL1pNUVlZUmZ3MEdG?= =?utf-8?B?QlpiTDNGWDJlRzVobHo0NWtrYUF4WUt2cThkUjVHUXBxdTI0aWUzYVdxU3h2?= =?utf-8?B?eHVqeW52UEhrQTZoMXc2M3NFa3hBYVZWR2N6MXZqaGlRTUdsU0J1TFRLUVJO?= =?utf-8?B?eFBHZlhYWklibUFmQWN3YnBmSmxWM3NQVk5JbTV3ZEN2S09heituNGFkUjJ1?= =?utf-8?B?eGtnT1AzTGhiZXdxV3ZwL0ZZNkxPTnZhaTBrM1orTEdSTmYvNGZnWFA1bk9B?= =?utf-8?B?alhyTDFVY3RXQmdOTUZIZlovaVVUSFNhVllJNi9uMWhSN2N4UkZRbW9NcUxW?= =?utf-8?B?OS94TmF3VTFOL1lkbjVHRmFWbTJDc0VmaG9KWHZOT1gvaFVubFo4NThOWmVh?= =?utf-8?B?YStDR1ZYeUZvbyt0NE1JN3NPbW8xUG1kbkl1ejNMVHdOUzh5elEzaG9lemxp?= =?utf-8?B?ZHZTVDlyL2tqSXN6YUZJU1RuYmt3ZEV1c3RxNzNoNlJBWkVHcnNUcjFScFRk?= =?utf-8?B?dHdpQThDM0o3Y1NIYjZSVUlDMVppRUxRU01FSEFvQytaczZ2M0dobHIvaXVv?= =?utf-8?B?NytDVmMwTTJscVpjRFBrZXdPblRnY2taU2tXUG56SDB2UXFDKzdKN1Z3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71d16269-ad4a-4818-252d-08dc4c6e7dfe X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2024 01:54:22.5371 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0118 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegutils: Avoid allocations when using AVBPrint X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpegutils.c | 21 +++++---------------- > 1 file changed, 5 insertions(+), 16 deletions(-) > > diff --git a/libavcodec/mpegutils.c b/libavcodec/mpegutils.c > index fc3e270631..7f499b3d0f 100644 > --- a/libavcodec/mpegutils.c > +++ b/libavcodec/mpegutils.c > @@ -252,7 +252,6 @@ void ff_print_debug_info2(AVCodecContext *avctx, AVFrame *pict, > if (avctx->debug & (FF_DEBUG_SKIP | FF_DEBUG_QP | FF_DEBUG_MB_TYPE)) { > int x,y; > AVBPrint buf; > - char *str = NULL; > int n; > int margin_left; > int x_step; > @@ -278,16 +277,11 @@ void ff_print_debug_info2(AVCodecContext *avctx, AVFrame *pict, > x_step = (mb_width * 16 > 999) ? 8 : 4; > for (x = 0; x < mb_width; x += x_step) > av_bprintf(&buf, "%-*d", n * x_step, x << 4); > - n = av_bprint_finalize(&buf, &str); > - if (n < 0) { > - av_log(avctx, AV_LOG_ERROR, "%s failed, %s\n", __func__, av_err2str(n)); > - return; > - } > - av_log(avctx, AV_LOG_DEBUG, "%s\n", str); > - av_freep(&str); > + > + av_log(avctx, AV_LOG_DEBUG, "%s\n", buf.str); > > for (y = 0; y < mb_height; y++) { > - av_bprint_init(&buf, 1, AV_BPRINT_SIZE_UNLIMITED); > + av_bprint_clear(&buf); > for (x = 0; x < mb_width; x++) { > if (x == 0) > av_bprintf(&buf, "%*d ", margin_left - 1, y << 4); > @@ -310,13 +304,8 @@ void ff_print_debug_info2(AVCodecContext *avctx, AVFrame *pict, > } > } > > - n = av_bprint_finalize(&buf, &str); > - if (n < 0) { > - av_log(avctx, AV_LOG_ERROR, "%s failed, %s\n", __func__, av_err2str(n)); > - return; > - } > - av_log(avctx, AV_LOG_DEBUG, "%s\n", str); > - av_freep(&str); > + av_log(avctx, AV_LOG_DEBUG, "%s\n", buf.str); > } > + av_bprint_finalize(&buf, NULL); > } > } Will apply this patchset tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".