From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5935E49AFE for ; Tue, 2 Apr 2024 10:16:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8E91368CF20; Tue, 2 Apr 2024 13:16:15 +0300 (EEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04olkn2075.outbound.protection.outlook.com [40.92.75.75]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D42DD68C865 for ; Tue, 2 Apr 2024 13:16:08 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QJlIYyfz5AhnTv7IPcXPJlvf0UNpogHBSsp8PELQGF7l/KGayPgnNR7RTVtB5hCraKs28VDl+HC5GhMWtn9JKsfRvMordpcGoAXQy9EUFbffkmPIujZUHdBjLvZxyLJPMV3CZw9JdMvdXBQrGoOeQ0n5aEj+g4ArYANVWwGjNnTwWpPPx4XLJvwCq1gbHtU7sTni+K0npW4nHPidYuroFihPy5C7dDkfG6MSveZ3inO+l2xpfLui1vzZyHC1FEScp7q9/9HmPna0RNkWhMi+pOkcP9VJuFUiT0ZiFRYH3sJ9C0AdaVH/Y11NOrur4Smek2E14wvlojz+ssGs/nmZlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8/P+niScJPb6XHgGw3GORxVqz9fOWsLeL36XQeH0Nq4=; b=gTpSNLR/XlEepNHx8Rj0AKdLbHQKg7itfUFIAi7HqUX1RRWRwnbjUgXb5MMU9a4js5W1e6qlYmSDLy9QxBEbpb6HZU176V7ed3PyhJC6FrEvzzkd42NzaoHrcEZ0MnzkGhe0kyLWwtleqjowpNWQHCyII49Py3IxmPOarbF/AE+XDOErasHZ8SOd/ui4DbdToeI28PBeB6JNCP2m774aC3Epy1OaGss6sigS/Ob0cUdzSAmVOxmoyAHz1Y8pf1tPZUXkX5cDDwAR2SG21DAgHKVhH3Gvt1hJPK2W/kiWGBJz1+/fJWXRalhSzF9QQ0C32NJ76U1avAlgYg9tj00ZrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8/P+niScJPb6XHgGw3GORxVqz9fOWsLeL36XQeH0Nq4=; b=C7gTA3x+3cb1Wpdi7v2XnPxcXZXR3je3yQFO/tu1CAzOkbIBHP2J7PsgID1cFNJlQfAwbPlopg2PwtMKJQrQKFIUBbyDZEaX6i9d5kxs601SSCT7EWGW1nwrXlTFdxfFrL3H7h2ZMhoxO39nJ0PWABciAZmNd/kY+5ISwrLSkFBV4mB9v4QOjv/pBdGr/me9CFiWkK2eBUGllxFd8xLSvIhiLFg/XdZqbNkqtDVTXmrqScyOw6g5pP1atTMQwxNCIdQOP7aOjyxjhVAqwJTJjdxItnm5rruYDg8ao9WXozRICq0a5iWw+K0otyszTi22aOuiIOGNBPLtgq8utNHqrg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by GVXP250MB1060.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:1b3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Tue, 2 Apr 2024 10:16:07 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.042; Tue, 2 Apr 2024 10:16:07 +0000 Message-ID: Date: Tue, 2 Apr 2024 12:16:03 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [po8+ekv7jkrP2r5fOKqHpX6IJNA0MW0SNO/MPbTrBtg=] X-ClientProxiedBy: ZR0P278CA0217.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:6a::15) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|GVXP250MB1060:EE_ X-MS-Office365-Filtering-Correlation-Id: e264764b-4b1a-43cd-a322-08dc52fde8fa X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0pAYhc0Bj59OYGmM/YWiXxQ4zzNcH5w2ZEe1cYrqmDi0fDS7n3Ow//gQGBceuj9u+4wuz30VX5uflo0Fpyj+A4RVMQkx6PGa225Zar2HUdx5fz64QTAxAKzRMUyg5OBwYYleGOLVPTNa/uyrwC4VF+Q2Arx9wflYarArqRU8tM94U7ZMvcR7w3DN1b2Kd+7PQUpxOOy301ZcI3OCBi/osxFcU6KaFbI4MzmZNHiGhBjxc8qafYxR0Zzi/K+dccUoxcB7ziIi6nHTynI3YNYC5qQbxxj7BixaZUmLlkvA6c4R9E1SbzMG013SYVdqy5DAZAIzo63hoFEsZ0Dv3IbYUORGJ3hRVXzhWlcQhmVfyHdfM63je6/MnnTle9lNxi48OY2DDQRBH8alcysZPpx4PeXk6XxSNRSVnBeYvVZ8DECcQRFprXBl2xuOu4bixVUYB6XJVYje1E6wptoI5Lqmkn1d4ZeSzWY3vIBAShwS0x04pnd7HXyurd5+pl5q6ojM/2g0CFvrqoo6/UIkehcDtg/JMPKZBNWWgdeKOZ9B7nq154rdW3Svd9+BkYuPux/6 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UTNsSUZmVmUvTmVVMW9wZXJiNXJXdVpPMzV0MFNRc1J2eGxWZGpXMFZWSmRT?= =?utf-8?B?RXVzWEVhTTd6aGJ0ZzVRT0pXQzhpTGowOVJrRS9BZ0Q0STEwUm1Mb2Y0dkJN?= =?utf-8?B?OEtkNit3OVVhbm5DUVkyU2x6YWFwLzdrSHFlNGFiV0h4OVEzSW8vZEh2WmJy?= =?utf-8?B?Z0VWL2lBSmZhZlZnSWsydkdvbmcySk1mTDE0cTFiNUdBRTZkQkI0QWFVVjhG?= =?utf-8?B?QXhSeUsrM01ZcHFrMWJiS0F5UVQxa2tXeVQ2NUlIVDBhTy85ZXhZNDVBdStz?= =?utf-8?B?dlA3MXByMlQ2dWZ1Z05YcEM2aFNic3lucVlzMVpTWkVMeDNYdTBQOVBsS2Jv?= =?utf-8?B?dXNyZDVKbXNncHQyclBjM1Y5cDR5KzcvRFJwZG9YUm43MnhKVFRYV25aUG82?= =?utf-8?B?dGlYby9nWThpM1Rwa0tFeGplc2I0TEM4aDdscG1PdVZSZUdHMDFJdlFLbjVH?= =?utf-8?B?MlVpQnVnMm5RamVTdkJuRlQ3dGZ6YWdjSG9tRmV2WURlRDQ3RDNtajBtK2R1?= =?utf-8?B?ODZna0NRNmhoRENHWHdEYUVTTmNiS2JWd0Z3QlN0aHIreHNpTjJLbUhMTTM2?= =?utf-8?B?UnpsTExWREJuK3JSb0oxbEJ1WUtPb1NYQWRwRUVPL1VFdCtLQUVkcWI5bVI5?= =?utf-8?B?aU5IK0xJTTBjcUNSSGt0WFp1NE8vemFyZU9BSWVSZW9HaWNwaWF3NXI3K1Rv?= =?utf-8?B?TGE0eTEwdE9YTU1vNkNnbmVJeGpma1FzQjQ4UTlRcFdkUklwbStUcEZSVk44?= =?utf-8?B?QndJUGJCd2NwbXRhQVE5ZGJGK1pZMnV6Q051YUhVU0l6dDVjblJZMVJhWkJ1?= =?utf-8?B?M3crdVJXUkI3ZHppeXRMcWJabHB2QU51M3hWMEFkZmtYOWlqQUI0cDk0Q1Jr?= =?utf-8?B?aEh5aDEySzBBR2UzSjRUNzF0Tll6aEltMDZ6Sis3WHB1c2J4aEk0bUMrU2Q4?= =?utf-8?B?bm5Mb0IrNzBXNFA4N2hYaXF4RlJmdm1mOThBdkxGNkdLeHFUMVpjaEFlV2tZ?= =?utf-8?B?ZHFWL3FUMlJ1RFNvUmZoV0Y1dkQ5RlJ6WVNWanpFaUcxT0VFTFB4YnRMbjZD?= =?utf-8?B?SjRqdU1uOXVZYVA2T3doVng3dEdDVjRhRjVCZXBDSG1sTG9aWEhMdXdLYktY?= =?utf-8?B?eEFPRHFqaEluK2JmMnRXalhydXB4TmU4NUg0aVJUenNKa1hHN1RQOVJWWUJj?= =?utf-8?B?WE8wU3dxVzJQem1mYUo1a25OUlJHaUVrWTRQYXJQWDhYUHVORmRpb2hKOWJQ?= =?utf-8?B?MGtsWWdNSnBuSUxLb2plTFpTallYS1ZIQlFUR2ZvRnBNellRNE5ybFd2OTJo?= =?utf-8?B?NU1BL3R2WjF1ZFJMSnc3UWpiWGVLbk41c0Y4b3E1azRwdGxMZGIraE9BbVps?= =?utf-8?B?aU5JT0U1TEhHbXU3REZkeXVwbmppWG8reXNTWGsyKzdsVGdNTkRLdzU4VzFU?= =?utf-8?B?RjlTM0NPdk42QmcxUk1OdDlkaTlIdkNmUGl4WU9UOVpMaFNJOUpBT0N0anRP?= =?utf-8?B?Wmh6aUlob05Oa210dFMvN0ZDellUQWw5OTlacWpGUHlnRDhscTlYWHZVckVW?= =?utf-8?B?ZC9aaU5wcTdwRnNwb0w4VGJpWmNOcHdsSVlweU03amhKd0F3SmxPNFRxVW5W?= =?utf-8?B?MVVISjZVQXBTdWt1YmQrTGVjem01SUFSM1NmTkFyYll0UXc0TEUwWDdZSHhm?= =?utf-8?B?dTZRUDJTMzM2T3gwNiszYXY4RENqTkJ3Y2RJVCtaNGU0MERVWldHVVFnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e264764b-4b1a-43cd-a322-08dc52fde8fa X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 10:16:07.1060 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXP250MB1060 Subject: Re: [FFmpeg-devel] [PATCH 5/7] avcodec/dsddec: Fix decoding LSBF samples X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Peter Ross: > On Tue, Apr 02, 2024 at 03:37:06AM +0200, Andreas Rheinhardt wrote: >> ff_dsd2pcm_translate() works internally by converting LSBF input >> to MSBF upon reading; its buffer is therefore always MSBF >> and should therefore be initialized with MSBF silence; >> but this is not true since e3d8963c3cb5b8cd31460dd9b3b9dba2a2343bf5 >> which this patch effectively reverts. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/dsddec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcodec/dsddec.c b/libavcodec/dsddec.c >> index 22009c70ef..2bb2e73b75 100644 >> --- a/libavcodec/dsddec.c >> +++ b/libavcodec/dsddec.c >> @@ -56,7 +56,7 @@ static av_cold int decode_init(AVCodecContext *avctx) >> if (!s) >> return AVERROR(ENOMEM); >> >> - silence = avctx->codec_id == AV_CODEC_ID_DSD_LSBF || avctx->codec_id == AV_CODEC_ID_DSD_LSBF_PLANAR ? DSD_SILENCE_REVERSED : DSD_SILENCE; >> + silence = DSD_SILENCE; >> for (i = 0; i < avctx->ch_layout.nb_channels; i++) { >> s[i].pos = 0; >> memset(s[i].buf, silence, sizeof(s[i].buf)); >> -- > > ok. > > with this patch, DSD_SILENCE, DSD_SILENCE_REVERSED macros and even the silence > var are no longer neccessary. > > i suggest reverting the memset line and attached comment back to way it was in > the initial commit (5f4f9ee99f4e9ab980bb18475009c701ba47a74f). > I see you haven't made it till the next commit yet. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".