From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6FFD64A7F5 for ; Wed, 10 Apr 2024 08:03:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A9F6468D15D; Wed, 10 Apr 2024 11:03:05 +0300 (EEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2108.outbound.protection.outlook.com [40.92.90.108]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 78FDC68CC1F for ; Wed, 10 Apr 2024 11:02:59 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V+vyUqsGfJSjd72SaKsW7hU6I9brR7JvV5aJ7AZMJAfqVD58G8JEkHQZxCumsL58+5Wd8VpCAmXIP2lt0Hrl7KmkIwHXwP/i209NGyQdGcEtXFtAdC9dexqYjfyKJfeScTJr1zY3X3T70hLVkucP/hEEs4dtXqNSaDhQE8Kxl5IBefUEn95gRtVXvhn0ixjBDT6KYwFoVKZC9tFuTNSEpBy0Q6BsmnjkB9W8ifuGRgk6zCW5sFk98CUR+DyGx6TvrB8WakhvzrAAx1HWAkh40h37eTxFOuNB934Jf6YzR+ph9Ivff+7dAGcMqrwBy8U8bzfxt0aRarNvuOvv+oVFmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0oYyIAe58JgrQgeKfKoK9vkGHHl18RoUuSitXfLGEUQ=; b=RY+c9Cdo/IOmuNyyHIsq/T6d7QhG9VDAq64FsirfLgEW3DxpbzKDOCT3X5Od170PChrYsVEy88rT0AibprYYTzQpFY2Cxy0sA8n9M7QPOg4WO9ii4B3iHqxWSy9dJVwmNpKxhkgUGJ+Lu8fXEwX9psXfuKWlk85Z/LthdvQ5nPFgpy3cwwFlpzclq4NtELdTicvLELlEo38aQQGfltpB2dW+vpYmS8Q65A0RBYIRGokXyoGmgFoXb/vGPUgZSj57tMfm6ut2bWCaiJ2ngr9uzWCcFTsI1JeDLgyrWrCLt7FYXXSC8WkjxAdXTa7iOcJQ8dDy+KqNnfQX1k3ih76geA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0oYyIAe58JgrQgeKfKoK9vkGHHl18RoUuSitXfLGEUQ=; b=F059xOBPY/fm5BXwYk0LdeKvIXY5/9s03tK01hF11t0blqDzLby4DzxzPmeKSQhprnkg4TlCTdA8EcrUa3dJFZy5CDmUUKWrkD+vUuLXYtKuVZCZZz7mn2VBdu300eSi6qblq6oxE2XSlDzlnD2jNKm7GiLXGZRRWEE5+5S+RDZX91Gy5u8KD05J93yPEeJbOg/r0A3IkP4qAxGDYAFtM9WvwF/0fSnIGwdgM0rimi4bGHX/zPGJyAyLnUIqEmHSYXuwsVcb2qQl/zS3EkL1+VhTn9nUjEV+mVjttVrqmNTWHSdcZIBz/D9fFUHXbm9KAY42uVU+86fKlKQWx+IjYQ== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PAXP250MB0518.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:28e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Wed, 10 Apr 2024 08:02:57 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.042; Wed, 10 Apr 2024 08:02:57 +0000 Message-ID: Date: Wed, 10 Apr 2024 10:02:55 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <171273246715.22242.7277960037711067953@lain.khirnov.net> <171273594562.22242.12579179149940227185@lain.khirnov.net> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <171273594562.22242.12579179149940227185@lain.khirnov.net> X-TMN: [CwWMPZMdlaMA1TYNh5+dMtqoiwkufcgbOMxUwKbEnoo=] X-ClientProxiedBy: ZR0P278CA0052.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1d::21) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <636a4ced-00d6-42af-9bab-133475bb987b@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PAXP250MB0518:EE_ X-MS-Office365-Filtering-Correlation-Id: 314e6fd8-5704-437d-a5fc-08dc5934a238 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JepM+x7ZBZi/mqcHTFebLR5ubQgTJtypa9h24lRj017h+XqdH/Av4CWxPFyKtFxdzTljcj5x2iX/X8AJmFUE3o7bZBoAp/FBoaKoemkoCRvptgzg8PnaKzsHr1almEuUwBWlahTWftmbkd3SUH3aP6D0UTZUCU792yo3/gzOEcet8FFc7p9d1NbVrVb264LYrngImZB2Z4/9B3NS4yXo9X3W4La5RblZjg5ghwsMRTsKY+xltMejEIv0Ij3kacBSNSL4xupY1LPYnEefCxi89Lu41ERCyo8rRdoO5OzaMgdGFQ984zNefprFdnAF7bvkfXhjtHPfCipYl0xoB8Hfzm35jygU/o4Z3cL+eEm/RLJTXQZEVFtIlRbNhgUSDydRa0BpRyuLocvAGjbU3TLYlYGhMdghUaEEuxDK8V0XgPjiKxru+NOmDXdz2wBXCvC4nu5W0b4lBHK+HMg6Ll27fYjkJj9i3PRs4cGm7084J2ozH7m47JGVIK9/2QOqY3Sz1+v2UUn7GrOM8aJEWjSY/2jqOICSalrKB50hTSKnXSylSABMQVtoS6sIeyXB7kht X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d08xM3Fza0tFWE1hdGRvMmo3eE90eFVQYVVrVjV3QWxta2V4TzI4em85Z0tF?= =?utf-8?B?Y3pnWjZUVTZHajROWVpkampxYnZManZVWGlVQ3RHQjkrN2NEd09UWGIvdERT?= =?utf-8?B?WGY0QkNWOVNYbDJvZVcrQ3BGU2Z2Y0hDZ2M2bGxENXhuL1BYK3EwdHYzZVY4?= =?utf-8?B?a09jZit2L1ZUbGVJSS9NZjFNYW9vWDVPRlhML0Y4U09NWDU1TFBIYS85NEtl?= =?utf-8?B?WjcyaE00V0ZUaUpqTEJkNzU3SHZ0S1hrK3RtZ3gwaDQ4blJJdUh0V3RUUXhM?= =?utf-8?B?NjZlRE1WRWtrNVl4QlBNdWVucDlqY0dPQVhnMU4rYTVSc1Voa2MrejVXOVc0?= =?utf-8?B?QkFQb0NHck1qbStiK3JPeHNQVlRaM2FTYTl0LzhrZTJIYjNZUjNSR1UwcFgv?= =?utf-8?B?UEEyWTdWNGs0OXQvWTliSXBDWERxS01uVmZQRzNYL0RCdW9YUUZPeVJvazhM?= =?utf-8?B?dkpwcmRhTTl0citzNlJjY0IvWktKckJESm5QNEJab1NsSmMzZktJRlVPUG0w?= =?utf-8?B?d1dkVWtnZnpNUUJDN0duRGpVZWNpckJEZ0w1bVVoR2NCTzlzcUtLQ3JqdG8z?= =?utf-8?B?eWJPb3hBdFJwRnVYcXY5TCtqYUszQ3YyZTNDQkVhaWJMd3FWY09Wc2xoQW1I?= =?utf-8?B?YnlNQmpHZkJzYVkxa2ZNNXBqbjRUazhvbTVib3Y0OFo5WnRERXVraHluSjNn?= =?utf-8?B?REZOZXE4blRDNnVING5xTHlheXdydVZSUTJFOWZXUWtjdFN0TG0yKzhhVXJP?= =?utf-8?B?eUdiR0trbjF2aStTUW1rQzhhSEVJd3QrVjAwWWQ3bmp3a2RZRkZPQjI2REI0?= =?utf-8?B?ZWQvWEZHMnh6NER1aVRORzhYZHBtQWFFbTZWbnduQk9LSlNkK2Y0ZXB5SC9t?= =?utf-8?B?UFFCSGFoNWVIV3FTQVhNd0hwOTVVeURIZkhkNmEyaURudzZJOG00V2hCa0hX?= =?utf-8?B?SDFvbldVYldYWm83T3Y0OG9vRXhPdHJNbUd1Ym9sZlZRaHpkdm9EK2M5MnVR?= =?utf-8?B?djFicUlpL0h6K1BERFQ2aWJIVXVodGtaK3JrTms5clNnYnlzVHdaTi9BVjYw?= =?utf-8?B?c2pLVUFPYWdvNjI1cmx2ZlVKb3B0MFdrWklpV0tTQWN5eXpUY2FxMldERHNS?= =?utf-8?B?NVEyVDJNakVHUGhKL0xRb05nNUdPbGluVklJeWxzb0FqeVNDMm1sMmZqNmpW?= =?utf-8?B?TVkrdnE5U2JuSXArL2VwdVVuZFpjRzFMbWdHUHRtUnBRc0ZPQVRaQzZYQjhp?= =?utf-8?B?L0V1SzBiUkRWZVlJd0dha1BPYmlGMFpLSEJTVHgrVUNEaW5CT0xacWR2UUNL?= =?utf-8?B?UEgrWCttY2xrTEt4VkFCUnorVXVJbExiYkFBUWxnQVFDZ29xU05aR1RuTXpS?= =?utf-8?B?Tlp5cyt0ZjNFZTZ0M0J2ZGtmbUdrRWIzR0xNbVAyaTBIckplR0ptWUd2cjNE?= =?utf-8?B?MkVqemlwMmhrUlJQOUZ1M1daUEdFZ0tzeGdVazBwRTFPcXRNTHN5RXJFNk1R?= =?utf-8?B?TGh4UDJQSXRidG5Ga1RlZWRnTzBHM0EwN1BQMkh0bUJWVDNEN0lWRFV5THZV?= =?utf-8?B?cFlXK2N1MkhhSFF4ZVJYSStLRE52cnZSREVkenk4SS9RV1djWTZKOXVidGw2?= =?utf-8?B?SWFoUlg3bDlaMS85bEJMY3BnbXdxUCtGdTY3OWF2TTAwcnlLVzllMk5NUDhq?= =?utf-8?B?N1FXSW1Wa3pqSVBoQXE5ZHkwRDR5SFArKzIrcGdLZVI5enBaR0c1Q0VBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 314e6fd8-5704-437d-a5fc-08dc5934a238 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 08:02:57.6767 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP250MB0518 Subject: Re: [FFmpeg-devel] [PATCH v2 02/27] avcodec/decode: Add new ProgressFrame API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Andreas Rheinhardt (2024-04-10 09:09:00) >> Anton Khirnov: >>> Quoting Andreas Rheinhardt (2024-04-08 22:13:40) >>>> diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c >>>> index fd356bd190..6b2c4312e0 100644 >>>> --- a/libavcodec/pthread_frame.c >>>> +++ b/libavcodec/pthread_frame.c >>>> @@ -779,6 +779,7 @@ static av_cold int init_thread(PerThreadContext *p, int *threads_to_free, >>>> if (!copy->internal) >>>> return AVERROR(ENOMEM); >>>> copy->internal->thread_ctx = p; >>>> + copy->internal->progress_frame_pool = avctx->internal->progress_frame_pool; >>> >>> I'd still prefer every thread to have its own reference. >>> >>> Looks good otherwise. >>> >> >> The opaque of this pool is the main AVCodecContext; if the main >> AVCodecContext is destroyed, the pool is in a state where one can no >> longer get new entries from it. So giving every thread its own reference >> is pretending to make it an equal co-owner of the pool, but it is not as >> the pool must not outlive the main AVCodecContext. > > But the only use of that opaque is checking whether frame threading is > in use, which is a constant during decoder lifetime. Might be cleaner to > avoid using AVCodecContext as opaque. > In any case, this is not important, feel free to leave it as is. > But whether frame threading is in use is only determined after ff_decode_preinit(). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".