Re: [FFmpeg-devel] [PATCH 1/3] api/api-band-test: Remove write-only variable

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

Andreas Rheinhardt:
> Besides being write only it had the wrong type:
> An uint8_t is definitely not enough to store the size
> of these buffers.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  tests/api/api-band-test.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tests/api/api-band-test.c b/tests/api/api-band-test.c
> index bbaa6edb58..d40e31b850 100644
> --- a/tests/api/api-band-test.c
> +++ b/tests/api/api-band-test.c
> @@ -31,7 +31,6 @@
>  #include "libavutil/imgutils.h"
>  
>  uint8_t *slice_byte_buffer;
> -uint8_t slice_byte_buffer_size;
>  int draw_horiz_band_called;
>  
>  static void draw_horiz_band(AVCodecContext *ctx, const AVFrame *fr, int offset[4],
> @@ -158,7 +157,6 @@ static int video_decode(const char *input_filename)
>          return AVERROR(ENOMEM);
>      }
>      memset(slice_byte_buffer, 0, byte_buffer_size);
> -    slice_byte_buffer_size = byte_buffer_size;
>  
>      result = 0;
>      while (result >= 0) {

Will apply this patchset tomorrow unless there are objections.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".