From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E4E654AD78 for ; Tue, 21 May 2024 07:11:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 29DDA68D29E; Tue, 21 May 2024 10:11:51 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04olkn2079.outbound.protection.outlook.com [40.92.73.79]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B7B6D68C73D for ; Tue, 21 May 2024 10:11:44 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=elxWOzMk11IKGi1vFAFHOZ0pFNlFfAx2KRIExsIIXlAWB4b98fOPwUy6Q8GG8FybQ9V9GZER5mAyvACFMu/yrMWp3blwrv5SaKs35/XpIQaBX1v4amplNb6VAiVMCpLvLOsbJzIqwXns3EnoIZEFh5ikOyHyFCZqjlnij1jhk9pNPX5HZQQ9LE1T0xKaWsIeBH+p1j0H2J5/tpgkoFIEo1Nq4EmdAmfZmRE1TUCRZDkwh1bO3BTtGwduZgvJ8rkcmJZdxRRTZUuoWhD0BzZ2U9rV5VZPRvBnTGFHbaIBFz5GMJlOuUqMCfRSu8YEu8Ftaw2I/O9sVb/2g7BRwWAvwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c4gy5g8CBiW3/eKf41uGHbNjQ2ssNPteN55NBr/HIh8=; b=OdbGrMLNAdhh6IyLL+hCxhOpleuxahBeAGkWSkLDujAcM74TdSJ9H/Ub7m1ow6iIUvaT0OQzI3fTADYuAfYDSp6lGHoEt6D6mVL7fuLK4JX9qNaoAGFbwvYm9RLpqG/COuBRNS9+9aLU6yqXzKeGrYXY+2cKcILciQQvfxUiQvtkuCigqLtP9WeAGDyUpG7WCLZI8bGp/3wsiHy1VTwgbbPslXwJGyvwoCkR+EwpRtmg58+39K265cGljJsTgUTVwna1ZGa7GkR2rDi7GTLkFGaDKbZWwuvrG9aTUCXLUUVTR7ELwLBo7snsbZPdC3/Z/dre2X1e6g0fSQEmJBVBaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c4gy5g8CBiW3/eKf41uGHbNjQ2ssNPteN55NBr/HIh8=; b=fhF8PNkKBkFyxUUQIqFyzMs+SwnrrdMLdPFwLEg8o0cVd9fntBj6j5TzEsyS+mIc+nvLn4yEQfyFwTYp1Eey2kqV7zGkNijWKa1MJs1Fs1rK4oL0PvA98MHAgVvR+Ze758wrVo3VTom6K/sx8EfI9/aWRbCh5mDVsZZbjQp79j2CWDAf1jxqIkZtMxXdI3og6g2oyWHttrAsf56lX640x70rgSZ1RcUhQ3eQQ24270MbLwwwAtmF9R1/xAATVBGIpoMKx9eJcjBvsnHpMmxHpK3Ub7vcMRgoRdJepIPiojguQlT1NXngbzJHuJLybzYZSzwOejnMm6I5yoNJjZ9gWQ== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0390.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:329::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.35; Tue, 21 May 2024 07:11:42 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%3]) with mapi id 15.20.7587.030; Tue, 21 May 2024 07:11:42 +0000 Message-ID: Date: Tue, 21 May 2024 09:11:40 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240507160818.71113-1-quinkblack@foxmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [R8P1XwgLZ/SUsE4cuJi+eH1YFGPOAYgoUKoUbJu2RZU=] X-ClientProxiedBy: ZR0P278CA0093.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::8) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <40254de9-1943-4a5a-a31a-57d71c67c4a9@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AM8P250MB0390:EE_ X-MS-Office365-Filtering-Correlation-Id: d225c9c0-373e-4bcc-f1c8-08dc7965442e X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|440099019|3412199016; X-Microsoft-Antispam-Message-Info: w0HR0JRlbpCZcmnEAidb2E2gH1nHAT2+kIirOxiV5EIR14uopKqs+xDgyfFtPdxYt7z6Mx/5l48bwM04FEtvAaMSsKVvegANA7AsilcaeQibGff3zgWQFIR9x3zoZgZEJFIgZwD6kYpF84RG+w9eTgtsuOiFtjkVMuDvycYC+4QQzpz336uukedfnArb/25PyupWE7/pQxSvHlwjQH9gXWMvJjgzrJXtMOcL4fX1au0dKMgNr37IlpTfeZhoxPRMpUJLHA9SOmfP6cco1jEE4aMIhn4J8RVdWFsLIvhlnm7ReX54iX3s3dfdcydKInXcMIK41K0yhGpoTANbemrc50JRo7nyP/nvHQe996O9J8K60R+7zs+mzwC66KFSSQ04bbpG5CxKa4jNSD6lT1dnmUBXnmQq6fyKoR8H/eZclbSzpei5krmy1L1L5vYQ0BSsQCzhe25dJA+SXYNogjMJqVRv9N9VgpPi4fn9yOrKQIkXT+3S9m1YTWY5vPtabiUfir8L0YztA1ggOx+7KkOKnlctwU7XLyHZDl58xNZjVRU5i2VXZy10cu+Bm6BQgDCX X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTZGSis1QmE3dm9LdStsRndxc1pFNEhxTXdTajVUZGVGUlhyWjJ0Mk9tZmJV?= =?utf-8?B?ZzY5Q3FrV25WVFFIKzhIQ0pYQkZ4WGxlR3BzYzRwYmMra3FKaVNnaG0raEZJ?= =?utf-8?B?OFN1YnlOd3dBTWdzaEthalEzQm44Z2ZaRXF0Z1VtRTlPRitkMmRCd054RFNW?= =?utf-8?B?QjMzQ2d0NUJFYldTZ3BVQlV1ZUhjSjBFTXNUaXJ4V2R1anhXaFlya1MzakN5?= =?utf-8?B?Sm5RUUE4UmlBdE1vaGdZMU1UMjkreUdlVkw4WTdHZWluRFVsUzhkTkkwU0Zm?= =?utf-8?B?STFGNGFOZ0tWOC9mZ1RSa1crNG1LUitiTlgxZmUveEVyeUtmSmZkZEdxN25o?= =?utf-8?B?RTg3VXBQL1h6VjhiZk0vUnRZSmRwbzR0T1BodnV6bHo4VXhzaXZPSnVjbENY?= =?utf-8?B?alkrQmlzZUt5dzczblhsdjFvSnNMTVRKTE1mUTNTRThZSlhnTWhrOStWcFlV?= =?utf-8?B?cUdxRlJrR0N1V3hVMktNNEZaYU9QMWhXMXVvckdQN2tabFZkV1FOSjVXRkY3?= =?utf-8?B?TFJTSWl1NVh5eDIyZDRaNVQyL0haR2hpNStxZEpxZmtrVzRkNXViYWdPKzhO?= =?utf-8?B?dFp4TUw1VW90eFNvOGxtSFl4S1QvVlN5MmlCamlidjJKMDllaHlZREhoclBV?= =?utf-8?B?Q2d1K3V1Wk9heU9LaW1pYzlKeTl5U2RKR1VqcmRLenJHZlNQSVgvMnFVK2V4?= =?utf-8?B?L002ZFV3ZGVMT1RTOVhRTU5WVzg2SWRLaGkxUkkxdCtsNUhJWk9EejZ1cWZ4?= =?utf-8?B?ekVzVU1FYmxtUldwYjN3ZFRKb2tJV0tkbkpIc2p6VkNSMVFkU1RLaFlFNWIz?= =?utf-8?B?MTJDOGp0UlFKL2JqVWYvRG5KMFYzQTFzcUMvWW1wNXczemR1VmNWa01PNzRs?= =?utf-8?B?ekRBMzJ4THJGL3FMWDEySmNRNk9Wc2dTc3RtOUtMKzY1aFJrTXd5eDhhVlB0?= =?utf-8?B?ZGxDWHNuRGVBcVdhTlRmeEw5U3lzLzBhOWxhN0JDcDZSVUYwclFUa3UrZEJF?= =?utf-8?B?V1l1alZ0dTRwZHE3Vy8zUStmVTByS3RYNjM2V3Y2dG9rYlFTM3BJdFFOYUhU?= =?utf-8?B?Y0xhaHVHRVlRUnZnN1RTenY3cEJwUTJ1aVNhZE9aK2NwQTJsR2Z5T3lVQk02?= =?utf-8?B?cGZzZ2Q1aGw0bXpBN3FiYnpOdUFTZ0RtejROQjFvZzdKd1dFL3pOR1RUYjFB?= =?utf-8?B?T0RWVlR3UXlXdFBnbmRtUnYvSEFKMnBBRGt6OWQ1VmIwWkdWNjVPZEZncnRZ?= =?utf-8?B?dnA3NGNIQ1J3SWNkY2p0amp5NmRsVWZ2ZnIvTjZtTEM2a0xBaEt5VlluU2h2?= =?utf-8?B?MHFIcnM3TVNuVmQvQW9CMVl4aFg5cnMvNytMbDZGUm9XUzFsT2w4d2FJK1l5?= =?utf-8?B?Qy9MVFNURmZzTnNRa2JsUXBza3RXc1RTcDNCNzFmbmRHQzMzQlBHR0dCQ2tV?= =?utf-8?B?RkZ0TnRNTmJma2hPUUtQeUdPVXFIcndZczRoQVQzM1JoMW1SU3JuK0tVTjZQ?= =?utf-8?B?TDJ0Q2JEdUNIeXpoTGJ5ZDFWTFhWbVJ1VWRZMVUxL0EwUW1sQU1BbmZzUnhi?= =?utf-8?B?R0ZHNmRSK2dKakFhOTVMZjNGMTFHSkh3NEVpdUh2di8yVnVOS2RqNnR1TWc4?= =?utf-8?B?dWZVL3gwaUUwMUNIdkxaWTNVYm9QUzJzd3FMV1ZxTUNyYmZ5MlUzQ3l4a1k1?= =?utf-8?B?YTdxajhZWW9URmNlVjNrWXdWQlhUNUF1NXNDaldlelVGUmpTakNmZ0Z3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d225c9c0-373e-4bcc-f1c8-08dc7965442e X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2024 07:11:42.4659 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0390 Subject: Re: [FFmpeg-devel] [PATCH v4 11/11] avfilter/vf_dnn_detect: Fix null pointer dereference X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Zhao Zhili: > From: Zhao Zhili > > Signed-off-by: Zhao Zhili > --- > libavfilter/vf_dnn_detect.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/libavfilter/vf_dnn_detect.c b/libavfilter/vf_dnn_detect.c > index b4eee06fe7..2a277d4169 100644 > --- a/libavfilter/vf_dnn_detect.c > +++ b/libavfilter/vf_dnn_detect.c > @@ -807,11 +807,13 @@ static av_cold void dnn_detect_uninit(AVFilterContext *context) > DnnDetectContext *ctx = context->priv; > AVDetectionBBox *bbox; > ff_dnn_uninit(&ctx->dnnctx); > - while(av_fifo_can_read(ctx->bboxes_fifo)) { > - av_fifo_read(ctx->bboxes_fifo, &bbox, 1); > - av_freep(&bbox); > + if (ctx->bboxes_fifo) { > + while (av_fifo_can_read(ctx->bboxes_fifo)) { > + av_fifo_read(ctx->bboxes_fifo, &bbox, 1); > + av_freep(&bbox); > + } > + av_fifo_freep2(&ctx->bboxes_fifo); > } > - av_fifo_freep2(&ctx->bboxes_fifo); > av_freep(&ctx->anchors); > free_detect_labels(ctx); > } Please apply this patch soon; there is no need to wait for the other patches. (I independently stumbled upon this and sent a patch of my own.) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".