From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E51B148C9D for ; Sun, 24 Mar 2024 11:10:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0F14868D38C; Sun, 24 Mar 2024 13:10:38 +0200 (EET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04olkn2059.outbound.protection.outlook.com [40.92.73.59]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DEBE668D266 for ; Sun, 24 Mar 2024 13:10:28 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=coIUwp4zqQyug+8YJqkGH1+jf5uqO/U6lQ2sjRCONp+LAT/+kuuDx39wWL8xKFMnDjObWsz/pJrEutA/oSrVCC5IIq1N88jBQFcEw01KpPtmVBQ7cq+wXX2jvDDOWsjBIrwNYayI/rjeSwZ1iQOfdB96D8MpceycycPso8ds/qeSCVnHpSYAEZLT4ofkgj/W8eDZ0qJc93AknCF8LnG1ozZfSxtVAGIWf6tOW1eaWeA+WC7G42ZML6aP28+FOr3T/lnmS/lxPW6UL1oodcnYTUJdATfMuFV/g8nAL2yddHI4rZdJiQBRMRvGDo92WRISdyuwz7i285tXI0h4Jlpuew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SL/jBSspDbz2R+yAvawGRg6E3yYu3DKS2rA77yyknQU=; b=DDvZDcCU9kAzRhlwoam66usvWuSdA+AT0Y/1Ka/8+PEHFOFeMK/l4Fh6M3uewb10p9SHgetUvDkHMj4zE8UDZZnQnzdZ/GPQMONyVoPpTWMQYiHEmX5+m/JIK75/qPvCg6IvBo1UuoWgllkA0nqo1ZqoaeUzeBgzHK505hir6hTQvOveKbqkACCePLiMb1Cn1ngTun3+EH468smSowJdlnIb47IawT2R79IJtMh/T+4kZixZSmWPotWqD90vKA6ilbh+d4nV4EaAo5IYrTH/X8W3Zid+sFsNtYOYurMXMtGY/2Yj0QHesLZgExSNPolrHixC+YdWPSqA2nnJFYzUMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SL/jBSspDbz2R+yAvawGRg6E3yYu3DKS2rA77yyknQU=; b=SenNJ37uUlH0fGew0794EkUaEuIR3KAEHANe7vzjUghCiwEohmX5LU2Zmbq/QPavgyv2KOw+z/NitG7LZl3M0W20UOKZa8WRgIWO8fWff1dP23pfGGG2/yCXi1mtXTomEDHANwsx33IqJrIcm3T5Me944ZbPZBNYlFYXsARewFIRFjHxWfo/OUdFFFRXar6LOsHopoFnk1CiLgaN4m/6/8Y7YSpWeWzfnbo29Cb41qW3KZUg4q40JewZ/x+OUe59P703twpZbe5BmvUNh97MHRiLl1MoNIWRNkO99TfM0GQsYqn9e7yZRXcgueJoZcCmb3IKf7O+tPjkZE2XbzozrQ== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS8P250MB0364.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:37f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.31; Sun, 24 Mar 2024 11:10:26 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.026; Sun, 24 Mar 2024 11:10:26 +0000 Message-ID: Date: Sun, 24 Mar 2024 12:10:24 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240323140054.4222-1-anton@khirnov.net> <171127245802.7287.14513769027741252141@lain.khirnov.net> <171127643259.1646.17791906321816556629@lain.khirnov.net> From: Andreas Rheinhardt In-Reply-To: <171127643259.1646.17791906321816556629@lain.khirnov.net> X-TMN: [oGUZevzQR/nfgtoVckX6PKUi3J39io7E] X-ClientProxiedBy: ZR0P278CA0097.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::12) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS8P250MB0364:EE_ X-MS-Office365-Filtering-Correlation-Id: aa7782ae-8493-414d-a20d-08dc4bf30221 X-MS-Exchange-SLBlob-MailProps: Cq7lScuPrnqkjmXb1vlddM5aSa/Epk3AYJ4FO7R1s/qq7l6hFB1+FMmupP5F3JickwkktN45okNuTY78UQ8PI414/jIXUamuIctdDcs1LTHol1QPOiZEVehoWgSquvgBJDIcn5rkQL0IbzfO7hia6RIzXbbpnvxXd+dfCchSOSR67hyEujT+SIYQZELAxOkqIc7UaeQhcq+smSX8TKQoonpT/bpVU6vcSs2lCYK94mKD0Z5Fmjik1f+xb3RVGi6GjO/j84n7e3eScsRt/LN+GFu5owN4Wf16qMPrLB7WcUOonqWQbbk1zudbSWHKw2LsdHD5DFBqLQNUyFzl3OArox+XaVxEgIKjZaCGJGlrCxuR8xQ51Uekn+vtFNce7fmXzSb08prwgtxS11Uk0NDTTw86yySNpBCwAy9SuM/r6UidSOn2wUJtLzIOKX/rp4GvlDEqa5EJkbtNDMDQz5Fztd4jmL1toUTHiM3d03PR0TH3Qv5DvLyj7nSDQFC7Kh58jw1zEuwp1pjXGlhRQJ/wqH6rvOQaLQohjiV1qYoYomBkkwkr84H0xk+tcTPwNxwdShMw4IhK4cAj+Pqe47PaqoYMhjRFUHA98ez/P190nUOglGlwG4ZebnwV+V8qKLa3ZvPgqs0j6syutViywByOF49fvJah1D1odXgo0ORTU0LZ+30mW8dO6oY9YfxSD2Bl3mu2LXj3W/iYQt7we6bX8PCkpzd+BwOgE1xkiVpsHNfZc/uYU+fI5WXWa97JdVnZPJBxtGQSfcs= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +OkWO0EStc3qKuUymHCm6FRvoZaBCz/ILSNHMxvptSKDO9TFePjb0OxlYTmqqxR32yyzbFDwWzQMsw6fnxFRSal25wnu1+7BcC56wf4zTHHsVeGXlBSbMkKdtQ+slRj7MTeGz1lcZKb7GnqcDJm1IAEM9yqbS5+YukJ1lPyYthesNMlecY7TMBXBG25iPQVobpVg+WWNBxnBQ5qi6muB3/LqoVGu1+M7UIcjd/r6vNke/MHW2/zYoRfDfWrq7+2AtnbBj4cZqthVS88uXOdqd8mVCIe1N3XZEXnhaIGEgoSlNV7KNE7KIKubodz6JtbGfe9l6rrONvSGZnmAlOehTBIOrtbmKwZz9xZp1MdghvLGkTPk7vBVNhylfxTfJ7RdBCmMt3X/s/G4ICyFDk2uCe3bi27riDDfFNM1+D/TKDQeFzXRbYpTzpu+JoE+ghfBoxnizmTUP/kmE9GyVp/0YoFiAmaDqvRaBY47Q7wM0Wq6embIx8orynfmzWlXPWfSatQnddP4z9W2j/MBv0w1oUe/Nzo//RDGzxir2ZPhYptRgKSvq+/A8tiz8UwxhtEf X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXZobkI0UVI4bnJwamRxNWJOR1hPa1RyOFp5emxzZS9ZQTd6dU5sNjdxcnNi?= =?utf-8?B?Mkpjbmd2T3ZMSC8wWEJuN0JpRU1uK0J0RXBuaWdqa2ZpVWhXZXVYN1JyQm9v?= =?utf-8?B?V3dmYWx0SkRoeitCczJuZWV4YzREWVVpSFNVdmpoS28xdFdtVEZnZTloaUdQ?= =?utf-8?B?QWhoS0RBZVkrTTFQYVlMcFNtblRrSjB0S1RMRkpFcFpYVEZ2cGptY3VWbU1t?= =?utf-8?B?KzNycUNuVlJybFp0K2lISVloRElRdmdVNGU4bTFCanZNTk9mVkRNN1haVDky?= =?utf-8?B?M0RxS0RweFdNYkhhS0NqRXJhRUxIVFBqei9Ud1BVaHFzSkpFMi9kWmFnKzhm?= =?utf-8?B?TklLU0hUZ3ZlWTFjcG5Udjdyb3RvUHBONURrRGRMa3Z3UVBaWkl2VHErWVBP?= =?utf-8?B?SThrTHBnUUtMVFplbisybEFoV2kxcjNHazRXVndUbFBhT2RKWU55cmMwTEk0?= =?utf-8?B?WENoT2F4UTRJYmtoeWdoRjFrMEtJT25LZ0lScldZb3FIYXRndnZIbmpoTzZY?= =?utf-8?B?ZFNUYlVkbDc1aUEvcmxKYXFMOU40Yk9FcmRQSXlHZUM0TzhtckszamhFcnlJ?= =?utf-8?B?YVR0djhDUWxDREpoUW9FY1dGOHNMNVpKRWQ1c2tLRkhWN3g0U25Ma3lIOUpz?= =?utf-8?B?a241OElsQWpGaDk1aE5xMkNlT0Q2eWg2UWNOSC9nT3dhWGI3bzBLbEIxSk16?= =?utf-8?B?UE9xWUFoaEJKQkZtVkhFS1ZueW1ENzdHd3hwM1hBWTBtYXh5RkIrQTJGVWJN?= =?utf-8?B?aGlqSUM5V0FVVnpSZXZ2ZlEvTXFmTVdpTjBDdWFlRGJCa0xBaXBvVjBPUUsz?= =?utf-8?B?cGgySlNVSFBtQlNnTlVzOEFrS3prQmZtMGhrTnkwVkhrOUtIZHg5OENvVklY?= =?utf-8?B?L2Vmd2I3eC9wTk9YeFhrdVAyZWFlS1B5YnlrNzBKMDZlU1pVUlBkN1hKRExU?= =?utf-8?B?cWVUVWFIdmhML2dXTHpNOWVPNFNkblEvSlp3WFpXdkdGbk52UHI0Z3dsdCti?= =?utf-8?B?c0c2dFN0UTNtbGpqcFo1U29Pa2hhaHluVHlUZGY0U00yVnJwV0dWdFU2dnV0?= =?utf-8?B?RGRXMDRnN2l1cFdacU5wQkdta2tHYm1pVU85bTEveXZsV0orSGR1Wml2WFhX?= =?utf-8?B?TDJESFp3WWJDbCt4VkZrcFlRZFRDQXUwUUdNSnhmOFhrZGExR3JSdWFxazRt?= =?utf-8?B?SWEvcGozUWhXa1FlN2R1Wm1VbHVVeWtYNjVaMFdtRUl3TTVaWkptaVorSG1n?= =?utf-8?B?SHdXSm9ZOFpjZW5vOFEzVU43eTROMnhIVHFFTXRLQjQ4a0U0MGtZVWUrZk1w?= =?utf-8?B?amJ5VHpyOCtkVTd0azkzY1A5VVNSbmV3amc3UDhYek05UEhMdnRsV3hiZENi?= =?utf-8?B?S3dUb3hmR011Y3Z2RllVSFBnQVdaQVQyaFJwRkF3Wk83ajJmSFROOEtWcUJW?= =?utf-8?B?b01kcWhrYmxCd3NiVWp4RnkrTmVlMW1oeEN4bCtZcmpDNUdhY2xOS3l5UkZi?= =?utf-8?B?dFQ5aUdWaWpwYVhKbVpqZW53cWRsajJWeUo0QVNuaW5QUXh4ZGZDbUlXekdG?= =?utf-8?B?N283ejdBOWorZ1ROa1Z3WlVWeHBVSVRjVm5CNTFFbTY0SkRMa3VCUVFPZHgv?= =?utf-8?B?dVJwVkFnbENnaFI1Qlh4QVJpNkxMc1FaRm85cW1BcUtFckcyK2NqU0pCWkM2?= =?utf-8?B?ZEZPM0JrMjI3b0xTcFg3TWx1QWRWc3V3eXhBell2ellLZUxJSG0rdi93PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa7782ae-8493-414d-a20d-08dc4bf30221 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2024 11:10:26.7469 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0364 Subject: Re: [FFmpeg-devel] [PATCH v2 08/12] lavc/frame_thread_encoder: avoid assigning a whole AVCodecContext X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Andreas Rheinhardt (2024-03-24 11:19:19) >> Anton Khirnov: >>> Quoting Andreas Rheinhardt (2024-03-23 15:11:59) >>>> 1. The earlier code would just work in case the user used a smaller >>>> number of elements for the matrices if these matrices were not used at >>>> all (which happens for the majority of encoders). This is no longer true >>>> with this patch. >>> >>> So? >>> >> >> It means there is a scenario where you break something. > > There is no way for the caller to know whether, and how much, will lavc > read from those tables, so it's invalid API use. > Incorrect: Given that these fields do not a length field, it is legal to put pointers to matrices of arbitrary length in the relevant AVCodecContext field. Just because the current code presumes this to have at least 64 elements for certain mpegvideo encoders and just because there are no other encoders using different values does not make it illegal. The reason we are in this predicament is of course that the API itself is broken. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".