From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id A85104F176 for ; Mon, 16 Jun 2025 07:16:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id E287668B510; Mon, 16 Jun 2025 10:16:22 +0300 (EEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2072.outbound.protection.outlook.com [40.92.90.72]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id DAF4768B510 for ; Mon, 16 Jun 2025 10:16:15 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bxsc982BSnRE67eO+JRi9uBAof6GbBnDhGdD68iMZM4ifqfeYLsQvqWdBxefzb0iOM5Zcy7U3FODCKhTZp7r7eQblmri+CuXi0eM9YAFVPjMOooKHiqz5zbZc2+cclqgz+CivE9/1DWMxqdu5HI8WceNP+9bBM05rVqw57CaxwgYZVuvrcmlkaWSfMHgI7amejya9P0K/Gnr8CGWAwD4PceSGSNAQaU8AcXkRMZdr1g8LRSMKRN5ilG9cJTUhPHIAlfqRuH6Ux2rMwlNCJggQFlMiwRo/deHkO+PA2GxEJ3sRENTIL87pB0mSUgLse/WE4E7xE7mTAn1039lbeY3gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JK2tk3GCXhdBe3eOvI/i31IN9ncpsf07s75q3yLMXAI=; b=C//Dlflcxjvd4q2J6qhIrkkJlHksUsmNbYR8Qj7Qoc3MYjPk42wZUQIUoDFNbzp8ivUvwaJ3OJloe+ouscXnlijHyg7B5xRjPpErmnXEm97ulOTnEYCXUfsE+w+04irWsPNy1HhGkaMxaMtV6MlgYV67i8DvP/EIdXdXWIX5HVRQDLGr9WhF4UagYjugQjhBPz6As9xVA1FN6ua0R2Xe68f+4nLcijA9Dnb8K4dVWPYQDx6vwHa1g1x4+GOM05ywTSIIYbYNRVxVXMZ/mnhh7CI3WWX/8ZyPVEjvH+jNjTAnlOSKE7sm+ruxNgebefsf2JbOQcAFRQbeg+uwPzQ0kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JK2tk3GCXhdBe3eOvI/i31IN9ncpsf07s75q3yLMXAI=; b=CVnComonRLlFPfDbYP2Ot7GcYCrnKlg24zxGAZHpjh6eIxZRh21RusVjKKHYcHnNYp2E00kizrhoVbSp+u5ga0pqDWZRJ3Ts7TvQm0t7CzMzZuPg+ffvQnOfOGBiUnZ4oHZlFn7VlcNE7+uxvxIEcWbZ/ZyuNkbtK1Vfv8aYD21pE7X5OLDt+wbTU9WhnPj3O0FRnWZ56CeqGAsXw7+hv1YZZUWINGgDcUN2YZWQgXIyXGxO8M0vTZtFaF89CpVpy9ESKqlAi7C2bbvfqufWpe+zSvTB6imwMAeqqruH8IqFgRX3n71BfhsvVrBJTUfLcngAmn0MW7HouFfGNnCdvA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by MRVP250MB1378.EURP250.PROD.OUTLOOK.COM (2603:10a6:501:5a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.29; Mon, 16 Jun 2025 07:16:14 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%7]) with mapi id 15.20.8835.027; Mon, 16 Jun 2025 07:16:14 +0000 Message-ID: Date: Mon, 16 Jun 2025 09:16:12 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-ClientProxiedBy: FR2P281CA0125.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::19) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <85ca42e8-1124-4c6e-b51c-5361a8fe0c25@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|MRVP250MB1378:EE_ X-MS-Office365-Filtering-Correlation-Id: b2308b4a-ab7a-4a28-cc8c-08ddaca5adca X-MS-Exchange-SLBlob-MailProps: AZnQBsB9XmpirIBHktUo1qChFBbx+NYsCJP5PUDUpgSCGX7qhTd+PhrVvFv9EjC7f9ETVZtCGpmrwb4rJtiTqWNjX1OFSTG1YCv4oRX86HhXqKQUX9Fuvp+EM36EAurBunSW7mYsFqXbwSVG0LqE5BN7H7gRWuN0dBaYjf8BP5HI74a9+mt7aAvhagg+K3bf51dvPUoHHhjqzyUc/DsQxQ7tTtV3YQcZoSqpCSngl+0W6l5prrzFBTHNUzQJHe4Nh9JmtPbf7/x2HPV8xZCT93/da1Tc7sEbpvzwlulC0zthDlW7d0z85LEOAP3HP1MJQ1MpK7O3qcFCpipTRwOweLBuhyM0Qu91LF7oHr2vJSk/MAdYi2yMvzL1ED6x2F/6l6rQjkn9bci72fmfvvkS6+c/cezz1xIrX4h4xf0Q085wE2rbj22lW9ANPzgoYzHughl6o1TStgUiCxQrUM+bGjLNCotbiIBERgJgf4QdRJ2Q5OobFHgdth5puWmWeb+gypeEzMzzWnENOedr3ipzuneZb/Obo/M233kUsMVoYb7VDYufg7TpRtUptZ51QWGXXkZE+xsITV0vP1bdzUN2b7RZjK2XGyZtG8j2fAVZuuodkaDs29QdSVzkZfmqplyK4Tfq9QVpZKQxWrlDN/pvQCdzLzY3g5WcTvxHuXVnKJ0NnncPx6JWFdWerG7Z9rck9jw31Zy7DHS26oZPXSB2SO/98zceS1n0tvt4mR0S8NhPVKsvW/T3n6snxsAhYIxVxy1eqeO/5Ig= X-Microsoft-Antispam: BCL:0; ARA:14566002|6090799003|461199028|7092599006|8060799009|15080799009|19110799006|5072599009|3412199025|440099028|40105399003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZVlVd0JwTC8xVUp3Nk00cEM0Ky9kYU41TnhaY21TMGNYZTV1dTAxSmtvY00x?= =?utf-8?B?N2xNK1NIQWdkQVRHRk14R2pGcUFBL3NadWtSelJicDlpUVBWZmlZK3o2aGJ3?= =?utf-8?B?ZXZ0RzQwbXhZNzBUSElhTDFjMWV3N3dyZTNmTWRtSndXUzRiUFNzSDVwUFlB?= =?utf-8?B?Qm0yU1ZlOHBIaThVTjFlblNxdE1MaGt6ejJKZ1A5YWEyb3c3a0ZDUWliQ3JN?= =?utf-8?B?eUNjaXYyUTU0RFJ1M1NOSEUxY0JRdFFWbyswU2FxU3lpQ0ROcXZrdzJzTmIx?= =?utf-8?B?ODA3VVh1RUhXZVZUSEVQQVBYeXRYWFRSNUhTalIvMjRZb3UzdExqQWFOR3ZF?= =?utf-8?B?SzRkUmIrSE83MjRTaUphUmozMGFwNDRwUUJ6Q0NFbWM2V0w4YVk5VXpHc0FQ?= =?utf-8?B?MDBMeDh3dWExWEcvTGNsL0J3MW0xTlBWa0R6MXBEZDlZbHdDUEduRjZSQjJU?= =?utf-8?B?ZkNXZ3pYbER0NEw2Qjk2V1haK3RKci92WHdEQS9aeE1ZSUs5amtpSjlrUExZ?= =?utf-8?B?YWFOUEJnbndWdUpnbS9wOGFmdlVXNUNjd3lGSE9VU0IzWFpSMXREMlRNYWhx?= =?utf-8?B?QnNmSytMUFFvcXFwelpObzZGTDVKMG5wKzhhd0JaQzM0Rk5VYjYxdldjdkVB?= =?utf-8?B?ZlVmNE0zYlFJcHhzT0lwQmdSaEFPdXZzTlRNazlZMjlvRjFQSUF2YUtETzJw?= =?utf-8?B?OHFVNDd1c1p4M2ZtaHBPYnlwUnI5R3hNVkZWZ3Z4L1A0a2RVYkIrSXB1a3Rp?= =?utf-8?B?ODhmMk03ZkNtRlZyT0E1TTljZXdDQUM5bWJadExCN3FrblVFUFAvU01qa3ha?= =?utf-8?B?a2d0S1lSNngraXRWYXZFclJhUVlPd1hqWjU1NU5CSUY3WkpBK2xERERMUTl3?= =?utf-8?B?SEZjTDg1ejJaeVhtdSthMUk4TFltV0g4eUJFcXVpOXJRMXdPc0FaTGlicC9U?= =?utf-8?B?dmFsSDR0dHNRckF0ZWhNNzFYWC93K3FsSUczb0RqUk9HTVhVc1ZjQWVsTE1M?= =?utf-8?B?cGlWditocnhZRnhON0VFdnRlT2ZSSzhueFUwUVpYcjRlb3AxdkRaVjJnT1Fx?= =?utf-8?B?M2tRVGNzM1FTUjRISklTRFZsTHNCOHZkcS8vc1R5eGt2OCtHZDhnbnNBcDF4?= =?utf-8?B?eXF1aWNyM2UzRVZ1K1ZMdWVtelU3YVFMS2VhVFhKV1I3MDFsNWx4Nk1ydE5y?= =?utf-8?B?YXlsR0tpVTdQNXdjTk1ESG40QW5zKzZhLy96RnhBZWo0OUd4KzlwTlV4V0t5?= =?utf-8?B?TG81QUU5SlNQQ0htZW40ZUQ3aTdYQlRDZkM2Q2hLMm5DNDlxYmRNa0pjNU52?= =?utf-8?B?bEV5U1BZZElpN1lwTmNKVEg5ZDVya0t0MFRPK3pnRzRVTzdFMWN0WHdkQ0lE?= =?utf-8?B?UHJNRXlMbU9yRENDMlErRFFObi9MdlQyWnRBM250VzlScVM0L3RvaHppeGdz?= =?utf-8?B?SWFmZ1dDVlFGRDY4SUtad3VkTnVkZHZKOWFFZ2M4MGJENXhTeDNEVHBvSTVI?= =?utf-8?B?cGduZitEMCt1YXNlMk93YkZNZk5FZFNFMmM4VndQRDVCUWREbERKTmJjenBj?= =?utf-8?Q?61dfktXlash7BvYucG8RbLxwk=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmFySVdzQUlxQ2hhdWYxYWowSnp2RlUzeUREWVl2eEFrczB4V2NlMXNyQjhY?= =?utf-8?B?M0liWGlKVXZ5MGxrbGFqZTh0QURVdTNUNStQbHZpdnFCY3k2SC8wWTNnNkpN?= =?utf-8?B?SGJ6Y3c4YXl0UG9mUzByMWlqUVMzSTlvSDl3TE52ZUxuSE9xcnZ3ZjJkRmZk?= =?utf-8?B?Rnh3TzdqN3liNUU0RnVwTlBEOGtKWkxnWTlTT0NndXZRSmpYRTExQUwxc09U?= =?utf-8?B?YTM5TGdaNXNiZ0tibEVlN0czQnM2dC9pMzgrR1MzYmdORThZU3FxQkVzYTE3?= =?utf-8?B?RnFERmFzdDh6QnRNTXhOcnE3WWphV29XYzBMYkhiekx2L1VkWTVITHY3NFg4?= =?utf-8?B?NGVrZVB5NE4vdUJCTS9Vdi81aENqR0s0Vmw3ODRrdkJYSXNTcVdISmZjU1JW?= =?utf-8?B?aXlaN1BxcW8vZXZGbEdqd0gxajNQS1ZGbmdnL2I5WnZxNkgvWGtQUC9CQWty?= =?utf-8?B?VDVUcXhIL1BMYjFDa1BIem5BblBweFBTY0tIemljVHpCN050Q2pXN29XRHdZ?= =?utf-8?B?WS9Gb3dhR1NtZXdDeUdsYmwxNGd6VmoyYkZaYUZYZmJFZ2FSWUNsdWhvNDFz?= =?utf-8?B?QWJWK1hkOGRNeHhTc0F2SFFPYTNvM0Q0cXRHckk1d1FkL3BSNndHNG94N0V1?= =?utf-8?B?akJyYzlhNGh2c0QxbnpYeVRmWHhBeHVaa25PS1FJV0thUGRTVmlmNzJKeEhL?= =?utf-8?B?b0FNK2pNRU1Pa1dMQkUxcW8zazBWaDk3TXY2QlIzd3hVZWNHU3R0SmM5TlZI?= =?utf-8?B?eFp4clJyVkJ1M1NxaHorOXRmanY1Rzk0RGo2U3dDaGQrWmpxRjlrazZjVEhs?= =?utf-8?B?ZmZkMWxldzRkeWYzTndsclZKZnVSdWE1VUg0cTVrSFJHZTJybVhYSFVNUUY1?= =?utf-8?B?ejR5MGVrcE4vUnYwNmRyQjNENWhubTJ1YzQyT3NWc2tHUS9kbWR5clliQ2Ro?= =?utf-8?B?L25hMkM0NGZQZmFqL1l4KzNsNlNlZ1o0am0vQmJ3N0diK2EyR2JvRDdKV1JN?= =?utf-8?B?SXc2TUtTb0hWc0FWNlVBanlaYlo2WGV4U3pCdnhOc3h5d0NRQlN4bHVXaGM4?= =?utf-8?B?OFR2TzIzdTZGNXoxaVdQSE5ROXMvNSthd3BTS1N2R016OUxyeFArL3AvcFJt?= =?utf-8?B?V0xGOTZKUXY2VVpPdHJFdXhGcUVsMTB5aTc3VHMvaHJXR3I5SCtkNFZkQ29w?= =?utf-8?B?eThTS0NYMFlra0lEMUZodnZuVE9MdnllcE5DUVMvT2g0V2JCUW1EcHorOE5T?= =?utf-8?B?aHhCY09SM0ZMd1JZNWpUMGhhbDl2R1NPRUpETjNCTER0dUNSSzlKKzc1TmpK?= =?utf-8?B?b0dvL0xnUUszYmF0TE5DSVRnVGg3ek9NUngyWDJiNGtkWEhLUjFJQkEwcTVT?= =?utf-8?B?c3Vxc2ExT3c0ajZPYWVORnNTYTdmMUJnWHJBMURYVU12Q2liaVVhaW1oWEVH?= =?utf-8?B?OFpUanpod0dqc3FPK1liUmFQSWhPa3NzUXVZeDV6TGFramxlS21aMEw1Sml3?= =?utf-8?B?cVFJU04yVmZjY3hObGNxdDV1VEFsdXBBWDVBZVQrZDlxcmhnU1Z2TjNjTlFN?= =?utf-8?B?c2JEam1JaVRBMHJYRW5sYU93WEVKZnFjNldpQVFzcVdmOW9ZQ1cxWkpCWTNy?= =?utf-8?B?eHRPSW84Snp5NDdjejczU2tuTTU2RUJBN3dWMTFyeFBNUnZSdWRlRXVLVW8v?= =?utf-8?B?WEdqOUZWeGVxcjVvM2ZQRTJROUtUYzRsdHI3d2IwZFl1WUh2OEVyeWZLaEk0?= =?utf-8?B?NFowaFJZZEJFc0dsaVNHc01iRkl5SlpJWnBMRzBvdk9rUVlaSXgzVHp1WS9F?= =?utf-8?B?SXNveVc4TFRCWFBSV0dGdz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2308b4a-ab7a-4a28-cc8c-08ddaca5adca X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2025 07:16:14.4508 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MRVP250MB1378 Subject: Re: [FFmpeg-devel] [PATCH] checkasm/h264dsp: Fix stack overflow in check_idct_dequant X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Zhao Zhili: > From: Zhao Zhili > > --- > tests/checkasm/h264dsp.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c > index f5f9650224..006532e08b 100644 > --- a/tests/checkasm/h264dsp.c > +++ b/tests/checkasm/h264dsp.c > @@ -328,7 +328,7 @@ static void check_idct_multiple(void) > static void check_idct_dequant(void) > { > static const int depths[5] = { 8, 9, 10, 12, 14 }; > - LOCAL_ALIGNED_16(int16_t, src, [16]); > + LOCAL_ALIGNED_16(int16_t, src, [16 * 2]); > /* Ensure dst buffers are large enough to hold dctcoefs of all bit-depths. */ > LOCAL_ALIGNED_16(uint8_t, dst0, [16 * 16 * sizeof(int32_t)]); > LOCAL_ALIGNED_16(uint8_t, dst1, [16 * 16 * sizeof(int32_t)]); > @@ -338,15 +338,21 @@ static void check_idct_dequant(void) > int bit_depth, i, qmul; > declare_func_emms(AV_CPU_FLAG_MMX | AV_CPU_FLAG_SSE2, void, int16_t *output, int16_t *input, int qmul); > > - for (int j = 0; j < 16; j++) > - src[j] = (rnd() % 512) - 256; > - > qmul = rnd() % 4096; > > for (i = 0; i < FF_ARRAY_ELEMS(depths); i++) { > bit_depth = depths[i]; > ff_h264dsp_init(&h, bit_depth, 1); > > + if (bit_depth == 8) { > + for (int j = 0; j < 16; j++) > + src[j] = (rnd() % 512) - 256; > + } else { > + int32_t *p = (int32_t *)src; > + for (int j = 0; j < 16; j++) > + p[j] = (rnd() % (1 << (bit_depth + 1))) - (1 << bit_depth); This is an effective type violation and therefore UB. Furthermore, increasing the size of the array has the downside that stack overflows in the 8 bit codepath may go undetected. So better add a LOCAL_ALIGNED_16(int32_t, src32, [16]) and use that for the >8 bit tests. > + } > + > memset(dst0, 0, 16 * 16 * SIZEOF_COEF); > memset(dst1, 0, 16 * 16 * SIZEOF_COEF); > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".