From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 174864B987 for ; Tue, 2 Jul 2024 15:48:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 29D1668D909; Tue, 2 Jul 2024 18:48:51 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2044.outbound.protection.outlook.com [40.92.91.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 17B4468D845 for ; Tue, 2 Jul 2024 18:48:43 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D5iaadeuaivGgwVBW9ej+JBmAJ5HLpA74JPaAAICc3qlMs/ygSGRxyNEeC45Vt27vOUJYu4b2JkHjt1NhrsAwBfbYMW/MFdBqFMWVtnDUyXpZTJ1JynxouzFF5I1l3TmvGQlIGvJUVzbLmQrCKIc7b5jcMCbQUAeynCtS9xDOmf6PBLDZBRvsoEUdCc4LfBUd+UripwYuRLgEn/mTCHf61Oz3gwM6iXOgoQ0bHiXARjW+4MpW0vnJMAND2/eKFu0V3LgsBT50/kg0YsTaLLPCkYSn0KAcU2xB1pD8GTl/PP4obCzghR/A8HQdKqiOG3h5mxHJnyDKUNr6DAYG2JK8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B+oQ1XtM4Iy4EwxoNhOX62+VjR02C3hlCHi+sEJHdLs=; b=nBmjV4Gz+rK7+XXtqKl5pcBezPlbzcHLYlinJoKuWQBi3OHclQTvXk0iibrVhRL+e08XswcaYrng0pQdI+BFQd49Ex8wA7rsZD0X0y0p0lYfScvVY4S0xUcQtdd9qqbZUmvCCkxtUE8RbSqr1beXQuWXDYgrzNKWm9zIrK0+TQdGTPF43nSGQHQHCaxgUsxFG+enhcQMgFIm5IWU19dYr4B0AFXdpDw6xWi85DrRvBy3522BFoTlYPHbaVfnQmYPflUq/bEBtbhRyt0DxT7nclk2N2+zZzgBOkCxyYdphC60OttqEoRLKruMRte6ciDCcR3v6IlA+dU/76krWGDS6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B+oQ1XtM4Iy4EwxoNhOX62+VjR02C3hlCHi+sEJHdLs=; b=KCHxMV3kY1S50z5Wl2hi0WVCAzNRrZc2V/sVIMlsHEywrEm8iNM7QnOSXWySy0B0Ee4S+923YLRZT1JLOkeJpzSA+xl7f3oJUss/hmSbcqvbfip37tQbMIsK1cr4SVfFYmNlA/6M2awUG6r585XP90dXyOrQmgc2oFnoglMnNhckhztkZOAFRhSTQSO1cUuLLOmFdYSNiWhksAcyF00A17dSnbKgkodEQHAdYMdhcd9jxGOCmFNVuPVfrgg5NxcyxbTl8fKtdfj6TUBYOfuGMKTcHl2RrPI+/E9Ufz7rkGGAsQa3kztgdTqT89sYC7zjs/+PmIZiyH4rkOlBUEXUwA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DB9P250MB0452.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:33e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.34; Tue, 2 Jul 2024 15:48:41 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%5]) with mapi id 15.20.7719.029; Tue, 2 Jul 2024 15:48:40 +0000 Message-ID: Date: Tue, 2 Jul 2024 17:48:38 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240702134424.133688-1-leo.izen@gmail.com> <20240702134424.133688-2-leo.izen@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [bVXXc+BRJuh4jqU5En9b81XJsYMlAIDahiIjrs50HHU=] X-ClientProxiedBy: ZR2P278CA0031.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:47::12) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <129803fb-3db7-4cc2-8029-3f509c32cb5c@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DB9P250MB0452:EE_ X-MS-Office365-Filtering-Correlation-Id: 55b2c648-a69b-45fa-8635-08dc9aae71d0 X-Microsoft-Antispam: BCL:0; ARA:14566002|461199028|8060799006|3412199025|440099028|4302099013|56899033|1602099012; X-Microsoft-Antispam-Message-Info: gr8PbiCcYreZb3RHqAn/Dnq82PzO1Ju5FsIv60tU6m8qbYVHQH5IjDa5MRCoTBkY7CSLXMV/6m+sIhfTnepTFk2WqEpotPCo077li7eOItN1d2IFYdKweiyS0ezBtHy+/oA7cr/2lrqKyX1+FmGnzXfJBAJbZsmwAIu6fggBFi3qaDVd01iwGhYVw9LjAe/Nm48CmYk+l627yZ20ZiCCJ1Ybl8wjr2tFvZVGCbXGUaiFGzW08h2AIUdCWraGOXu5NO37MJSMWHZ+9IX3hegD44nT9lVKbvFDpQPMIgLpcLeQfzo8zEtRJnMDgzcSIGIO09m6lU97VFwAU6eTUB7PlPLXKVRwdUOsS72SPzH4yPbPz1bFatD826Y7W5W6HJbe43f8YrKu/cisA4qBxjXY0YnzanVjB3kcCC6jRVZgN0A1Ny1eJOGqTIycWAGWErVxxhWlQiQ7Bn/FdginTFFXulJO4ztndQasS7l/Dr8YbD9D0iVj/lL0a8RYCLNDYdUY6/nQohqDItOTIZqLR92qSyXbvYwOdCBs9FfJ2OdkwdGwpF16fUz3GYex+2Vi9ttjfXvB5i+PCZT3zh2QzFN/xb5ie3QRKEfcD79n0CQJWx8x76aG8bHmUP2feD5D3nqU75aLacES6eB6tiYG/HyxLn/EIUbxr5X7eeCkwUHq0Djdtgn+xJWXjo0jmOIsUc05ap7Jynw/3xfb10ysuU19xeaDXPLqwn14MSBewc2c93k= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXV3MHdiN0d2c0JhRGw1d29FVVJWempjbm53c004SmRlYmpvSmpYM1NXN1lX?= =?utf-8?B?cTgzSy91N1I4a3ZJYmZhZElUUXFNcnMydVI3b1RJYUwrQmtZWEhPSE9VRVZo?= =?utf-8?B?cTk5QUlwZzlUWXZEL2hEck5DTE15L2hiY1FjVFdFSGNFa2Z5Tk5wR2dUYXlh?= =?utf-8?B?R3B2Tm5aSi9zK3Uxc2hWK0hkRHV0Q202TWlBWktRSHRxOWNGUjdWNjRtQzFy?= =?utf-8?B?eHRGNmRKcUFUOWZ3clYzaWdGNW5lUnNFYTdHaUJQOVJtVFNTYlJEdTZ6RVIv?= =?utf-8?B?aTYzakJqcjlTdkdsR3hZZXk3MjBYcjBRQnFoSkc1b1U4RkYwMndlK0FBSVBv?= =?utf-8?B?WTI5WFB0SnpZc3JJZi9Kc1ZadFl1MkZSc3EvZzBVRVZBeDNEWkVjY3V3MGUv?= =?utf-8?B?MDdLcWpTMFIwaHFxVGRXTitOc1ZqazdnZnFDaVR2VjRTaHdLRkpvZWM3cWxX?= =?utf-8?B?NnRieXFuUkRaTWpYd2xLWHFJdVl2R3NhN0hNUEpodG5MLzJRVWhyTXlLVmRS?= =?utf-8?B?V0JlUXJibitVZG50NjlJYlN6czBVT3VISktENExFU2tiUjVncU5Yam9QV0l0?= =?utf-8?B?VWNvcUlJOVBPM005MGxUT0ROb0drT2NjeC8yRWZiMFkvMFdmQmFiM21JK1RM?= =?utf-8?B?Q2MyTHZvYWphOFhEVFp4NjI4bGNGMHcvZFIxTnlsMkFPaTJxT1FtUTlja3Ir?= =?utf-8?B?U2xYS0tEdjB6bkNEcVNRSC9QMmxIZE5aTU9ON2RSTkRRRUpkeXVyczR1aDBF?= =?utf-8?B?RytLMndScSs1MFViTXc1NHdyamhHc2ppN1Z6SjI2UWRaOXZTbjVGVkd2Mkt1?= =?utf-8?B?SzhkVVh0TUxTYldDZDJxVWw0bDZwcFZuSDBrVDhxTXdkaGJCMWhGa0VXalFv?= =?utf-8?B?eFFUQTFOVVRzWHNlS1B3ZnVJR0xhQ2V1QUJuek51TEFZQXJJNE1kS09YeHhB?= =?utf-8?B?enVCL2dTQ0FCeVdPVHdWeE5wdmh4SWlsamo4cWRlNFZMRTNPc0tzMHJ2R1lX?= =?utf-8?B?a0QzVldyMkRDL1dwclFSTCtQRFpNY3B6K1BxYm1uK015UXViTVc2M0QyOUI1?= =?utf-8?B?b0V6d01vdU45NEExUlZETEx3K3czTWNkRFBqK0srdTRjNko1cGViZlhxUktN?= =?utf-8?B?M0w3MEFSZml3eisrZEtNM0tzYXA1V1VFd0Qrb0Fyd3dvd0dhTUVjaVRZS3o2?= =?utf-8?B?MVQ4RmRFb2h6RG8rbmVLL3F0TTlzUzJrbzZhTzBBUDByK2NEaTBpUityS1VW?= =?utf-8?B?Q1BYb3lhRXZreDVZcmtSVTVDNWVlQzZtaUlkQytrNUFqQjNNenFGL2JaYm5M?= =?utf-8?B?aHFJc1h1NmRRTUR5TFBPaFZRWkVpU1ptaWd1T09NOCtFQjRsd2cyNHFsSjZS?= =?utf-8?B?ai9YRlJUaXBITy9RYVRyNWpsK3hkYWpTMlBSUDRkMzBTRzRTQ1IxaGhjVHdi?= =?utf-8?B?enBudkpQdGJ4TFNKNHBvaEhRbklRZVZZK3BBakxRcFYva2hkZzlkeUwyb3hC?= =?utf-8?B?VFhJR2lIc2I2VDZ4SWM3enRMSllJK1Q2REVOTjJyQjR4b0RadXc5V2lVdUM0?= =?utf-8?B?dTlXdFRtZWNNck5iYzRUWXJkRGI2cTZkdzVzdUV5Qm0zYmZOa05oVnY0eU1h?= =?utf-8?B?ejJKYWZrVzNjUUI2dEZERytwOTFNVFlPQXBJaXNEUEZ3VEc3RmpoQXlIcy9G?= =?utf-8?B?QktUQkxFQmltUmdYUWtsVU5TY0JhUWpRUU02KzFtbWdHbWpxUDRCOXp3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55b2c648-a69b-45fa-8635-08dc9aae71d0 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2024 15:48:40.6644 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9P250MB0452 Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pngenc: fix mDCv typo X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Sean McGovern: > Hi Leo, > > > On Tue, Jul 2, 2024, 09:44 Leo Izen wrote: > >> When mDCv support was added, there was a typo in both variable names >> and also the MKTAG itself, incorrectly listing it as mDVc. The tag name >> stands for Mastering Display Color Volume so mDCv is correct. >> >> Typo originally introduced in 78949041417caaef0c82b2b23d7defdd88aa2378. >> >> Signed-off-by: Leo Izen >> Reported-by: Ramiro Polla >> --- >> libavcodec/pngenc.c | 18 +++++++++--------- >> 1 file changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c >> index 89c3d5b83e..7ae16fa2c5 100644 >> --- a/libavcodec/pngenc.c >> +++ b/libavcodec/pngenc.c >> @@ -450,17 +450,17 @@ static int encode_headers(AVCodecContext *avctx, >> const AVFrame *pict) >> >> side_data = av_frame_get_side_data(pict, >> AV_FRAME_DATA_MASTERING_DISPLAY_METADATA); >> if (side_data) { >> - AVMasteringDisplayMetadata *mdvc = (AVMasteringDisplayMetadata *) >> side_data->data; >> - if (mdvc->has_luminance && mdvc->has_primaries) { >> + AVMasteringDisplayMetadata *mdcv = (AVMasteringDisplayMetadata *) >> side_data->data; >> + if (mdcv->has_luminance && mdcv->has_primaries) { >> for (int i = 0; i < 3; i++) { >> - AV_WB16(s->buf + 2*i, >> PNG_Q2D(mdvc->display_primaries[i][0], 50000)); >> - AV_WB16(s->buf + 2*i + 2, >> PNG_Q2D(mdvc->display_primaries[i][1], 50000)); >> + AV_WB16(s->buf + 2*i, >> PNG_Q2D(mdcv->display_primaries[i][0], 50000)); >> + AV_WB16(s->buf + 2*i + 2, >> PNG_Q2D(mdcv->display_primaries[i][1], 50000)); >> } >> - AV_WB16(s->buf + 12, PNG_Q2D(mdvc->white_point[0], 50000)); >> - AV_WB16(s->buf + 14, PNG_Q2D(mdvc->white_point[1], 50000)); >> - AV_WB32(s->buf + 16, PNG_Q2D(mdvc->max_luminance, 10000)); >> - AV_WB32(s->buf + 20, PNG_Q2D(mdvc->min_luminance, 10000)); >> - png_write_chunk(&s->bytestream, MKTAG('m', 'D', 'V', 'c'), >> s->buf, 24); >> + AV_WB16(s->buf + 12, PNG_Q2D(mdcv->white_point[0], 50000)); >> + AV_WB16(s->buf + 14, PNG_Q2D(mdcv->white_point[1], 50000)); >> + AV_WB32(s->buf + 16, PNG_Q2D(mdcv->max_luminance, 10000)); >> + AV_WB32(s->buf + 20, PNG_Q2D(mdcv->min_luminance, 10000)); >> + png_write_chunk(&s->bytestream, MKTAG('m', 'D', 'C', 'v'), >> s->buf, 24); >> } >> } >> >> -- >> 2.45.2 >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> > > This did also land on the 7.0 branch so I assume it will get a backport if > approved? > Why should it be backported? This patch has no user-facing consequences. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".