Re: [FFmpeg-devel] [PATCH 1/2] avformat/file: Constify android content protocol

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

Andreas Rheinhardt:
> (The discrepancy between the definition and the declaration
> in protocols.c is actually UB.)
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> This and the next patch have not been tested (apart from "it compiles
> when the android content protocol is disabled").
> 
>  libavformat/file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/file.c b/libavformat/file.c
> index dd5819c06f..8f3b35c795 100644
> --- a/libavformat/file.c
> +++ b/libavformat/file.c
> @@ -670,7 +670,7 @@ done:
>      return ret;
>  }
>  
> -URLProtocol ff_android_content_protocol = {
> +const URLProtocol ff_android_content_protocol = {
>      .name                = "content",
>      .url_open            = android_content_open,
>      .url_read            = file_read,

Will apply this patchset tomorrow unless there are objections.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".