From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5575B47AEE for ; Sun, 31 Mar 2024 01:36:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7BDDF68C900; Sun, 31 Mar 2024 04:36:47 +0300 (EEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2077.outbound.protection.outlook.com [40.92.90.77]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7F51D68C496 for ; Sun, 31 Mar 2024 04:36:41 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H1TOfVitKAsDlrqRKASrEm3+kEWKdN6iEekAjl+94bDeE+v1cdzqiJjADi3hs2o3vv6Mp018Ffe8aatKbW8JDNUP9H9lIUa0Vz8a8Y7PcAmybsoQ+r7RKW6htkB5mmbGNIRHnjKrUvpmLB170Lkq8Psde9kgX8qESd5GWZMJVU6D7Suao04QwDaAdcVXdBNG1ePy3stHdKNZUyqAsh/8lfjjJftI2FQXOqPaYizfLslj16Qam2pD5A10Y4n5QNkUsnSgtkBj4maH3u3sLB5KqI5T51TyAyXA4ruynzDO+yOG6MmxoYHxf5CgB2etJW9HhlAMJOOuDbhRdhlhtMGG7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wiy9ZJjmb+aH7VnzvAm4JcjHmlkSJ26z1g9603/Ef40=; b=WSjatpEzbtFhErUpWG/LfW5KemQe/3x3MHpv1DZs4m1Q/Cy8msabRxj8hHVYn+qH2xZxoHtzjb3jTsaY1fg1YCRtfO24eWe2HYFEB/G6TvOp+NgMH2MX7g/TtxK5ASHNQoe5mS7eW+fqVMdaMsEoQNOHC3suXPsOB5gw9aFhFk07M+rULvELyenajrwt4T5pzmsADgg2H/hC7KL0PjPMRl0Gm7NqhTsjd1opFAXD62E+1maW+QrAoSpcMjibXY47JU3BFVbatiGTrq40v4PrsVhHv0ynRv264Q0Kh4bGyM8vqjvHfo/EbHn+oR3Svo0s9LjXpQcL3qNF2xTeT1Ocpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wiy9ZJjmb+aH7VnzvAm4JcjHmlkSJ26z1g9603/Ef40=; b=UnWqBlOexsHvyqNCd2jmGpKqpD0Kt1PJEk6eZ/at9y4EFFNZTkkDCCYTUnzdC1FbCxulVySFBd9m/TjPEAAHG5+cxwUSxttTNPlzCQTNzuGFs0QGu/NVzdyKFHF2n5h66H/3S7Hh4Vbk9bRvwSVjmQLVc535V+moRxqsxAaB/IREc1lLMSo7VZ5M6/EIDwu8RyFKf5pFwQgOY2L7tzMX2IZ3fDww7VLfCD/A+b53vVgsW6jvmbqaLS58Lj6S9p9+3e+sQKhBiNFPWeBD3oX0CbhEXy4+rFzlUt77eHDP/VNRM7nerLaLcgAzzxgK4giQbR/SMec++5HzRhxzM54Dhg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0139.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:322::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.45; Sun, 31 Mar 2024 01:36:39 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.042; Sun, 31 Mar 2024 01:36:39 +0000 Message-ID: Date: Sun, 31 Mar 2024 03:36:37 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [VP9HQmAJEOkY/0XbaBtUr9ON6rUzfFab] X-ClientProxiedBy: FR0P281CA0222.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ac::18) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <32b5d5d4-137b-40dd-a4cf-73b83d46420b@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AM8P250MB0139:EE_ X-MS-Office365-Filtering-Correlation-Id: 0de9a50d-76cf-43d9-6b36-08dc512302b7 X-MS-Exchange-SLBlob-MailProps: Cq7lScuPrnoJcUdKf/x7lPgcBdzEH/VZJFTzBBKQJpcNnzMfF0bykveXJwiM9SsK36GMchs8a1GcQwvH41DyEoY8WU0zfJbZCLTwoOdOge+bXZndMBO/kf2WsxaNb3jf5GRr9dd6qfyxPl7yACvO91szXdfprW6HWnaS6tkURCDHZHhs4qUj0vFGynq8ae0cJlGrW9oc1fxFgxpnYNvxYFkAI4x0p2ucvvTSLl2sM2tAMK3PsGAIv8SbM8qBUk4+pFG5ROwhIVST6nZjt85bIrSCjI51lVFRLMgtxQV3Ux0QnbiXvemppqCo4wxSQpvjWw6RNCbskR51C3r23nMn1ampxDPH6vjJPFXRdi+ikuHS6A/oaYY8I77Mi/EfC1p3ftZpzEN2ppFwod/H9n6JjcQfDVWHdwnv0uITapRKKQUIPXtmbJmrorZOGhsnr3HkuAE0lSr48Sc6VoQWXgqTGB2vHCmuW8rdrRlkcS0BbfYDctoE0UpeWViNtYU5ClqVEhsc3hmHQPYouBsSHdOd5dyEZZzCwwbFWpFD/HhNIj3jsGBr5OThgtimXoZJRMFnd+eQvjTeJyCxlfh+X/M07rdg/WnmedLWegBm80W0Qpgs0Jsb31g0hmednZFKfTt5C+i6oMyGKMpYoiQYvgKADgeneq2024//vyB1aCtlRLDwBWN2+rU4mb4DEitLC92+5SCkPH1YEFz2AwVQOqrwpG4GdsDjVtHETadMWO7BDq73s3Arf1cgLercGeUudzM1L63DnjFK1iY= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kU7ONhaOQ5YZ1rZ2H0Pbp3OVqWha31hJtbHU96atnc6RYRzIV94X6IDTKTWzUNLLe4rknFTL9596YDWGle0hGGVKUIWIfdA7kB/4TAGgkt+wzJBwoe6A68hK4svVsEFzSoieJmFAJLQAxhAha6AyBpXbKuIZC6FWsOGhiQ+Hhx8Ye2SP33xJMh2hrYOawKpfVaiNVJotvhFuRKM9UXNnRw4LRtyqnETPnVy45c1fe+wN7tfIvLoX7PUKcBFhRXZl/EbTLsLVS2djgk95mjR8QXFWO+pP08GPnlU+BeugVgNlCmAerOUucNGVdAjdMRL039YvM3ykye7KPmKT3Wga2lQsXN6U07d0doJN8UWamOMa7/1mqlO833IC/haCUIf8wt+5rGuLaF+A09+8/fXVV/L3IaHhAyIL6IRh5OxeOLj30NfMbwlkoeV3aLVQpsFrv0aBYxpBTGlIg3Nd19AyFLEO4Miv0O0DWcp6LpCEDKiXAEMEGS+MT/Beg2sMw1Njk/hSdCBj7PUExbBoUL/8mqUHgbh7S1Qfqp26VG3U5dHz8fNFK/DlLSjmCGrT3yEc X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2VmWndSc1h6SERPZjNLTXFVd3c5K3BES252VFRxemFpaEQ3aUFEVlpFK3Ji?= =?utf-8?B?Nnl5OFlSSU93dHFleVlZVjFhbXd4Lzd2cDJsaENPRCtjbEFLdUxzNGRKTVVV?= =?utf-8?B?cnJvdFJBNzJSMHBFTUwyRnhQS015YTlDTXJhbDV3d2hmTE1VWS85R2R3OTBM?= =?utf-8?B?MVFGcG5JSmZ5QlZYR1YycjJMVndFdDF3em1ZRWM3Z1dZRFg4ZDhUbW5Fa29C?= =?utf-8?B?aTkvbGcrU0FnQTJjSGpEUW1HZTJ2NU9CNEV6bmpUbDVIckRaa0pGZ1NuNG9G?= =?utf-8?B?N25UYVBzeHpXVjhqNnZxbktER05UeDg3aEIrczNhVER1UDcyVDFMRmhuYnVH?= =?utf-8?B?a0RVSkM4NlF1WW1DWVgxdVl4Y3YxMnFhWmUwMGVJd2IwOGNoTUFVcXNHYXdn?= =?utf-8?B?SWRWb2hITHlsS2dSYldsMGcvUmUwTTBIZUJNanRBK0NkYkI1WXZvQjVyTG91?= =?utf-8?B?VnZDY3lCWXh0blF0RTJJV1hXT2dOU1FoQWRvSndYUU9Ick1WbGN0QkJBQ2F5?= =?utf-8?B?UDE1RnhhMTljb3ZGWDFJVmp5M3Q2SzBCNUVISUxDNlhGbWdJd1ZISVROOXRF?= =?utf-8?B?bGQ1L1ByT1BDcU5KQ09GUlpWVXBZNU1NZ0paWkV1eFdveVJYQm5aRTRaWXR1?= =?utf-8?B?Ylg0YXlCVGpRVFZWeXJoclRJK0I1aytPVGhvcTZjNFBWU2owenl6cjR5YTJS?= =?utf-8?B?NE4xMU4wRnpzNjIycWFvcFlQZUlsVW93UW5LSzZMcnliL2lxYnEwaFNWYXlR?= =?utf-8?B?N20wQ2dHdlFVQmh4elB3UTdRdDhUOFdYL0lBQ0dvR3p6RURCWlFTWEpvUVFj?= =?utf-8?B?OE1CTC9paVQyUlF2bHVYekZ3S3hzVFhCbC9aS29JVG9vdGxjL2RKbnNPWnRq?= =?utf-8?B?dWtpajdOMm01ckJJNWJsYnI3Y3JpbTFDRTVmWCtDbWpRQkxtUEZCTzVUeWwr?= =?utf-8?B?Z1pBRUJ5SEVCR0YrR2d2YzFWYmsrUERnc0JodG4yWG5TOVRqNzVwMHFyaHIr?= =?utf-8?B?VENWY0NPS3RCNmp5bTZIdCtUbTUrRGp5OVd5a0lBN1FrblErMnRoNlh3c256?= =?utf-8?B?LzVlOHVZVjNPZXhsTmdLZ3Eya3lHR1Vadld0WTF4eGlGYThONVIzU1Jsd1dC?= =?utf-8?B?Y2lvT2hMc3NXd1psUTgrTllNZFMvNUhGdjlGelNVL05PbkN3SCtLVThzRmhY?= =?utf-8?B?dXlQU0lzRVVTWU1GNVdac2wyM1J2aWc2VGMvbm5QWDVtaHNpL0ROSkVzUTht?= =?utf-8?B?d2J5TlpFdVN4QldvSEFzbWFtQnFGS2hxeHROUW9PMzAwREVjOVR0K251TVRl?= =?utf-8?B?Rm9BR0s1T29ZekpjNjFJK1FPOEtlMTgzemphTDg2L1J4SUFGb1ptck03ZUNS?= =?utf-8?B?dlBOYTV3WFNESU1NeDZRV3UrY3pHcG1UTkJldTdmWnRWVzdBTkFsSHIzdGFU?= =?utf-8?B?L0lGK0RTTTF6N092WHIxcUZjeFJndXVJSHk2RWxtUk9IdlF5RTdON0trMUI2?= =?utf-8?B?OXQvQ0NjR0dURGlsOFcxb2pLbndGdjF6VjI0TWVFYytCTkZRYVpsUGw3TkQ5?= =?utf-8?B?VHM0UWZ6SURXbmNBcy9ZMWh1T3cxNm5kT05vWnRON3k4NXRrNFI0VWxnSFA3?= =?utf-8?B?K3laR2tPckNtMURyVkhkSDFmMVJiaEtLT0J4MG5OUmZPcjIxdThIYU1BQXR1?= =?utf-8?B?T00yb21RbHFPN1pJZ2xpNmZHUEN1d2RPSWJvRlc5MitYUTdhUWFqTkJ3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0de9a50d-76cf-43d9-6b36-08dc512302b7 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2024 01:36:39.3753 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0139 Subject: Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: Don't free AVOpt-strings manually, fix crash X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Steven Liu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Andreas Rheinhardt: >> Besides being redundant, freeing manually is actually harmful here, >> as rtmp_close() may call gen_fcunpublish_stream() which dereferences >> rt->playpath. >> >> Reported-by: Armin Hasitzka >> Signed-off-by: Andreas Rheinhardt >> --- >> libavformat/rtmpproto.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c >> index 4b01b67d28..b1d73b3d75 100644 >> --- a/libavformat/rtmpproto.c >> +++ b/libavformat/rtmpproto.c >> @@ -2917,9 +2917,6 @@ reconnect: >> return 0; >> >> fail: >> - av_freep(&rt->playpath); >> - av_freep(&rt->tcurl); >> - av_freep(&rt->flashver); >> av_dict_free(opts); >> rtmp_close(s); >> return ret; > > I am pinging this and explicitly cc'ing Steven Liu, whose commit > 991cf95fdeebc3af added the av_freeps to be removed above. Steven, did > you just feel that there was missing freeing code for the buffers above > or was there an actually confirmed memleak (there shouldn't be)? > > - Andreas > Another ping explicitly cc'ing Steven Liu, this time with a more recent email. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".