From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5565544F95 for ; Tue, 13 Dec 2022 15:02:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A7D2068BC7B; Tue, 13 Dec 2022 17:02:03 +0200 (EET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04olkn2055.outbound.protection.outlook.com [40.92.73.55]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 51DB668BC5D for ; Tue, 13 Dec 2022 17:01:56 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CWpTVRUJmO+x9VrpArKMEvjbi3Zx3fBMr7UQw4ziyTEJgFIxQE5ZczS7W90DowNpGg8UOWLB3KRqvsC2K9S5QbbS8mL9ZOwzjXa4vWB5lHIUpG1a5KDB9K9V8FGMzc9JWAK3cA5JWbgBGCMMllILcXu2ut/+O371ba8hS6pRg8+E4D2CQRhZ0jdOB7l1bh2qTWu7rBVFQ7u6/wuY81srF0hdgP5pMlDwOoMLYkgq3oW4N3tZiwP2nsrtsdLGr2ZDvl4vAdDGExz+OtJ8lqLf6grMoXx4XA60B8qeMGkLslZEEMbBq5rRDuKDafq6pR9SiNm/4rrc/E/6yw6/bO6YvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HvSvMSnG/aWuim/arPxbcI+MYkR1ifJhW06vTiYBvpU=; b=V2qYKqRtwURSTqrWlEm1SRQJKWjBArXPqR3ctUEyFCC/+IAvbvmPzy99EWp4ej46RQxH62lwKwcHAxEf3Rpd81ccS7Kt7ixMvYmV172iQIvpkeCfSngcHul+a9guXte8rF5gwOLu0s3XT29X9Pv/MiKI798WWcHxy3pXUVo2JsFPjL0lbtjdBp/kHZzUeKUuAkuqhIAbkaJZI7BojEA+Le+MNaWC13EcJuFrOXRDHNOk2555ykD0Q4o267sd22Tv7sNJh9b6Ojr0jxiRiXwhR1wATXDKKqeck37g6oU6YPzMWlv1KLyJ/3tbYnxcg9hIo53n9BJf+tlYo9JrWCdMUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HvSvMSnG/aWuim/arPxbcI+MYkR1ifJhW06vTiYBvpU=; b=i7/u55sS8xbwHMFSLRWKs4SjuD9BOxye4UauXQrp+Z3Kb4GGJZ/A1SxC2SN4E6wjm9R3ojEYBo4O0z1Eeqxb6HoJUrl3j9/Vse5Aoodm6zl8L0Xz2IoDQy9xVKeW9HbkK/DRRyHfz0c1fTD9plX7FbIwyQqgLVrSqBJIs4i45NYQ/GPkY88eyuROReeV/XsgfbjkW0bSDFyaN+kqPEcnKj7L6tpkTMuyZkOBXl1fE0E6nhbxgdoCndmajWP1opjqcbmlgt2n1334ecZC3M3UImY1STZ7NBfDItKMwGotBtz3Fy2FQazVpmp/BEcZ6ME+APm0ggiiURwtHAcV7B0G+w== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PR3P250MB0023.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:14e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.11; Tue, 13 Dec 2022 15:01:53 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::da14:61e3:630a:70b5]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::da14:61e3:630a:70b5%7]) with mapi id 15.20.5880.019; Tue, 13 Dec 2022 15:01:53 +0000 Message-ID: Date: Tue, 13 Dec 2022 16:02:14 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [5y7XKqRzwKcwk9YkM7Yh4/Cml/HtJT/R] X-ClientProxiedBy: ZR0P278CA0043.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1d::12) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <70d39a8d-69ca-bbb1-f5ef-0029444086af@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PR3P250MB0023:EE_ X-MS-Office365-Filtering-Correlation-Id: 1d70b386-3b0b-4e31-4103-08dadd1af82e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d4fBjRVFEuBD6e1WfRCt1NmoNUj7C4/9aHzZ2qieDI4Tl/2CmeZhEU0LmN/itMR60b/UCuI6sUTnrThrGqxZ55T7PrDcNuIof/lWxUJmhha0IspUtTaVrtcal0NM5+TBQZygpVDuwCNPbq0rAIArG3H6cFCj2IZLcKNLpwk9JwEJa3aO3n+z2pFb9exAc52jzRgBhNQWcWBtNGbw+AtzvRUEDIrTwx0vghvIEbIUpa1cNg3+ymZht591OCTQtB7RVbLW+jKaDTDpofLcoxG/j1q7cmstKbvGEEDyhc7buZaRjbFqBK3NKaNewMds7rrxL+SkV4Pcf8bPUP2cRRsGdmeW4uKQwz5mstxUyrBn1I5KUiimSPO4+yZqYeS96IxPhLvuKLkheeW//dgbZt8nZeGAnHisFG0avidgXoKb1fLY8WKwhWBMy1lk8kjOwMhDhVrhBx6zsQM3/KJdF5jE7XnRTlMUTs1uXZzVTtHPadEPqYWZkoNtXjhuJt8wrtoPMI2Xdz91F389U6FME8e1JR7dwa5lR2yaA4Bq3hU7GHVaV0OjMn5LyksqIwmPWlskUofYj8aO5u1Sm/+jBHv2CJs6TuU6MHjS18OLjntZ+doZ/6BSOY+CwaLAhqCLSp54x6NPQz7G2y9aaHPirCXnq6jTaqzwW+aYxNAq1aGg9PA= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VjFFS3RGc3pkVUgxQlpKQXRQNkxhSEd2Y1hIT1J6WUx1MGp3ZllWUUwwMWZP?= =?utf-8?B?aDlrTXdvaUFGTk55RzlCUG43L0UwdjdTUGVwQlFrYnRORmpDeWdpZDlKWXdh?= =?utf-8?B?Q2xjRkFKUE4zMHdCRTFHTWdGTzgxc3MxMVA1ZjNjcFhlTzBmc2RrZTdiSXhO?= =?utf-8?B?RXJ1LzhlL2xIaEUrcmZwUXhFWVUyWS9qQjV1ekE2VDhPR0Nsbi9kM01oZW1E?= =?utf-8?B?OXNMZ0JLTmhzOFlzSjRFMTNESWl3MEh6KzBaWG1GNUNFWU9yaHBPVkx0cXVZ?= =?utf-8?B?OXNoNytaT1RwelFhQ29Pc0RnQmxHUGs4VHpPUWxGeFdoYlBsYnJPTmN0N2xa?= =?utf-8?B?cFJlRnBmd2NiTnRmYzRvVmp4NWxIakd3Q0V6K2d3VkRmc3k5MFFDTlRWUkdl?= =?utf-8?B?OGpvNEJYM1N6V2VaMlAwclJMdHdaT2xDS096STRxWm1Lb2JJanNJUUkrZHZj?= =?utf-8?B?OWZTNmdHTFhsczhGVkpUVGNGWDdoamp1a2tDc3dXWGlFNlJJOHFNcEZaQ3Av?= =?utf-8?B?cEJkaEJxNUV6MzhmRm1Cajk2dGY5RmRRVFduZ0RQaHNVWWhReDE3Rm9OR1Yy?= =?utf-8?B?RnUxRUpzc2ViNFpOc05mOW9pbXpSNkJQRXI2SkxJNG1PK2Y3dis1L0V4NHUx?= =?utf-8?B?RWZrdm4vK3R2SDNlVm9MT1BrN2h4enRNSTlFRDdVOHhZYUYvY3F6aTdkYU0z?= =?utf-8?B?R2NiMmxWd1NlNHFldW1semQ4eUVFTXN2eGttVmFSZThXSmdaWVlDWnNWaUwy?= =?utf-8?B?WjJzVGxPblI5c3ozZ20wdWFkbDZHRnFCSGoyRU5JSDYwWUhXYnFWc3FWUWNN?= =?utf-8?B?bVhDcVo3d3VSTnpVVWxQU0kzR2ZtNFBpTHM0Mm9hcE9keVI4SHhEZ3FhdTJn?= =?utf-8?B?UnRUMXp6elVlVHI4Tk1sOWRPVVhzODFHSVdJa0l3dU5hb2pVVFhwOVQ0Y21R?= =?utf-8?B?UzlRYTdhb0g2ZnNKU3Arc25mRXRRY21nQ0VjYUt2MXNMVGRWVnhhT3ZDM255?= =?utf-8?B?cHh6M3N4MURYUUdra2RDWFJ4SEkrMk9IWDFYMktTTjMvLytzM2FHUUxQeHdx?= =?utf-8?B?eTVTdXVjODduWlo5dDNRYnM0QVY0UTAzS3MwL1JveUk4MkNVdU9HdHZ2dUhq?= =?utf-8?B?R3VGTE1YNzFJT0RtbnU4dGxmT1JSaTlVTTA4TlprY0E5ck1JMUNhbDhZWmVz?= =?utf-8?B?b3ZMVWQ1dGMzSzIxNXlHT2g4UjRYT0pOSlFKMHFQZWI3S2V6aUthcXZxQ3pU?= =?utf-8?B?cERiazJxR293RjdZRDN0ZFFYZTdweExjZjhKYmVpTFhvZ0NtRHFSd1M4VWh0?= =?utf-8?B?cFgwa1pOS2UxbmFYN05WTDB3ZXgyNEFTd24yMnJrSVJyUCtpS0x1UEVSRXdk?= =?utf-8?B?VlpWYW0ramdXdXNXMnRXbGpEYmJ3eWVIaCttL0x1ZGNuaXVjWi81UW5tQjNZ?= =?utf-8?B?eTVFSHpkOCtTNTNqa29BYjNJVDJNSldxNmtLZ1FtVDRkc0dPclpiZVk2aE5y?= =?utf-8?B?OGlsc2tFSVZ2eFBNVnFhcnhIa3NvczlFb2xrNmRKaUZ4eUNtdkcvUTlWNXlR?= =?utf-8?B?bkpnUTRQMElWQWIvdTlPTVoyYmxRQTZmdUpJOGNkbzZ5MVVGR2lScGV5eWx3?= =?utf-8?B?QTlTUCtNbk9rVVNYVzMwN2pJWXlSUTNOMlVXUzF3S0tKVkEwajNGazFIbzEr?= =?utf-8?B?Tk9rTytsVzNlUW5rcG1UTjA2VCttUXFIeWduZjZJTWQ5MlpOSEVGMDB4WVo2?= =?utf-8?Q?zZm5JySlcH6h0HD5tg=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d70b386-3b0b-4e31-4103-08dadd1af82e X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2022 15:01:53.2764 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0023 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/x86/Makefile: Don't build empty files X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Should fix ticket #9909, fixing a regression since > bfb28b5ce89f3e950214b67ea95b45e3355c2caf. > > Thanks to Carl Eugen Hoyos for analyzing the issue. > > Signed-off-by: Andreas Rheinhardt > --- > This would be my solution. What do you think of it? > > libavcodec/x86/Makefile | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/x86/Makefile b/libavcodec/x86/Makefile > index 4e448623af..41ca864849 100644 > --- a/libavcodec/x86/Makefile > +++ b/libavcodec/x86/Makefile > @@ -140,8 +140,11 @@ X86ASM-OBJS-$(CONFIG_QPELDSP) += x86/qpeldsp.o \ > X86ASM-OBJS-$(CONFIG_RV34DSP) += x86/rv34dsp.o > X86ASM-OBJS-$(CONFIG_VC1DSP) += x86/vc1dsp_loopfilter.o \ > x86/vc1dsp_mc.o > -X86ASM-OBJS-$(CONFIG_IDCTDSP) += x86/simple_idct10.o \ > - x86/simple_idct.o > +ifdef ARCH_X86_64 > +X86ASM-OBJS-$(CONFIG_IDCTDSP) += x86/simple_idct10.o > +else > +X86ASM-OBJS-$(CONFIG_IDCTDSP) += x86/simple_idct.o > +endif > X86ASM-OBJS-$(CONFIG_VIDEODSP) += x86/videodsp.o > X86ASM-OBJS-$(CONFIG_VP3DSP) += x86/vp3dsp.o > X86ASM-OBJS-$(CONFIG_VP8DSP) += x86/vp8dsp.o \ It seems like that there are linkers out there that complain about empty object files like x86/simple_idct.o ("ranlib: file: libavcodec/libavcodec.a(simple_idct.o) has no symbols" as reported by BBB); the above patch is still needed to fix this. I will therefore apply it tonight (with an updated commit message) unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".