From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1AE9346FA9 for ; Mon, 24 Jul 2023 08:34:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2329668C615; Mon, 24 Jul 2023 11:34:33 +0300 (EEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01olkn2080.outbound.protection.outlook.com [40.92.65.80]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B3D6168C196 for ; Mon, 24 Jul 2023 11:34:25 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ljjAGp7asuhibhVHXYhgj7wqxT96uh1g51uuesK9Zu+CzhzjsphfXXaUCmz3ZRkr9eU5qxZm95jmUKSFt8OUMM94ItYqPL8od2PeVzdjnmFYdWplorWsg58DhtW+KnJ6LZo/2PHvseCTdi10rmaiwNQ4dp05nKA2e/wx3uzOlFS8xztVzVXagjAY8A5A92INZXdTQ+TMDCXKsgIanhVGPYW2kueYGrNFgWQw9saCRmVCKPEM2FrGULhF21DuPVbZv/x8EM59FDiW9h6e9KAC3m6qP0toM53UAvtpn3vsAeJrG9p5vi2dsraAWOCLUQME6TM832DynA82RWD8wXPoeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lNgFheYggfxc0Hbz6/yDY+zKC1ArDdfLp+WHsU/rpZY=; b=FcU4RPXOdlewa6+Ilq0ILUCgk+3N5++XSN4319EfUcT41yHwpmu9d/VOZdLP8fJlO9KS66QePNVa5Njg0PcfI6s4Cnj5COshSWJqoBbiy27kHzAd7DYxsMk51755psI2HmJ02DYn7cRkeKTJubJIMhJgEvSpPUnQBL/fQo1zjAt83TMM11NuY67IdVeRLPjq1jQt2jyhZ2izhb/us/J+8hhuB//9I8nsTmYnrOlXWW1e4MhCVd2iWBV4BdQaWWY6t83vQN8jDroA5w2FeSqwRInXlHbVc4Kz/+iLe5TsFY7UwFjvZYiDuZ9f3g8WCXTVVv0ufCzKU+vsXni06popCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lNgFheYggfxc0Hbz6/yDY+zKC1ArDdfLp+WHsU/rpZY=; b=lQSeNpIbScucNVNUD09AHu7hO4uOTcluylQ1g65eAD4HnxJuNjLNh/G69M0Fgijw3szw5ZsEK42FrlSU2wo0X6ZfYCuqTfU1ABAKP2ZXZiWRtJ7bqpLV5K9FnP6hrceuMr+pNgGqGuA7oKKkrVLUEuBwYIC2WLydsnaBj00JkLuNAHb5K6AL9dpmVXK43mBO9mAMERCdqeOJDcKjPQLzBcM+iKkhOfUbhpiq+VU3dM9kXRZpzZrOfxDJ6iTKpcL8VX0/+Vvwg2IDhsy2NDWR+mS4MaQigIusGzaqi/NG+Bdz2HYjlvnyv35QB3QwCwc5TkiYGa8qDUgE2Y3ebGc6Ag== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PR3P250MB0226.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:179::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.31; Mon, 24 Jul 2023 08:34:24 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::9bda:3062:4e88:521]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::9bda:3062:4e88:521%3]) with mapi id 15.20.6609.031; Mon, 24 Jul 2023 08:34:23 +0000 Message-ID: Date: Mon, 24 Jul 2023 10:35:34 +0200 To: ffmpeg-devel@ffmpeg.org References: <20230616222048.6562-1-michael@niedermayer.cc> <20230616222048.6562-2-michael@niedermayer.cc> <20230722154044.GH7802@pb2> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20230722154044.GH7802@pb2> X-TMN: [Vr06E7q3yk5qxCsRzn6SYp0R9ALdb6Lq] X-ClientProxiedBy: FR0P281CA0049.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::15) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PR3P250MB0226:EE_ X-MS-Office365-Filtering-Correlation-Id: b8a6f769-55d2-4a04-7ba2-08db8c20c8b3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: akkgzn7HkM6S8hPDlHVmVmM3fNkL9guKB2ACnyyO0sDqCXzwlQEoJEVD7rT0rXtWQTXQLrdqGJV0vICbAymA4sOoh2WVrIetWPd5kiuti4XC7k4eHY12a0k7ceXJNJp7IhZSG5kAxTich+MsuzxGix19Kc5GLhQq6PZ1lS8RgMFQ6XzWL28ucsP0Mw3NZWQLkPzO72vmcZSNU4JEqNzROCBYdp/X+Rli0HOeyS6yJkp3uVOOqoqIUJ4fT0+o/GLboboJyFMFaO8HFWP6vXYKns+MM8LgcBBBI7bU5nuvKQnA+p6Dukl/D3Rm6z5Zix4pqRRF+fhERPKJJwD7lTSqIf4UxSMMER0Eckl6QgkIGDSuQ1/RoVM/gvqEtnsYEpPPYVvpQNezsZcmRvviz7yOBydwp54uFqoquGt0Iys5okS/DitcoqgpbFybg/EtLJtOZvJBVjSekNNbMcugPb7hb+SYFihD3qFM1MsrN4Q0oZtbt46+ZSmm4W1GsG2SnTs6Fbf67Q0er2E9QnOmgUurm2y257NiNo2dbkj7Vt/qZ31RdZ7P2xNiBhwVYBNlana5 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N01QdnhsWlRmYnFNQ2RqUUhjVFVBb2ZGczJCbkZmempiQjVMdDExRWxVck5D?= =?utf-8?B?ZHE2YVBwaExjZVBTOXRTWnJzUVBBRks5dzVrdDhoUldKYVJaM3ZnbDFrT2M3?= =?utf-8?B?TEo2d2ZtMzVMUDZEcG1hRWxmLzhHN2xGTXFvRjNMM3FBYXVzVU9XMGE3V1V6?= =?utf-8?B?dUJkUmFOZDhJeHZiUTVlNmpLczhvNjlIT1JJTDhPZ3FqYVZ3bGFDcjFXc3lH?= =?utf-8?B?UVhxd0U3TUxkdnRjQUZlaXFuemhrczNqS2FycE9xV2lEc25uMWdrN25NQ3dl?= =?utf-8?B?SHVDakZ6aHdZNFJkbUp4TU5Xa05QRmdxaHBjSEpvb2wxNHVvcDE4QzNwa28z?= =?utf-8?B?cTZSbjlIalZDRGlDUlcvaUdpb29jMm1DNDBsa0E2MnQvYUEzYWhKQkUzcFhB?= =?utf-8?B?YitPRWovQzNpNWRRZVhTUGRWSEJyQ2s1NE9sSTBTbEZ6QUtwRldoSmkrNVhy?= =?utf-8?B?M05FSk1ETUp2U1I4WUpNQmkrRnhBOTVqYVNVU2ZEcks0VklyZm5Gb2pmbmVG?= =?utf-8?B?NHd1WTVrd1Q5WXdZZGhaUUlwU0Y3WTZ0Z1ZIeG5Cd25nVXZJVmRDdE9BV1dm?= =?utf-8?B?bmEwME10SklML0c0TC81NEQ0VUFzbFdPYmhkVi9qc1QzcTlQd1dNUmRtdkcy?= =?utf-8?B?Q1ZPM3BoZGdvMFhGTklJTHRaSTFVMzNTWVBWekYrVEp5cm45amNaU0lOWmZ1?= =?utf-8?B?eTJEWlJSeXdZbXBFdWlLOG9mUEFrLzdHWFo3WDRtRVdQVXNjL2hhZ0tFN3Zl?= =?utf-8?B?VjlyL2ZVVTdidUZ4cnh1WFFLVUUxVmZYdjV2Tk9PSWM1dW51YjdOcWtialR4?= =?utf-8?B?cjkwcmZCYldKai9wcVdUazE0cUgwaUpPSFJQcmpGakQrUnIwLzN4TUNaTFZW?= =?utf-8?B?cXNMSGJ5Y0Jnb2xMSHRNNGkzMVJtSExxR0M2a0s3bmNkaElGOGJEVFliWE9z?= =?utf-8?B?Q0FpZXhDbWw2a1NLV2V5dTlvcFlIQ25wU2hTdnh3TEJPS2g4dEErdk82eWhF?= =?utf-8?B?S0tnNG13eXFOSWZiTlVXekUrVDh6ekZEUTZuVTNSOW94REpaSG9jcjkzUzhI?= =?utf-8?B?Zi9QQU1KU1BQODQ1WjN4T0dRR1Z5eDFpOENXdmFnOEo3d0tkSVJSZTN0aU5r?= =?utf-8?B?NWpzRHIzN1J1bmtQL2dZMGN5KzFiVThycEtHeXZpRGhxemNDRWcrYTZ0ejhx?= =?utf-8?B?aTl5cjJjdUt3NGlFOE5ZMjlFOWpRdDBscTNsK01SNGp1VmtaY1d3aTZ2UHhD?= =?utf-8?B?WGd0VUhkWHBHMXczRDlUYzZmTk5IU0l3RjVCcVQ0Ui84RXU1OXJrWG9TMytQ?= =?utf-8?B?MGlmVmFUbG8yMm9iNHpmbng3RWdVZzNyWjZnVmNqaGs1Z05zMWxySG9MMmVX?= =?utf-8?B?SlRZUDBDakdmMVBYa1RVbGdMR0c1WEVISU0yaThQeitRV2MrK0pJMnFkVGFU?= =?utf-8?B?WDU1c0NxUkI0VGtDTDBFeXhMc3pJd3dtSC9kSlFOb1VFeWtaM2VlNHlNOXo5?= =?utf-8?B?Mlp2Tk5TNkVOYXVYTXo5UTZSckRxMXgvUGpjZUZ6RmVjcXlBNlQ2RitLU082?= =?utf-8?B?YWErMlVrVWl4Vk9KaHprQTFhbFNWRmx6L1BuRXEzcWVsSTdVWFVWS1pjR2Mz?= =?utf-8?B?TGdtc3dvdmxybGU4NFZwWWU2MlZnNzFKb1JNZm5wNFBjdXhYNnBYWTBGYXZT?= =?utf-8?Q?qThwMVp++vnZxZlm1YLV?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8a6f769-55d2-4a04-7ba2-08db8c20c8b3 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2023 08:34:23.9589 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0226 Subject: Re: [FFmpeg-devel] [PATCH 1/5] avutil/tx_template: extend to 2M X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Sat, Jun 17, 2023 at 12:20:44AM +0200, Michael Niedermayer wrote: >> Signed-off-by: Michael Niedermayer >> --- >> libavutil/tx_template.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) > > will apply patches 1-4 > (this should reduce the differences in the avradio repository in libavcodec/libavutil) > I actually wanted to complain about this; but then I saw that it had already been applied. Before that, I believed that this patchset was meant to be applied to the fork only and therefore didn't give it any scrutiny. These patches should have only been applied after the decision to merge the fork. I am against applying patches to simplify maintaining a fork. E.g. I am against further avpriv functions (but not absolutely) like you added in 4/5. Your patches are even very suboptimal in this regard: You added two avpriv functions, yet only one of them (the non-fixed-point) is used by your fork. Furthermore, you only need these 2MB windows for floats, not for int or doubles. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".