From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6EC074AEE1 for ; Thu, 23 May 2024 08:43:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 288EA68D3CA; Thu, 23 May 2024 11:43:41 +0300 (EEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04olkn2098.outbound.protection.outlook.com [40.92.75.98]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4376368D22E for ; Thu, 23 May 2024 11:43:35 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dy5clPOzq1SdkSvsr/OaFRa674bd6i0+58JgXglGXIOFbxMEkMk2XPHJDrMthmcGcnNLINY4DwR4r3X9/InnpuLrNW+xaPcRblgTmux5lGPjFeb2y6wMvVZY5nH5oEQ3lDPsNdYMnXZUoj2e8ZN4VuVKULl0vFarFLd/QCq9Ku51k3fx5nBgxmCFKQ4gna2rjqBkKOMRsc0rKlDYFKi0CUbyPd4SH0u0sGgabyujSoR1dHgPL6/UQiIpbeptIeDel8T9DN66KLWS6TqRm6q4FsiUHXoZ0BCd4NkLeREYliwIohwF0QI162Lo5U5PWsc2yKdAITzSvmO5b/0M5TrVBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K9s06gI7UGe5GLWAoe0z4ERTbdGG8j8/reuAMVSKPhw=; b=cIEysz+3tiTluAQWzlKRzugTepxFC+vI2Rn0Cc487ADwS+bOfMqrTk2tzYXrG9Iv/554NFavO+Fy/vwjl/AowPBzRrLAEkvlrX471M89Kqt5inHRPqvyipuLFh+B+9BtNtBxYKyoscBczxl1fUzFAp/0gyy/fhZ1jxFUOUIZxqcMGa5eqUjY/GkbVEepzWbibBYJcoSUKYeLHj9PFt4oKPnzOJ+cgHrawSNMgTEwg9mR8AIicFv7SYBWqsGBiO3YtOFHzRihVqWDEVY5UXzT9EpLTmie7RlfsId/hK3mNlnIFyvZUoTIs+JwXXNXo735vWsG7iMQST7O5px2zAVG/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K9s06gI7UGe5GLWAoe0z4ERTbdGG8j8/reuAMVSKPhw=; b=DqCF6mBFeFilv+Dh8lh+AW9CJapLc+N0IHzuDZTUYcIgECj1zSjh3F6gEoRcngW0s4xsX/fCUKe/Kkk29e/TsqLM8OHUdskhqL2RiW2afLeZqR42G4rddbW6SP8pVu6KMKzkXjpBaG3jYTTeKSYYCAeUKpPh3mc/VL7/J23lREEIRKRDgK7nVChqQGKAFf9gOrVSbL7tkoy2Ux6adBLw8enb1BZ7jSCdIbteRN048Qr/7L//SvUQuTGy4v6YRtuIWaEeTtfOf+w5Jcy/97HvnZhuOS/ducoDMVpUq0DO1V6SsdsYUMAcC7zVjBIeeMzAdWptXzso5UTUrkgyl3uKrQ== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DU2P250MB0014.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:2b7::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.36; Thu, 23 May 2024 08:43:33 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%3]) with mapi id 15.20.7587.030; Thu, 23 May 2024 08:43:31 +0000 Message-ID: Date: Thu, 23 May 2024 10:43:28 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240523083750.1332-2-llyyr.public@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240523083750.1332-2-llyyr.public@gmail.com> X-TMN: [P2xnxR2Z4FjAhMkj8LHa1LB2/9d1XSdhiJllTQYaTjg=] X-ClientProxiedBy: ZR0P278CA0092.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::7) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <65b84e35-0ef5-46f1-96e3-e09e804f4906@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DU2P250MB0014:EE_ X-MS-Office365-Filtering-Correlation-Id: b5d44cae-008a-4318-f5cc-08dc7b046cd0 X-Microsoft-Antispam: BCL:0; ARA:14566002|461199019|440099019|3412199016|1602099003; X-Microsoft-Antispam-Message-Info: lbtW3p8Hj0dPOlm2D2ZDhUb0Y+HcnaGrKUep1S4HwTDqB9ekRGp9b8p26+6jpp4RdwGC2NiX7vatOELKksPpTOPy57rvvp4+kfdbLXtPx7HbMJ5KzWrdaHLgTa9B1mlLBalcIo2PGtdtji2uEfR1RS8g9eoHD9ekgsH7LQ5yGXvzwgrujjqMJetj+lpkZsjdmXDpG8aPKOS2w4lL2IJPzL7phEtchT+7oU9Wbo/FIruU/v1VqcaUSkDOIOqEJuZGAmzMjdLSvDooo6jqvhRYHXz89MePoR2ECp7vHsJOu4W5IBiWTU40oUjnYDnkB1AVNTNEO2fgSO6I8+BWK1ObLxEi3zgDyaeIQ8EBv73nY/UFTZng00dvRIi/BgaBGB/KXQE+vcLI/NaVUrjipM4WW6s2+HLpFSJhSSY/GmQK0tf+z5REMCExfKPjltD621FInjoAK2YC4BkctgYPde82dsN6rIStIKWhRI3z0ZaYd/MUCTtjQPMqc2kC78+UpnW6nrCsYS/5BUA2KFPVeSdDg5aq85j7jcMA41YFzc/fPQArbP2B9oFwORXajgRWp0CANwGo3es/Q0vc807qASwtMaZ/ku3O/3/41+E852+4ah7CB6EUGMV4u8iA9o1HODILnAmtmJ9wNjAAnPE7AVOjVxDy2rx7aEW0f5l3GRTriS4= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGlwYnVGWFBzL2p0bkpxbU1RNm9jWUx5L0tSVzJhQ29xbW9KOW5aOWVZNm9O?= =?utf-8?B?U2JSL1ZiVVhqNFNwaGMwY3l6SEE3NS9sQWhvempxMnNiV2oza1R4SkFiTWl2?= =?utf-8?B?U3lxdDc1WFhrdXVHY05LMHNNWTVRcFNsVVFnQS9kWGZpNkE4QVZLWGg1QUtY?= =?utf-8?B?VWF0TkgxUDdTRGJPTVV3TDMyRUd6aS9GQ3JiYTlxOG5VeThHUVRrYjVZdXlZ?= =?utf-8?B?SnYxWHZ2Q0ZGZDV0S1kzQ3FRRFdSaWVnajh5SStPNzB6TmZUZEx5bmRYcUo0?= =?utf-8?B?UWdhcGtZN2J5L0dreFQxOHRmV3g4LzVIa1dNNWtYbVhKOFNydjlQbjl5eitM?= =?utf-8?B?MmlaMG1RT0dITHZXZTlMR3VFMUZZSlhqa1A1TldyclNmdlZReVdtZkpMMGFz?= =?utf-8?B?ay9LT2xLcHJTeVVhNFlrSytrdCt6dXYrdDQ5cFVFZDMzTlRmUG9jc2JVYklI?= =?utf-8?B?d1B5MGtuNThoWmp4Y0RNL05tU0ZjaUdpUkRNTnY3M3Mrc2N2K3dSQnMxbnJF?= =?utf-8?B?WmxMZUpwc1JGV3czSml2RjVjRjNUNWNGR0ZkOWQwV0R6M2k3TW5zdmhGMVJm?= =?utf-8?B?K3Z4UWgrQm1wUWdmMkdQZk55ckk4NEpDTW9DRnQ3NHViQWlra0xFTXZYR012?= =?utf-8?B?dEFidzl6TUZWanc1TlhqWCtMdVF4R3NpeDVpZkNWQlh2Y08zOXJkVXFlY2lV?= =?utf-8?B?Y1F5ZDB5S1NnV3h3bHBiQVN3UHBSUUM3M3UvdWlxTzFRYUs5TjM3Q0NKQXIv?= =?utf-8?B?WVdBaWFNOEI4VlRaampHUkRXZmVDQ1dESUtBbWxkNXVudDBOeHZpWHJ3QWpy?= =?utf-8?B?L1B3cmF4V1pKSmVObUNmNzVwUlBsbytNVDZDMEptVy9SaVhwWUFDa1Ird0Nl?= =?utf-8?B?UUZsbldrZXAxNk5OQmgrQzNrejU3Zi90b2luZXpmQkRTMHhuRjQvQ2lOYmtS?= =?utf-8?B?WmwwbHlCU1FnWmNHWUdLaEQ1MkliWDQwVlQzQ2VienRPNU5uN1Z5WkUwemVP?= =?utf-8?B?QlBQT29rMHpjTXd0K215STRENTNLWGM3U1hyMWxiUlh3ZUJsRHB2RTdGRUsw?= =?utf-8?B?ODNhUzZtNURjSGtXWmxBeTZXMm5qUktrczl1dUYxamNHUHJEY2ZTQlZrVDdC?= =?utf-8?B?dkI1eGRQZG5sYlZPUlpXSHVBaEJyUlZwcE5Cdk1zL2ZDMXBRVW5BQlNKWU5R?= =?utf-8?B?akhsRDdTZDQrMEtlNHRyR0tBamdYbktVMldZMEpNZmYzaXF6NloyVnh0YndH?= =?utf-8?B?N21ibjZDa0xOd1ZsQnQrWVQ2c0E0R2hwYit5aDhOdzNaQjUyWjZNdzJDWkhT?= =?utf-8?B?M0M3VXZWOTVSSGJRekM5TElYTjZHWlZJMDhGaEV2RWgwbFV0OEJCM09ldkVy?= =?utf-8?B?dlBKUDhROXR4NFZKQ3FFTDAvVWF6a04yV1lGczI1QjBuMnNhQUQycTliUFJq?= =?utf-8?B?TUdpWTIzK3FSRnNRNHBtV2tVb0R3a0FBdTJMQUJ4KzRFUVR1REhQVDdTSGFa?= =?utf-8?B?WlE2a0NyZFJ6Q09XRGo3OGVxMXRxdUowb21IQSt5cTN5Z0xFeEFSU2xDcDEw?= =?utf-8?B?YWxpanVGNEVHMlhyL1gxeW5IMzdoSkFDNk91TUZLK2FDbkhuY0ZuV3pKdUJV?= =?utf-8?B?UG5Ic055NUdJY1IyM2VCMEhTSDhZYWt6Mnd5UXgvRnROeExYUmJoU3RsTGx6?= =?utf-8?B?Y0FXN1crNEFDK2IzclZqMTlFUEYwRXpneSs0QWVIRmxVMlJ4VlE5UDNnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5d44cae-008a-4318-f5cc-08dc7b046cd0 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2024 08:43:31.7891 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0014 Subject: Re: [FFmpeg-devel] [PATCH v2] lavc/vp9: reset segmentation fields when segmentation isn't enabled X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: llyyr.public@gmail.com: > From: llyyr > > Fields under the segmentation switch are never reset on a new frame, and > retain the value from the previous frame. This bugs out a bunch of > hwaccel drivers when segmentation is disabled but update_map isn't > reset because they don't ignore values behind switches. This commit also > resets the temporal field, though it may not be required. > > We also do this for vp8 [1] so this commit is just mirroring the vp8 > logic. > > This fixes an issue with certain samples [2] that causes blocky > artifacts with vaapi, d3d11va and cuda (and possibly others). > Mesa worked around [3] this by ignoring these fields if > segmentation.enabled is 0, but d3d11va still displays blocky artifacts. > > [1] https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/HEAD:/libavcodec/vp8.c#l811 You should probably not link to HEAD here, because the line number will be wrong in the future. > [2] https://github.com/mpv-player/mpv/issues/13533 > [3] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27816 > > Signed-off-by: llyyr > --- > libavcodec/vp9.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c > index 6e2d18bf9595..8ede2e2eb358 100644 > --- a/libavcodec/vp9.c > +++ b/libavcodec/vp9.c > @@ -709,6 +709,12 @@ static int decode_frame_header(AVCodecContext *avctx, > s->s.h.segmentation.feat[i].skip_enabled = get_bits1(&s->gb); > } > } > + } else { > + // Reset fields under segmentation switch if segmentation is disabled. > + // This is necessary because some hwaccels don't ignore these fields > + // if segmentation is disabled. > + s->s.h.segmentation.temporal = 0; > + s->s.h.segmentation.update_map = 0; > } > > // set qmul[] based on Y/UV, AC/DC and segmentation Q idx deltas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".