From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 7/7] avcodec/tests/bitstream_template: Make it clear that the return is intentionally not checked
Date: Thu, 23 May 2024 10:22:56 +0200
Message-ID: <GV1P250MB07372FD9BEF45A570E8F3C8F8FF42@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20240523011758.2434580-7-michael@niedermayer.cc>
Michael Niedermayer:
> Helps: CID1518967 Unchecked return value
> Helps: CID1518968 Unchecked return value
>
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavcodec/tests/bitstream_template.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/tests/bitstream_template.c b/libavcodec/tests/bitstream_template.c
> index ef59845154d..d8cf980bee1 100644
> --- a/libavcodec/tests/bitstream_template.c
> +++ b/libavcodec/tests/bitstream_template.c
> @@ -74,7 +74,7 @@ int main(int argc, char **argv)
> for (unsigned i = 0; i < SIZE; i++)
> buf[i] = av_lfg_get(&lfg);
>
> - bits_init8 (&bc, buf, SIZE);
> + (void)bits_init8 (&bc, buf, SIZE);
> init_put_bits(&pb, dst, SIZE);
>
> /* use a random sequence of bitreading operations to transfer data
Test tools should actually test.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-05-23 8:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 1:17 [FFmpeg-devel] [PATCH 1/7] avdevice/pulse_audio_enc: Use av_rescale() to avoid integer overflow Michael Niedermayer
2024-05-23 1:17 ` [FFmpeg-devel] [PATCH 2/7] avformat/ac4dec: Check remaining space in ac4_probe() Michael Niedermayer
2024-05-23 1:17 ` [FFmpeg-devel] [PATCH 3/7] avformat/ape: Use 64bit for final frame size Michael Niedermayer
2024-05-23 1:17 ` [FFmpeg-devel] [PATCH 4/7] avformat/argo_asf: Use 64bit in offset intermediate Michael Niedermayer
2024-05-23 1:17 ` [FFmpeg-devel] [PATCH 5/7] avformat/asfdec_f: Use 64bit for preroll computation Michael Niedermayer
2024-05-23 1:17 ` [FFmpeg-devel] [PATCH 6/7] avcodec/sga: Make it clear that the return is intentionally not checked Michael Niedermayer
2024-05-23 1:17 ` [FFmpeg-devel] [PATCH 7/7] avcodec/tests/bitstream_template: " Michael Niedermayer
2024-05-23 8:22 ` Andreas Rheinhardt [this message]
2024-05-24 1:11 ` Michael Niedermayer
2024-06-01 0:21 ` [FFmpeg-devel] [PATCH 1/7] avdevice/pulse_audio_enc: Use av_rescale() to avoid integer overflow Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GV1P250MB07372FD9BEF45A570E8F3C8F8FF42@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git