From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4B59C4A73D for ; Thu, 4 Apr 2024 19:53:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CE47068D0F4; Thu, 4 Apr 2024 22:53:51 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04olkn2049.outbound.protection.outlook.com [40.92.73.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A992D68CDE3 for ; Thu, 4 Apr 2024 22:53:45 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cI9CGCaeCugFkPMYkcsI3z5O4hG8A8w1e+W+0EHO/GIHbRWs/pkw3Ktv18fxLdJfQmBnjpFmSbBD/ZjP3XayJtJgDHidkNwGCWz0z19ISS7XlrXOjE74Iibyjzyg/ZNeibx8Mkypayxd7qJ3p642sEdJhdLxrPah/ppBs5zztNffGV0TD0WWXGukVasmkot1Clle47sD7PwFKJBc4NquL+Mmj1Cf0Jdm3mFnwqe3ZbvDVEtQIwap8uQH5VnFzDFOwaw+tSzosD9lZcE/C8snGKXoXL5bXKcaY//wWE/IfXdBRGjZ3oGwTtOoFM1TBqKRRTC2nRQwLRvW7Klw+3YTRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+j/d8m/7/ZhgVsyuP8VE25lkcF4Q4gBA+9ulZ3ZwglE=; b=PA4bkOdpRxJcFbFfDgzmtuZ1rWW3xa93+luyF+UWAnv/CfmtFVkIsFgjddDJMV7q0ncQoSaeOOzqs67xrXn5FUi06LvpgRHLoyGIs/j7KwY05Ny7Bph+UqcpYU0NjdEWB6W3ELQVqndsTFWllGOG2TJFm1oWi5thNEmYKwl9/qG2oCGzbrBs2FTizj+hGFvuhKdN3Kjr+YHlqtNVqyCdH/oLobGtchK4CDUB+o/QDDaW5sTCCBgWlfmHhgskB0v9Lbp6PzWwqQzDP+IMJC8drwisLuW+gK3A2qwhAlTpGWVZLqxf03MklOZDqJcpPwNmaGy7nTOvzJlZ0Mmj2ArTfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+j/d8m/7/ZhgVsyuP8VE25lkcF4Q4gBA+9ulZ3ZwglE=; b=k6iB8LUK23RQazSMWQPDRQM5Z3yVi/9ZFeatOuq3ye5P/U1OziygMjuVHlLEuycVnyoDMqfrakxEE6uUEVnn8vrCF6dxWWxVPfd2DOW1zV185z6IS4/A1/r+0Ws9kjpdMq18vjXeiT+H+SEJHiSTKIEHWYLZlZYwf0ZppfB5V2XWkcMSO/VqmNAgfI+iSnJ6d+uyHevx+tA70P8F4lNJ+yNfcyd+P1HIpY+MMdYWxIFBvBpYdudy4v50suvppyRzQjbUCr+I6TFol2VkYSThKMhoy3exMjx7PnBeNNjp7Hl4+gLrciG9TM7HCvIxU0yM7jCNUQwFKWjyQnH2R86eyg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PA1P250MB1066.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:459::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Thu, 4 Apr 2024 19:53:43 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.042; Thu, 4 Apr 2024 19:53:43 +0000 Message-ID: Date: Thu, 4 Apr 2024 21:53:41 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [ZRcVdoSSB+POZ6R3Mvm5IoIlLyXumoPFtoRxYbcyXnU=] X-ClientProxiedBy: ZR0P278CA0109.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::6) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PA1P250MB1066:EE_ X-MS-Office365-Filtering-Correlation-Id: 59417022-6204-4bb8-daf9-08dc54e0eec9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZMJl56nucl2TNoANhOmxQtxrTcVi6KocTYAvbXfTu7NEtYUQQSvon0L+sUiIUWyHxNcocwnnftrfmDOJn4rykZDSMHrM7Ow27TsQIzK/Wt09Sqd3v9QWhKu5QvGWdgO7wGYvjjvvd9vZ4tVeSwOhutXyYnA1aIvSyXlVPgbcCGtQHPGibopf1nWi+eha8tQgvCbqrQxzeE2fZ/4EI6UcFJ+3hvABVZYYAGqnRwejdLHZwxCL+gBx7RnIz3U9VGs89ZwPqRCh2iUdsVuyZ9B/nVeEaTNeYwSot/3cER1SUt9nFTcIYmDJix2oeO/kjnWtnDCF7noeE7ZmpdxVg9V0kFhmmtcS1atAIte5Jxo55BLLPBU5S1Q0jzcpgIKGhyhKexcjvL1lVibX8hGiEzbHhhYQbcupxWwJpJaLtAYtO9l9zTYiMMw8lZ3+LXH/jht6nKXW/QpTp2xx+CMfR+yehX3xn2eNWQaHBnUsxxs+SlSh8imH9BxG3o+Le27E71d0r7ZgFEj3jV1g6/V+1XoQR22dAyTJrn535VCww4hb2C8K+4hAuPeMkT9bOScANnUj X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUJIT1F6dlBLWUQvWlJSbWVLRHNnM1lMaHNVT21NUHEyaXJTWkRud2VONVlq?= =?utf-8?B?ZFc5dlNBYmRtMnk1QmMrc01nUllKcEtFRFl6TXNFWTRaMnNFaU04Z09TV3dF?= =?utf-8?B?UTVNL3RnSnYrNmwvWWJOZko1dXVOQWNoZXRtdWh1VlBpa0U4TCtPdUpPd1FM?= =?utf-8?B?Zi83b3ZIWEpjd1k1Nkp4bEJiTWdIY2ZCUDRMa3A3RFc4ZzZoalIwYmozaVJT?= =?utf-8?B?djZ2a0MwZldmQlBvKzAyVUFzanFCNkd1em5HU3QrY1NJcDk3bldEQXlLMG9N?= =?utf-8?B?WWI5cks2b3ZqRExIUjdEWFdPc0grWU90anpsSzBKM0xXZmMySGxvTVVMTzdn?= =?utf-8?B?emVobnNVNzQzdDgxcUlpMkxDK0RTNlg1YzdmY1k2TnBoKzNZN1hSaWZkZHEx?= =?utf-8?B?UjBKUWhZN3VtOEpXdU1CN2t3ck5HQnBtUmFyRktQbFhjeHhkbjkrMnRia254?= =?utf-8?B?a016UWZEZG9nUTBVYisyYkpiR08vcUpQQ0owOW81TzFpd3NGTTduVmIvbnJU?= =?utf-8?B?K0JLMlBhYzAxRDUxT2pKb2p3dzRZTXNkeHhDSnQ0ZjFpd25zQnJ3eUpEUGpB?= =?utf-8?B?Zml0a0hwakk1bmV3TTIyTit3VjIrVGEvMVJTSGFiajZGMDkwcnF2T0duVmVk?= =?utf-8?B?RFY3UGNuU0dDWnNnMzlKR1YxSVdORW1mTHo4VGsvcnNlT3NERGYyekpjYTlr?= =?utf-8?B?MlRwRHNnOHdPWWN4YlFXdlcvTEFzaW13MjNZY2p6RGN2amR0Yzl5SzZDRUpM?= =?utf-8?B?WGR0UVJueGJpNE1yRkRweGZLdkxESEE2SmJxMmkxY2dJMkNpem1FWDJRdWpt?= =?utf-8?B?bmpLcW13VkovcVdzZmJKVWZTR09kT2NPeW1GNEdSQm5aenl3alBWb1REZXRz?= =?utf-8?B?VVUyYTYvOWIwTnJKTWgzekVSZE41NytRZ3RKZlloT1FhbUFqSDhRZ0x4bXZr?= =?utf-8?B?VTkzMG1SOEkveXZEc3hhbURwNUZDSHVlZXFhc0Y2QU1hdnZiN0lYUU84V2dR?= =?utf-8?B?VHM1NlJ2bXlTTkltVzJWTkZoVDBTa0JTb0FlZFJKNXFCTyt5UG55OFlSek1H?= =?utf-8?B?d2R3UGRTbVNVdG9pUDMwWVdhMnhNNVJDNXVyR0NuUm1UUTk5dWF0b2daczFN?= =?utf-8?B?QmVEOUFrN2ZaNE1CVnpXNFp3eXVtNnRBRUVTMG9hWWp1ZVVMZUNEdXA5V01Y?= =?utf-8?B?UFE5Q3lRanNZY2o3NkNOVHRtazdDL1M4NkJDK0x1RzRMdFR2SlNsMmxkSllv?= =?utf-8?B?TitQdC94am8yYmxWOUxTVWR3cDdaZVpXT3NmVVVvbTFRRnRhamhVOG9jL01i?= =?utf-8?B?NjZuVzlWUDBKazhaOExLQ2kwTzh3WXQxTlVBZlB6Q0U3SGhGY3YvdU04U29j?= =?utf-8?B?bVlJM3dTUS94SzdUQU5YZnVKU3FwTzhTV2dyWGdPcGM0VWJ2VTh3K0ozRmVB?= =?utf-8?B?cVg4SUdwQnYrRFdUUEZZblJiTGtlVmhZRGI4dVVMdEdLMjlhbE1oTUxrS3Vr?= =?utf-8?B?Zm1tNmJ5N1ZuNlpHaFRyTy9nKzJvZVl0QzVlYTZjcWRIZ0x2bjhNd0pVUmpF?= =?utf-8?B?aktqdDhRU3FnL3RIOGVOTWRKUjhmRElNOE5NZ1lUNDZXKzB4RjQycnNCZ3N6?= =?utf-8?B?akY0ZllYbEdFRUFIVng4b3kxUHFDSFRxY3Z2WjRMYzNrY0JGSktIRUpzaXd1?= =?utf-8?B?NS9hNGdNV1RJaDRKODFZa0tGY1FkNXphOVh4cmFOU3JjbW9qaDZSZUlRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59417022-6204-4bb8-daf9-08dc54e0eec9 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 19:53:43.7906 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1P250MB1066 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/ppc/h264dsp: Fix left shifts of negative numbers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > PPC equivalent of c756b3fca240df75ffa28e75f2eb34834c10294d. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ppc/h264dsp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/ppc/h264dsp.c b/libavcodec/ppc/h264dsp.c > index f50f2553a2..0650768d7b 100644 > --- a/libavcodec/ppc/h264dsp.c > +++ b/libavcodec/ppc/h264dsp.c > @@ -663,7 +663,7 @@ void weight_h264_W_altivec(uint8_t *block, int stride, int height, > DECLARE_ALIGNED(16, int32_t, temp)[4]; > LOAD_ZERO; > > - offset <<= log2_denom; > + offset *= 1 << log2_denom; > if(log2_denom) offset += 1<<(log2_denom-1); > temp[0] = log2_denom; > temp[1] = weight; > @@ -712,7 +712,7 @@ void biweight_h264_W_altivec(uint8_t *dst, uint8_t *src, int stride, int height, > DECLARE_ALIGNED(16, int32_t, temp)[4]; > LOAD_ZERO; > > - offset = ((offset + 1) | 1) << log2_denom; > + offset = ((offset + 1) | 1) * (1 << log2_denom); > temp[0] = log2_denom+1; > temp[1] = weights; > temp[2] = weightd; Will apply so that this makes it into 7.0. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".