From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 47A764CEE7 for ; Thu, 15 May 2025 11:08:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id BC40A68BF9F; Thu, 15 May 2025 14:08:23 +0300 (EEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03olkn2078.outbound.protection.outlook.com [40.92.58.78]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 48CE968A2A9 for ; Thu, 15 May 2025 14:08:16 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nSi30uMmBluPb1o0/FJwMQOuebMlnV1lwqLziMxYUoGWqALIq79GAmgL+Fcs30KesXW04PDPd2E7KnL1aIfuo/g6Rsa5O1qLevgfeQxKvfoi6Lc9M/zWNazlg5YA4M2ASsO36YYVJ22XvkaikqWPxFacGEffFY3RTjy96Cdbp9SvqRC6gfK8os27L41AWpPzqLx43aHflQMIEdYnlnoCyoJL6eYI/ndUk25egADN7Vn45Wy+bnhUYSNCX1e9G3xqTgSuygeIdDm2RX0WsQ55MKyDA03W487Nbgm9cSiWzVEdUcEUMR0HujpANLuh3GhbC+SJF5qplOrMsH2Xjt5k7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AfhElNA5q/9NLAyT5BVwyYOWq7eV+PnkIapkpjQqhUI=; b=OkEvVlVLjhrdZJgPCbkLNkD0WN3GKQFApFErT+RMliTV0UbHVYAe6heau5QgZhvTTopfqv7XQmdo4UY+BpTGrSlH0ShCEf2n2Zz5Biz+HGsfZnJFA2xHWsncqWLqEFO5ooqRmwco6kTRNvol5bS5OqbZyBkwVoFQYrDR/h1nG+jZ83SPDWzauD3O09UfbbcoU3l/HDXR7p5T6BSjOE7xkpk9+PcAY3USzf7nSer1URl8m+TvVrukStCtUnhJrLhFWLLN+0s00uUjbHl0n7CtTU2Dk0dqvkryhljeHCGjgt1GwADROK4jdKoA5lVcjxVXIf8Zy3avauMgoALYwoLOew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AfhElNA5q/9NLAyT5BVwyYOWq7eV+PnkIapkpjQqhUI=; b=KFH/givYGilAzJoy8uS7gcCZKFCDAfWJZanyR3fkfFvN7PgWqaeHW+aD3eKSNJtvbasdz0FJbDFQB/akMTfvwHXp208ggSscBtBqkGVAVOazHd1WiWs3gwUpQwPFgSUTti9B1le1SGiHB2TKopXfBq8+dxDYy+RbyMOGqw3d5+0rYVNDL28tMz9jEI8Ozv1/ABgO+YT9fbqllYoGD15sQd7Q54ihrmhkXv/Z/zVeMsVXJSraaMGXQer0lKhsBbkNoBmdx1bldLbFUuRCVQWsjDZ9w0igLFAy6bEKdxuQd8mcYEtRNKr7+Xa3B7xwMHTXRXmDbl0/XCJ0Wl6piQ/llQ== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DB4P250MB0927.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:384::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.30; Thu, 15 May 2025 11:08:14 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%5]) with mapi id 15.20.8699.021; Thu, 15 May 2025 11:08:14 +0000 Message-ID: Date: Thu, 15 May 2025 13:08:12 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20250514172213.20463-1-ffmpeg@haasn.xyz> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20250514172213.20463-1-ffmpeg@haasn.xyz> X-ClientProxiedBy: FR4P281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c8::10) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <958f4487-10cb-4b6f-af18-86f4e1649ae0@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DB4P250MB0927:EE_ X-MS-Office365-Filtering-Correlation-Id: 340c67d6-6ec3-4014-ea2c-08dd93a0c950 X-MS-Exchange-SLBlob-MailProps: AZnQBsB9XmoaApi1aWVt9ILKZbGoHsd6D1I4EwQ/Lrma8Kktfl7Z3uc7vunJlpWktLJOF+BIaoo276lSp6rMQUXtTnavIdMibfz+XpBOgFN8sqAyZB6+afoXs6xeiG45I51LWW+oirBe1ZWGmexGbjQKHaJ7pPD/cm0cCR7HYzxAJpw96BPzUbQYCF4+11u+BFzQmpHxy/Qr2NJcOU84BjbP/AgMwCs+dP6vljMO8JDBZdHoV0sMKiCbSg2d9PCtxUCNn3SIG6CGFJt7IGZxSG1ZuqHGkwbD/hkJx00Q6OuZGkK2k89/nfksLId/DrDegd5aCTONJt46aco71T8Rt4mDHvIczF+5BanLoypaUKodZcZ+qo+w6gdQS7gKhUVY13pM22+ZDtc9oxwokaghU5Ip6fnRn9tiGhOgfKJwRycFWWX/Uf7d50fYpOJEdrIqSV5ex1iiJqqsUPfyZ7kINTfKdQLWvK+/EUVzcu9VtOmkcEFc85z6N3pMvXlmJfkSixRV9eQ1gxMwv/VvGSvM6oN3nYIJ+ZYVtFE7U8w4MDbDL4vQ7IOE02Mp/ar8xajGadeK/UMw60QV891N1Uer/0ODts0xJNEXDGr0R0HSZ/obTJIhRftwcA4AKgNcalmCZSMadLsupwA9f4dM7LTXZ0rkXkuPNEEZtSStt2GieqfEjyE9TCsXj5pM2M52/KZv6dCbGMJA5d+U//2mD6GQboqJULYRQAfyhkwlcuhKXPAHj7ZRWFCUKnU5eHy9h+NX+TSCOEa5FPE= X-Microsoft-Antispam: BCL:0; ARA:14566002|6090799003|5072599009|19110799006|41001999006|461199028|15080799009|8060799009|7092599006|3412199025|440099028|12091999003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SVVkbElKTk1aUXp2bTlWRjlPRFp6WUVOMHhWOVUyL2Y0K21ob21scGI5Umtm?= =?utf-8?B?anhJbURxbC9FNTFQWWxxT0lubGJlNUpRdzYxYU5NbmNxaGo0dlh5WnYvMzhB?= =?utf-8?B?dVI2cjExTlJyM1JHeGkxNXhqeDRzUWF2NUt3S3o2YXIxcWFlKy9XM0tzK2do?= =?utf-8?B?QUV2YzJjZGdLMjZRRHhXYmsyN2xEY1pUL1kyNVRHdTJpOEN3VFhWeXF6a0NI?= =?utf-8?B?OXBUbWdhMTFReFhvNngxYUtQSUdaTzFuZW1paVlsVUR1dklwelM1cUVNZGZ0?= =?utf-8?B?b2Z1UDlDZjAyaEJGWkJYQlh3S28zSk9lSVZQVUhJdU5oMkZtUlJSVyt3TXk4?= =?utf-8?B?dXVHdTJRUEQxSTVDV0V1akc2aHZ0cUxVQk9sSGZ2WE1zR2hlYjZVU2QvOWJ0?= =?utf-8?B?aWFGeVZQTitUQlI5Kys2YzhsRE5ucS9sb0tyUGhiZTA3Q1k4b3hkZU9HMisz?= =?utf-8?B?MkVwakZkM21FV0dScnpidHVtTk1WM09tS2NZTE5CSTlZS3pTZ3huR3ZweEd2?= =?utf-8?B?T3hWT0NrTGVVUkVGdnBaakdxSmdVVTRhaldSL0VXZ2k5cjByVkhkdUl0R01t?= =?utf-8?B?akNueWdLZnIzdzJpNzF3ekFiYktkTnNIbmtiaEFPSG5zbGMzMXJ0eS81U3Vh?= =?utf-8?B?VEYvc3ZwNFV0L3lnTmxob3V4bnBXYUZzekVzbENkYnFyQXhDZG1qZ01IVnBt?= =?utf-8?B?b0Iyd3g0YVRqZVQ0d0c2VGl0cnJMRWwxMW9KWXRrbUpMbEI4ZXVBcm5namIr?= =?utf-8?B?TzFhTXpIZmhsSWY2ZFdXdTdXWkRkYld1Y3NoNGNMYWFtWnN2akZhOUIwZXFJ?= =?utf-8?B?SHJhaE5OeldGNzEvSzNmY3FxREdEa0VMV211Um5hTVJVVlg0N1dRcUo5eGZl?= =?utf-8?B?Q3VqWTd4akZyUldrcEFEYk9kMXIzeDFQcmhFeVBONndrWEhlQzhXVmg1LzlL?= =?utf-8?B?S1gzRmhOMXliaHcyeTdWek5uRFY1VENudXBhYWhsZzFIZmZlYmMxb21RU1Ey?= =?utf-8?B?OVBJNXoybERvZXNjYlVzZkM1akhFRTVnSFBwTVAwNThTcGpSYmxia0FmTnBp?= =?utf-8?B?Z3lkTDYyTTlyOUtSQVBBRUdzeFFyQUJPQWhTY2w4V2M5R3htbFRPNGU3Mk02?= =?utf-8?B?ZHNxRjVuS0NDWHZUY0c1R3IxRi9VTUxWNTBLb0QwcWI5R0l0KzhxUk1mN3Nu?= =?utf-8?B?QnFRaFNycVNEaHZUbWhpbVhoRWxwNDZBWVFiS1JXMWxwUVZlNDRwL3E5VTUx?= =?utf-8?B?aTFrcnRYc2ZmbXN2N0tSbzZBUFJGN3dLajVjRTdMTTR3QTl6Yjd1SlFXYU9w?= =?utf-8?B?Q0krRTZldndQYnZIODJOWjlLSjVUb2dkUEY0dytNWWdLWFBXY2pNQmU0d0dO?= =?utf-8?B?N3A4MDFvOTRodk1GQ1dTZjB2a0hzblJET3U2ZTEyYUdUL3NyVlc3SFlyMFh6?= =?utf-8?B?RGVmTGNmV20yU1dLVlhueG5teWMxMy9GMktBVXpoU1FjUXVPUmJvS2xuSHRJ?= =?utf-8?B?dmRCV2ZYVnVQNjNGdFNOQUVjcGM1NklPd1hMRUttWC9WRlQrZ3JjcjA1a2py?= =?utf-8?B?Sm50azJDaFJrenRsajEyclVyMTFDc3ZyUVJSa1Z4ZkQxcDhFdHBsUHVLNHVG?= =?utf-8?B?M2czdmVxNzRuZHVXQWxtcFJ2QThlckE9PQ==?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnVlR3d2clVCWkl6QzZlWlF4VVAvSHA3cFNMZkJlaDJrZ1AwTWlwMUVSL2xJ?= =?utf-8?B?ZzU4bWlLN2VkaDZaeVlvM3RuWS9tbHFvUlcrSFhQWGNialNSM05sMlJRVldp?= =?utf-8?B?K0laL1ZqWit3S0NMMzZtSHFWYlF6Sy9BRkN4MXhZVVRSaWdwS0Zpa25QeTBz?= =?utf-8?B?N0JUa0pQK25xL0RrMSt6eTJvMEEwOEpJWFhNQVRqMTI4VTJQNExwRzJ6ZW9h?= =?utf-8?B?V1RvWXhTUm1SaHMzUzNIbkI4djg0dEpwV1RmTWVqbWh6TXE4N1Z2ZUVxQVdm?= =?utf-8?B?OGczbEV5SXZ5T2taeTlwL3M0VGpXZ2VJbUU5UXNDWHlGOVozcmQzTmhuU05o?= =?utf-8?B?R1lWeXB1akEvclpsdzJVNnNpMTMvMXlTTnBic0dvdVdnY2wvYkRUZmY2TlZh?= =?utf-8?B?TDZwVStFMUhlRldHRXQyUnd6alQrZnBmVjRBYXFWSE9uamtLRGNmREozRzha?= =?utf-8?B?U1J2V3NhaERYT094QzZTd2tQRHhsRysxeTBwcGxFRnRDeGZIVjZHK3lrM3Vm?= =?utf-8?B?aHhsRy80dkM2Wkxsd2Jqa0hWOUtKMTRKbmFESy9VZnUyRjcxVTVxcHV2MERF?= =?utf-8?B?dW8yMEdkTGtPaGtWTGVLaDZGckVtdVZFTGcwMEZxU1JZK1FrOURLY2wrN3d0?= =?utf-8?B?Ti9FVkg1ZjZYeFFaTG5Hd3dxdDVOdENVakNJVW10emk4WER6Y3RKM25CUFJK?= =?utf-8?B?L2gwUzZYRURqYy9CL2dubWhyNGNuVzNJSGl4VWc5Q2VienJOdUJNL3J4aFFY?= =?utf-8?B?SGZ3bmZGNDR4dTRmd1F3TXdCdGx1UVpscDMxMk9RU2RDSUR2WXc0Szh5aENj?= =?utf-8?B?TEdNUFIrVGxSUU1BVGpLUXVvM3JoUlJTRmk2U1AvVVhTVlZtOExEaHdPSHAx?= =?utf-8?B?QUYyZG9NelZJRms2NjF5R0xNdG9RN2RKVVNKRFF2R3Z6UzA1L2doOUUzYkMz?= =?utf-8?B?MmNOY0JGSmZSaWxacm1hVGd2OEJNdDQ4NU00bEdLemYxSmQwNmgwNnFXaWpR?= =?utf-8?B?NVZqRjgwNDk1OC9FZDNrS0UyWStXdFFpMGNEM1E5SVMzaTRINUM1RE8ydXFN?= =?utf-8?B?TjRmR2puQmgxbGRjOGd0WjQyTEhFeDJ6UFZHQ1ZybHRvWFZ1NDZCWElIK0sr?= =?utf-8?B?Ri9vTUxDYzEvcGlva1B2dWNnZzJ3cnNBTHhHNkxZM3BFYlR6ZTlQSWhVR01q?= =?utf-8?B?K012dVJ5dkhneEVOa29ZYVhxRDlsZ3dSZ2w0TkdFNDJpU3FtZHUxWDY2VjUx?= =?utf-8?B?YWxVYjhyZ1REU1FkcWtOR2xUQy8xTDlCRmhsVDFSRnp6WFFaUmE0NlFrb0hi?= =?utf-8?B?OXFxS3RFbjQyaWNNQlFYWmRnYnZqU0dOQmVXTG9FMHA5cmtTdHZ2QWJ6R2lF?= =?utf-8?B?ZGxJYUV4ZXRkVVhRLzdZSW9SeTJlWW9QaHJtbVNzZlhDS3NGVmhRV00vbGtD?= =?utf-8?B?b1BJS2xtZ09zUHhaQ2I2citWd28veWNGd0loWlNQbzVjSXdWaEgzRzlCQjFx?= =?utf-8?B?SW9KZHBsTlBwRFQwdnJLNkZxZndsa1hSU3M4eVNFVjZsUmg5OE9tMHBORjlU?= =?utf-8?B?ek0rWVRnWlpSSGx2ZjZ6UkswcndHcUpQYVJHY0R0VjZmNmdyV0tJejFBbElr?= =?utf-8?B?WGFzemh3UzJxVEdUNENSRktNSVdLbTBrSHBqeDVCYmlqL3JXdjlLSVdQajRR?= =?utf-8?B?UTRNNnRjZngrSW05eENBQndjc2wzbmdyY0pKalgvVWZ1bFFkSGpKOUErS1h6?= =?utf-8?B?NDUzOGJ2eG1XNldoSEtJd1JTUnM5OERNVlNMYWNOTGFQYkVDNEEzWHFsam5R?= =?utf-8?B?QWZZT3ZOSVEwYitVOFd0QT09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 340c67d6-6ec3-4014-ea2c-08dd93a0c950 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2025 11:08:14.3061 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4P250MB0927 Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_libplacebo: add shader_cache_dir option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Niklas Haas: > From: Niklas Haas > > Useful to speed up shader compilation. May significantly lower startup > times, in particular with large or complex shaders. > > Sponsored-by: nxtedition > --- > doc/filters.texi | 5 +++++ > libavfilter/vf_libplacebo.c | 29 +++++++++++++++++++++++++++++ > 2 files changed, 34 insertions(+) > > diff --git a/doc/filters.texi b/doc/filters.texi > index 679b71f290..66cb3e6c20 100644 > --- a/doc/filters.texi > +++ b/doc/filters.texi > @@ -16307,6 +16307,11 @@ as a list of @var{key}=@var{value} pairs separated by ':'. The following example > shows how to configure a custom filter kernel ("EWA LanczosSharp") and use it > to double the input image resolution: > > +@item shader_cache_dir > +If set to the path of a directory that exists, libplacebo will store and use > +cached shader objects in this directory. This cache is not cleaned up > +automatically. > + > @example > -vf "libplacebo=w=iw*2:h=ih*2:extra_opts='upscaler=custom\:upscaler_preset=ewa_lanczos\:upscaler_blur=0.9812505644269356'" > @end example > diff --git a/libavfilter/vf_libplacebo.c b/libavfilter/vf_libplacebo.c > index 86e1f43dea..ca7d9e253a 100644 > --- a/libavfilter/vf_libplacebo.c > +++ b/libavfilter/vf_libplacebo.c > @@ -195,6 +195,11 @@ typedef struct LibplaceboContext { > int color_trc; > AVDictionary *extra_opts; > > +#if PL_API_VER >= 351 > + pl_cache cache; > + char *shader_cache_dir; > +#endif > + > int have_hwdevice; > > /* pl_render_params */ > @@ -522,6 +527,21 @@ static int libplacebo_init(AVFilterContext *avctx) > return AVERROR(ENOMEM); > } > > +#if PL_API_VER >= 351 > + if (s->shader_cache_dir && s->shader_cache_dir[0]) { > + s->cache = pl_cache_create(pl_cache_params( > + .log = s->log, > + .get = pl_cache_get_dir, > + .set = pl_cache_set_dir, > + .priv = s->shader_cache_dir, > + )); > + if (!s->cache) { > + libplacebo_uninit(avctx); > + return AVERROR(ENOMEM); > + } > + } > +#endif > + > if (s->out_format_string) { > s->out_format = av_get_pix_fmt(s->out_format_string); > if (s->out_format == AV_PIX_FMT_NONE) { > @@ -676,6 +696,9 @@ static int init_vulkan(AVFilterContext *avctx, const AVVulkanDeviceContext *hwct > } > > s->gpu = s->vulkan->gpu; > +#if PL_API_VER >= 351 > + pl_gpu_set_cache(s->gpu, s->cache); > +#endif > > /* Parse the user shaders, if requested */ > if (s->shader_bin_len) > @@ -714,6 +737,9 @@ static void libplacebo_uninit(AVFilterContext *avctx) > av_freep(&s->inputs); > } > > +#if PL_API_VER >= 351 > + pl_cache_destroy(&s->cache); > +#endif > pl_options_free(&s->opts); > pl_vulkan_destroy(&s->vulkan); > pl_log_destroy(&s->log); > @@ -1328,6 +1354,9 @@ static const AVOption libplacebo_options[] = { > { "fillcolor", "Background fill color", OFFSET(fillcolor), AV_OPT_TYPE_COLOR, {.str = "black@0"}, .flags = DYNAMIC }, > { "corner_rounding", "Corner rounding radius", OFFSET(corner_rounding), AV_OPT_TYPE_FLOAT, {.dbl = 0.0}, 0.0, 1.0, .flags = DYNAMIC }, > { "extra_opts", "Pass extra libplacebo-specific options using a :-separated list of key=value pairs", OFFSET(extra_opts), AV_OPT_TYPE_DICT, .flags = DYNAMIC }, > +#if PL_API_VER >= 351 > + { "shader_cache_dir", "Set shader cache directory", OFFSET(shader_cache_dir), AV_OPT_TYPE_STRING, {.str=""}, .flags = STATIC }, Why do you set the default to "" instead of NULL? This gives an allocation even when the option is never set and makes the check for whether it is set unnecessarily complicated. > +#endif > > {"colorspace", "select colorspace", OFFSET(colorspace), AV_OPT_TYPE_INT, {.i64=-1}, -1, AVCOL_SPC_NB-1, DYNAMIC, .unit = "colorspace"}, > {"auto", "keep the same colorspace", 0, AV_OPT_TYPE_CONST, {.i64=-1}, INT_MIN, INT_MAX, STATIC, .unit = "colorspace"}, _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".