From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5920D4098A for ; Sun, 2 Oct 2022 16:39:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BEC9868BBAD; Sun, 2 Oct 2022 19:39:05 +0300 (EEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-oln040092066101.outbound.protection.outlook.com [40.92.66.101]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3009268BB93 for ; Sun, 2 Oct 2022 19:38:59 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FpcqLu/3vFDKQxwTSYiB8W6Zs/EkDPWTMw+yy9YIAYgvWrHVDA7Sn4ui1GncHIdyKFX2e/0cfutATkrpX2FM3WVaAl0HX9RWQ7CIRMivh8YN3RQ2D2oGhC/Tsv9xtqSqoQg1Z2xQXK3Hu+SxVJ3D4Lv5GfrVd4li9yePjKykcvT00Rw1Xm8lEq0PVQ1vEgOFDLXyGpVqiVI7E5TeD5R5YA8pml5WFdEaAjGp2impfoIdOPFBxTetkPy69A52iEdLrOL0DDFmRXokPnjzMS+wvJLsniJkRLD210zCEn3ahrj35jyGhOMnDaJt0wH2gMnWpWsqXvrgtCkQ/FkY5WA1hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qwuvqTM/MlKuLgngLREECpBdLHMbRarokyVOXzqMCFQ=; b=R7822enumMg0mS7dzZAR2rKgNJ6selOwuAQucXuzKwqFHIoj/uGsE3bEhkbrK6ZeVOZ8Yr7yXQ2XrygChwmk4BpBb/4+Fq/9tyfl+Znrwcag/FGKlFWtce5FLdqGVL8EHi0GoFcIzHz4IbZeoO6qwzvVymNUUAMqzGV77tU4jncFZibaQXNt8cCSmwt1A6mq6TQcNwO+lSLSI8w6KVVWCGUuF2VmMNZd+u0UhyY5Pxq4zyhi8xjijuNPFkT1MB1SVBEOEZhB5ZThfq66qyFGhhehQKJpdDdbIcDeYAli2uOkXC56Evpim8OATyADL5tqAfLHSL+v6WSCHq5KBB93Kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qwuvqTM/MlKuLgngLREECpBdLHMbRarokyVOXzqMCFQ=; b=OJR/pCWvTF8oPp7pub2tYCBpdClKcxsPpH9rwOzy8+VRoVJjW2Htas7/9l601TDZ9DowSVo4plXfG5BbEFhccO8QaUuMIaRdz4Z5R2jvVDAxDEGo1CFQxYz72ZtfYKrB9W6RKIDpRuCs/wuQ8vsECYg2VrfjMjOhD8CJpEjxKvHfC63A9rL1FAX78ExtE2+0TKa5vl2auNz1A8TbxE2RKROmc43u7yT/voGc3VJnW/5itQ6VhXKQEtWR+trvafA5OfR8SRG0cB6kxinxCrin575u6TWT2ttMFfRhTS0+CBQhuvRK2vfDXxQZ0zy5bJRTu2Uj1gfIbAaHAmxw5BvFlg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0279.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:32a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Sun, 2 Oct 2022 16:38:57 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::68bd:2fc7:ac52:38f8]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::68bd:2fc7:ac52:38f8%9]) with mapi id 15.20.5676.023; Sun, 2 Oct 2022 16:38:58 +0000 Message-ID: Date: Sun, 2 Oct 2022 18:39:03 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [2O045PhudIwSkpFYucbTadFuorRuXqXp38ifGr7FurE=] X-ClientProxiedBy: ZR2P278CA0043.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:47::17) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <315cebd2-e2a8-5cb9-4e12-9444f6f31778@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AM8P250MB0279:EE_ X-MS-Office365-Filtering-Correlation-Id: c37dc627-1daf-4c36-782a-08daa4949a69 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UlIfy/avhM+EUmnuZCCPahUqv0mInAcRvAH2dh18G9nrCCIIjtMCKxgglNwDsgJLLK14mgM/1sraB1Nfk7Y/G1ED3aLvplun/pIu3OC3xYZ854ZTzE5CCMG9mFysDE2qsNXnYxwg+/GWYDyNaw0TyejqlJPsK0bXBh5M9WseiQL3Ml6Q0qZz0nEIs77p+RQXtPKJeYU4uXpAaKX4qDV2T+GGpQ5Rws/7Dm1nJCReSMXeoZRvfm+E9ds3r1EReaLo/PV1QDuSHkxkop+FDJbIvd0YoviCBxpdmQJaWEt57Lk/c327idYOvnnFzbNLRgZ3ABKO9IPOJ8rg0Bq2P8BgDcO3Na+ovlKMlhM2FPbLPDXe9OSqD7l3ciISCSStu1tJosxXvQvw/tQX8GQ9pgKlUJkzLR2MpTSIAmp2jnjg90CwZws+K04z5FLN8HNZiQJC/WBRvmOhIXonVK83cluc0riKYYB+Do7H8xgseWZ8fmR5z7RO/Ho2FiS5j/HH7CKd7wWJaE2nZuTqaJpBPB+6GcbfQdf8NcczHPH18o4mpxSCNew7R3FfvPBxSE5htFHCqGXC5qyuJDsq7vq3kEbcURr43Jvvwt6e5nJ4rvMwHCN4ZdIqvm+Vaoqjz0TTkZaUXvS2BrlH2Myza+JdpiZz6lbQHyo3nhzrlY3ao81WzB4+lY4JvEQ0+yEdSpKFAFDy X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWJxWWZzOGVqRW53MFB6Uy9XU0J3RDhWZkNsWnlzVklFRmpBLzd2QjdwL1Nx?= =?utf-8?B?THdYYjhpVUpoQUdxVzNQa1M4dFJBWHNvMXFyc2lMTjlFTVZTSG5nYnZia2g3?= =?utf-8?B?VjFvYnNYcDNuU3dEQm5ib2x2WUZlaHhmYWZCcTlRMk1VZFo3WkNObUJjZEVn?= =?utf-8?B?NHQ5RXhYY3JQb2Q4VzRtSE5CMWhoOEZGcHNZUFBKdmxXRmg4NmJWYmdwNGVJ?= =?utf-8?B?OFJFcWFncm5kNEZmTHVnRWpMRG9lZm9UQ3RiTDFMaU9JMWlmUUhFWjNrb2tR?= =?utf-8?B?MHlzU1lwZFlkeE9tREo0NXdYSE9LWlNYNVNSa1ZLVm9RYzNMYVVZTURJNkhZ?= =?utf-8?B?emRPSVJKSTUvbklxVTNRSTAyd2U1dk94ZHBBMnVrcFRQbEFiL2swR0JHNVBt?= =?utf-8?B?UU9nb0ZlWXdsaGZJMGptU1I3WjZLN3NyTENCZTMrM3crUkZPNnZnTVBTd2tP?= =?utf-8?B?emtVRks3ZFlnMlVSOGtsYmp3d2trS1NMOG00VVN3V0dyRXpyYm9lTWtrTmNS?= =?utf-8?B?K0xzRTlweUxjeURHSDB1RFVtQlBHeDg0M3JqUTVDdmxoKyttQ2JvWllFQmQz?= =?utf-8?B?Z1FQN3FnOXdYbWhQV2F6QUZnN0lyTUxFWjNiL01FZExYQVpwYlIvckFhcWNo?= =?utf-8?B?ejlLNnRST3NUU3pDSy85dGZNUkllUEpoVmxnZ2poOEF5V0haZUZPZS9YdURw?= =?utf-8?B?dlNnQ3dmM3V4anAxU1hXdThoRzdKL1VYOXdlWUlCSStGZmMvS1J0WGN4aU52?= =?utf-8?B?NEZldUt3YjFsZUtBVzhPZTRPRlJjZFZWVXczdXNzVnZmRVNkRzE5cXNvQ2Ra?= =?utf-8?B?Z2g3T0l5ZlZ4TnRJRDcvKzlESGdtN000Q3BQNUdHYWFCaEdMRllqUXVPRTll?= =?utf-8?B?VUQ4NmFmdFl1Y2NvVncrWG9LUzFNRTloQTRESVpraG54VkxnNEN0V2t2NFNl?= =?utf-8?B?WUpuOEZoY20xcXBZWHJvdjZza2F0bTNrTWtTNDlKN1I3eG0wVVU0bXpWUU1G?= =?utf-8?B?aTM5WFBCeWl4VG1NS1ROVkdGZVIrd21BR0xCc2ZVVFNUQ1dwQlJsNnNmWmNJ?= =?utf-8?B?VW1RMVhreE9GMWh0SDk3Y1JVQ0Z6SUNFOVBERTdqTHFtZWFnUDdBMStpVE1l?= =?utf-8?B?WEhVbWhFQ29Bc2Qxcm9WS1pSRGNUNWxMaFh6S3J2eEV1NXdpc0I4d1FYRWxQ?= =?utf-8?B?U3ZZVy9yM1h3N3Fuc0FmQThMcHZrTHVDUUJZdEc1Q0tuN2tocmRRRTF0aW84?= =?utf-8?B?eCtTZUFlVU5MMmRHMnBSZndmNjVINXpweXJPSGd5d3daMHdXeG42T2xMRDVR?= =?utf-8?B?QW5vNjl1a0JGdURaSmhQM1V1VTFJVjM0M2hCY1FsWDVVMG8xc2FCaE1OTGth?= =?utf-8?B?MHR0RCtXcmNwalZEb21zaEN0LzVDQS9NcnphRkw0ZC9rWW4vWGJtR0hzSG1w?= =?utf-8?B?ZHVna3g4cElhN1VybmNZcUxBbUV2YzVDcmtETnFXOUszRFJ0RnFPNHBNNGZF?= =?utf-8?B?dUNVZk1oLzRRdGlGRmpMZEh6dmtRUE02U2lYL3U1Z2JkTWVuTFdZenJJbS9q?= =?utf-8?B?bDBKTjAvYVVHTVNSRGd2S2x4bUFVMFV3dHpiMkZjZUZIc3k5c0FYd0R0VG1y?= =?utf-8?B?UmxXeDZFV1liUDB5cXhKWTgyUWN2NWtzZytqNnQyTENkb0RNcU90aVNiajNJ?= =?utf-8?B?VnhTZWNhZ3NFZ3k2WlpRYU9yNjg5U2VTZ3dxRGNhVXYyRE5KRzBnN2lNSjlp?= =?utf-8?Q?OSANhAsgyBFRCLHiY/yvieag3h4VmKobz2oMq28?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c37dc627-1daf-4c36-782a-08daa4949a69 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2022 16:38:58.0951 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0279 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/pngdec: Don't use unsigned for width, height X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Otherwise p->linesize[0] * y will be evaluated as an unsigned > which leads to segfaults in case linesize is negative. > This happens in the apng-dispose-previous FATE-test in case > one makes get_buffer return pictures with negative linesizes. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/pngdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c > index 582953d17b..3c3eca601e 100644 > --- a/libavcodec/pngdec.c > +++ b/libavcodec/pngdec.c > @@ -1387,7 +1387,7 @@ exit_loop: > if (s->has_trns && s->color_type != PNG_COLOR_TYPE_PALETTE) { > size_t byte_depth = s->bit_depth > 8 ? 2 : 1; > size_t raw_bpp = s->bpp - byte_depth; > - unsigned x, y; > + ptrdiff_t x, y; > > av_assert0(s->bit_depth > 1); > Will apply this patch tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".