Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] FTR decoder
Date: Wed, 31 Aug 2022 19:55:05 +0200
Message-ID: <GV1P250MB0737265F7C752A205512236B8F789@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAPYw7P713o_j6cim4kuRmdVsQXDafVeWQ5J2gp-sVue5Vsyu7g@mail.gmail.com>

Paul B Mahol:
> Patch attached.

> +    union {
> +        uint64_t u64;
> +        uint8_t  u8[8 + AV_INPUT_BUFFER_PADDING_SIZE];
> +    } tmp;
> +
> +    *poutbuf_size = 0;
> +    *poutbuf = NULL;
> +
> +    if (s->flags & PARSER_FLAG_COMPLETE_FRAMES) {
> +        next = buf_size;
> +    } else {
> +        for (int i = 0; i < buf_size; i++) {
> +            if (ftr->skip > 0) {
> +                ftr->skip--;
> +                if (ftr->skip == 0 && ftr->split) {
> +                    ftr->split = 0;
> +                    next = i;
> +                    break;
> +                } else if (ftr->skip > 0) {
> +                    continue;
> +                }
> +            }
> +
> +            state = (state << 8) | buf[i];
> +            tmp.u64 = av_be2ne64(state);

It is simpler to just use an uint8_t buf[8 +
AV_INPUT_BUFFER_PADDING_SIZE] that is set via AV_RB64(buf, state).

> +            init_get_bits(&bits, tmp.u8 + 8 - AV_AAC_ADTS_HEADER_SIZE,
> +                          AV_AAC_ADTS_HEADER_SIZE * 8);
> +


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-08-31 17:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-31 16:42 Paul B Mahol
2022-08-31 17:55 ` Andreas Rheinhardt [this message]
2022-08-31 19:15 ` Andreas Rheinhardt
2022-08-31 21:23   ` Paul B Mahol
2022-08-31 20:25 ` Jean-Baptiste Kempf
2022-08-31 21:22 ` Paul B Mahol
2022-09-22  9:09   ` Paul B Mahol
2022-09-22 13:21     ` Anton Khirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=GV1P250MB0737265F7C752A205512236B8F789@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git