Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/tiff: Remove commented-out code
Date: Wed, 28 Sep 2022 03:07:07 +0200
Message-ID: <GV1P250MB073724AAC56089C89E9DC4618F549@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <AS8P250MB0744F5C729656212F053CD7F8F539@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>

Andreas Rheinhardt:
> Also remove a variable that is only used in this commented-out
> codeblock. This fixes a -Wunused-variable warning.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/tiff.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c
> index 3a610ada85..fd9db18c0b 100644
> --- a/libavcodec/tiff.c
> +++ b/libavcodec/tiff.c
> @@ -1882,7 +1882,7 @@ static void camera_xyz_coeff(TiffContext *s,
>                               float rgb2cam[3][4],
>                               double cam2xyz[4][3])
>  {
> -    double cam2rgb[4][3], inverse[4][3], num;
> +    double cam2rgb[4][3], num;
>      int i, j, k;
>  
>      for (i = 0; i < 3; i++) {
> @@ -1900,11 +1900,6 @@ static void camera_xyz_coeff(TiffContext *s,
>              cam2rgb[i][j] /= num;
>          s->premultiply[i] = 1.f / num;
>      }
> -
> -//    pseudoinverse(cam2rgb, inverse, colors);
> -//    for (i = 0; i < 3; i++)
> -//        for (j = 0; j < 3; j++)
> -//            rgb2cam[i][j] = inverse[j][i];
>  }
>  
>  static int decode_frame(AVCodecContext *avctx, AVFrame *p,

Will apply tonight unless there are reasonable objections.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      parent reply	other threads:[~2022-09-28  1:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-25 18:22 Andreas Rheinhardt
2022-09-25 18:24 ` [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Remove unused function parameter Andreas Rheinhardt
2022-09-26 15:13 ` [FFmpeg-devel] [PATCH 1/2] avcodec/tiff: Remove commented-out code Rémi Denis-Courmont
2022-09-28  1:07 ` Andreas Rheinhardt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=GV1P250MB073724AAC56089C89E9DC4618F549@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git