From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9389949B96 for ; Wed, 3 Apr 2024 15:28:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AACAC68D15F; Wed, 3 Apr 2024 18:28:19 +0300 (EEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2077.outbound.protection.outlook.com [40.92.89.77]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 104BF68CB44 for ; Wed, 3 Apr 2024 18:28:14 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HvjJesiaehTc/BSaYnmnQVsg6JDsgPzFyoGToMsCAWY1LJRwcAx7EJkGBaXPddO+zLbaQupUPe+NC2Ijj1+FbpqTjCqcp06q006vSHKb0R5EAr6zRaq/Utx8AYFvFhakZsDjkcMVMkByP177h5GcEnNpr187nhe6OCrR9HUnJrhvdsheqiVjkmFBpDJ1/Hsy/iq/CKSkslukz1n4qaH30wyCVE7k+6zBGWUg7f3PQNnrCOkyNyr1q9kr0jBZEMHIIcOtRYz6r5YzefFTuq0Q+TC3xjau4G7nASODMFHbubFTge2g9v0w5f0tcE71hnbImm85HiFttkr/oUtSIE0fBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CSoazvtRdi2bmmfgN9cVgZBUJmNFL3oBSqTuwIYD0kg=; b=hgTwe7c2hEFGoy8m3nE2khNEJYyhcYDSVbkfKwzsNA/K2Dvr6BW50TWB6TdyxsIEashoDGeJLkpoTdx5s7xdr6dGQWcpVHuMaKcyVSyTJNxQQkGSAazLQIQMzLQKhKrCTz/9I1duEO0TEYUe2FdO30GLQNjpzdlqd2QW3czhpOgooBpgHhvl20LxrqZNhgH3c/1KhtkAeESOvmHAGtsTOisVjmd67n0M3u0OEGHXh9QFOvzL+gRBqJgsF90xZEIqXLutKcFLJUC7e7P+51PRzI36a96U9YLuIzBIsjzy8ge5OpsQQ5TtaaFgNnQh+xihWWcDbksbJ7gIBj165S0qxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CSoazvtRdi2bmmfgN9cVgZBUJmNFL3oBSqTuwIYD0kg=; b=ojV4rVcWJ82k6xnxkfuv2ug2VqNznzW+Y5af7QJUWko43xFNposIZLbeOuKbDugOMrLMinsQ3xPGGMmItEmID9i8KqWqm1HjJ0DJlCQjq5agDE5/TyXtf3gO8BIiGKrZrXrD8nJNqC+6zUiurWiIQdzQmgDgaNad8wG9O1Q7Kk7UrU+WVqmrBhpYJXnOhvxJT3VUby/YJLgjAf/BRfIFU3pXhe/w8zEeon08psCO3BsshyrqQeYH/0YpUQ0np5CXIWIivD6c8weIgQu6hx1jSIfZGoZb/oDeTLyzCbceMsrbyfRtbk19hzlPa5TGjXlbUifal2jaZprRYk5WpK8lgg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0058.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:3d9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Wed, 3 Apr 2024 15:28:11 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.042; Wed, 3 Apr 2024 15:28:10 +0000 Message-ID: Date: Wed, 3 Apr 2024 17:28:08 +0200 User-Agent: Mozilla Thunderbird To: FFmpeg development discussions and patches References: <171213341995.28449.17458538396305228565@lain.khirnov.net> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <171213341995.28449.17458538396305228565@lain.khirnov.net> X-TMN: [943GyojW1HbkFUX2+IIG38KS+e7PbY904yTcjlyQkJM=] X-ClientProxiedBy: ZR2P278CA0053.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:53::11) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <4c272ce1-a0d0-4dec-90f8-a05a7c72f546@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AM8P250MB0058:EE_ X-MS-Office365-Filtering-Correlation-Id: 259297d6-9efe-49f3-6899-08dc53f2ab9c X-MS-Exchange-SLBlob-MailProps: Cq7lScuPrnqTbNMns+cyPJZyEykIufolz/ZYNxoRregZzFpJFJKymUH84kAQAe+dOCmXsMmoM+FlhGvb05Xe03Vq/Yoj94/o2T/mfl5BBhJAlpzt2tg92CsCL7gJsgNHuy6X7YpCg9Wbdp+LXAlv+Kv6LDGptP4p4fRcCPeM+zpu7mn5HcrFmKliMGlspR/X8GwS4ihieoGHA5aqIBVths5WMZgxOR0cqvykSIC2hvXqhE4OUcwNY050GbMZG4d74pcPVRQy5T+IfiebuXwBYA+Aag3c8OEpj9CrOg1aJJ991DwMzDyfcvWmqWX9Z8Q2HvsJAkAyNX6LA/6W+gyuMK5azJcIaJ66xIe4fE3TTQQsJknuC8YqqGgFtfoS9zuOgKIW+6cuAzMhjbHqmZW4UYOazKs+bjmQNuTleMAb2RCzxgobEDo6TQYi7HCUj+nbYGWSSiQvXMgNDWLU47q9czyKuXoIQ7ZmK6FZsOTEWU8kIpsJwU9tlB9YnnogWfmpIBmjDKAyq/avQqETQKaDQl6YP55f7JNth1UzF5WxcP5mh97qsW8dQHq1s5s7xdzJNch82E1ThPhc4XlM7v2A/wVGBIuOTQj//db4UAJVAlxXaj01EDUPTJQqylng/NnTX88N+xAvmGBPIFSS352gWG9X7bCKnwRk9uLZtYyOrlMYQ2Ht4FuGQ4wMQ4/uV8XUKYyUuZoH9e6qKZ4WQdLVDWovVj1K6fLFKdx+esjUN/wJk3ELjh0LLuXKajkcUTAlGk7Qk2GNB+s= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wuo+dVh1hSuE8mjfyEnbQYfdTkKVMBAeyXrfFKUyV4V3PN1RZhMUS2SJjSyEctBfB58WffQ6xH/gfZ4/n3c1E7bKeJnjrQDRY+n7/dsYemn/wf9m5Kp6hIneqlfs1SikkY5MRpHeji9Onnsrr4ROU4shTX6uZVWsFJyWh/WMaaZIuPIdK1fnIhtTMIltPnV1HFNsjxz5VGv+DcOeXGEZR0QNzU4ncRLnaOs17ld7Py4f0Dws9gDsbMYWUa+bOmdnYII+MghTlYcVXtOnTBcjKe/xlsj6E1E6Ixzq4s0R8ht/rSrtR9nF7I2aEKlUWJtfbwOY+qC5UXBA72E5V9Yj6FvZXHq5P/BMGksvKXQs2wL5xjVoPe5Ph2VIj2fk10GuOHbPF+GxThf0aVHrlEg0M88p9cQqA9V6XR5SDEUdw3rjTBXBOHAk0/zmPwsXlhFn1Kd2qUaTWOawkWv0k/T935KqyS52TH/M3XUwsuXBpLk6q7DzHIWrJ9rBeLc9OJo5BkjWOPROedZw07c8ofc4CTiiV2aHIN5z6r0mIYVTvLroAHobKel+00o0r0uxMxD0 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bk5BOUFadVFDZzFxdXdTbkJ6RFhnZHdOYjJ1dUJsZ2REaUs5NlAvRndSTmtY?= =?utf-8?B?V0lqcUZYcUhKb1BjbW5zVldTTG5IeFVjKzhRR1JPYU51UXRmMWFBRVE1cG9B?= =?utf-8?B?NUgyWkxtenNDeFR4VHdaMkpVamYvUnF3bWV0Ky9sNDV5QWZNVytIZnhTVC9q?= =?utf-8?B?Vnp0bGd0Z3loUE1wNTN1SEVzbjYzSUVTOVR5NjVvTmJoUnBuQktKclFsd3FP?= =?utf-8?B?NHYxeGhaWUpIWXdqQVMvb2xOejJUVEpFcXZ5dmpNTTdsSjhVWHFwRU1PVjF2?= =?utf-8?B?dndsNENXN2s2RkpVeVVjMUltdGVQSEpUS1hNK2twM2F6Q09PNXZxdFJ4bDN5?= =?utf-8?B?UzNBUTdLbFZkQlpGQWhIVW1nMmlldHZHbUo0R04vcjRMcEdnekorWkYwRWNs?= =?utf-8?B?eFB0Y3pSMnFoc21kNnptRitIZmgvWTB0MllYM21aYjVjTjhJdWZWMS9ta2da?= =?utf-8?B?a0lidk92M3FsUWI5RE9ZZ2NnL2FlN09NZ2pVenRQNDJxTktPbTJFRWczd0tL?= =?utf-8?B?VGxORnByQ25Yd250YXBaV3E1RGtjazhZemNLM0JISmtWcDRpMHlldG1SYkJx?= =?utf-8?B?NTJTSWc1YUdWYlRQUXg0QkhNVzFnYWhiQVM5ZGgwTUIzbThVc0J3MTAycWxs?= =?utf-8?B?QTVJbWhtbmo3QS8wSEExczJzcWtxTWY2b0xWVDcvTVNzNGh4VnljMXFqaTRk?= =?utf-8?B?QXIwTno0emY4SEpzV3hWY05tV1VZVGRhWUIyMjUrNHdKeDJXc0R4K1JKbUt2?= =?utf-8?B?QjhFQ0gwbjdjYnFNczVhei90S3J4KzBCeUxMTVMxbk93Zk8rdDZsUXhPTWI3?= =?utf-8?B?cHYxM2hySTAvMEZUWkphWVJwZldJSG9nWjlTRkZlOUhQZUFGOFVvT2hLU25R?= =?utf-8?B?dDBzOUNrRjRaRVdyeUNXVDA5UThGbDJjQi9iQS8rV1FTUXJiclhDcnROWVM3?= =?utf-8?B?UmFpajZ4NVlCMjdrK3A3WHZvbGJCYklJdUpScTQwSCtJY0RJTllmWERBd1B5?= =?utf-8?B?NVBVbjZtMjZnVWpHVkJYSEpaN0xRVFhWaURCY0lYYWZpTFZlc0dSVk0xZFJ6?= =?utf-8?B?S3ZIQS84ZU1QUTVHazhhbTlHcGFVKys2emhUdFNxdnZoTW9JS2FMZzZ3K1Qy?= =?utf-8?B?VFV5TndGemV4cDdMSndaK0xvbWNrK2JsL2I5Q2kybTIvZUh5T21QNjhvNDJu?= =?utf-8?B?TXdiSTAzaVdwK09wMTQ0aGFMT1IvUzd4SlcvNUN2N1B5alVuOVIycVFNZk5y?= =?utf-8?B?NW5SbVVZYjBpMnVsYS9VampqREZ6a0FaOGMvaGhmaFVKRGJENS9rWXFmQUVr?= =?utf-8?B?bkVhS09sbVcydFNEYTZBYlkyM0xqQWMwdHNxb3JSZGJySGo1V0luOTZ4cndV?= =?utf-8?B?QUdraHZvOUtrbjFnS2UxTzQ2aGtlUTZORm9LRWVDSzJwczR3bDhHd2oyR1hv?= =?utf-8?B?N2oxWE9rNFU2UkxwTEpwQmRMM3p5SzJHcGlyUDBLWTJGZndHVy84cDdzMkhG?= =?utf-8?B?ZVE1cEZMVzR6ZUYrM0V0U1FzKzBuWFVFdWRHencyRlNRWGFhdkl3T3hnZlFt?= =?utf-8?B?RjBnT3ZaTEpXbGZwZnJBNkVnOVF1NjliaVpKK2lFZit0cy8xa1h4RjRtRE5w?= =?utf-8?B?Z0FEU0lTVEFyV1g4VmxJTHNNSThWODNuc1VQeDgrWi9JT2ROZktDUG8wMTVh?= =?utf-8?B?c3hHdFJER0tubUM2NDVmNWpZOWRndXhJeitIazNBaGg4aURaT3o4Tk5BPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 259297d6-9efe-49f3-6899-08dc53f2ab9c X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2024 15:28:10.8838 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0058 Subject: Re: [FFmpeg-devel] [PATCH 01/10] avcodec/libvpxenc: Avoid unused-variable warning if VP9 enc is disabled X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Andreas Rheinhardt (2024-03-31 07:30:26) >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/libvpxenc.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c >> index 635cdf7a0e..bcbdc4981e 100644 >> --- a/libavcodec/libvpxenc.c >> +++ b/libavcodec/libvpxenc.c >> @@ -49,6 +49,9 @@ >> #include "libavutil/opt.h" >> #include "libavutil/pixdesc.h" >> >> +#define IS_VP9(avctx) (CONFIG_LIBVPX_VP9_ENCODER && avctx->codec_id == AV_CODEC_ID_VP9) >> +#define IS_VP8(avctx) (CONFIG_LIBVPX_VP8_ENCODER && avctx->codec_id == AV_CODEC_ID_VP8) >> + >> /** >> * Portion of struct vpx_codec_cx_pkt from vpx_encoder.h. >> * One encoded frame returned from the library. >> @@ -359,8 +362,7 @@ static int frame_data_submit(AVCodecContext *avctx, AVFifo *fifo, >> FrameData fd = { .pts = frame->pts }; >> int ret; >> >> -#if CONFIG_LIBVPX_VP9_ENCODER >> - if (avctx->codec_id == AV_CODEC_ID_VP9 && >> + if (IS_VP9(avctx) && > > Weren't we moving towards getting rid of our dependency on DCE? > I recall some discussions about this in recent years, though I don't > remember if there was a consensus. > This patch does not add any dependency on DCE, because the code block currently #if'ed away does not contain anything that would cause a linking failure with a compiler not performing DCE. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".