From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id F36204CE70
	for <ffmpegdev@gitmailbox.com>; Mon, 14 Apr 2025 20:02:24 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6925B687CB6;
	Mon, 14 Apr 2025 23:02:19 +0300 (EEST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05olkn2010.outbound.protection.outlook.com [40.92.91.10])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4E56E687BCD
 for <ffmpeg-devel@ffmpeg.org>; Mon, 14 Apr 2025 23:02:12 +0300 (EEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
 b=uSGKVXFB1RRhoq7nIw38n50JJeg2qV6f30y5uffi6j9rT8nmB+LeH7AVoUI8dQoEhp0tjHVg748Gr2ZyMgHg6UhV8OJnZdT7E/++XBp6KrOinCPDf+MiFh2P7fC3G3vdAHHELMQ60wz6+Y8I2t5tpN4CzsAcMVMPK9s1f0LVG9i8PNIX61VGSkxJ8Eis9zICTvCT4Ze3LhR3B8Fjv0yJ/yAhg3WlRSxd/8LTQcNI9vw1NPxi7NDWeae/CggMS0+Ez/XjImr8tRergUL91Gu7RP/EK3dEjPijh7UK2m3IUwYYz9apY1sKny0xncIhBpFc1HyxWx1fGQJUakO+yR/AHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector10001;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6St218JcVHvmRRfHYwWGafsWCRXQu0c0uFxBW1nvFY8=;
 b=kO9tM9ftDt2vgA66VIhV8zrSRvA1Zri+6xYx+D8QmuZn7m1j3OhXSVv5WSY7V22pS0qK6ZFNOHB3BXxe2dvhOU+v/pYmOq/15vBTvuagixizPIcMPrQSOvJ520YE1f5PN0pWXpavHttWf2E65EIF/Z4jkSaReykWhhBlC8hgTjU4VMuNtR23xsQgLzP63WlDEx7z3IY0UlDtMkrGp/u4TH1HrKUPSsipbnTFJGBbFqNZwdBMXjqNkAL7joJpKr4YGAO5f0Emu0e58a8Smm3kmZj21/9rprFP9QufeNHhff5frvzPnJtoBwWkaRK/5fXHG0nt8sT7zFzNdpE3TkOO7Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6St218JcVHvmRRfHYwWGafsWCRXQu0c0uFxBW1nvFY8=;
 b=LIA2LxVBFz70gwJwWzChdKyi5Lt/t4xLQr9zUMDv+M2+IqXxvgrjBz3yEl0rN4BcYaFbwixvrX7lQ+CqeyfRbYKv2KXE/9twj5ZxK8Z163V2uBCKyp08piYGXrJjm1a4F3ymMc2A8p42j/ohCM+iXOYPLUI8OIhyI+d5dr3L2/+nhMVhU3vqSlCUTWyY8UXZXIg3vsKf8r63zhIg4q2AX/Bfc+z+HdiuzcGkL8z+2vSvkgGuiPNoMCCOUWrZGDMRyzym/k5lc4qYkE30IsYUN894Taurye+LFxa4LM18qRkYjBR2irNebKdhaQgx5mVjun6OMLCdawuS6aSmbypD3w==
Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17)
 by PA1P250MB1068.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:465::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.18; Mon, 14 Apr
 2025 20:02:10 +0000
Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
 ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
 ([fe80::d6a1:e3af:a5f1:b614%5]) with mapi id 15.20.8655.012; Mon, 14 Apr 2025
 20:02:10 +0000
Message-ID: <GV1P250MB07372355826C0087EDBB80248FB32@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
Date: Mon, 14 Apr 2025 22:02:06 +0200
User-Agent: Mozilla Thunderbird
To: ffmpeg-devel@ffmpeg.org
References: <20250411131205.718305-1-gseanmcg@gmail.com>
 <20250411135222.720908-1-gseanmcg@gmail.com>
 <CAPBf_OmuuvTztOSa00q3yM5CeSFh1G5jL+MYPAUsOHn_+QcfXQ@mail.gmail.com>
Content-Language: en-US
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
In-Reply-To: <CAPBf_OmuuvTztOSa00q3yM5CeSFh1G5jL+MYPAUsOHn_+QcfXQ@mail.gmail.com>
X-ClientProxiedBy: FR4P281CA0089.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:cd::18) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
 (2603:10a6:150:8e::17)
X-Microsoft-Original-Message-ID: <e4131acb-1974-4db0-b174-d1ec037f3337@outlook.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PA1P250MB1068:EE_
X-MS-Office365-Filtering-Correlation-Id: 3f8833d1-c804-4625-8828-08dd7b8f3dda
X-Microsoft-Antispam: BCL:0;
 ARA:14566002|5072599009|19110799003|15080799006|7092599003|8060799006|6090799003|461199028|440099028|3412199025|12091999003;
X-Microsoft-Antispam-Message-Info: =?utf-8?B?OHRuNXIzSy9XTUpwdVU2VEdDWUNpMk5jNFlsUXN4dHk3TjZ6Y1VHN3pGaFZE?=
 =?utf-8?B?ZW5FUjF1aExDUnprWk9EMlk5Q3pYMkJSRXRWanF2Ti9qMS8vRDdvOWMyR0ZH?=
 =?utf-8?B?R2pZb3paZ21qQXdlNzdOVWlYMjkvMWtzMTc1aTZPS0pzSEhZdEJQcDA0dVJH?=
 =?utf-8?B?VEQvRno2bk9lSXN2eVltVHQvU1FLd0Mya2M3Q2VpRFlvQjhCYmJrQ2ZFcXZy?=
 =?utf-8?B?YndnUGJBTzg3aDBLUUN2OVhMZE92Y3pPeTh2UEZDdGVIMVNIbFdFZjhidkZ5?=
 =?utf-8?B?T3JKeU1aNFNQTHZXd1lOc2FEWTBWemY2ZjM4alJ4NHZGYUs3QzI2enFOeWFK?=
 =?utf-8?B?bUhqRGR4cHpUemF1UHBLTWRjc2xncUhBNzZLRUF2d2ZVKzhXUXFuMGpseWFq?=
 =?utf-8?B?aHpKcmhURlpGTjVEN1l5WFhaVEs5M2hPamttcGlxc1QyRUw4OGRIQzkrQjJW?=
 =?utf-8?B?SEFFZUVZUlA0MTBQazVTQjZiYmVYOWJhd1FYQ3JiNDBXelhYbjkwN2pBS2Zk?=
 =?utf-8?B?cFV6eHFBdmVZRFRDRy9TV2lDOEtTbkFTa1NIZHlyTitFWG5SRGVkeENEZ2gx?=
 =?utf-8?B?cjhOUEZEWDFBcjJYcW1vTjFIbEJjVi9zNmdzZ09hY1FEcDFJaFF5UDJ0d3F6?=
 =?utf-8?B?Qm9JN3NVYjF4V1R1ZDA1dmVPMTBLVVpzR3kxNXhIQkc5S1pTZGh4ZFBrMnI0?=
 =?utf-8?B?Vng5c3NzNlZpbDlQelk3WVB2NSs1RGU2RHdoOER5OGFDL3d5SDE4QldkTENa?=
 =?utf-8?B?emI1OUpPclpwWHRZY2grdUlUSlRoS2xoWEVEbjFnUjZVbmpQektSYVZpOTd6?=
 =?utf-8?B?Qzd1dUtJTWlaQ0RtMFVuNjd4WXd2dEhRSkFSNDBUTHdzZjBLcHVlSlZVaTQ5?=
 =?utf-8?B?NHdkMGc1bWZ1NEI0eEFWcTZNcVV3ODFCNytyZk8wbEVLMGNoak5BeWFwNTlJ?=
 =?utf-8?B?UkVZWVMyM2pzbU92WEtYVTFtRXVBWmN4RkMvaFN2NDBISmVreklEdHJISTFt?=
 =?utf-8?B?c0JFNzJPRkJMRk50clFheFJkMzhxVTF3UDJGM1hTcUtFK0UyYUJlVGtsSTFB?=
 =?utf-8?B?SGVtY29pd21NNWNuSmc2ZGxES25LSlZwZmgrcnowMTl2L3hRVFFMS1lFZE5H?=
 =?utf-8?B?cUZmcC9sYXNjRURaNStLN3JYbklFV05KZitEblEzbURCbnFqY0NzZ2RiRStj?=
 =?utf-8?B?ait0dkk4enh1V0FJek9wR2l3SEVkeUdRRHpGd1U0SjNPQVNBMTYvc2ZpS3ZN?=
 =?utf-8?B?OGs4dzQwOTJ5OXYrVjFQR2NWM0FpNzlLcDNhNm51Z3l3TFlpTXllcWUzMjJi?=
 =?utf-8?B?ckF1N1BHV3A1OXp2SzBOYlRwbVdzYWhOb3Q0bUF1RGlsbDJXVUJXQytJaHJo?=
 =?utf-8?B?eGpwUmUvRDZLczU0VUhIUjhWWGk4WG1OU1VOMGhma05hZWRCYnRZVS9zSEt3?=
 =?utf-8?B?bnptNC82bjJIZGNPTWlsTXNkbkJsdUpEelUrQXI3TUZBcGx2dHdxSUNnNmFa?=
 =?utf-8?B?VzAxWU1YMUM1S3VwWVhiZng2aWF0RnRHTHpGRXRzSTNDVDJLZXF4bk0yTVhW?=
 =?utf-8?Q?dLqYeL+NdWQZlaSEWCzfnb5i4=3D?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WW9LRnExU2NSblFxNENnNllzWWUrYmU3MXc5SUwrZ1hVbE4zS3VRQWJzdHV2?=
 =?utf-8?B?M2M5ZDgxZjh0WUNIMW96YnA3aHVuT1BKV0VDZWJFZHNQNE1nVCt5alVhR3Y5?=
 =?utf-8?B?bXB3cjhoQVphTmc5cWE5NFV1QWRMeUZLcWt4U0duOTlVekt1aFVLbUpxZkdU?=
 =?utf-8?B?aHQxbmVNRVc1cy9VSkpCblVmeC9BUEkzRDBqSVJvME1DL01JZEtrZ3lvbkZa?=
 =?utf-8?B?blhLY05HYnU5OHJ1VGI5d2NOV05oQ2VuSmdLQ05tUXp6ZDJFdjMyeTVBU3hU?=
 =?utf-8?B?U29DYWV6VE4vWldHa0Faa2FucmlPMWI2aEVQVWhiWnhMZm44dTdaNitRanhp?=
 =?utf-8?B?S2dtaVkwN0IzdUVROU1henJrRlZjSnRDNTNyc3JndUhCc0tIMUlhN1NaUVRD?=
 =?utf-8?B?Rk1vMGFIdEM0M0wyYW9iWXQ2SEFBQ291VlNLM2pZT3hVSlkyRTFjWjk5L0ZX?=
 =?utf-8?B?dmdWbGMrczZneDdxZEhtaWM5VTdHK0phUkxNZk9NUlROQ2QzVC9OOWtnTDVL?=
 =?utf-8?B?NzB6Ny9VRnJyZHFzcXBWaXdDYTZGT2Y5VUwzLzB4Mk13ajFISy95WE50Zzh3?=
 =?utf-8?B?bzVVM1lPNVhYQldVdXRYc2x4SWlsaDY1elpRKytJNUtzMGFNM2xHcElqZjNR?=
 =?utf-8?B?V0c0UGRTU29hVmVFbm5KRlRpOUdNcDdDeG1WTXNyb3A0Y05jYmplQTRRRlBl?=
 =?utf-8?B?RytBQU1idG1kU2JCVVRNSnBFZ2lHODVuS1g1OXF6UmJPMWdWVTZvc1gwaElo?=
 =?utf-8?B?SkdjTEFqbTBvdi9qZGZWbWswcHNDalh5eG5ROWJ2K0Z2VHpkZ2tRT2p5SThX?=
 =?utf-8?B?aE5EOUVIODh5bFVRTUxwbEN5dDJmeFhNaFAxYWw3ZS9MK0xjaWdHUitwRll2?=
 =?utf-8?B?Nkdsb0pGU09jWUIvY0drY2JXYjZBZVh5ZXo1U001NUhpM3ZCSTFIZWFadExH?=
 =?utf-8?B?bnlZQ3JDa3RXemhFWHVvc0dtL010WS9Nd2p6VEIvQXF2RmlvUEFTL1E5Um5j?=
 =?utf-8?B?V2VBR05TZTd5YlJMRllYcllkaGxRSzFiR0paNllxWUlWS0VWSXpBRElHRVhF?=
 =?utf-8?B?aVBQQkJRYVV4WXRXVGl5UWpidFlicVpBSkZPQVlTV3NGN3orRGVYR2FVS0g2?=
 =?utf-8?B?OXoxbkhYb3ZxYms1ZWpLaFJYVzh5NzQycjluWnhqc1Q1cHZ0eTNtTmVXd2lY?=
 =?utf-8?B?bmNkb0lZSE43VllRUTVhTVJ6Q0dRbXM5bmxnbXhnc3NMYzdLcjF6SjYzRlRS?=
 =?utf-8?B?V3lzTHJlc3YyN29ac05Zd1RHbXpBbXcvcGNYdlhvOWtVaU5iYTVvY1dWZmVa?=
 =?utf-8?B?RTVkYUhhOS85MnFyd2c2L1FxeFhmb00zWkNUTUl5RTFHamlEVlYxT2kybk9Z?=
 =?utf-8?B?NFBoa1RqSVNpTThVUHFaTHQrUGQvUC9vOTVuVDdXU2RMZHg4cE1lQzdVdFI0?=
 =?utf-8?B?ZW1Ba3pQUkwvNjhiMG1KeXQ0ODI1ODczVCtvT3BGL0NKbkxURE9idW95NjJR?=
 =?utf-8?B?YXNsbGVsdXVCdldTS3FESHFsdUxRU0R2QnNUaVpJTStiYytJQlNhRDVQRXow?=
 =?utf-8?B?MFY5elg3N1pLcmNxdm5VdEdlMHdTK2RlTVdjMWx4SkJ0SytsV2lsbFVybnF2?=
 =?utf-8?B?QmdNQ01TSEo0VjMxeUc1ZlRHSFYvQlJIbGRUOTZkaGRSL2ZqZ1BIcU1pSGVT?=
 =?utf-8?B?eXhqSXhtUGQ3ZWxiTFhPSGtRUEVXY3VUVnFBWC81Q0NPN2RtajYyL2lab2Qx?=
 =?utf-8?B?N0EwOG5nUE11Ulhlek82TVZ1eHlRT0RUTS9Zcm1qNysyYVZGMzBEa1hHeG9N?=
 =?utf-8?B?dEVDZjNqUXRPU0hBQXJyQT09?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f8833d1-c804-4625-8828-08dd7b8f3dda
X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2025 20:02:10.8407 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1P250MB1068
Subject: Re: [FFmpeg-devel] [PATCH v2] libpostproc: deprecate the AMD 3DNow!
 define
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/GV1P250MB07372355826C0087EDBB80248FB32@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Sean McGovern:
> Hi,
> 
> 
> On Fri, Apr 11, 2025, 09:52 Sean McGovern <gseanmcg@gmail.com> wrote:
> 
>> It was left unreferenced in 1f0948272a0fcd0e4947f629b600983f3338c02f.
>> ---
>>  libpostproc/postprocess.h | 2 ++
>>  libpostproc/version.h     | 2 ++
>>  2 files changed, 4 insertions(+)
>>
>> diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h
>> index 5decb7e8a9..7010c2b51b 100644
>> --- a/libpostproc/postprocess.h
>> +++ b/libpostproc/postprocess.h
>> @@ -87,7 +87,9 @@ void pp_free_context(pp_context *ppContext);
>>
>>  #define PP_CPU_CAPS_MMX   0x80000000
>>  #define PP_CPU_CAPS_MMX2  0x20000000
>> +#if PP_AMD_3DNOW
>>  #define PP_CPU_CAPS_3DNOW 0x40000000
>> +#endif
>>  #define PP_CPU_CAPS_ALTIVEC 0x10000000
>>  #define PP_CPU_CAPS_AUTO  0x00080000
>>
>> diff --git a/libpostproc/version.h b/libpostproc/version.h
>> index bcbdd210c4..5a272630bf 100644
>> --- a/libpostproc/version.h
>> +++ b/libpostproc/version.h
>> @@ -43,4 +43,6 @@
>>
>>  #define LIBPOSTPROC_IDENT       "postproc"
>> AV_STRINGIFY(LIBPOSTPROC_VERSION)
>>
>> +#define PP_AMD_3DNOW               (LIBPOSTPROC_VERSION_MAJOR < 60)

defines like PP_AMD_3DNOW are not part of the public API and therefore
use an FF_ prefix (actually FF_API_ prefix).

>> +
>>  #endif /* POSTPROC_VERSION_H */
>> --
>> 2.39.5
>>
> 
> Did I do this correctly this time?

You forgot the APIchanges entry as well as the minor version bump.

> 
> Also it seems a bit much to wait a year or more for this to be actually
> removed. Can it instead be keyed to the next minor bump, or is this against
> some guarantee we give our downstreams?
> 
Actually, you should bump minor with the deprecation. And yes, this is
against the API guarantee for our downstreams. See lavu/avutil.h.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".