From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 317B746B00 for ; Thu, 3 Aug 2023 21:11:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8319968C6E0; Fri, 4 Aug 2023 00:11:12 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2099.outbound.protection.outlook.com [40.92.91.99]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A2B7A689E65 for ; Fri, 4 Aug 2023 00:11:05 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HirbmCa5Q40Ew6tVfP7ItuP67kPIHR+kCkxGgLl/lr+2QmjEsn7Fxr8Kn5Q6IoE+RsSUIz3OJtMNDS/tnAhHyJLvMiBstbjJbQox/z1Q9W1OrRHwA0YDf2aQWd9X4qCw3ASDd4F9WSpBImbonYEbbsukmCVC9u+UbVr2pdqfbGXmJHg/6CPoLV+Y5Bd6WcrNUWGckw8NRqAoecDKQ/EBjRzdttR9qtlTi8i4RyyT47YUHCtp4CKL3ZSmQOCty9fTybJRtVgFOwPLrCnXNg9caSDeujzHlBCQvjGqKlbuQ1D14SPz5cIo0B+C9NQHA4gaKWa87zeWYrL1KkJaIR/DyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P8enfyaf5eJGi0GNQNXOBafJFAbJAewi/Vf1Pf1a1/E=; b=kIfoZEiU+33IEV7w62b4zmCaQPprL53zY+7xv+CvOjrcDdeJmtFu7cHW4kZM08SeYwntW/keRERZg7BCdYSA0kweGjBevVrJtGSMxYLs9xHIlSSD9pobsTBboAWckyHeDoQQuAtkDD0BD4vIn4qxZHr2vv6u5S9/TqszU78Ly4rWdXTuy5nVL49HJfjXM0eOJb3BWDuokaZICi59aXnFA5f4VPGfR/sMJ+XoaiSc2ZiSOEJjK9BVnoHGw3re/rO0GBcznxd8gDKMnR39DSUOxjCt2cApx7JMFaXzXdX1k2U6KrJzchKeANZ48HoSAEasnFnzJCEoim/1WAhxYw9DSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P8enfyaf5eJGi0GNQNXOBafJFAbJAewi/Vf1Pf1a1/E=; b=VVSTWSiWlcuOTH6C9Bfkhr60MD8sJfUeRGO2+TJKeD0bA66UVnNBeVcEs18vzqp981ttPlmFTSq3C3suGQ5BaIctEnqbJAXQKqpBuUMpi+iQBygdAy9kSISdwi0EeLwf0BNE+hCiyzxnYvB9Zq0CXEW2I+0Y8pq5lIQ7kkDqlFQBcx8WTD/p4BITNNf0dgRKMGPPAeovomBqCQsRtt3Nwu504wJht0LNpJZiXT/IXage2HVr2mIDKOUe4bLI6e4UGdDp5NjGCcohMIaMGYRW0vHaNCpPshLH2279DJs79UtvQkMhxOngoraaqvI1tFg8YXcQdjbyyOVZhvDE/bxU5w== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS8P250MB0006.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:359::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 21:11:04 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4d3a:7ca6:cf28:9e8c]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4d3a:7ca6:cf28:9e8c%7]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 21:11:04 +0000 Message-ID: Date: Thu, 3 Aug 2023 23:12:16 +0200 To: ffmpeg-devel@ffmpeg.org References: <6561CC23-7B71-4647-870F-C91D46144AE5@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <6561CC23-7B71-4647-870F-C91D46144AE5@gmail.com> X-TMN: [cXnk8j7E6hl18MuRnZxUZHu1ALPrpzZf6hB6NaDQEio=] X-ClientProxiedBy: ZR2P278CA0066.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:52::20) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS8P250MB0006:EE_ X-MS-Office365-Filtering-Correlation-Id: 64915301-b847-437e-60e1-08db9466255c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mcbv9pEUYXUPbW0HZlgLgcnbaWwK0z9mSdaOxGjrrs94zJeEItSj0fvseeiAp2ibwsOMXUIZ/DPggWYTgu6HPdwkcUqVKIz2xoMfS0iVaT2Wme+Rc49k8DHQ3/JU5vvpQ3rXF2S8pVPX0XVODE2v9nKGxglGzgR5hCxAVkEx2XR8XE/D7ot3WJPyqcwVyeRWRNJpDtkuafMT18B6Deo5FELDSqrvnPEBKGWGPBcC5qQMONsP9yKbpqmQIbPmDqpsMQlG2NcOb/TDgI9x1nOauG7vS1W07KDNAWh0H2Z/iasVFqn1W9lJmbxF3jzHcmSyA+hTYimG+LbjqzBTlW+6KwaFPLCupWg4FJk3Dna+EmHfjb8gZxs4+dw1Ae/qFOfIIsnSj6YEUjcxfujC9Gcynrh8VfrhooZ3MHjzaOiYaTKLfKrQeC+ycK/Tu0jKus9URU37SxDpOjJTE1K4upN3MfrggN0Vq+w8qPN2jM+jLkDVPHO+27oXXu3dnL72br0FD4/0/9ZsBPJoY8Q4sWW7ollXIRqIPmLvfXJlrWxpP8HKUk0v4QdJH4O2YFSp9csL X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXhHbXhLTmxYYUxONzhua1BENElLcWh3N2w5SWpyUDlIM3pLVmt2ei9SL0t5?= =?utf-8?B?OG84WGJDOVpIK2pBbUN5aGRGNnoyazU1UW1nakZQUTg5UzJFL1E4M2dHTTRM?= =?utf-8?B?R1Z2TXhBbGxSOTVwMEs5NkVHZ2RHWUpDUkVXTC9TejViNFg4MmI3dG8rMkNp?= =?utf-8?B?QlEwSlJ4dzU1Q3ZXVVVFSTFYMlFmaWNpT29WRkZXRm5XNDFYRFgxVWlNaUUr?= =?utf-8?B?RWJjTjVwb05RSjVNek1VWnVjMjd0VTdTRWU4RUdnV0RxSkZYaFFTbWNPVXJx?= =?utf-8?B?SDlmam54ZVduTk1MaUUreWtyU0xydnE1SEgvdEtSNkMrRVNDOU9sem8wcXhE?= =?utf-8?B?N05rWVZTdHQrTS9Vanl0ekVEYTFwYjd3WXFPVjY0b0RxeWxqaWhNMFE1ZGZJ?= =?utf-8?B?WEZabE1UTTJFREFJQWc3QmtCVTF3U084UjQzYXRBK0JvQ3J6TGxoY0cvZGMw?= =?utf-8?B?czV0RVhGVGRITmhnNko0OExxT0c0Um5QS3lEWnZHa2Y0TmorS2xFUlBKS3R4?= =?utf-8?B?aG5kcGF1VFVpOTdzNkxmeUJMajZkNm1iRlhneWREWXJrNDNlcCtZaCtPZFk1?= =?utf-8?B?QmQrWEZyR1NsNmEvdGhja0J6cWlCZzJwYmZFZE91ZmNCK2ZWbngvOE5PTm5Z?= =?utf-8?B?OS9VQWVnRWozc2xkM1JyLzVDaFhGZmpxTkh5N3JjcklKaVFiMXJyOFVoczR1?= =?utf-8?B?R2w3MFB1aUNGV1IrcFJwVS9WU0QzSGhBaW5BYVR2N0NzNGl0cWQ5a2hsVU5W?= =?utf-8?B?Uis0Q1YrTW5nKzVxVWFJcWtMaXhQQVdKMmNzMlJrejNWNEsvZ1cxY04yWU1X?= =?utf-8?B?OTh4d2hZTzRXdlhYN1VKQnlPclN5V0taZTNiejA1Z0FaWmdsR3R1VXk0bmxp?= =?utf-8?B?REJ6ZHAxMUV5ZUJmN1dRZ0dOaDEzc0xaZ1VCR2VoVHZCUUE1TVZiT0dyRGFG?= =?utf-8?B?MDlTNGJMT29ORHB0UkJwelA5enMzYy8xUkdnM0pEam9YSnhJakNJWFVlSjhO?= =?utf-8?B?Y1BITEF0enJCMGdJeXBuKzFsWnRqV2NseWt2UkdWRS9kQjhLTDZPQkM1R285?= =?utf-8?B?RWtWOWtEeVIra0ZEdUgxM0RlSG1QK1FJTFlpcDBQSEswdTk0QXp6LzkyeWtZ?= =?utf-8?B?MElkRkhHK0Jna05rRE9vZnBQZ3M1ekFqOWtqYUNzeWtOb0lZTHB2c0tIaVdB?= =?utf-8?B?aC90R3AybkZWZm1FeDFldElxaUpOS3NySW03dldxWWhEcGRXREM2dmtwdFVR?= =?utf-8?B?YjJpSW5GdERyMGZIYUdlWFQxMGw0Q0NYdUUxaXIwRXJQSG5kTllUd05TRFNJ?= =?utf-8?B?T1poejBzNHJJUjJOdm5pQ1k3NWlsZlF3N2xEMVhweHZlaXhFYU9NNjNld1Vv?= =?utf-8?B?cGk4YU9OYlFUMDhLK3JacmFmajAvTEtkMmVMd2czM2JmTEt2cWdEcGlpUmtq?= =?utf-8?B?c1YvSDlEYm1UU3pGMU9HVEVzVTZTMUJZTWxWOStTUXluTW0rTE1XWDlhT0RO?= =?utf-8?B?UnplaVRNekR5LzFMVEVBUHg0REdrYnlDdlkySDBjWVhXckJKWExrN09Oc3NK?= =?utf-8?B?eVhJTGJtQUwvSU5QdzJEL0trbUJoak1oVVpxYnkyRDZWSHliUU5oMkF3SEor?= =?utf-8?B?ZUM2Y3ZBUG1UTU93a1liYVFHVzVFU3g5Q29IcHRPcEVNMStJZ014U0d6aitT?= =?utf-8?Q?DGyfnDeiTwxtA9KkRxUv?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64915301-b847-437e-60e1-08db9466255c X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 21:11:03.9719 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0006 Subject: Re: [FFmpeg-devel] [PATCH 3/4] avfilter: Deduplicate default video inputs/outputs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Marvin Scholz: > > > On 3 Aug 2023, at 16:33, Andreas Rheinhardt wrote: > >> Lots of video filters use a very simple input or output: >> An array with a single AVFilterPad whose name is "default" >> and whose type is AVMEDIA_TYPE_VIDEO; everything else is unset. >> >> Given that we never use pointer equality for inputs or outputs*, >> we can simply use a single AVFilterPad instead of dozens; this >> even saves .data.rel.ro (8312B here) as well as relocations. >> >> *: In fact, several filters (like the filters in vf_lut.c) >> already use the same outputs; furthermore, ff_filter_alloc() >> duplicates the input and output pads so that we do not even >> work with the pads directly. >> >> Signed-off-by: Andreas Rheinhardt >> --- > > [...] > >> +#include "internal.h" >> + >> +/* An AVFilterPad array whose only entry has name "default" >> + * and is of type video. */ >> +extern const AVFilterPad ff_video_default_filterpad[1]; > > This should probably be a Doxygen comment. > Changed it and the audio one in patch #1 locally to: /** * An AVFilterPad array whose only entry has name "default" * and is of type AVMEDIA_TYPE_VIDEO. */ - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".