From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 70DE34C8AA for ; Tue, 10 Jun 2025 02:58:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 0690668CF7A; Tue, 10 Jun 2025 05:58:37 +0300 (EEST) Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02olkn2023.outbound.protection.outlook.com [40.92.48.23]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id AAB7A68CBBA for ; Tue, 10 Jun 2025 05:58:30 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OnqPHiBoUYhEF/hE/PCd74NkY1BuxM28qNPyhgu4a3BYinF2bYfrRSlM6khYD1U6GTLC9t15I9ArVPLuKU92sHpktUQCTz4uPK914YNgWfozCsL7K831VBNOFdtVpaNV43KgcSrVydSFfDW1DFa46Ojts7NJhQlOWeAb6aJk7KTwCLdZDqQBT4p6WBcctEEU8QmaiM4VdFiEu66YegjkaSKeyv8L0xBGPllA+muN4pKe6blI5oytjH4eJsV6j3UKcbGvrZIBEoe6a4nb+tLu9Fjr8wZmt1tnqVKUx95l31hrjq7AjW3dO65eZXjB75I2XG3R1/SzodAMcSx7767rrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6tNgz9f4BNCHWhKfilq0kevxzFF1sCLo8nLQxXyR3yg=; b=AkAhOkExx7lAmzEVm9a5bGnnTe5zG8TJRgWO3M2qiJZ2w+u0M+HHB5GsoE3+cgcu4v3QrQNwxqvGhGLnJAriS93iwCMrx42XklRMpSwP5DF5CD9M6ZmPrzzjXAYEgZBldIsb1MjMJQYkO3bZECQKrw+fdz9n5BZMyUn9avqJTM+kUJVLzzKJEubAYHKEEFR5jRG+pX+TBGX/J2vIUxgB3hWzzJtQAMt9FK2aZGVy36Iz1XfljrvxBph3EG11Ie1fy5OACQ0dZWaA7/nD1so1Q+lVDSs0cfKXCSB5z+LHgTkPYIYGwFwOIhStP3uqlnFCK0nPQoEzK5MCNrXtClomRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6tNgz9f4BNCHWhKfilq0kevxzFF1sCLo8nLQxXyR3yg=; b=cWR9YKULVgGJb7m0jbaLBUs+F2Iq03jV4h4sLqOvqjM+mYUggdWPQs4rez/nbZI9SRLMfMhCupI4FvKYthudqAve4N5GKsNOS3lF9jzzny3ou+rFmLbjjjK4Lc6rPWKo9GmjbaA7v4bT6Rfz1VL25UabCK7lUoTqsGybpE8iI1bASBjdOAPLRq8PlEpNeTM63okPF4Rf9lDMcIJ74FNWaCBfbp6nVl+z1KxecDRgkvyxGnqUQNrO3xz8JedaWMJ6Yw2krOZTaThL7tDL503H5wc5mI0xKhqwDTY8TaEFBF7mCepzb1UwIx0vephfNbNPbqiiAfw0KFCdcQc/zbkRtg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PR3P250MB0113.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:170::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8813.31; Tue, 10 Jun 2025 02:58:29 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%5]) with mapi id 15.20.8792.034; Tue, 10 Jun 2025 02:58:29 +0000 Message-ID: Date: Tue, 10 Jun 2025 04:58:27 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20250610023143.27169-1-pkoshevoy@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20250610023143.27169-1-pkoshevoy@gmail.com> X-ClientProxiedBy: FR4P281CA0217.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:e4::19) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <32040050-5407-4e9c-8180-3caf505ac75c@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PR3P250MB0113:EE_ X-MS-Office365-Filtering-Correlation-Id: 681c9726-2053-448e-cc67-08dda7caad2f X-Microsoft-Antispam: BCL:0; ARA:14566002|19110799006|15080799009|8060799009|5072599009|7092599006|461199028|6090799003|12091999003|440099028|3412199025; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RzZsb1RpU0k5V1pXaGtwUFFFUndPdHJRdm1lSHd5MXpxbjhzZm11QXpoSWlV?= =?utf-8?B?SnpqbStKdHRLNWtXektiTU1VVHRTTlRFS1ZPdDI2ZlZiOTJ0eE1qelRtbmM3?= =?utf-8?B?MEVKYURpdjNVOWdUY3hoanBPamdFWVUvbm56eXlzVnhIR0RRK3IxbkdwdkpN?= =?utf-8?B?cFMyM0J6bGxYdG9la2o1SEhnV1BiQ3Q4dTR1UUgzSWdHUWFlZzNHR3o4K1Bq?= =?utf-8?B?aW1lQmtwOUV2Q1BIYVgrQmRPRmNxOXhLR1R1R2ZMTGd1ZE1LRmNqV1ViaXRx?= =?utf-8?B?bmdYSVFTZDFyV3F6dkhaQVJBRTVwR25kYXl4VWhUK2xzYlhOcU5LQUgxdzh3?= =?utf-8?B?NkxEdDhEVEJoWkdEVm56KytOZExzZm44RHpianQ3MXBBdldFSDIwd2R1R3Fv?= =?utf-8?B?cjVyOFZUdHhFZVVLYnQ4VVYxNTViWU9Sdm9JQ1NKK2VvVWRDSksyMUF4UTVR?= =?utf-8?B?RmZrY1J6V3pRMjg4K25WZEZZbEZMVDB2UUE0dkgrWFBJYUhEU29NUjFVaVNh?= =?utf-8?B?OVl4U09CQXU3eUpCSWRmRVlCMEJUMTBSQkg5NFcyT2grNitqK0ZCUjVjTHUv?= =?utf-8?B?V3kvSDJJY1RGTmJLQ1B5UlhWSmVHMDZWemtLK0RuTmVCMExJd09lUEhRRS9L?= =?utf-8?B?ajFtaTZScFJnaUFXUUtkMEZ5a2dPVk12SjJ6SGUvQmlEa3MxYkJwd1BJbmwr?= =?utf-8?B?NGMzQzZxWHpJcFlPTXZDUEFNZHI4KzRMQjZMRi85blo2bjQ5My9NanVDdVBa?= =?utf-8?B?eXM2S2lOTTJUSkx4anlraDZqSzdGdWdkanNqenoxWjY0YnJKeXpkWWxFQWNB?= =?utf-8?B?K0ZTZlI1eFR5SC9hYVVIdkxxYlRwMUROSG1iSytKK3FyNlBSeExIbGpIdlFR?= =?utf-8?B?L1YrZUE3U1ZlQkxheEd3b1hrKzJQcFZuWkd0SUtrVWpsbXVESW45UTRtV2Rl?= =?utf-8?B?cXNxaElQNWRwMGZYaDhQNEFZRnVhaEpxd0dDTkU0amY5LzRjek1yUCt0Z3JC?= =?utf-8?B?K21tV2NxUExuYUdOd2lqc0xMQm9kYUkzZk5udk9Fa0VuYk5PY3RSbjY1WUVF?= =?utf-8?B?ME5xMVVHVHBNRTEvM0hVajhuYmxOalpEdHpTMFdEdStVNWx5SVFHN21QS3lD?= =?utf-8?B?L0d1ekN3RWw3U29wKzV3STh2a1pCZGRCK1k4K1NnakpQUEFsa0FVNGRXemJx?= =?utf-8?B?YVpFZEF4NUhXUldtT1F3RGdrR3JFUTl3akUvL3o3YTNSVU14bFRsbW15cVVF?= =?utf-8?B?WTdUeUJ5MDlsaFFTdExsNWlteUxTdmdzZUhkL3hDL1k0bFhKMTYxWWM1QjBK?= =?utf-8?B?U2w0MW9lL0ExM1ZBNnZqbG1xL0dkM0JnY1BIN3liSm1YdUhiaTEvQUtYQ1ds?= =?utf-8?B?WHAwSTFpblI2SG8rR1FyL1ZaanpEb1pML2dvVjBOZkk2Q3lweS9HV3lSZ2Vj?= =?utf-8?B?MzFkczBCcVFFSVJ2WjZuNllQMjZUUU1hN3BGeG5DMXBCcnB1YTE1MEhGUnlv?= =?utf-8?B?b1hONU4rVUQwbm81dFFoT3F2cnpTZ3JodmF4MGVDNUUzM1JjMGdHZVVTSlZV?= =?utf-8?Q?BnVt7dTesGS4BNbAIrry+JJxU=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDFaTExsQTJLWmZ0azdKSnRramptSjZLb1hYUkIrWWNiT0l4dlpOcWpWOHZn?= =?utf-8?B?VHlxd0VvVExJc1JqM1RHSVJkUW80eW5OdUxTbXQ4b3FDdThhK3FGQVRGS1lV?= =?utf-8?B?c2hqeWl0SUlKVko5ZFY5dG4yRU5ncGhpR2N3WE11Vjc2TS8rRnJPOC9CQktD?= =?utf-8?B?L2dXSEV2Sy92N0t2eGc1clRYWVpVc3NCOXNBQStpMVVBS2Rzbmd5NXBTaXdB?= =?utf-8?B?eEZXd3lheTB1cGplTHE1QUM0VERDWks5VE1jVHpQSDFoUExlOStJeXdHbGR4?= =?utf-8?B?NEFpNW02bDFWVWV1a2lGUGZkaFNiSHVJZFBYalFwTkhPV2JxdjF0TTRHdS8z?= =?utf-8?B?b3RTaFNYR3MvZjNXS1QzUjF1NHc1NTJYMzFrTFpIVXB2VUJDM0NQSlM1bUE0?= =?utf-8?B?TnpOTlluZkFMVGZiMTUrMFU4ZHBiMUtNWkJWSDdlZlBrSW5zL3ovNFpmQnZw?= =?utf-8?B?STErOVFYM0hTVjZEY1BkR1JCaWNYZlZOUlBrU0FsMDdWcVRTcE5sTlZTaFZw?= =?utf-8?B?b3ViU01Oa28xaWpHVlFnQzVxRW90N2tKdkF2S0VlWEYvVFVtWmhCbWpwS2VH?= =?utf-8?B?cHBMUzR1TktaVnZzUXlVNnlSaG4vQlJnZ3R0Mzc1Vkk0NHZCMGRTYUxEQS9X?= =?utf-8?B?ZnU1T3FLRWxjZTFhV1N3Y0NaQVVEYjFXZkRBb0h5SUFEMTNTc2JJVkxxaFha?= =?utf-8?B?c1VpTFYyeWhQQ3d6WVBkclI5L0p5MkdOOXRVMmptbkpRbHpiTlVCOHorMjdY?= =?utf-8?B?RWROTjloUTdiaGlBdWxQcW9sVUVuTDhYWmVEZGFJQmJ4eTFDZTU4NDRXd1NB?= =?utf-8?B?UzJUK0gwWUZBUGhkV05uVXdpMjdxT3JHbkpFVkRoNi9BS2tIRVF2K1lkc0JD?= =?utf-8?B?S1YyUTVQOGxJUkdyYW43cXcxVDJPV21iODZZRG9xbFhIV2h0NGJJZVJlQVR3?= =?utf-8?B?Zy9mMzJNNm5xMVczSFpQK21ETFRhcW1IaUU0VjdtQm5LMG5USytnN3QvbUVK?= =?utf-8?B?cDhXOXNXbVRJaFhXejdHNVFUNGlpajd6aWtwdzBqa3FJcHNTUHlHNVVOc2dk?= =?utf-8?B?VWJ3UU1GSEcrYWdWN0dWYmtQN0lKQ2JSMCthNGl6QlJQeFBLWEp3NnFJRW1h?= =?utf-8?B?NE01SlhYbC9hWFFyS0NUcmFXSE5FT3RrZHpLYTIvSnRncHlGU2J6cGNxUjMy?= =?utf-8?B?NnlxZEZLVXFxYTEwSTVzMnVlSXI4VGV5VVBqTkNNdzlBRUR5SHM0RE1ybHlL?= =?utf-8?B?dytQVlJwSXU3UnE3YUZJUUZWSXE1SWdNL0Z5OVh1SldGMWZGUldTeDdlMTdl?= =?utf-8?B?d29NUTRRV1gwdHpIN2lIclBaRkpycCs1Q1FDTUpJY0xSOXQ3UUYxMGkwYjNQ?= =?utf-8?B?OUtxM29NMlpmT3JEallrU3VHKzBWdzRnRnlzNk1PVkhNQ2s4TXBjQ0VQcVJ1?= =?utf-8?B?eDNqVlptOUlvclB5YVBOQytvQzZmeHg2YmF4d0FISTdYb0xSQlhVSm1CY1V1?= =?utf-8?B?ZFZVTk1oOWVjdjkvZ3UySlNDZGVXYjRySHQ0S3BhTDNFOW9BRmdOTC9wTnR4?= =?utf-8?B?TitwRWxLRlFKdnVzdWRsdXZBd2o4WHlmZFIxN29kT3hDeGZBK1B5QWxBTXF0?= =?utf-8?B?RDRJa1ZnK0x2MkZDVm5hMUZETkJSdHRBR05pRVdiOFUwYXJjN3VmTitzUHlr?= =?utf-8?B?cHcvZ0NkMTJqcCtWM2hzNlI0R2VYOHU5T0JtNlFZR2FPWlJ4MkUxTm1lRGw3?= =?utf-8?Q?CnA9sWshU7blzLS/gsSIRywtYA5Xdd5Ms/YvzKA?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 681c9726-2053-448e-cc67-08dda7caad2f X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2025 02:58:29.0091 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0113 Subject: Re: [FFmpeg-devel] [PATCH] avformat/demux: Fix segfault due to avcodec_open2 failure X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Pavel Koshevoy: > Fixes 'ffprobe 1_poc.mp4' segfault introduced with > commit 0021484d05f9b0f032fa319399de6e24eea0c04f > --- > libavformat/demux.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/libavformat/demux.c b/libavformat/demux.c > index ecd4f40da9..d74d51e169 100644 > --- a/libavformat/demux.c > +++ b/libavformat/demux.c > @@ -2078,8 +2078,8 @@ static int has_codec_parameters(const AVStream *st, const char **errmsg_ptr) > static int try_decode_frame(AVFormatContext *s, AVStream *st, > const AVPacket *pkt, AVDictionary **options) > { > - FFStream *const sti = ffstream(st); > - AVCodecContext *const avctx = sti->avctx; > + FFStream *sti = ffstream(st); > + AVCodecContext *avctx = sti->avctx; > const AVCodec *codec; > int got_picture = 1, ret = 0; > AVFrame *frame = av_frame_alloc(); > @@ -2104,6 +2104,12 @@ static int try_decode_frame(AVFormatContext *s, AVStream *st, > goto fail; > } > > + if (avctx && avctx->codec != codec) { > + avcodec_free_context(&avctx); > + avctx = avcodec_alloc_context3(codec); > + sti->avctx = avctx; > + } > + > /* Force thread count to 1 since the H.264 decoder will not extract > * SPS and PPS to extradata during multi-threaded decoding. */ > av_dict_set(options ? options : &thread_opt, "threads", "1", 0); 1. Unchecked allocation. 2. This AVCodecContext will be mostly blank; it does not inherit available extradata and other parameters. See codec_close(). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".