From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A3FB54B41A for ; Wed, 5 Jun 2024 11:53:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8D0D468D67A; Wed, 5 Jun 2024 14:53:29 +0300 (EEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01olkn2103.outbound.protection.outlook.com [40.92.65.103]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 22D9168D362 for ; Wed, 5 Jun 2024 14:53:23 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dQzZCYVXfqteboOsT838e+jertNRu9MXfsnW3PF/+RBk5Ss7uiSQZLlHGadfh2heh/NE/P0hNaLsdzS0GZNmIxAb3BFaHxad6Ph+sxblXtULW6iZBTjJl8HP8VdkXacUjd9Q32XTPVFEl6WCzs8UmHY7fXJSC1QqRSYeJW3lIv10nNhBKmSCKUSS824bCbg9fmZUYleN0SgWnLWUJD1Dp1JXSAUhlL2rEHUqnEaWBngvUjlXGdXXC2uoo6ydMo9+WnWNPdN97Y4UqdcHpVAf4CErcvazq8sIp/DbFJ5WufzJNx6eC5kooGa97LhfTSRWJVsC4atHiRHWO8z23cCHfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u0eKek3gYn2tKUQCsYGxl3XctrR3ntca8XM8cLOEHpQ=; b=eK2FGJd36M+48FCthSUt09DFC6u3/jeDri/LL9OD0+hFQHtbuMTAowFJ89ol5OG/hjnom3BJmySp+cON2IX556zQIn2Jz2xY9OtCH/Sy3uC9fO9Eidi8EPUmhinVHTEs60TqnPn3wX9KplQhXk3IXJqdUBpNwlehqZd/WHwTO6hP+O0pdVVCzmWuzEY8BDFoBFTeoRyF4wRGoaGpHpGY+LI9Guk/xXspuHrQHHxkQWifhA8iwzE4R/rtmC0K9h4zlIWpftpO235Cwkzo/QgzahiijhmpJ3I/ln1/O9XMDkUAMUBjc2CWLFM/67z/nZrloWE/WTeJIGMxvBlo0yAfFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u0eKek3gYn2tKUQCsYGxl3XctrR3ntca8XM8cLOEHpQ=; b=uBYU+u+vC9Uldc3DfLl9WiwbMRs9zQphq1H2Ld5DSWShAeQAHzRexsQ+8GPt7c/R8Pf0s0NO+LTthNsF76nr9pyCJOKIUS+1w0t9bpISY8+vfo9IvvQzVgk7/or+QoSFAlKmchJE7/JFBzwldWQ/tuv8/MDnmgevxeiJ5vf/zzFlYBwTyoOSQs8p9FpolAA1EQ2Ld/MRYTWv97ukWNjXVpF7RSMH1xupl/H6woC+SeGdSZNUvDDJweEHBKBZO311WSlpsvKEJCVXk56f1HUTAVSA3feWweABzlvkVgQ+MZ49OUKP9yB2PKD+pG0bjXKYLjNT1mCeAsmvLvAXT0yfkA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PR3P250MB0001.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:14c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.26; Wed, 5 Jun 2024 11:53:21 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%4]) with mapi id 15.20.7633.021; Wed, 5 Jun 2024 11:53:20 +0000 Message-ID: Date: Wed, 5 Jun 2024 13:53:19 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [hoP5SYhlHzBcLK+BAzsOMdWSIyC9ZJJj7MYLrp3p6Q8=] X-ClientProxiedBy: FR2P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::14) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <6afe4af8-f8df-445e-8ae7-8fe7ee127221@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PR3P250MB0001:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c4dd9f2-297f-411b-c1a9-08dc8556189d X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|3412199016|440099019; X-Microsoft-Antispam-Message-Info: MgW1n7TcKzNpaBbhEPgWNaXNBqL4RMGfuG0UmWErjME4O8xcbGKSH9DG/EVY02HXAXACa/8s8Gw268OclGNB6JuAvE5OcPOAbkyyPgvHdR0POviQ7Z0++ScZ6NsQA/Pp8JBxMDN0eCykPxzicGlPFa0/8mdlG+YKB0yJjKJrHI42LpmwYFKSE7ZPBwplyfkljpB0M6CVJaJWEuPV5+al95bF5XLvuI+8791dn0wszpMykZwIEGlSgn+nnURPqp8+Nmq5EShPvFAyNtVZ/IPLHXO8ZOIn6+aToAaPI2yl+bnkTy5b8kR2oK2nlfNCL8cCpdGzYRSnghChzj4SY7SItYRpc1UkSmaVKWeY9uGqbWqoib2OhDqTHdgpzDMT7fhsQeEXVuhh1e0gYSPCl7nVPA766mDhL//E9c3/PTpio5IDkH15RBh4oGSp1ELVX4cSsdIV2ES0iyxHZJe9sxl0/qnUARY1yF4Oovv/WvC6fJSbUqBZuAJCaGo51Vx1McSYMhwt4peMam7n59kTYJnVgwJ7lMTFQfSS6me76ddMZPFiCiwF5F4voxSqutTFzyw/ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RjBNVWlIdkM4LzVSSlZhMmhSYkc0cU04TW12QkFXMUVoa3c3Y2NTWVVxUVVy?= =?utf-8?B?ZkZFNDY4M1Ezc0t3My9DZERWbnFnK3VoV3h2U2hKbk9MRU1jSDNZc0htQVph?= =?utf-8?B?T25kOWxwOWhqeUhVeXAyWVQ5MVc2ZkNjWU5OamhpeDZJejlYd1hCdUxBSGRX?= =?utf-8?B?WWJqUC9DdUZQZk5ZRTREcWVmdm5HVnNzcGdORjVLNzFmRklhN1V4SUJPZTlw?= =?utf-8?B?M2p3M0hzWmJ4TVpkU3A5RG56QVBPdVYwOEs5ekZ3a0QvV09pUU8yaUE5YU1k?= =?utf-8?B?VVlrdkhJb1hwNHpIR3R5ejllR1dwRXdzN3RyTE9YRzQyamkrUlJsRllOOEdw?= =?utf-8?B?TzhQOEhYMFQ4ZTVaMzc5T0dTSTRxUXZwTHk4YUdrY2ppUVRnYVdRNTlmR0Ir?= =?utf-8?B?b2JReDFtUU9MQ3lGaUpWd1lyMkM0aU54NC84ZUJtL3d5S011ZTFzZU5rdEs1?= =?utf-8?B?alcyY3JxS1d6Nit6V0NYMHl2ekRXc3dNeVR0M0JvelNiQ0Uyby8xL2FtTTFp?= =?utf-8?B?T1FOL0JYK3ZjUW1XUURJNVBEVnBUWFRRTnB5ZTk2UnFGOFdPYU5LZHdoVTNn?= =?utf-8?B?OS8zVXVDWUFoc2xsaGRCUzZLZHVEbWsyWUlzNUJGVHdWQ3lnWTl6d0lLMnRh?= =?utf-8?B?QUcvM1V1L3RXUENYT2gzc3ZUQ3QrUUJLVFN1MjFHR054NmdzNzd3QjBsUU9v?= =?utf-8?B?TGNHN1pKbG9lMnpEcmNwcVFwS28vdG5BVWRCL0xUNWZ6S3BlVWw1d3F4ejMy?= =?utf-8?B?NUNJdHBIVnRTdjNKc0lreFEyZ3E1TWw0OWhWaTZ1TmRUUjVuZDFaS0x4K24z?= =?utf-8?B?Qm5lMG05aDJCWWdkSDNMUzMyQUxMZ3htam1BWk41YU55Wk9uTW1vS2NVM2Zr?= =?utf-8?B?RytGWmc4VXgrajVjc0QwUFZ5ZTNoVGdqUUNib2hYTXV1ZEpiMlRNWEQzK3c4?= =?utf-8?B?V2tyVStEWEVnVVBTSTZsQjBhejIvVEVSOGRxQ1RMRnMvOVpCM3FLQThpMDU4?= =?utf-8?B?dTBpZ3cwTDFJKzBPRHUvUXdOSFA2SmdFZ3l2V2dCYmN5bHlPNURIaWY1Z3B5?= =?utf-8?B?aFJsU2ZjcFdNVm5PUFVmcmpHSVNmOC9oVWJWTnNlOUZYMmsvR2J5UUtMY1JR?= =?utf-8?B?R3BDak1IMjY0YVNKSWsyZ3NsY1dLbGh0UXJRLzc5SGE4SEZYVHJSbDdoNUVy?= =?utf-8?B?ZFhhMHc3RmJKN3dqVTJtaktZUEdiczFCdWVjc0hpVzhTZ3FpVnZrL3JYRWVF?= =?utf-8?B?UHdLOGUxa3VyQTM0RWdiNHVrdjNaY2ZTVkdMb1FCVzI1UEJ1R1crRUNqV00w?= =?utf-8?B?NWhIY1lQWUVBNmMrT2N5cHdET2N5c3A4Y1M5NlczeGVDL2RIbkMrRk83MG10?= =?utf-8?B?WUw1YXRFb1I3S2VKYm9sS3RzZmhEaFpGelA4MG9jaWQ0ejVkRTBOR0RheGVO?= =?utf-8?B?SlBoRkdJWXo0TmhoSWlnVTVBNy8vMmxSZmF3MEREUklMK1EwclZybGkwWkNt?= =?utf-8?B?L1REVmFsS2todFJoTlZFbi9Sdm85bXVBc053MWM5czF5RGFwTDczbFNIRmhl?= =?utf-8?B?NzM1cWpkamV6c2xmdFJZU2Z4VnlPV3dqeHdMSXlrb2VYbmh4dmc4Nmc0aUhi?= =?utf-8?B?WUdDbWl5MHBidTZENnAzVEg0a3M0WVBQVDdRU0VsdUhHVXEwbmxYNG1jRlN2?= =?utf-8?B?VHJzUUM5UFF2SjBteTdDSGxRQUVIZSs0VFRsR0NmamZ5eHZaK0FUYWtBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c4dd9f2-297f-411b-c1a9-08dc8556189d X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 11:53:20.9059 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0001 Subject: Re: [FFmpeg-devel] [PATCH 4/7] avformat/vvc: Fix crash on allocation failure, avoid allocations X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > This is the VVC version of 8b5d15530127fea54e934043a64653859de07353. > > (Hint: This ensures that the order of NALU arrays is OPI-VPS-SPS-PPS- > Prefix-SEI-Suffix-SEI, regardless of the order in the original > extradata. I hope this is right.) > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/vvc.c | 169 ++++++++++++++++++++-------------------------- > 1 file changed, 73 insertions(+), 96 deletions(-) > Even after these patches, there are some strange things going in vvc.c: 1. There are at least 71 bits in general_constraint_info (if present), yet only 70 of these are written (the gci_no_chroma_qp_offset_constraint_flag is not). 2. The code contains checks for VVC_DCI_NUT, yet these are dead, because these NALU type is filtered out before. 3. A comment claims to need at least one VPS and SPS, but it actually checks for SPS and PPS. Does someone know what was intended? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".