From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C82B04A594 for ; Sat, 30 Mar 2024 04:21:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4588768D43C; Sat, 30 Mar 2024 06:21:24 +0200 (EET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04olkn2086.outbound.protection.outlook.com [40.92.73.86]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7473D68D1FC for ; Sat, 30 Mar 2024 06:21:21 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IfwCfySq1vpB04DsXSNoTvROlMEVZehR6Ez/r9b5xaUvxS57JI6at86ZUBArDZpnuiFGx/WnV5dGGKCT1afn0jtQZYXrQhC47n6ro0RegpwyTMSYhf/jLY7/geKiSdzSujVfQdCdoZ7sUugVAzS7kFZkf8pjkge8rjxe+DEHOmlE07gvWJ6jPGjAOuBp4WJ4Lr0D57LmS0CuAmQL4rdNEnQFRXv5I9bVY0ao6mxFiDVacXF7sAIS5tBjCoEedDNntaEAcDmEGTZMRr72zdo890Xqa07r90KTSiTRyS+HE7W+BKkCyz7m9S2r3qEYE4INpnzx54zdrRcAzNb/p1H5PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0TCUzI9YgZVxX7jLtlhsWnNrn8WhsbPVvDGgVhipz6A=; b=PpwmcpcmetGtwwjAsGh8WTh8bZBbA2ztdlULxFUElx8X75NrWOEn1zJRjwcF2hX4peeC1MpFZ18AHk3IPf7ss2wMKbF/K/F/Pds5O7q/vQiN8bWGnVwYb3h/yT1QtoNEVDOwKNgooLk/j7fIqbCNGx7q5E37drbsntY123G1XlW5Pr8rExZkCplIsvc/LDidQGz87vXYWVPT1dhSGF61JdcEF7UnuYgfz7lxIy3iijwfQFRuExcio3iVNVJzrh3wckqt0ULLlSoQqb+0bHjNP8lTSgL5NVjzcqEAgZ96/A6zIRvJTMMqy+2Us1m03bjBgfcpJ3kG+XospIgl2Fnoag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0TCUzI9YgZVxX7jLtlhsWnNrn8WhsbPVvDGgVhipz6A=; b=JD0JLj0KViItM2GkvNS9/yAHxGOk73xUp6NFe36b/hAz4pMWZCQeIUm3kIiwqKyruIFjuKFaiJLVGT+0lcMVFYqUiGHLFRU5Mu18Q2R8q0Hyn8vtFBce0ExTzPWJNQcosngLvWoSvXuFxmDMsjEhNMb2cshFgR7e6OnQ/ERUyME4BUYgf9XPXnU4+FCzMwCjWbeKTojvFx+g2fmcrztCI+sGLPJ+4ABwFnRZBpWxX+9z70xg+B80UT/Rn2j8D2j08zXlbR3KWepycBG53505B0lcDhVfSmMw99k9RQGwfWjM5wYdGB5sIqIsvTEdqTaHnp1Dv3M4/xp86u7G6Ajhrg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS8P250MB0070.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:37d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.42; Sat, 30 Mar 2024 04:21:19 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.039; Sat, 30 Mar 2024 04:21:19 +0000 Message-ID: Date: Sat, 30 Mar 2024 05:21:16 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [45YY5Qd1EUpbJiZHfj8wkzVDofIflek2rmQXRO44rrA=] X-ClientProxiedBy: ZR0P278CA0010.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:16::20) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS8P250MB0070:EE_ X-MS-Office365-Filtering-Correlation-Id: 19bda136-cdbe-48f9-5a41-08dc5070d922 X-MS-Exchange-SLBlob-MailProps: Cq7lScuPrnpFX5gNBgVui3gV5iTh+bLDNoIos2F1JubMy3PqbIcDxf3dbfC1pjb5t6ZfMsAmRy+y5hpm+lnQcMQ2+7RXXS7s1l+vjEa0XaWchq0DVX6JWLU1XNCgVkfnOrk6NxGitXBnc8uHEc7bI+69gtDqud12AgUbyyCI3GVJGMpNKukIC8DTqBIXXL+IQzTxBLvaTGbxOzXK9Vn9WGdVPimO3q/CTo33PaLOrAUiEInwMmaDTDarryFlLns+kZ9q5KmakauBnREcyR8RZFa+HQyiV9EG/BQwR/t2sn5QpqKVvJ7MWm9koeSBxWb0KxgazLQg42glnvkpPZLRhxvulH8fScrZus9fwT6DL+fVTWA8QW8nGfa59zSvXhNhxPJU8wVT+FtZXi44dyq2p06JBQ6osCNZTGlEG2fnSaWOLQ4Yrg/yZQ5I4oVt630AmY4euJWGwk6YI//Q8vs7DzjracIzKqgkJXKpKyCQagLv5+7HUdjZm9MKse1P8er2DLkbkcQsW+bPZS0SFINNbJPQzJp83tvEPwjyKHEMr/vuRh75BOd7aEOZeYFuiS7IxRbK+UtNbTZCAKt9gL7VpZuWZbWXZrFvWD+hWf7jPn0+9kEXAmeGWEcUVuCsEFZnSbPIag47rzUNGyGwVicW8/OYrt1lDOo0/6Wi4fLOy7CCNUhcmyO2Y4dMv/gVuzHZtEABQ8knlj559CMd7dAbcN5j/zrJsuefJwHbCTT9ads0HsYin8SEP0NasPccfpEpQpgxr4Dbh4g= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u89VSKgLSXtvT2GuLBJLgXXFLxTCldAL7LHJymaOWjjPRPN0Fq3wRnzd95jiUf1tTHPjmXX0nHoI15W0MyH47RiF/veeiHS4xgGUeajWteulvSa9o++zPp8azOFWUZfBeuV+Q97HxCGQsP2AjZP/6Pssmum/tSmw+7R7wofhZueM76yh1VUd0Tqc6xejOapA0dZoppYA+NE8nkXS05EoJMseXS7+L7ajkOTVEP43rexIybmHCuUiiks4NdQtrSbcw67TVxnVGaZhWojCmENw2fGUwyxYWfEEKEUhwTrUsxQ4HzlKqkdOkcpq6Iw5ZqGX3kDuEahaXe8wB2cQ95hG6SWixDU4EHiFeiK/gSzKV1UwiSyHneynZW7MmPebmcI0evlFe1HEjFfAPuux/Xncs+ijtSPDrfG49AtYVw4XQJC5u/zJlFFKv2XKgZXolCU6MSBWDlB2X+nTp6N+dsOKa1hjKEJc+o9e7gIZXfbZIzarjj1T/s5tr16qB5k1ylzllHm6mYP49jmchF3hCg2RzYTzs2LEO8H+RS3TaHc15TuP3dVvBFNiopUp1cxP9+y/ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VEZRdE1zMnlmMnI2RWVwZ29HUmFyTldMWHZpcm5CMm9TYkxZNURocmF0alpU?= =?utf-8?B?UWtBRnBTOFN6bXBSOTZGbXpwZ2NKcE9EU2x3bGJ6M0ZnellQS3Jpa1o0eUt4?= =?utf-8?B?THlMMVdQZjRWTFlkRjhDVEZRWGRQL2NpMStFOFdnOUNENk5DcjRtWEdlZnpD?= =?utf-8?B?V3NPNSswOVVLZ0dwTDNOSTZWbVF4d1IrZkJ6bmJ5cFVabUlYSENTbmZQVnNw?= =?utf-8?B?VGxadmhWa3ZkN0dpRWJvNlc4T2tFRW9xMU9DbmgyWWxTZHYyY2xQbDRsZXY3?= =?utf-8?B?QlJDL3YwL2FzaGFFWFFzdXRJNHJTeGxROW9WSzFEaFE0dUtyU1FmTDNCZits?= =?utf-8?B?Q1UvWVJ6K3BKcGlBSERRMGticnI2NTlySjQ0NWtHQkNmbGNpOFZRT0xMd0ti?= =?utf-8?B?cU1Wdktsa0QzTnJoU1VxQUMvUzZVNTQ4WEJGVEc3MjdKRXcyYm52Rm12RUk5?= =?utf-8?B?NjR0THk0dXhwdVo5alAxZnkxU3hOalYxZ3V6OTJ3MzNiOXdRdXIwT3g2M1U2?= =?utf-8?B?eUEwODBkcGQrQjYvTmRGVjF1VytJVTR4RUVQUlY2SmtCbUhVU1paa1NKR3hY?= =?utf-8?B?RWRCLzRIcHUrVTFnNUQ0RXQ0cFhEbHNTeEdpNEk4NnBHTmgwSXVlTkkwN0lw?= =?utf-8?B?OS9XVENoemJWVjI4MitDOUE0VVVreER5TmE4bG9SWDlXaXFnOE9sUnJUV01a?= =?utf-8?B?UVZjbVBScDBrWDJyM0FhTlFHb0pzeGhZYkhmRVRjUDhvSW9DcXY2STk4bnJ2?= =?utf-8?B?OTkwLzd5T3NHN0plTmZmaXpWajJhekhtV24zc09KZDBvQ3ZFOHQ2cE0vOHRz?= =?utf-8?B?WjExQkp5aFd2OGVsVHFjMGhVMVE1RmVINkRRcmV3OXI3aUxFdmlvWFhwRmIr?= =?utf-8?B?UTNtQUVVNkhnSklDUm15R0hNVUpOYWRDQmtzU2N1WHMvLzl3enFMWnZNODJ5?= =?utf-8?B?eTFxVklydVRSUGdSNkxKVGx1UGdSdU1IYldzUXhDUlFtUWNHY2VNMlc2VC8x?= =?utf-8?B?aXR5VnRFV0M3c296K0crVWRoZ3pCd3I4RkpMdXNIWVlkMWplNVNjNU5yM2o4?= =?utf-8?B?VFF4MlJqcVNnUnUza2lxTEVwdDM2c3crem1qbkpET1BzNHVQV3FwUnBId3pR?= =?utf-8?B?WTd0VFNvUUpTUkVVQzFxc1RsUnJJL0JiTFNHVFZ1NmdCZ3ZBVkJZWitXUldG?= =?utf-8?B?aVNnNmJlbUFUWUN3ZE56Mm5RSjgvU2lGRnF6WC9HdUxUQ0piaFlSOWxQTHk3?= =?utf-8?B?TjhrSE5NWTFXZ0ZIWGRINWpSZzBISDc5c1N6MjNxNDk4YUpoNi9NK2w4RTQ4?= =?utf-8?B?MzBORWt2VVhYaWJ4WEZMc0Zyd1hQeDBZQWZQdEdhUXV1UE1MU2orbTBod1dn?= =?utf-8?B?YzVIcXJoWmRCakpmLzBMeVpGaUs0K1VRUk8wUjVpZUxiVUJsZXFiWUJSQytF?= =?utf-8?B?NGdpc2t3VlM0alNpdWlUWENaNjhYV3dCNHNlSXo0R2VtM0RjRktXZHhnQUJP?= =?utf-8?B?SVZnc1gxRnJObS9FaEl0WHB1YTM0blN5cmwwZXRySC8rSnJGbTY5L0lOczJT?= =?utf-8?B?aXNiZjZXZ0VVZGx2Ni9WcGNNWElDUzNzcnlSdXhSTmt0cWgvWkwrcXJLUTBp?= =?utf-8?B?V0cyVnJQZVRqdzIraXd0MHJIRFJCVnNUVnk4UlZKd0UxS0NiSmdpM0hyTGx4?= =?utf-8?B?aWNPL3BZZloyVWJQTXpsV255dnlZTmV4QStkcWNDL3p6d1RsME1xUHBBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19bda136-cdbe-48f9-5a41-08dc5070d922 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2024 04:21:19.1506 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0070 Subject: Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: Don't free AVOpt-strings manually, fix crash X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Steven Liu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Besides being redundant, freeing manually is actually harmful here, > as rtmp_close() may call gen_fcunpublish_stream() which dereferences > rt->playpath. > > Reported-by: Armin Hasitzka > Signed-off-by: Andreas Rheinhardt > --- > libavformat/rtmpproto.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c > index 4b01b67d28..b1d73b3d75 100644 > --- a/libavformat/rtmpproto.c > +++ b/libavformat/rtmpproto.c > @@ -2917,9 +2917,6 @@ reconnect: > return 0; > > fail: > - av_freep(&rt->playpath); > - av_freep(&rt->tcurl); > - av_freep(&rt->flashver); > av_dict_free(opts); > rtmp_close(s); > return ret; I am pinging this and explicitly cc'ing Steven Liu, whose commit 991cf95fdeebc3af added the av_freeps to be removed above. Steven, did you just feel that there was missing freeing code for the buffers above or was there an actually confirmed memleak (there shouldn't be)? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".