From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 87E344AB2D for ; Wed, 12 Jun 2024 13:53:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6872C68D9CE; Wed, 12 Jun 2024 16:52:58 +0300 (EEST) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03olkn2104.outbound.protection.outlook.com [40.92.59.104]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 450A068D99A for ; Wed, 12 Jun 2024 16:52:57 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aha3usrpIWEFGYB+SB2TuE6zrjzKR1YeyLfhUvHTXx3ckL1jBUtcFl+jA/sMDUr0K8zzXhnAjTcYld8dFvr8OQNGNBRnIWV4wN1FibP0opq8L2Uv8fO932Bq6eung4ox4PxlfMTQ65TvLK7xlPVEl1UD8vfVj0Qo0+Sb1OlDLfTM/NimsGu3r4WTHu0LBGYdevESWyh2aRqVjAlwIzuQhf6YoOWeV9CqieK7yuO5NieDzzWZfh8jeHPA2kUahK/hhwCP9nz25vPekswzp/3/KK4nfyUrkPuGuhWfvo0FRlSDTDMSM8GkzppmF7vU5g6skTBsKawkrCMjZnZLMcXQ5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sWOvVLkWZb6Loif63r8nv8i8kmAd3qXp+fvusmXKNGA=; b=VomQQeV79xQ2XEoxBYs70QjijqlXyggmZ+TxDGGwkQ3UIdRGLOf5YdXRTT53t2T+mscA+uYY5aUzijk8cR2dPJ3nhJFEW4eieLz7zPqLpIhAfM4HVBpxV6bjMTB1mdULczC23mXrYkE3uvUeU/uiimS5b4EmolU4TBddB02702C2Qc1L3gdcyEgioi+FXss8+dTpGLOyEji8vEM216jJ/UfKsCqYVlcW6R94jpupFJ4AcfUcJcNvcw5tcptpsUuCSaFuLBEcNsI6p0BqIomkvgUOHjx+ua+iDZbH0L1SDbxVlNEYo1NWm9kDwnDNjN2CZjc5D0SlRFqRaddtWumN8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sWOvVLkWZb6Loif63r8nv8i8kmAd3qXp+fvusmXKNGA=; b=hyQCJBOT2nY9ODKVoQAt6RxWb/pDlQID/SGHpXWHEy7/BwQwllzcxBQ5GX8LO6dDaJFUoh+VweYPTpPYUrh8o6wrZXak2czx1f22qJULtn1cwrYDCucFlf9vOGpv7yrfGL3a4BNVj6oPTxXdMDqaqxVc17j2srPdFmzN6XzpTc3jgs2ORYcuuF7U92jg4OwCn1MAXg9Dh7jiuO+4dNCrhFSW130TYQIMmiJdAEbVePw+xA+MSMkcN/rMYdTaWTHzyu7oOBgmp7h/t5pdcSP5Ibc4HToHY8NivwO2y0OPeVpQZNoOuhKjZGMSKDZs6YgF7QH5Hpsa7qg/dHxpBw1nog== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS8P250MB0054.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:359::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.37; Wed, 12 Jun 2024 13:52:55 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%3]) with mapi id 15.20.7633.036; Wed, 12 Jun 2024 13:52:55 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Wed, 12 Jun 2024 15:48:23 +0200 Message-ID: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: X-TMN: [96A1eMqwDl+2qTsFyfOzJNJcyyogcw2gHZoQ0YUPDoA=] X-ClientProxiedBy: ZR0P278CA0189.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:44::6) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <20240612134853.2102377-26-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS8P250MB0054:EE_ X-MS-Office365-Filtering-Correlation-Id: d358aae5-ae03-430b-e92c-08dc8ae6f5d4 X-Microsoft-Antispam: BCL:0; ARA:14566002|461199020|440099020|3412199017|1710799020; X-Microsoft-Antispam-Message-Info: 7Ib9mG0z2eko+TQ+L+6HqpXQmQ9z5V8W5UteXI3R0LyadP0U/uZ8zGCE0PZP3dJxRRL74G213HgX34XLaCBGograXbBo+mML5hHJLnWtA3BvTxyLfLN2/4SHOwVL1Ii5ugqfpg2taYqO0rFVYDoGsv/1MaOFcy36BuGDiDdEV/02VdbpGijUGiUzLAWlg1xhxLg8a/b7lnxFIiFmiqYmRXypat6PStD+2IR8ltZt4aN+XkA4t9azOgCa9iX22opShb8/XiQ7QIjW3AycOGoJuzDXi+mO4/cLjeR9sOz/sUljGd4xLia3nnzrRYom/a7KNhIUvu9GuRmBg2q/iEn6q6zetDuh/W7vteH06hOPU746jgI1QLT8jwhpzZMD6ryI7DybRhV8DLs5ULwaK6dYCHi9kf9uBYtN6e4df4IW8ziqTUWZQ6oX6VPtayjrJwp6S58528yOEj8Q+fEDz39p4ikYUofvn8aeM7NJTvo5qMJH+wAKfc2BS2hzYqrvz5Y+eVbOnYCUUb1BTITr/Ddx7MT8Cd3zeHNjlbZspoqhhQHJnTBL7C/dct4KVs0f+Ny1WszRQwehCAek1TaDTbwxa6vESYILm+P2Yc6/fNMy1V8sJgi9hv6UBsKtpwhpQczu X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IzUmVnTMeGYWND8myqCYp5fa+ML4OWY/XMNYM/euymqayxjeW9qU33nMneB2?= =?us-ascii?Q?om+i36e5kj27ivG6IpKcEk49HXGmvAP+hzjqfmhvHTFOmyldUIORvSTmTqFW?= =?us-ascii?Q?AWxco5G/Bip4AGvAMcHFI0aqH62U+3b09H2mEdRTnxFFRBSQKYOdgJCxxLLy?= =?us-ascii?Q?mQJj1klnSyj+VtEWPG6Ol+uXjoEdxO+m6j1iFaJvYKcD5ZQKjZw2CE1xB24I?= =?us-ascii?Q?JjGw9/ySbLfwiTW+N1ddsnlji+/Mqr66S5PbkCo1Wt4D1rkQyqmxtFLl5mBk?= =?us-ascii?Q?kTTLajp+2TqtChXpHkWCoMBi0LMPyBOKqJ9NzGwPxRr53RJLVwcr9FnU8sPu?= =?us-ascii?Q?nLl4cDBXv5Zl0zH1txZ9TfhIU1Y5QarqIcmEcBEfT/ByXJdVPwZvWHap3rGC?= =?us-ascii?Q?QZe8xk7zsLbGVSe/j+o4ibjiVnL2fzgPGgq/s7SDZei/1eVhVJcwJP4MUYZY?= =?us-ascii?Q?snee4vGU6n209OOoKswYQT7sVyyw7xbFzK8gmqHhm+J1VISzbuHmAfUHZ8G4?= =?us-ascii?Q?MQWBgHhohwb4KOP9zyzhA93R4bJ1q+70jA/xvfnrzox2f2D7t2OG26zj6N/C?= =?us-ascii?Q?4VJckA3RJb1UizcFt+fhNeBDsUUhjmNsYp/uRdPn6APrPNazKJLowxSuk4Uj?= =?us-ascii?Q?PolqlMh6HqIu6fQupmCqwCnXsICZIRdVmxxO5SepqVEFM0Qlg/0FkmV3U7qH?= =?us-ascii?Q?qxC0rSpbmYr1j4wc8zebrmH1cXY/nM1ySb2eRwIL07a5AjS1sZLX7VAh+00d?= =?us-ascii?Q?LEx+cHpCm1Zs9bq4oazOtY8jPfFF2A/At6XJberEZix+1PeNq00xrXBOEQpU?= =?us-ascii?Q?4Xf4v3cFu2zUj/NSdyzWMmrB9udpp/UV1PiVlYurfOE0tm8U5twbrgZk54dV?= =?us-ascii?Q?dZv/ea6e9eSSPYAoZsHE1cB0DW6P/tk2XUgwFJ1cwiw62SzvahRWiZ16Sk4K?= =?us-ascii?Q?Tul0vpKJYbfWctCYuN28rFA9U6wP2B5ViC/Xsmz5WTDfefMb+574HKAzg4ae?= =?us-ascii?Q?YJe9Cr26boclsnaWIZM9mWu55WxcvzCoQcvGhINuUZf31M4s8mdqWJ12mJHj?= =?us-ascii?Q?dDneNtWGXuacwpfgnggcQeDT2eOsoQlezRvRZkWHdKXQzWaSXHYepGIbJYb7?= =?us-ascii?Q?rMElFbQXI/wScRoiRuOOrH1oIN98/FVqEWTlOY4aeL5aHfyCayoXMGiBKjVr?= =?us-ascii?Q?agRbTgkBMGhipsCVTDaFQVYMObw6ik4TUFnuJEyqRy4GZPzO6SLhC6nClXSG?= =?us-ascii?Q?IWPfmaDb4fbh+FxG3kAsVjtgnXKrXg/su2/AIeo/JA=3D=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d358aae5-ae03-430b-e92c-08dc8ae6f5d4 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 13:52:55.3711 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0054 Subject: [FFmpeg-devel] [PATCH 27/57] avcodec/me_cmp: Zero MECmpContext in ff_me_cmp_init() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Not every function will be set, so zero the context to initialize everything. This also allows to remove an initialization in dvenc.c. Signed-off-by: Andreas Rheinhardt --- libavcodec/dvenc.c | 1 - libavcodec/me_cmp.c | 2 ++ libavcodec/tests/motion.c | 2 -- tests/checkasm/motion.c | 3 --- 4 files changed, 2 insertions(+), 6 deletions(-) diff --git a/libavcodec/dvenc.c b/libavcodec/dvenc.c index f2221d0b94..c42ab8931e 100644 --- a/libavcodec/dvenc.c +++ b/libavcodec/dvenc.c @@ -98,7 +98,6 @@ static av_cold int dvvideo_encode_init(AVCodecContext *avctx) MECmpContext mecc; me_cmp_func ildct_cmp[6]; - memset(&mecc,0, sizeof(mecc)); ff_me_cmp_init(&mecc, avctx); ret = ff_set_cmp(&mecc, ildct_cmp, avctx->ildct_cmp, 0); if (ret < 0) diff --git a/libavcodec/me_cmp.c b/libavcodec/me_cmp.c index dfc351d7ae..27da787c71 100644 --- a/libavcodec/me_cmp.c +++ b/libavcodec/me_cmp.c @@ -995,6 +995,8 @@ WRAPPER8_16_SQ(bit8x8_c, bit16_c) av_cold void ff_me_cmp_init(MECmpContext *c, AVCodecContext *avctx) { + memset(c, 0, sizeof(*c)); + c->sum_abs_dctelem = sum_abs_dctelem_c; /* TODO [0] 16 [1] 8 */ diff --git a/libavcodec/tests/motion.c b/libavcodec/tests/motion.c index caa8ecb8be..c37fc551c3 100644 --- a/libavcodec/tests/motion.c +++ b/libavcodec/tests/motion.c @@ -131,12 +131,10 @@ int main(int argc, char **argv) ctx = avcodec_alloc_context3(NULL); ctx->flags |= AV_CODEC_FLAG_BITEXACT; av_force_cpu_flags(0); - memset(&cctx, 0, sizeof(cctx)); ff_me_cmp_init(&cctx, ctx); for (c = 0; c < flags_size; c++) { int x; av_force_cpu_flags(flags[c]); - memset(&mmxctx, 0, sizeof(mmxctx)); ff_me_cmp_init(&mmxctx, ctx); for (x = 0; x < 2; x++) { diff --git a/tests/checkasm/motion.c b/tests/checkasm/motion.c index bfd1a3c17b..7e322da0d5 100644 --- a/tests/checkasm/motion.c +++ b/tests/checkasm/motion.c @@ -116,9 +116,6 @@ static void check_motion(void) AVCodecContext av_ctx = { .codec_id = AV_CODEC_ID_NONE, .flags = AV_CODEC_FLAG_BITEXACT }; MECmpContext me_ctx; - memset(&me_ctx, 0, sizeof(me_ctx)); - - ff_me_cmp_init(&me_ctx, &av_ctx); for (int i = 0; i < FF_ARRAY_ELEMS(me_ctx.pix_abs); i++) { -- 2.40.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".