From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 8BE534C722 for <ffmpegdev@gitmailbox.com>; Wed, 9 Apr 2025 07:27:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5D96E68A769; Wed, 9 Apr 2025 10:27:45 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2040.outbound.protection.outlook.com [40.92.91.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 02D07687B78 for <ffmpeg-devel@ffmpeg.org>; Wed, 9 Apr 2025 10:27:38 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fvDcDrtvU0FGyyY/8F/l12NY/f75DeUCvmsFGFtnoWMVorDI5E2W4/DItGZ4X6MhdcON8eZ3FEQkkg3Tf+SEHCkB6oW090Kj1telgr4wq/k5/8GSiraGsjp8yPHAiqGrNMMeQ/5XQwybCbZ/YAKYQfnwSjvpBpBdoPD7NA39inmgy/tX40jAIof4dBDjfe75P4vif1wr5O6jI0qhOESsuNuRBY67N6q+p9d4KDirxaGXcdrV7xG8etIk00vbjzglzJjFVALVJJ7aMIh5nA2xwvqBY/i7smANcbwT/FCFKdT0K7hjhSdgKhSL8aU/ATANnJHQqSIJ2hrpaBac3EisZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=crGGfSPqMXAnHxngFMKgGVlGIQBCvqym/Sxj8T6cK7U=; b=V3rR6uK58ZbvQ8C15LpIVsT4KFcQbPWedo/+kv0d8HP+9d05AiBBV2oA8vCBXwAAn/YafGFNo0oLwmpkA6ZbuUDcqs/9xpWtLjUb5HSueBCTDSg64aSfvToeXbJGVnWxZ8zvwWZKVunl6+xk2Vx4x7ac3GB9/9KfYi4Jj8sBnaFLo9bzeHmkB+hKQ9VtaWTZ0jw4eP9uaeAM4y4DouBjDmNWEST25pt5lDBW5Nlu5o2HdAO91HtkeSS6oePKVPLCj6TUPFeG77mSMY00trlSju7NCujOoImVWYM0BLgJDyHLQzGN2WZkUXNPtaLP8GFQNo+yACY65uzFd1NpLAxWfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=crGGfSPqMXAnHxngFMKgGVlGIQBCvqym/Sxj8T6cK7U=; b=F87NE3juo50HSbyeIQFCu56wyGCehyru37h1wI+LGblURJHTn1sdgFaFw8qEXDE7oA949X/57/htA1G3mk1ldbdyK/KtT96G37B1GuRPC3j9JOt0kppGAl0yPdgL0t36Go5ee+qCnHOi6bpcG2rd53clEncSZEmjcEDwT/ojLU+TwbEg6QQ8h19k6I2lf540AMXZSIo0BsFyvv62w2n83ObeW2ZZBsAYRReYf5dfp68pgMmhxmP6Vfufs7bpHp3OAoxlnc106pZqUmZ1DPlWVaDOAsJb/JqCl09Rt/Aw5DW0BtfY8jqeZ8RXJyby7ogg2ZBgNCMsKS8cNQxDN/KfKQ== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PR3P250MB0292.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:17f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.17; Wed, 9 Apr 2025 07:27:37 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%5]) with mapi id 15.20.8632.017; Wed, 9 Apr 2025 07:27:37 +0000 Message-ID: <GV1P250MB0737112FAE6531CCD0D282928FB42@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> Date: Wed, 9 Apr 2025 09:27:35 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <pull.59.v6.ffstaging.FFmpeg.1741858241.ffmpegagent@gmail.com> <pull.59.v7.ffstaging.FFmpeg.1744178102.ffmpegagent@gmail.com> <6c2d6f1e97d4809275afc9c82486f7b9f9807156.1744178102.git.ffmpegagent@gmail.com> Content-Language: en-US From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> In-Reply-To: <6c2d6f1e97d4809275afc9c82486f7b9f9807156.1744178102.git.ffmpegagent@gmail.com> X-ClientProxiedBy: FR2P281CA0155.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::15) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <96883593-6264-423b-87df-3b17e72d56ff@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PR3P250MB0292:EE_ X-MS-Office365-Filtering-Correlation-Id: ce9534f2-4f51-460a-d126-08dd7738007b X-Microsoft-Antispam: BCL:0; ARA:14566002|15080799006|8060799006|19110799003|5072599009|7092599003|6090799003|461199028|3412199025|440099028|13041999003|41001999003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SldlUHVLZEQyUk95UnBwMmVoNWtGdkhrS2NnenZ6dTZieUUvdjlHUGdnaFA0?= =?utf-8?B?cW9ubnVHSmhyY28vQ0FHRGhXZHhyanBOTzMyRm1yTWRtRHg0VVVNK0Y5SjVv?= =?utf-8?B?VUh2RHhMWTc4WXFPWWVwTkUvWW9rS0oxU254ZGljWXlBQ3h1Tno0ZTlGejh0?= =?utf-8?B?SHdPSXNOeGU2VHViQjFXMTRtaThhdVRrcGtQSC9XUk5MdHBkOWhtUHEwelVi?= =?utf-8?B?ZXpJTG04Tm1sRmF6ZENMUWxudmMrbkI1UUljUVpPd0VSSzg3QThiZ01XdUF4?= =?utf-8?B?MUt6dUI1aTlUeEJhRk9wMTlCMDBaTEpMQUVFTG9QTFgyVUJnbWR1cEZ1VE9L?= =?utf-8?B?cHQvcnNsMXVGcGN5OVljelllUTNucGZ5N2Q5UGNXVjhtTGxyZ0gxQ1VWa2RP?= =?utf-8?B?SWRhRlJ3NlN4WGJ5bWxZc0Y1Y0FYZ3l1T01ZNDRDelZYTnhkNTZQTG1tUU9w?= =?utf-8?B?OGw1Qm4wL0ZuUXkrVWdRbTJPaitZdG5Mbzg0Sm5qRHpRRnFwdFZMTm9CeWk3?= =?utf-8?B?UE5FckRJbERMa0JPMlhpRGNpbEJUVGZJN2pKNTRvL3VPRS9kMWJvQkFDWS9C?= =?utf-8?B?bW1jeUZueFBtMUZ3OHdzN0U3eXYrb1VBakhhNUZlVk80SXd3OU9MUktEMUFG?= =?utf-8?B?cVA3Y3JTRlNBUS9lZ2dFdnBVZGd5dVMreDRYR2NyazVYT1AwMGk5eDk1K1Y5?= =?utf-8?B?ZlFKY0lndDErYURPVkM4Sk9kckltajZ3VGFKQkdKQzVpOGR0RGw5c0I0MWtk?= =?utf-8?B?Y1YybnJxUnMzUnNGZ3pwVHlUYjljNWdVNTgvMzFxcWFVZHVXWjNwZGlPV2pS?= =?utf-8?B?ZnpGaW1Qck01OTIxYzJ5NjVvdU1DYVZ1TkxKUk10T0lRMGgvL1ptM0UrRFQ1?= =?utf-8?B?ZElmUXppT2ZOTytxZzk1ak1ieTNabWtzVExlK1JJa3FOY2JGS2VabnQ5elJD?= =?utf-8?B?aFdwTjFkMGpiOExWKzNtaDQ1NVNIVFV4ZUpyTG5VdGM1WGthS1JMa1FOWGpv?= =?utf-8?B?VnFkS1k2RmhRR242VzdVQTdINklyK2VRSzNnRmp4Q0ZpK0VOeWNYR3kxYkVw?= =?utf-8?B?aGo2WDJxUzVUQU8zb2pVRENBSUFhNisxQXpIbzJ0V2I0VkJQNDVWU3RrcC81?= =?utf-8?B?Z0NkNC9LSnJpRjgzVmsyaWxuWmdRZXJ3U05sZDczTzZXUzFFTmtVQ0ZHVFBh?= =?utf-8?B?NGg1Wk5wMGhlbUpGOC9WR2ZKdmFqWGhzV2FFa1BqZzdMOGhwNDNwRkVab05k?= =?utf-8?B?MURlN0hVeDRzRi9paDZPR1lpZFJIVGVnWUhVZVpaSTNFS0VpZ2p3bG5YNlJM?= =?utf-8?B?Qi9qZGZoSnlQYW9HU1pVUVRhbzMxTUlKbGRHYzN3Y3lWL01CZ2Q0OVJWaHNp?= =?utf-8?B?NDk5Y3JhaDYrM1lPc3BJZmg5RmxlNDQrRnRTZUlBZk1NdWM3bEJFTlRZNS9K?= =?utf-8?B?dHowSmcrM1NoNmRDb0dOaWxrUDBPL0NzYk9hNmM0b3lUK3ZNRndMSkh5cU9N?= =?utf-8?B?Zk45WDBHUFRRYUFvNTRQVG8xS2p2WGtOU1ZLRlNya24xYTlZcWg4R1dDbHdy?= =?utf-8?B?Z3FIYzA1TkpDUzFyVng0K3hnNU1Ta1cwVUR0L0dZN0pvejZSa2xvbnY4YVBC?= =?utf-8?B?M2pVbGxEcGpJZ2hKNmRwN1ZIMTZmY2c9PQ==?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkdPcytENjI5clQ4Y2lNV2JmZS9mY3VGT0hJS0ZxT05ScmpHd0pJemtzLzhP?= =?utf-8?B?SDg1dkFVY21lU0xOUHcrNHo1dGNrWjBzbDZiellWWXY2Ymd4WjMrcG95akpn?= =?utf-8?B?K3piQUxVWkZGUWNETFMzT1N4OUxMVnpQR0trOUpydkF5MENPVEZ3aklRRWhM?= =?utf-8?B?emNMUS92SjZ5UVkwRDB5ZlNUL1A4SUd1eWFjVE8yV0pIbGJZb1pKQmhnNGx5?= =?utf-8?B?U3ZKVWhoR3VNQlkxZWR2K1NEcW9kMlE2RVQ5cm1vWnRqVUgrRlZheSthakpw?= =?utf-8?B?K1NvYTl1ejlSTmhUWTE1RWl1Y3BIZzZXcndkZVhyeGZZdGpSelRRb3B3MEhL?= =?utf-8?B?bjJ5dnFuNm1NMlMyWWpqUTkwYm1xSkJtVy9NSjFRNmRDNUtLM0tXbTBQbGV1?= =?utf-8?B?ZXQ1cHU0aWRlL0NQZzlkd2ZCWm9wUkdrc1paV2c5NHZvNHJ1cFFDVWJGNmJ5?= =?utf-8?B?enFualFnWW40R2p4ay8yYjB4eGwyYTdiUC91S3NsYVQvL3lRckduRVBKNWJy?= =?utf-8?B?bHJUL2xEWXRrUHBuK3R1c0tUdlh4ZVVuQ3hjMXNPRjdBdDZOeU4rd1Fzcnda?= =?utf-8?B?RVhQQnJlb0NQdVk4dHFQa2VSVmFHT0x5Rm1uQmJLRm0waHZTQnhnRGV6WmUv?= =?utf-8?B?cWNTempacUlGaUx1bWV1YzNNR3dKckRPUWFJSm9tZXhGemFEMWxxdFhXQUFU?= =?utf-8?B?a0Z0VitTQjVCZ3JyVEVER3hMUis0c2RTQ2JscTh4bEdVYUNRejlDc2dOMFFa?= =?utf-8?B?TXd3azFqbHZwV0MxWnBmdXZOSmRGOGx3a2tyRk1RMllFeUFIQVgvOUxNVVZi?= =?utf-8?B?MVNySEkvY1hQeGFySlFFc3VYKzFyUk9yTFlYZHF4ZTlLeWh1RnRISldLZXk1?= =?utf-8?B?MEdzbHhEazZkclVZS1EzUUJEcjh4UDd3RGIwaUdGcWtnMnIrYldKYTBqRG45?= =?utf-8?B?aGt0RXZRRnRiZWorbjNSSnVmWUNWNkFrZEF1am93WUIvNkxtOC9kQ3NSUWpJ?= =?utf-8?B?MXlnN1YxRUgxS21KLzF3cHNGczJpQkJiWVY2REl2Qkp0aWtpNHR3emxqZEpp?= =?utf-8?B?dzJqT2ZuUFNZMmgzMEVtOWpkcjZ1QTlYQ1lFQzUveFNtZ2t3YTl6THhaL0ZD?= =?utf-8?B?cnBsYkQ1MnR4ZGpQYmYxZEFXaWFXejNVck82UFQ4bTZWTmtZRTl3Y0ZuMTNP?= =?utf-8?B?YUp3OTBiL3l5dmlQSFIwQytyOVFkMW8raGpNMDE1dGM4aHB3K2F6K0hyMWM2?= =?utf-8?B?bnpXcTd1WnJBNWMzWW5xcEk4dkRWU2dJNHU4SjVtVjVnT09BcFBpT0pSUXRy?= =?utf-8?B?dEJVZkR2ckJsd2VPTks3cXJMVGRZRmhpcHFVT0p4eDRuZTJwK0MwZFlJRmlq?= =?utf-8?B?NmM1djA1eXloeTFCLzZvR3RydTVuRWdKNFo0elAyemFiR05ZNDBhZ0F6VEx6?= =?utf-8?B?NVZqODhPUU0zdXVEc0NsUTRFdE5uWWFiaXEyVmk4azcrNDM0TkpIa3AvQ0dt?= =?utf-8?B?dGJ5Mk5xWEVoSzQzSks3UGZCcHVUZXRlR0ZIOUljT0hqK2NwQ1VYSDN5YjdG?= =?utf-8?B?SkQrL1hWUUxkZHRYa3hNa2U4cmVGRjAzbUUrckZWbUthWkFOdGVqcVFDSnFy?= =?utf-8?B?R25Dc3FDNDJzeUdTOHpicU1mVlJtZEhhQnBRdTdLQUZVQWM4UFBYYXFYTUU3?= =?utf-8?B?TnNpaVRubzlRWmg1eDlReUpDdW8zWDR6SDFsNTR4d002R2Y3Z2dkWG5CVTkz?= =?utf-8?B?WHVvVGtBT3FTYWx6ejlWaTh5Wk9VcTZpaERCaW5FNUlYSmlLQjF4MVp6K2o2?= =?utf-8?B?aXNZcUNBM3dicGg3a3psUT09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce9534f2-4f51-460a-d126-08dd7738007b X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2025 07:27:37.0084 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0292 Subject: Re: [FFmpeg-devel] [PATCH v7 1/3] avutil/log: Add log flag AV_LOG_PRINT_MEMADDRESSES X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/GV1P250MB0737112FAE6531CCD0D282928FB42@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> softworkz: > From: softworkz <softworkz@hotmail.com> > > which is controls prefix formatting. With this flag set, the prefix is > printed including the memory address, otherwise it is omitted. > In libavutil, the flag is set by default, retaining the previous > behavior. fftools remove the flag as default. The implementation of this flag is counter to the usual one: It is enabled by default, but every av_log_set_flags() that does not set AV_LOG_PRINT_MEMADDRESSES implicitly disables printing memory addresses. This means that it will affect users that do not opt into this. I don't think this is intended or that the new system makes sense. (Due to the av_log_set_flags(AV_LOG_SKIP_REPEATED) performed early in the main function of the fftools, they are of this kind even with this patch alone.) > > Signed-off-by: softworkz <softworkz@hotmail.com> > --- > doc/APIchanges | 3 +++ > libavutil/log.c | 8 +++++--- > libavutil/log.h | 5 +++++ > libavutil/version.h | 2 +- > 4 files changed, 14 insertions(+), 4 deletions(-) > > diff --git a/doc/APIchanges b/doc/APIchanges > index 65bf5a9419..27afa5ba81 100644 > --- a/doc/APIchanges > +++ b/doc/APIchanges > @@ -1,5 +1,8 @@ > The last version increases of all libraries were on 2025-03-28 > > +2025-03-xx - xxxxxxxxxx - lavu 60.2.100 - log.h > + Add flag AV_LOG_PRINT_MEMADDRESSES > + > API changes, most recent first: > > 2025-04-07 - 19e9a203b7 - lavu 60.01.100 - dict.h > diff --git a/libavutil/log.c b/libavutil/log.c > index c5ee876a88..7ce23cc31f 100644 > --- a/libavutil/log.c > +++ b/libavutil/log.c > @@ -56,7 +56,7 @@ static AVMutex mutex = AV_MUTEX_INITIALIZER; > #endif > > static int av_log_level = AV_LOG_INFO; > -static int flags; > +static int flags = AV_LOG_PRINT_MEMADDRESSES; > > #define NB_LEVELS 8 > #if defined(_WIN32) && HAVE_SETCONSOLETEXTATTRIBUTE && HAVE_GETSTDHANDLE > @@ -327,16 +327,18 @@ static void format_line(void *avcl, int level, const char *fmt, va_list vl, > > if(type) type[0] = type[1] = AV_CLASS_CATEGORY_NA + 16; > if (*print_prefix && avc) { > + const char *p_fmt = flags & AV_LOG_PRINT_MEMADDRESSES ? "[%s @ %p] " : "[%s] "; > + > if (avc->parent_log_context_offset) { > AVClass** parent = *(AVClass ***) (((uint8_t *) avcl) + > avc->parent_log_context_offset); > if (parent && *parent) { > - av_bprintf(part+0, "[%s @ %p] ", > + av_bprintf(part+0, p_fmt, > item_name(parent, *parent), parent); > if(type) type[0] = get_category(parent); > } > } > - av_bprintf(part+1, "[%s @ %p] ", > + av_bprintf(part+1, p_fmt, > item_name(avcl, avc), avcl); > if(type) type[1] = get_category(avcl); > } > diff --git a/libavutil/log.h b/libavutil/log.h > index dd094307ce..450b4544b9 100644 > --- a/libavutil/log.h > +++ b/libavutil/log.h > @@ -416,6 +416,11 @@ int av_log_format_line2(void *ptr, int level, const char *fmt, va_list vl, > */ > #define AV_LOG_PRINT_DATETIME 8 > > +/** > + * Print memory addresses instead of logical ids in the AVClass prefix. The logical id system has been removed from this patchset. > + */ > +#define AV_LOG_PRINT_MEMADDRESSES 16 AV_LOG_PRINT_MEMADDRESS seems better given that every av_log() will likely only print one memaddress. > + > void av_log_set_flags(int arg); > int av_log_get_flags(void); > > diff --git a/libavutil/version.h b/libavutil/version.h > index 5139883569..4717cd562b 100644 > --- a/libavutil/version.h > +++ b/libavutil/version.h > @@ -79,7 +79,7 @@ > */ > > #define LIBAVUTIL_VERSION_MAJOR 60 > -#define LIBAVUTIL_VERSION_MINOR 1 > +#define LIBAVUTIL_VERSION_MINOR 2 > #define LIBAVUTIL_VERSION_MICRO 100 > > #define LIBAVUTIL_VERSION_INT AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \ _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".