From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EC16848C8F for ; Fri, 23 Feb 2024 03:28:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 438BD68C291; Fri, 23 Feb 2024 05:28:02 +0200 (EET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2090.outbound.protection.outlook.com [40.92.89.90]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 38D9768A9C7 for ; Fri, 23 Feb 2024 05:27:55 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MUjZ0LA51NgO34CPfU8cPB6eV+8nWbFZgivE7oc07LFOZu8Xpz7YCoVtaJpOQihumbJA0PluEO+b1Us0lQxenumCgPintsEvfFdD6xB6HplyH4O6E+ujg1fPAr7kzt2Fenj71On+TzeHhB1HJOqHPBUlwqWvWbxtRT+VEF8OXnF/oODPf7H57B78rFPCMyE34+NqA4GwZPPHPJk7Y/4syyAoLodVlpWPElQRPrhpWOUFkm5Bql2JYguURwrVhvHwzwgb1oH8T0z6d1y7FDczPAJzghFC+P5KDmdsBw4cXvnxfRhFKJLBWaxxbE3JZB3fThoKI8rHpEoCqHmAfciijQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3szrIPUlREsU0froK7sIwThVYw/rYs2IGglAB8Td6CA=; b=me0v+wz3HsjOdVC3tVC/AjOiXn+MZLkHibS4f+tJhjOHgOsPao6F21oDHDanmjbg8XB/SHZjTn0eT70mk2xSGCjkWVI8BD9sq7ahhee9VNLUsO3CJNLfQUQhPwbG7U0zVofAcu8zXMum8KknK11Lh48S8mcq+SVRbJ1dUun/p0+PtHjXz9R5zu8npDu8JBpj0gYYUbUe9l+KgxqwBOrg7zHnIzS1XlznyyRTZgLAoX3mOCa3zAjQYy+4mKrZ7++cvESskxC0WnR7wU94mjDOApxyU8EX/fzgkLH/CxhfJFaTS31FhFQhp0QKiHeti5Cco1lg/06e1qhS5F1Tf6hBPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3szrIPUlREsU0froK7sIwThVYw/rYs2IGglAB8Td6CA=; b=skNU+p7U9oXl45wI2uG4L9n8lwmRAsV0+WHqDL+5Zx4FpO/37QaXDZB8JPmA7Gw32Wc8RQXiR2A9jj4lW8beGqKJD3iJZURJq0FTovB/WY1O3QPIuC4Jfn9+aPhYm6CuVwRzjt/y8iUZ7sYLnPBZT/7aHgkGhD+Ca1f8ZtvLsA4hIxaJduz+UTsZN98VGj2n4UcCn1nnvdsxKwc7f8dEs+/i6a001T5LUax/bcp/RqqwyV2HGTjAg9EZhvWLEh5fAcal+KdG0SOSWvn68JFlb8FzGyu0rdKoNj3GfnP+oVC7bhz0EHsU4WsQxteRfVHe2+UpLy8LhHgxfZGGWPHKUg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS8P250MB0393.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:37e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.24; Fri, 23 Feb 2024 03:12:40 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::ebdc:87bf:6f91:3ae5]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::ebdc:87bf:6f91:3ae5%7]) with mapi id 15.20.7316.023; Fri, 23 Feb 2024 03:12:40 +0000 Message-ID: Date: Fri, 23 Feb 2024 04:14:37 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240221111003.185240-1-jdek@itanimul.li> <20240221111003.185240-2-jdek@itanimul.li> From: Andreas Rheinhardt In-Reply-To: <20240221111003.185240-2-jdek@itanimul.li> X-TMN: [hO2HCoUgnlPyW0IpZOCo0qSckE/P7nFl4Om5/gX4vZ8=] X-ClientProxiedBy: FR3P281CA0084.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::20) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS8P250MB0393:EE_ X-MS-Office365-Filtering-Correlation-Id: dedca796-1841-4425-637f-08dc341d4b87 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ykibc3XauVK39+ZMI+eRqAisge+D3/q2IxVClKJeF6I2yzlpy/+MypnM0BasUQhFVDTq94g3ebXSSIQm0ZK6PLhNDzKmIPaHt2o0OlFiw248zuFveRSBMlMnWiEvVwZep+RZasWiA3Is+FSc+S3P8RKpGPBd4/Ftzy6eSvLFILOUbHmvw9d67iEvbNznI5lA6tUnugS6B4NqI4t3IObrDXaEIWWM14lIemtglnOI2onDLnK/x7Wp3VaJjAm9VWGKq0XX9sa5HmBO97tzRRLYItKYtOcTZpCja82RwxjjqzHDL1U7RMlyL/dFmRe3oe/qEeIHfrnCAahy9H1dZwpBWV17JTJB/z2mRq6qVbLQ63mjOMmul8WKCduIgjjbdGuiskRsFufcstOKMI3igmDq4lL6cnyBr9Viro4ejLx6h/A4HQj7y9XfF98CZg4YW2X9QXd7cIIeCGNYfJHhC4u+ivTSVdCSkVBhGURmbaGHNeEZe6kK9O10poxprcD7BO1yuymk1haE9I0yJmmKA5GgiYp7HeTxnQmBb0wi4cHNwnMiMFg+GlmYC84/i/JsIL/b X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dm1rQTBjWXBwWHVNVUc2TXdxbWZ4Tzg4TlVIbzJpVktwbjBwRU9vcnlUbzA1?= =?utf-8?B?WGd5ZXdndXdQb0RKT1JQZGZ4VDg3L2RmdTN3cUUxME9nNlFZQW5WWjlrNTMx?= =?utf-8?B?Y3Y3NEpkenl1Yk00dFk2andVSWJ6aWI3dHhuQmFJTEgxWUp2WlB1Z2FyR3RW?= =?utf-8?B?ZUdrLzRqR0xZQmJvcnl0bklDeVBKN0tYQVZhV3VMT1pRZ1Z6VnNNOHZHT3c3?= =?utf-8?B?S2ozdkFtc0E4N0h4ZzBNaGNtYUNGVzJ6eVU1MmxqdjBVd2ZxcEM1cE1mSDNs?= =?utf-8?B?RmJuZHQ5ZTdGRGZ4Zk9hbzNXUDhBN2dRV01mc2RDbExESVJpYllpMjdYZ0Ry?= =?utf-8?B?TThBOVlKbUFQb0ttcDNWamdvRFpEMjFUQk9Ec3BXQlFrY2dkT2JVSVdPS3Nh?= =?utf-8?B?N3RBTnZXbVlWWW5HcmkvaHdNdlR5dHBRS2FQVTg2UExLbjZ4MzNpQVRQSS9V?= =?utf-8?B?VCtWdkR3NHA0MDJPc3RFNW1yY2RmaWErczZnd1JBWG9aWUlOejVoZE1iMS9p?= =?utf-8?B?WEJVM3RiOW1wK1Rkbks3azQvaGNmMitnV2gxWVVOMm82ei9CQ3ZZK1JRRS9V?= =?utf-8?B?VzRmOE5CYUFpVG92UGlLNEhLOEI5aHBCZXNHdUxUVmNXNmtIdFMyYmpUcHp4?= =?utf-8?B?aVNVdHVoeElQWHNRMlV4cUFjQnB0Sm1uU2YvTkJjNnY0Ky9oekxHZUNTSk9B?= =?utf-8?B?NUpWRFhjV2t0Y2Zmd1NSSkdIUWhPc2pheTlObHl3d0tDUC85T0pBZlZEQTNU?= =?utf-8?B?R3BSY1d6WGZud3kxTHFBY21welhHanh1Vm5WbTB2cFpJakRtM2QxZzZSbXNR?= =?utf-8?B?cVpoT3dYLzBkRUJnbW9GejNjRHU2VVBvWnpUazMzd0lpamQzZU9VNmtreDZm?= =?utf-8?B?OXZrNDlVZllyNHQ2dE9sZkRoL2x6UWhEdDZCZEhzRlhEeTMxT2R1RFNTNFJI?= =?utf-8?B?VTBFZmI0RDJteDVUeWJyZ25naitsTTdKcjN2bEZmUE1uTWJMaEJJWkVmWkZh?= =?utf-8?B?b3VNVU1xdmZuQWk4QThFWmZQc1pSVTRxRm9ZRDF5RmZNMnN5citPSGt3ZUVZ?= =?utf-8?B?anV6a1RPQ0hNUXZwUkVQRkx4Mlp5cTNmYU90L2ZWS3pVVUg4dnBJbFZFclho?= =?utf-8?B?cThwNlBuQUVJOVBadGpkTXBtTnNxaFBIQWtyWUg3U2E2dHV0M2Z3aFBTK25r?= =?utf-8?B?TnVlQTBlMi80K2YzdnhiZ3loL1pGYmQ4L25NMmJMMlpoWUI3QnMyS3lzbktN?= =?utf-8?B?WmtCVXRiVW5uN1N0Vm9yMTkrNnRzTUozbE1CVjk3TXVQbW5iUGx0NEY5ZlFX?= =?utf-8?B?TmdFWnZBNkRGNG5DaUd1YTNmL3hSNnVOUEhuUnhnL3RPZU9samNVYUVoUVd3?= =?utf-8?B?M3RzUUVLMzlnSWZhSld6L2kwWDh3ZGRpQzkxQmtiaVdNa250ZUc5NW1GSlIw?= =?utf-8?B?VDBtbmQzMExsS0s4ZHI0UXFxQmt1MGRLQ1Z0a0oxd3RmYTlkNDJ0RTZDR2tC?= =?utf-8?B?cDBZR1BTRnh4ZnppdmlFM01tb2ljMFRoODF6ZmN6Vzc4UlFpRmptYnIzcEhF?= =?utf-8?B?Q2I1a1dtbFhHeHlvTTBUSXBYZWVaNTZOdDlIV1Z4ZnZGSE1kR1VZSERBZ3Qy?= =?utf-8?B?S1ZzS2tJaHdHbC80WkVmcUdrNzZFczg3ODVQZ1hLWUp6NExCbHNPWm9oeHY0?= =?utf-8?B?RWxsMUZzVi9mN0tDdGJLaWUyQjBHb0tveEQ5LzR5M3Y5YnV3VmV5WUF3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dedca796-1841-4425-637f-08dc341d4b87 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 03:12:40.7545 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0393 Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec/x86: disable hevc 12b luma deblock X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: J. Dekker: > Over/underflow in some cases. > > Signed-off-by: J. Dekker > --- > libavcodec/x86/hevcdsp_init.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/x86/hevcdsp_init.c b/libavcodec/x86/hevcdsp_init.c > index 31e81eb11f..11cb1b3bfd 100644 > --- a/libavcodec/x86/hevcdsp_init.c > +++ b/libavcodec/x86/hevcdsp_init.c > @@ -1205,10 +1205,11 @@ void ff_hevc_dsp_init_x86(HEVCDSPContext *c, const int bit_depth) > if (EXTERNAL_SSE2(cpu_flags)) { > c->hevc_v_loop_filter_chroma = ff_hevc_v_loop_filter_chroma_12_sse2; > c->hevc_h_loop_filter_chroma = ff_hevc_h_loop_filter_chroma_12_sse2; > - if (ARCH_X86_64) { > - c->hevc_v_loop_filter_luma = ff_hevc_v_loop_filter_luma_12_sse2; > - c->hevc_h_loop_filter_luma = ff_hevc_h_loop_filter_luma_12_sse2; > - } > + // FIXME: 12-bit luma deblock over/underflows in some cases > + // if (ARCH_X86_64) { > + // c->hevc_v_loop_filter_luma = ff_hevc_v_loop_filter_luma_12_sse2; > + // c->hevc_h_loop_filter_luma = ff_hevc_h_loop_filter_luma_12_sse2; > + // } > SAO_BAND_INIT(12, sse2); > SAO_EDGE_INIT(12, sse2); > If you disable them here, you should also ensure that they are not assembled at all. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".